ruby: configure mis-detects isnan/isinf on musl
PATCH 1/2 ruby: configure mis-detects isnan/isinf on musl
From: André Draszik <[email protected]>
The configure script does not detect isnan/isinf as macros as is the case in musl.
Help it by providing the correct result viaCACHED_CONFIGUREVARS.
--- meta/recipes-devtools/ruby/ruby_2.5.5.bb | 3 +++ 1 file changed, 3 insertions(+)
meta/recipes-devtools/ruby/ruby_2.5.5.bb +3 -0
@@ -32,6 +32,9 @@ EXTRA_OECONF = "\ --with-pkg-config=pkg-config \ " +# the configure script does not detect isnan/isinf as macros +CACHED_CONFIGUREVARS_libc-musl += "ac_cv_func_isnan=yes ac_cv_func_isinf=yes" + do_install() { oe_runmake 'DESTDIR=${D}' install }
Signature · 1 line
2.23.0.rc1
PATCH 2/2 ruby: fix non-IPv6 support
From: André Draszik <[email protected]>
When IPv6 support is disabled, this recipe mis-configures ruby so that it end up non-working:
--enable-wide-getaddrinfo instructs ruby to re-implement the standard getaddinfo(), but IPv6 support is still automatically detected via ext/socket/extconf.rb independently of that flag.
To re-implement getaddrinfo(), ruby uses the obsolete getipnodebyaddr() and getipnodebyname() functions - i.e. according to the man-page, glibc provided those only in glibc 2.1.91-95; and of course compilation fails. [1]
Switch to ruby's standard --enable-ipv6= configure options to make the build work without warnings, and ruby work at runtime as well.
[1] Compilation and linking actually succeed, albeit with a warning regarding implicit declaration / unresolved symbols. The error is only obvious at runtime due to the unresolved symbols...
--- meta/recipes-devtools/ruby/ruby_2.5.5.bb | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)
meta/recipes-devtools/ruby/ruby_2.5.5.bb +1 -6
@@ -9,17 +9,12 @@ SRC_URI += " \ SRC_URI[md5sum] = "7e156fb526b8f4bb1b30a3dd8a7ce400" SRC_URI[sha256sum] = "28a945fdf340e6ba04fc890b98648342e3cccfd6d223a48f3810572f11b2514c" -# it's unknown to configure script, but then passed to extconf.rb -# maybe it's not really needed as we're hardcoding the result with -# 0001-socket-extconf-hardcode-wide-getaddr-info-test-outco.patch -UNKNOWN_CONFIGURE_WHITELIST += "--enable-wide-getaddrinfo" - PACKAGECONFIG ??= "" PACKAGECONFIG += "${@bb.utils.filter('DISTRO_FEATURES', 'ipv6', d)}" PACKAGECONFIG[valgrind] = "--with-valgrind=yes, --with-valgrind=no, valgrind" PACKAGECONFIG[gmp] = "--with-gmp=yes, --with-gmp=no, gmp" -PACKAGECONFIG[ipv6] = ",--enable-wide-getaddrinfo," +PACKAGECONFIG[ipv6] = "--enable-ipv6=yes, --enable-ipv6=no," EXTRA_AUTORECONF += "--exclude=aclocal"
Signature · 1 line
2.23.0.rc1
PATCH v2 1/1 ruby: fix non-IPv6 support
From: André Draszik <[email protected]>
When IPv6 support is disabled, this recipe mis-configures ruby so that it end up non-working:
--enable-wide-getaddrinfo instructs ruby to re-implement the standard getaddinfo(), but IPv6 support is still automatically detected via ext/socket/extconf.rb independently of that flag.
To re-implement getaddrinfo(), ruby uses the obsolete getipnodebyaddr() and getipnodebyname() functions - i.e. according to the man-page, glibc provided those only in glibc 2.1.91-95; and of course compilation fails. [1]
Switch to ruby's standard --enable-ipv6= configure options to make the build work without warnings, and ruby work at runtime as well.
[1] Compilation and linking actually succeed, albeit with a warning regarding implicit declaration / unresolved symbols. The error is only obvious at runtime due to the unresolved symbols...
---
v2:
* switch to --enable-ipv6/--disable-ipv6 instead of --enable-ipv6=yes/no, as the latter is not actually recognised
--- meta/recipes-devtools/ruby/ruby_2.5.5.bb | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)
meta/recipes-devtools/ruby/ruby_2.5.5.bb +1 -6
@@ -9,17 +9,12 @@ SRC_URI += " \ SRC_URI[md5sum] = "7e156fb526b8f4bb1b30a3dd8a7ce400" SRC_URI[sha256sum] = "28a945fdf340e6ba04fc890b98648342e3cccfd6d223a48f3810572f11b2514c" -# it's unknown to configure script, but then passed to extconf.rb -# maybe it's not really needed as we're hardcoding the result with -# 0001-socket-extconf-hardcode-wide-getaddr-info-test-outco.patch -UNKNOWN_CONFIGURE_WHITELIST += "--enable-wide-getaddrinfo" - PACKAGECONFIG ??= "" PACKAGECONFIG += "${@bb.utils.filter('DISTRO_FEATURES', 'ipv6', d)}" PACKAGECONFIG[valgrind] = "--with-valgrind=yes, --with-valgrind=no, valgrind" PACKAGECONFIG[gmp] = "--with-gmp=yes, --with-gmp=no, gmp" -PACKAGECONFIG[ipv6] = ",--enable-wide-getaddrinfo," +PACKAGECONFIG[ipv6] = "--enable-ipv6, --disable-ipv6," EXTRA_AUTORECONF += "--exclude=aclocal"
Signature · 1 line
2.23.0.rc1
Re: [PATCH v2] ruby: fix non-IPv6 support
Just wanted to request, would you be able to provide a ruby version upgrade as well?
Alex
Quoted 69 lines · André Draszik
From: André Draszik <[email protected]>
When IPv6 support is disabled, this recipe mis-configures ruby so that it end up non-working:
--enable-wide-getaddrinfo instructs ruby to re-implement the standardgetaddinfo(), but IPv6 support is still automatically detected via ext/socket/extconf.rb independently of that flag.To re-implement
getaddrinfo(), ruby uses the obsoletegetipnodebyaddr()andgetipnodebyname()functions - i.e. according to the man-page, glibc provided those only in glibc 2.1.91-95; and of course compilation fails. [1]Switch to ruby's standard --enable-ipv6= configure options to make the build work without warnings, and ruby work at runtime as well.
[1] Compilation and linking actually succeed, albeit with a warning regarding implicit declaration / unresolved symbols. The error is only obvious at runtime due to the unresolved symbols...
Signed-off-by André Draszik <[email protected]>---
v2:
* switch to --enable-ipv6/--disable-ipv6 instead of --enable-ipv6=yes/no, as the latter is not actually recognised--- meta/recipes-devtools/ruby/ruby_2.5.5.bb | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)meta/recipes-devtools/ruby/ruby_2.5.5.bb +0
-0@@ -9,17 +9,12 @@ SRC_URI += " \ SRC_URI[md5sum] = "7e156fb526b8f4bb1b30a3dd8a7ce400" SRC_URI[sha256sum] ="
28a945fdf340e6ba04fc890b98648342e3cccfd6d223a48f3810572f11b2514c"meta/recipes-devtools/ruby/ruby_2.5.5.bb +0
-5-# it's unknown to configure script, but then passed to extconf.rb -# maybe it's not really needed as we're hardcoding the result with -# 0001-socket-extconf-hardcode-wide-getaddr-info-test-outco.patch -UNKNOWN_CONFIGURE_WHITELIST += "--enable-wide-getaddrinfo" - PACKAGECONFIG ??= "" PACKAGECONFIG += "${@bb.utils.filter('DISTRO_FEATURES', 'ipv6', d)}" PACKAGECONFIG[valgrind] = "--with-valgrind=yes, --with-valgrind=no,valgrind"
PACKAGECONFIG[gmp] = "--with-gmp=yes, --with-gmp=no, gmp"meta/recipes-devtools/ruby/ruby_2.5.5.bb +1
-2-PACKAGECONFIG[ipv6] = ",--enable-wide-getaddrinfo," +PACKAGECONFIG[ipv6] = "--enable-ipv6, --disable-ipv6," EXTRA_AUTORECONF += "--exclude=aclocal" --2.23.0.rc1
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Quoted 7 lines · André Draszik
From: André Draszik <[email protected]>
The configure script does not detect isnan/isinf as macros as is the case in musl.
Help it by providing the correct result via
CACHED_CONFIGUREVARS.
Is this reported as a bug upstream so we can remove this workaround at some point?
Ross
Re: [PATCH v2] ruby: fix non-IPv6 support
In reply to Alexander KanavinQuoted 1 line · Alexander Kanavin
Just wanted to request, would you be able to provide a ruby version upgrade as well?
Not anytime soon - I'm just working a quick proof-of-concept.
Also, if you look at Alpine, they are packaging all the bundled gems separately, so ideally the same should happen when using yocto. But that's a bigger task...
And I don't know anything about ruby :-)
Can't the auto-updater do it? (Without the repackaging?)
Cheers,
Andre'
Quoted 63 lines
Alex
Quoted 60 lines · André Draszik
From: André Draszik <[email protected]>
When IPv6 support is disabled, this recipe mis-configures ruby so that it end up non-working:
--enable-wide-getaddrinfo instructs ruby to re-implement the standardgetaddinfo(), but IPv6 support is still automatically detected via ext/socket/extconf.rb independently of that flag.To re-implement
getaddrinfo(), ruby uses the obsoletegetipnodebyaddr()andgetipnodebyname()functions - i.e. according to the man-page, glibc provided those only in glibc 2.1.91-95; and of course compilation fails. [1]Switch to ruby's standard --enable-ipv6= configure options to make the build work without warnings, and ruby work at runtime as well.
[1] Compilation and linking actually succeed, albeit with a warning regarding implicit declaration / unresolved symbols. The error is only obvious at runtime due to the unresolved symbols...
Signed-off-by André Draszik <[email protected]>---
v2:
* switch to --enable-ipv6/--disable-ipv6 instead of --enable-ipv6=yes/no, as the latter is not actually recognised--- meta/recipes-devtools/ruby/ruby_2.5.5.bb | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)meta/recipes-devtools/ruby/ruby_2.5.5.bb +1
-6@@ -9,17 +9,12 @@ SRC_URI += " \ SRC_URI[md5sum] = "7e156fb526b8f4bb1b30a3dd8a7ce400" SRC_URI[sha256sum] = "28a945fdf340e6ba04fc890b98648342e3cccfd6d223a48f3810572f11b2514c" -# it's unknown to configure script, but then passed to extconf.rb -# maybe it's not really needed as we're hardcoding the result with -# 0001-socket-extconf-hardcode-wide-getaddr-info-test-outco.patch -UNKNOWN_CONFIGURE_WHITELIST += "--enable-wide-getaddrinfo" - PACKAGECONFIG ??= "" PACKAGECONFIG += "${@bb.utils.filter('DISTRO_FEATURES', 'ipv6', d)}" PACKAGECONFIG[valgrind] = "--with-valgrind=yes, --with-valgrind=no, valgrind" PACKAGECONFIG[gmp] = "--with-gmp=yes, --with-gmp=no, gmp" -PACKAGECONFIG[ipv6] = ",--enable-wide-getaddrinfo," +PACKAGECONFIG[ipv6] = "--enable-ipv6, --disable-ipv6," EXTRA_AUTORECONF += "--exclude=aclocal"Signature · 1 line
2.23.0.rc1
Re: [PATCH v2] ruby: fix non-IPv6 support
Quoted 2 lines · André Draszik
Can't the auto-updater do it? (Without the repackaging?)
I think it fails at the rebasing patches step - merge conflicts can only be resolved by a human.
Alex
Quoted 19 lines · André Draszik
From: André Draszik <[email protected]>
The configure script does not detect isnan/isinf as macros as is the case in musl.
Help it by providing the correct result via
CACHED_CONFIGUREVARS.Signed-off-by André Draszik <[email protected]>--- meta/recipes-devtools/ruby/ruby_2.5.5.bb | 3 +++ 1 file changed, 3 insertions(+)meta/recipes-devtools/ruby/ruby_2.5.5.bb +0
-0
meta/recipes-devtools/ruby/ruby_2.5.5.bb EXTRA_OECONF = "\ · line 37
Quoted 6 lines
meta/recipes-devtools/ruby/ruby_2.5.5.bb +3
-0@@ -32,6 +32,9 @@ EXTRA_OECONF = "\ --with-pkg-config=pkg-config \ " +# the configure script does not detect isnan/isinf as macros +CACHED_CONFIGUREVARS_libc-musl += "ac_cv_func_isnan=yes ac_cv_func_isinf=yes" +
Please use _append_libc-musl and drop +=
Quoted 11 lines
meta/recipes-devtools/ruby/ruby_2.5.5.bb +0
-1do_install() { oe_runmake 'DESTDIR=${D}' install } --2.23.0.rc1
--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Quoted 11 lines · Ross Burton
Quoted 7 lines · André Draszik
From: André Draszik <[email protected]>
The configure script does not detect isnan/isinf as macros as is the case in musl.
Help it by providing the correct result via
CACHED_CONFIGUREVARS.Is this reported as a bug upstream so we can remove this workaround at some point?
Now that you say it - actually somebody else did before, and they've also fixed it in later versions.
New patch coming.
A.
Re: [PATCH v2] ruby: fix non-IPv6 support
In reply to Alexander KanavinQuoted 4 lines · Alexander Kanavin
Quoted 1 line · André Draszik
Can't the auto-updater do it? (Without the repackaging?)
I think it fails at the rebasing patches step - merge conflicts can only be resolved by a human.
OK, I'll try to have a look anyway...
A.