4.19.76-stable review
Greg Kroah-Hartman
maintainercover 4.19.76-stable review
This is the start of the stable review cycle for the 4.19.76 release. There are 63 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Tue 01 Oct 2019 01:47:47 PM UTC. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.76-rc1.gz
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
and the diffstat can be found below.
thanks,
greg k-h
-------------
Pseudo-Shortlog of commits:
Greg Kroah-Hartman <[email protected]>
Linux 4.19.76-rc1
Ka-Cheong Poon <[email protected]>
net/rds: An rds_sock is added too early to the hash table
Cong Wang <[email protected]>
net_sched: check cops->tcf_block in tc_bind_tclass()
Jian-Hong Pan <[email protected]>
Bluetooth: btrtl: Additional Realtek 8822CE Bluetooth devices
Fernando Fernandez Mancera <[email protected]>
netfilter: nft_socket: fix erroneous socket assignment
Darrick J. Wong <[email protected]>
xfs: don't crash on null attr fork xfs_bmapi_read
Ilia Mirkin <[email protected]>
drm/nouveau/disp/nv50-: fix center/aspect-corrected scaling
Hans de Goede <[email protected]>
ACPI: video: Add new hw_changes_brightness quirk, set it on PB Easynote MZ35
Jian-Hong Pan <[email protected]>
Bluetooth: btrtl: HCI reset on close for Realtek BT chip
Stephen Hemminger <[email protected]>
net: don't warn in inet diag when IPV6 is disabled
Chris Wilson <[email protected]>
drm: Flush output polling on shutdown
Chao Yu <[email protected]>
f2fs: fix to do sanity check on segment bitmap of LFS curseg
Michal Suchanek <[email protected]>
net/ibmvnic: Fix missing { in __ibmvnic_reset
Mikulas Patocka <[email protected]>
dm zoned: fix invalid memory access
Chao Yu <[email protected]>
Revert "f2fs: avoid out-of-range memory access"
zhengbin <[email protected]>
blk-mq: move cancel of requeue_work to the front of blk_exit_queue
Jianchao Wang <[email protected]>
blk-mq: change gfp flags to GFP_NOIO in blk_mq_realloc_hw_ctxs
Steven Price <[email protected]>
initramfs: don't free a non-existent initrd
Coly Li <[email protected]>
bcache: remove redundant LIST_HEAD(journal) from run_cache_set()
Dexuan Cui <[email protected]>
PCI: hv: Avoid use of hv_pci_dev->pci_slot after freeing it
Surbhi Palande <[email protected]>
f2fs: check all the data segments against all node ones
Marc Zyngier <[email protected]>
irqchip/gic-v3-its: Fix LPI release for Multi-MSI devices
Lorenz Bauer <[email protected]>
bpf: libbpf: retry loading program on EAGAIN
Shirish S <[email protected]>
Revert "drm/amd/powerplay: Enable/Disable NBPSTATE on On/OFF of UVD"
Himanshu Madhani <[email protected]>
scsi: qla2xxx: Return switch command on a timeout
Quinn Tran <[email protected]>
scsi: qla2xxx: Remove all rports if fabric scan retry fails
Quinn Tran <[email protected]>
scsi: qla2xxx: Turn off IOCB timeout timer on IOCB completion
Waiman Long <[email protected]>
locking/lockdep: Add debug_locks check in __lock_downgrade() - again
Waiman Long <[email protected]>
locking/lockdep: Add debug_locks check in __lock_downgrade()
David Lechner <[email protected]>
power: supply: sysfs: ratelimit property read error message
Nathan Chancellor <[email protected]>
pinctrl: sprd: Use define directive for sprd_pinconf_params values
Vadim Sukhomlinov <[email protected]>
tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations
Josh Poimboeuf <[email protected]>
objtool: Clobber user CFLAGS variable
Takashi Iwai <[email protected]>
ALSA: hda - Apply AMD controller workaround for Raven platform
Shih-Yuan Lee (FourDollars) <[email protected]>
ALSA: hda - Add laptop imic fixup for ASUS M9V laptop
Takashi Sakamoto <[email protected]>
ALSA: dice: fix wrong packet parameter for Alesis iO26
Jussi Laako <[email protected]>
ALSA: usb-audio: Add DSD support for EVGA NU Audio
Ilya Pshonkin <[email protected]>
ALSA: usb-audio: Add Hiby device family to quirks for native DSD support
Takashi Iwai <[email protected]>
ASoC: fsl: Fix of-node refcount unbalance in fsl_ssi_probe_from_dt()
Hans de Goede <[email protected]>
ASoC: Intel: cht_bsw_max98090_ti: Enable codec clock once and keep it enabled
Marco Felsch <[email protected]>
media: tvp5150: fix switch exit in set control handler
Naftali Goldstein <[email protected]>
iwlwifi: mvm: always init rs_fw with 20MHz bandwidth rates
Emmanuel Grumbach <[email protected]>
iwlwifi: mvm: send BCAST management frames to the right station
Saeed Mahameed <[email protected]>
net/mlx5e: Rx, Check ip headers sanity
Saeed Mahameed <[email protected]>
net/mlx5e: Rx, Fixup skb checksum for packets with tail padding
Saeed Mahameed <[email protected]>
net/mlx5e: XDP, Avoid checksum complete when XDP prog is loaded
Or Gerlitz <[email protected]>
net/mlx5e: Allow reporting of checksum unnecessary
Cong Wang <[email protected]>
mlx5: fix get_ip_proto()
Alaa Hleihel <[email protected]>
net/mlx5e: don't set CHECKSUM_COMPLETE on SCTP packets
Natali Shechtman <[email protected]>
net/mlx5e: Set ECN for received packets using CQE indication
Aurelien Aptel <[email protected]>
CIFS: fix deadlock in cached root handling
Gustavo A. R. Silva <[email protected]>
crypto: talitos - fix missing break in switch statement
Tokunori Ikegami <[email protected]>
mtd: cfi_cmdset_0002: Use chip_good() to retry in do_write_oneword()
Sebastian Parschauer <[email protected]>
HID: Add quirk for HP X500 PIXART OEM mouse
Alan Stern <[email protected]>
HID: hidraw: Fix invalid read in hidraw_ioctl
Alan Stern <[email protected]>
HID: logitech: Fix general protection fault caused by Logitech driver
Roderick Colenbrander <[email protected]>
HID: sony: Fix memory corruption issue on cleanup.
Alan Stern <[email protected]>
HID: prodikeys: Fix general protection fault during probe
Jack Morgenstein <[email protected]>
IB/core: Add an unbound WQ type to the new CQ API
Nick Desaulniers <[email protected]>
drm/amd/display: readd -msse2 to prevent Clang from emitting libcalls to undefined SW FP routines
Greg Kurz <[email protected]>
powerpc/xive: Fix bogus error code returned by OPAL
Leon Romanovsky <[email protected]>
RDMA/restrack: Protect from reentry to resource return path
Juliet Kim <[email protected]>
net/ibmvnic: free reset work of removed device from queue
Marcel Holtmann <[email protected]>
Revert "Bluetooth: validate BLE connection interval updates"
-------------
Diffstat:
Makefile | 4 +- arch/powerpc/include/asm/opal.h | 2 +- arch/powerpc/platforms/powernv/opal-wrappers.S | 2 +- arch/powerpc/sysdev/xive/native.c | 11 ++ block/blk-core.c | 2 +- block/blk-flush.c | 6 +- block/blk-mq.c | 19 +-- block/blk-sysfs.c | 3 + block/blk.h | 2 +- drivers/acpi/acpi_video.c | 37 ++++++ drivers/bluetooth/btrtl.c | 20 +++ drivers/bluetooth/btrtl.h | 6 + drivers/bluetooth/btusb.c | 4 + drivers/char/tpm/tpm-chip.c | 3 + drivers/crypto/talitos.c | 1 + drivers/gpu/drm/amd/display/dc/calcs/Makefile | 4 + drivers/gpu/drm/amd/display/dc/dml/Makefile | 4 + drivers/gpu/drm/amd/powerplay/hwmgr/smu8_hwmgr.c | 5 +- drivers/gpu/drm/drm_probe_helper.c | 9 +- drivers/gpu/drm/nouveau/dispnv50/head.c | 28 ++++- drivers/hid/hid-ids.h | 1 + drivers/hid/hid-lg.c | 10 +- drivers/hid/hid-lg4ff.c | 1 - drivers/hid/hid-prodikeys.c | 12 +- drivers/hid/hid-quirks.c | 1 + drivers/hid/hid-sony.c | 2 +- drivers/hid/hidraw.c | 2 +- drivers/infiniband/core/cq.c | 8 +- drivers/infiniband/core/device.c | 15 ++- drivers/infiniband/core/mad.c | 2 +- drivers/infiniband/core/restrack.c | 4 +- drivers/irqchip/irq-gic-v3-its.c | 9 +- drivers/md/bcache/super.c | 1 - drivers/md/dm-zoned-target.c | 2 - drivers/media/i2c/tvp5150.c | 2 +- drivers/mtd/chips/cfi_cmdset_0002.c | 18 ++- drivers/net/ethernet/ibm/ibmvnic.c | 9 +- drivers/net/ethernet/mellanox/mlx5/core/en.h | 3 + .../net/ethernet/mellanox/mlx5/core/en_ethtool.c | 28 +++++ drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 8 ++ drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 126 ++++++++++++++++--- drivers/net/ethernet/mellanox/mlx5/core/en_stats.c | 9 ++ drivers/net/ethernet/mellanox/mlx5/core/en_stats.h | 6 + drivers/net/wireless/intel/iwlwifi/mvm/rs-fw.c | 5 +- drivers/net/wireless/intel/iwlwifi/mvm/rs.c | 2 +- drivers/net/wireless/intel/iwlwifi/mvm/rs.h | 2 +- drivers/net/wireless/intel/iwlwifi/mvm/tx.c | 2 +- drivers/pci/controller/pci-hyperv.c | 2 +- drivers/pinctrl/sprd/pinctrl-sprd.c | 6 +- drivers/power/supply/power_supply_sysfs.c | 3 +- drivers/scsi/qla2xxx/qla_gs.c | 134 +++++++++++---------- drivers/scsi/qla2xxx/qla_init.c | 11 +- fs/cifs/smb2ops.c | 44 +++++++ fs/f2fs/segment.c | 44 ++++++- fs/f2fs/super.c | 4 +- fs/xfs/libxfs/xfs_bmap.c | 29 +++-- include/rdma/ib_verbs.h | 9 +- init/initramfs.c | 2 +- kernel/locking/lockdep.c | 6 + net/bluetooth/hci_event.c | 5 - net/bluetooth/l2cap_core.c | 9 +- net/ipv4/raw_diag.c | 3 - net/netfilter/nft_socket.c | 6 +- net/rds/bind.c | 40 +++--- net/sched/sch_api.c | 2 + sound/firewire/dice/dice-alesis.c | 2 +- sound/pci/hda/hda_intel.c | 3 +- sound/pci/hda/patch_analog.c | 1 + sound/soc/fsl/fsl_ssi.c | 6 +- sound/soc/intel/boards/cht_bsw_max98090_ti.c | 47 +++++++- sound/usb/quirks.c | 2 + tools/lib/bpf/bpf.c | 17 ++- tools/objtool/Makefile | 2 +- 73 files changed, 669 insertions(+), 232 deletions(-)
Greg Kroah-Hartman
maintainerPATCH 1/63 Revert "Bluetooth: validate BLE connection interval updates"
From: Marcel Holtmann <[email protected]>
[ Upstream commit 68d19d7d995759b96169da5aac313363f92a9075 ]
This reverts commit c49a8682fc5d298d44e8d911f4fa14690ea9485e.
There are devices which require low connection intervals for usable operation including keyboards and mice. Forcing a static connection interval for these types of devices has an impact in latency and causes a regression.
--- net/bluetooth/hci_event.c | 5 ----- net/bluetooth/l2cap_core.c | 9 +-------- 2 files changed, 1 insertion(+), 13 deletions(-)
net/bluetooth/hci_event.c +0 -5
@@ -5545,11 +5545,6 @@ static void hci_le_remote_conn_param_req_evt(struct hci_dev *hdev,return send_conn_param_neg_reply (hdev, handle,HCI_ERROR_UNKNOWN_CONN_ID ); -if (min < hcon->le_conn_min_interval || - max > hcon->le_conn_max_interval) -return send_conn_param_neg_reply (hdev, handle, -HCI_ERROR_INVALID_LL_PARAMS ); -if (hci_check_conn_params (min, max, latency, timeout))return send_conn_param_neg_reply (hdev, handle,HCI_ERROR_INVALID_LL_PARAMS );
net/bluetooth/l2cap_core.c +1 -8
@@ -5287,14 +5287,7 @@ static inline int l2cap_conn_param_update_req(struct l2cap_conn *conn,memset (&rsp,0 ,sizeof (rsp)); -if (min < hcon->le_conn_min_interval || - max > hcon->le_conn_max_interval) { -BT_DBG ("requested connection interval exceeds current bounds." ); - err = -EINVAL ; - }else { - err =hci_check_conn_params (min, max, latency, to_multiplier); - } - + err =hci_check_conn_params (min, max, latency, to_multiplier);if (err) rsp.result =cpu_to_le16 (L2CAP_CONN_PARAM_REJECTED );else
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 2/63 net/ibmvnic: free reset work of removed device from queue
In reply to Greg Kroah-HartmanFrom: Juliet Kim <[email protected]>
[ Upstream commit 1c2977c094998de032fee6e898c88b4a05483d08 ]
Commit 36f1031c51a2 ("ibmvnic: Do not process reset during or after
device removal") made the change to exit reset if the driver has been
removed, but does not free reset work items of the adapter from queue.
Ensure all reset work items are freed when breaking out of the loop early.
--- drivers/net/ethernet/ibm/ibmvnic.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/net/ethernet/ibm/ibmvnic.c +5 -2
@@ -2000,7 +2000,10 @@ static void __ibmvnic_reset(struct work_struct *work)while (rwi) {if (adapter->state ==VNIC_REMOVING || adapter->state ==VNIC_REMOVED ) - goto out; +kfree (rwi); + rc =EBUSY ; +break ; + }if (adapter->force_reset_recovery) { adapter->force_reset_recovery = false;
@@ -2026,7 +2029,7 @@ static void __ibmvnic_reset(struct work_struct *work)netdev_dbg (adapter->netdev,"Reset failed\n" );free_all_rwi (adapter); } -out: + adapter->resetting = false;if (we_lock_rtnl)rtnl_unlock ();
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 3/63 RDMA/restrack: Protect from reentry to resource return path
In reply to Greg Kroah-HartmanFrom: Leon Romanovsky <[email protected]>
commit fe9bc1644918aa1d02a889b4ca788bfb67f90816 upstream.
Nullify the resource task struct pointer to ensure that subsequent calls won't try to release task_struct again.
------------[ cut here ]------------ ODEBUG: free active (active state 1) object type: rcu_head hint: (null) WARNING: CPU: 0 PID: 6048 at lib/debugobjects.c:329 debug_print_object+0x16a/0x210 lib/debugobjects.c:326 Kernel panic - not syncing: panic_on_warn set ... CPU: 0 PID: 6048 Comm: syz-executor022 Not tainted 4.19.0-rc7-next-20181008+ #89 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x244/0x3ab lib/dump_stack.c:113 panic+0x238/0x4e7 kernel/panic.c:184 __warn.cold.8+0x163/0x1ba kernel/panic.c:536 report_bug+0x254/0x2d0 lib/bug.c:186 fixup_bug arch/x86/kernel/traps.c:178 [inline] do_error_trap+0x11b/0x200 arch/x86/kernel/traps.c:271 do_invalid_op+0x36/0x40 arch/x86/kernel/traps.c:290 invalid_op+0x14/0x20 arch/x86/entry/entry_64.S:969 RIP: 0010:debug_print_object+0x16a/0x210 lib/debugobjects.c:326 Code: 41 88 48 89 fa 48 c1 ea 03 80 3c 02 00 0f 85 92 00 00 00 48 8b 14
dd
60 02 41 88 4c 89 fe 48 c7 c7 00 f8 40 88 e8 36 2f b4 fd <0f> 0b 83 05 a9
f4 5e 06 01 48 83 c4 18 5b 41 5c 41 5d 41 5e 41 5f
RSP: 0018:ffff8801d8c3eda8 EFLAGS: 00010086
RAX: 0000000000000000 RBX: 0000000000000003 RCX: 0000000000000000
RDX: 0000000000000000 RSI: ffffffff8164d235 RDI: 0000000000000005
RBP: ffff8801d8c3ede8 R08: ffff8801d70aa280 R09: ffffed003b5c3eda
R10: ffffed003b5c3eda R11: ffff8801dae1f6d7 R12: 0000000000000001
R13: ffffffff8939a760 R14: 0000000000000000 R15: ffffffff8840fca0
__debug_check_no_obj_freed lib/debugobjects.c:786 [inline] debug_check_no_obj_freed+0x3ae/0x58d lib/debugobjects.c:818 kmem_cache_free+0x202/0x290 mm/slab.c:3759 free_task_struct kernel/fork.c:163 [inline] free_task+0x16e/0x1f0 kernel/fork.c:457 __put_task_struct+0x2e6/0x620 kernel/fork.c:730 put_task_struct include/linux/sched/task.h:96 [inline] finish_task_switch+0x66c/0x900 kernel/sched/core.c:2715 context_switch kernel/sched/core.c:2834 [inline] __schedule+0x8d7/0x21d0 kernel/sched/core.c:3480 schedule+0xfe/0x460 kernel/sched/core.c:3524 freezable_schedule include/linux/freezer.h:172 [inline] futex_wait_queue_me+0x3f9/0x840 kernel/futex.c:2530 futex_wait+0x45c/0xa50 kernel/futex.c:2645 do_futex+0x31a/0x26d0 kernel/futex.c:3528 __do_sys_futex kernel/futex.c:3589 [inline] __se_sys_futex kernel/futex.c:3557 [inline] __x64_sys_futex+0x472/0x6a0 kernel/futex.c:3557 do_syscall_64+0x1b9/0x820 arch/x86/entry/common.c:290 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x446549 Code: e8 2c b3 02 00 48 83 c4 18 c3 0f 1f 80 00 00 00 00 48 89 f8 48 89 f7
48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 2b 09 fc ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007f3a998f5da8 EFLAGS: 00000246 ORIG_RAX: 00000000000000ca
RAX: ffffffffffffffda RBX: 00000000006dbc38 RCX: 0000000000446549
RDX: 0000000000000000 RSI: 0000000000000080 RDI: 00000000006dbc38
RBP: 00000000006dbc30 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 00000000006dbc3c
R13: 2f646e6162696e69 R14: 666e692f7665642f R15: 00000000006dbd2c Kernel Offset: disabled
--- drivers/infiniband/core/restrack.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/infiniband/core/restrack.c +3 -1
@@ -225,7 +225,9 @@ void rdma_restrack_del(struct rdma_restrup_write (&dev->res.rwsem); out: -if (res->task) +if (res->task) {put_task_struct (res->task); + res->task =NULL ; + } }EXPORT_SYMBOL (rdma_restrack_del);
Greg Kroah-Hartman
maintainerPATCH 4/63 powerpc/xive: Fix bogus error code returned by OPAL
In reply to Greg Kroah-HartmanFrom: Greg Kurz <[email protected]>
commit 6ccb4ac2bf8a35c694ead92f8ac5530a16e8f2c8 upstream.
There's a bug in skiboot that causes the OPAL_XIVE_ALLOCATE_IRQ call to return the 32-bit value 0xffffffff when OPAL has run out of IRQs. Unfortunatelty, OPAL return values are signed 64-bit entities and errors are supposed to be negative. If that happens, the linux code confusingly treats 0xffffffff as a valid IRQ number and panics at some point.
A fix was recently merged in skiboot:
e97391ae2bb5 ("xive: fix return value of opal_xive_allocate_irq()")
but we need a workaround anyway to support older skiboots already in the field.
Internally convert 0xffffffff to OPAL_RESOURCE which is the usual error returned upon resource exhaustion.
(groug: fix arch/powerpc/platforms/powernv/opal-wrappers.S instead of
non-existing arch/powerpc/platforms/powernv/opal-call.c)
--- arch/powerpc/include/asm/opal.h | 2 +- arch/powerpc/platforms/powernv/opal-wrappers.S | 2 +- arch/powerpc/sysdev/xive/native.c | 11 +++++++++++ 3 files changed, 13 insertions(+), 2 deletions(-)
arch/powerpc/include/asm/opal.h +1 -1
@@ -275,7 +275,7 @@ int64_t opal_xive_get_vp_info(uint64_t vint64_t opal_xive_set_vp_info (uint64_t vp,uint64_t flags,uint64_t report_cl_pair); -int64_t opal_xive_allocate_irq (uint32_t chip_id); +int64_t opal_xive_allocate_irq_raw (uint32_t chip_id);int64_t opal_xive_free_irq (uint32_t girq);int64_t opal_xive_sync (uint32_t type,uint32_t id);int64_t opal_xive_dump (uint32_t type,uint32_t id);
arch/powerpc/platforms/powernv/opal-wrappers.S +1 -1
@@ -303,7 +303,7 @@ OPAL_CALL(opal_xive_set_queue_info, OPA OPAL_CALL(opal_xive_donate_page, OPAL_XIVE_DONATE_PAGE); OPAL_CALL(opal_xive_alloc_vp_block, OPAL_XIVE_ALLOCATE_VP_BLOCK); OPAL_CALL(opal_xive_free_vp_block, OPAL_XIVE_FREE_VP_BLOCK); -OPAL_CALL(opal_xive_allocate_irq, OPAL_XIVE_ALLOCATE_IRQ); +OPAL_CALL(opal_xive_allocate_irq_raw, OPAL_XIVE_ALLOCATE_IRQ); OPAL_CALL(opal_xive_free_irq, OPAL_XIVE_FREE_IRQ); OPAL_CALL(opal_xive_get_vp_info, OPAL_XIVE_GET_VP_INFO); OPAL_CALL(opal_xive_set_vp_info, OPAL_XIVE_SET_VP_INFO);
arch/powerpc/sysdev/xive/native.c +11 -0
@@ -235,6 +235,17 @@ static bool xive_native_match(struct devreturn of_device_is_compatible (node,"ibm,opal-xive-vc" ); } +static s64 opal_xive_allocate_irq (u32 chip_id) +{ +s64 irq =opal_xive_allocate_irq_raw (chip_id); + +/* +* Old versions of skiboot can incorrectly return 0xffffffff to +* indicate no space, fix it up here. +*/ +return irq ==0xffffffff ?OPAL_RESOURCE : irq; +} +#ifdef CONFIG_SMP static int xive_native_get_ipi (unsigned int cpu,struct xive_cpu *xc) {
Greg Kroah-Hartman
maintainerPATCH 5/63 drm/amd/display: readd -msse2 to prevent Clang from emitting libcalls to undefined SW FP routines
In reply to Greg Kroah-HartmanFrom: Nick Desaulniers <[email protected]>
[ Upstream commit 0f0727d971f6fdf8f1077180d495ddb9928f0c8b ]
arch/x86/Makefile disables SSE and SSE2 for the whole kernel. The AMDGPU drivers modified in this patch re-enable SSE but not SSE2. Turn on SSE2 to support emitting double precision floating point instructions rather than calls to non-existent (usually available from gcc_s or compiler_rt) floating point helper routines for Clang.
This was originally landed in:
commit 10117450735c ("drm/amd/display: add -msse2 to prevent Clang from emitting libcalls to undefined SW FP routines") but reverted in:
commit 193392ed9f69 ("Revert "drm/amd/display: add -msse2 to prevent Clang from emitting libcalls to undefined SW FP routines"") due to bugreports from GCC builds. Add guards to only do so for Clang.
--- drivers/gpu/drm/amd/display/dc/calcs/Makefile | 4 ++++ drivers/gpu/drm/amd/display/dc/dml/Makefile | 4 ++++ 2 files changed, 8 insertions(+)
drivers/gpu/drm/amd/display/dc/calcs/Makefile +4 -0
@@ -32,6 +32,10 @@ endif calcs_ccflags := -mhard-float -msse $(cc_stack_align) +ifdef CONFIG_CC_IS_CLANG +calcs_ccflags += -msse2 +endif + CFLAGS_dcn_calcs.o := $(calcs_ccflags) CFLAGS_dcn_calc_auto.o := $(calcs_ccflags) CFLAGS_dcn_calc_math.o := $(calcs_ccflags) -Wno-tautological-compare
drivers/gpu/drm/amd/display/dc/dml/Makefile +4 -0
@@ -32,6 +32,10 @@ endif dml_ccflags := -mhard-float -msse $(cc_stack_align) +ifdef CONFIG_CC_IS_CLANG +dml_ccflags += -msse2 +endif + CFLAGS_display_mode_lib.o := $(dml_ccflags) CFLAGS_display_pipe_clocks.o := $(dml_ccflags) CFLAGS_dml1_display_rq_dlg_calc.o := $(dml_ccflags)
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 6/63 IB/core: Add an unbound WQ type to the new CQ API
In reply to Greg Kroah-HartmanFrom: Jack Morgenstein <[email protected]>
commit f794809a7259dfaa3d47d90ef5a86007cf48b1ce upstream.
The upstream kernel commit cited below modified the workqueue in the new CQ API to be bound to a specific CPU (instead of being unbound). This caused ALL users of the new CQ API to use the same bound WQ.
Specifically, MAD handling was severely delayed when the CPU bound to the WQ was busy handling (higher priority) interrupts.
This caused a delay in the MAD "heartbeat" response handling, which resulted in ports being incorrectly classified as "down".
To fix this, add a new "unbound" WQ type to the new CQ API, so that users have the option to choose either a bound WQ or an unbound WQ.
For MADs, choose the new "unbound" WQ.
--- drivers/infiniband/core/cq.c | 8 ++++++-- drivers/infiniband/core/device.c | 15 ++++++++++++++- drivers/infiniband/core/mad.c | 2 +- include/rdma/ib_verbs.h | 9 ++++++--- 4 files changed, 27 insertions(+), 7 deletions(-)
drivers/infiniband/core/cq.c +6 -2
@@ -112,12 +112,12 @@ static void ib_cq_poll_work(struct work_ IB_POLL_BATCH);if (completed >=IB_POLL_BUDGET_WORKQUEUE ||ib_req_notify_cq (cq,IB_POLL_FLAGS ) >0 ) -queue_work (ib_comp_wq, &cq->work); +queue_work (cq->comp_wq, &cq->work); }static void ib_cq_completion_workqueue (struct ib_cq *cq,void *private) { -queue_work (ib_comp_wq, &cq->work); +queue_work (cq->comp_wq, &cq->work); }/**
@@ -175,9 +175,12 @@ struct ib_cq *__ib_alloc_cq(struct ib_deib_req_notify_cq (cq,IB_CQ_NEXT_COMP );break ;case IB_POLL_WORKQUEUE : +case IB_POLL_UNBOUND_WORKQUEUE : cq->comp_handler = ib_cq_completion_workqueue;INIT_WORK (&cq->work, ib_cq_poll_work);ib_req_notify_cq (cq,IB_CQ_NEXT_COMP ); + cq->comp_wq = (cq->poll_ctx ==IB_POLL_WORKQUEUE ) ? + ib_comp_wq : ib_comp_unbound_wq;break ;default : ret = -EINVAL ;
@@ -213,6 +216,7 @@ void ib_free_cq(struct ib_cq *cq)irq_poll_disable (&cq->iop);break ;case IB_POLL_WORKQUEUE : +case IB_POLL_UNBOUND_WORKQUEUE :cancel_work_sync (&cq->work);break ;default :
drivers/infiniband/core/device.c +14 -1
@@ -61,6 +61,7 @@ struct ib_client_data { };struct workqueue_struct *ib_comp_wq; +struct workqueue_struct *ib_comp_unbound_wq;struct workqueue_struct *ib_wq;EXPORT_SYMBOL_GPL (ib_wq);
@@ -1166,10 +1167,19 @@ static int __init ib_core_init(void) goto err; } + ib_comp_unbound_wq = +alloc_workqueue ("ib-comp-unb-wq" , +WQ_UNBOUND |WQ_HIGHPRI |WQ_MEM_RECLAIM | +WQ_SYSFS ,WQ_UNBOUND_MAX_ACTIVE ); +if (!ib_comp_unbound_wq) { + ret = -ENOMEM ; + goto err_comp; + } + ret =class_register (&ib_class);if (ret) {pr_warn ("Couldn't create InfiniBand device class\n" ); - goto err_comp; + goto err_comp_unbound; } ret =rdma_nl_init ();
@@ -1218,6 +1228,8 @@ err_ibnl:rdma_nl_exit (); err_sysfs:class_unregister (&ib_class); +err_comp_unbound: +destroy_workqueue (ib_comp_unbound_wq); err_comp:destroy_workqueue (ib_comp_wq); err:
@@ -1236,6 +1248,7 @@ static void __exit ib_core_cleanup(void)addr_cleanup ();rdma_nl_exit ();class_unregister (&ib_class); +destroy_workqueue (ib_comp_unbound_wq);destroy_workqueue (ib_comp_wq);/* Make sure that any pending umem accounting work is done. */ destroy_workqueue (ib_wq);
drivers/infiniband/core/mad.c +1 -1
@@ -3190,7 +3190,7 @@ static int ib_mad_port_open(struct ib_de } port_priv->cq =ib_alloc_cq (port_priv->device, port_priv, cq_size,0 , -IB_POLL_WORKQUEUE ); +IB_POLL_UNBOUND_WORKQUEUE );if (IS_ERR (port_priv->cq)) {dev_err (&device->dev,"Couldn't create ib_mad CQ\n" ); ret =PTR_ERR (port_priv->cq);
include/rdma/ib_verbs.h +6 -3
@@ -71,6 +71,7 @@extern struct workqueue_struct *ib_wq;extern struct workqueue_struct *ib_comp_wq; +extern struct workqueue_struct *ib_comp_unbound_wq;union ib_gid {u8 raw[16 ];
@@ -1576,9 +1577,10 @@ struct ib_ah {typedef void (*ib_comp_handler )(struct ib_cq *cq,void *cq_context);enum ib_poll_context { -IB_POLL_DIRECT ,/* caller context, no hw completions */ -IB_POLL_SOFTIRQ ,/* poll from softirq context */ -IB_POLL_WORKQUEUE ,/* poll from workqueue */ +IB_POLL_DIRECT ,/* caller context, no hw completions */ +IB_POLL_SOFTIRQ ,/* poll from softirq context */ +IB_POLL_WORKQUEUE ,/* poll from workqueue */ +IB_POLL_UNBOUND_WORKQUEUE ,/* poll from unbound workqueue */ };struct ib_cq {
@@ -1595,6 +1597,7 @@ struct ib_cq {struct irq_poll iop;struct work_struct work; }; +struct workqueue_struct *comp_wq;/* * Implementation details of the RDMA core, don't use in drivers: */
Greg Kroah-Hartman
maintainerPATCH 7/63 HID: prodikeys: Fix general protection fault during probe
In reply to Greg Kroah-HartmanFrom: Alan Stern <[email protected]>
commit 98375b86c79137416e9fd354177b85e768c16e56 upstream.
The syzbot fuzzer provoked a general protection fault in the hid-prodikeys driver:
kasan: CONFIG_KASAN_INLINE enabled
kasan: GPF could be caused by NULL-ptr deref or user memory access
general protection fault: 0000 [#1] SMP KASAN CPU: 0 PID: 12 Comm: kworker/0:1 Not tainted 5.3.0-rc5+ #28 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Workqueue: usb_hub_wq hub_event RIP: 0010:pcmidi_submit_output_report drivers/hid/hid-prodikeys.c:300 [inline] RIP: 0010:pcmidi_set_operational drivers/hid/hid-prodikeys.c:558 [inline] RIP: 0010:pcmidi_snd_initialise drivers/hid/hid-prodikeys.c:686 [inline] RIP: 0010:pk_probe+0xb51/0xfd0 drivers/hid/hid-prodikeys.c:836 Code: 0f 85 50 04 00 00 48 8b 04 24 4c 89 7d 10 48 8b 58 08 e8 b2 53 e4 fc
48 8b 54 24 20 48 b8 00 00 00 00 00 fc ff df 48 c1 ea 03 <80> 3c 02 00 0f 85 13 04 00 00 48 ba 00 00 00 00 00 fc ff df 49 8b
The problem is caused by the fact that pcmidi_get_output_report() will return an error if the HID device doesn't provide the right sort of output report, but pcmidi_set_operational() doesn't bother to check the return code and assumes the function call always succeeds.
This patch adds the missing check and aborts the probe operation if necessary.
--- drivers/hid/hid-prodikeys.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-)
drivers/hid/hid-prodikeys.c +10 -2
@@ -555,10 +555,14 @@ static void pcmidi_setup_extra_keys(static int pcmidi_set_operational (struct pcmidi_snd *pm) { +int rc; +if (pm->ifnum !=1 )return 0 ;/* only set up ONCE for interace 1 */ -pcmidi_get_output_report (pm); + rc =pcmidi_get_output_report (pm); +if (rc <0 ) +return rc;pcmidi_submit_output_report (pm,0xc1 );return 0 ; }
@@ -687,7 +691,11 @@ static int pcmidi_snd_initialise(structspin_lock_init (&pm->rawmidi_in_lock);init_sustain_timers (pm); -pcmidi_set_operational (pm); + err =pcmidi_set_operational (pm); +if (err <0 ) { +pk_error ("failed to find output report\n" ); + goto fail_register; + }/* register it */ err =snd_card_register (card);
Greg Kroah-Hartman
maintainerPATCH 8/63 HID: sony: Fix memory corruption issue on cleanup.
In reply to Greg Kroah-HartmanFrom: Roderick Colenbrander <[email protected]>
commit 2bcdacb70327013ca2066bfcf2af1009eff01f1d upstream.
The sony driver is not properly cleaning up from potential failures in sony_input_configured. Currently it calls hid_hw_stop, while hid_connect is still running. This is not a good idea, instead hid_hw_stop should be moved to sony_probe. Similar changes were recently made to Logitech drivers, which were also doing improper cleanup.
--- drivers/hid/hid-sony.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hid/hid-sony.c +1 -1
@@ -2806,7 +2806,6 @@ err_stop:sony_cancel_work_sync (sc);sony_remove_dev_list (sc);sony_release_device_id (sc); -hid_hw_stop (hdev);return ret; }
@@ -2868,6 +2867,7 @@ static int sony_probe(struct hid_device*/ if (!(hdev->claimed &HID_CLAIMED_INPUT )) {hid_err (hdev,"failed to claim input\n" ); +hid_hw_stop (hdev);return -ENODEV ; }
Greg Kroah-Hartman
maintainerPATCH 9/63 HID: logitech: Fix general protection fault caused by Logitech driver
In reply to Greg Kroah-HartmanFrom: Alan Stern <[email protected]>
commit 5f9242775bb61f390f0885f23fc16397262c7538 upstream.
The syzbot fuzzer found a general protection fault in the HID subsystem:
kasan: CONFIG_KASAN_INLINE enabled
kasan: GPF could be caused by NULL-ptr deref or user memory access
general protection fault: 0000 [#1] SMP KASAN CPU: 0 PID: 3715 Comm: syz-executor.3 Not tainted 5.2.0-rc6+ #15 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 RIP: 0010:__pm_runtime_resume+0x49/0x180 drivers/base/power/runtime.c:1069 Code: ed 74 d5 fe 45 85 ed 0f 85 9a 00 00 00 e8 6f 73 d5 fe 48 8d bd c1 02 00 00 48 b8 00 00 00 00 00 fc ff df 48 89 fa 48 c1 ea 03 <0f> b6 04 02 48 89 fa 83 e2 07 38 d0 7f 08 84 c0 0f 85 fe 00 00 00 RSP: 0018:ffff8881d99d78e0 EFLAGS: 00010202 RAX: dffffc0000000000 RBX: 0000000000000020 RCX: ffffc90003f3f000 RDX: 0000000416d8686d RSI: ffffffff82676841 RDI: 00000020b6c3436a RBP: 00000020b6c340a9 R08: ffff8881c6d64800 R09: fffffbfff0e84c25 R10: ffff8881d99d7940 R11: ffffffff87426127 R12: 0000000000000004 R13: 0000000000000000 R14: ffff8881d9b94000 R15: ffffffff897f9048 FS: 00007f047f542700(0000) GS:ffff8881db200000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 0000001b30f21000 CR3: 00000001ca032000 CR4: 00000000001406f0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Call Trace: pm_runtime_get_sync include/linux/pm_runtime.h:226 [inline] usb_autopm_get_interface+0x1b/0x50 drivers/usb/core/driver.c:1707 usbhid_power+0x7c/0xe0 drivers/hid/usbhid/hid-core.c:1234 hid_hw_power include/linux/hid.h:1038 [inline] hidraw_open+0x20d/0x740 drivers/hid/hidraw.c:282 chrdev_open+0x219/0x5c0 fs/char_dev.c:413 do_dentry_open+0x497/0x1040 fs/open.c:778 do_last fs/namei.c:3416 [inline] path_openat+0x1430/0x3ff0 fs/namei.c:3533 do_filp_open+0x1a1/0x280 fs/namei.c:3563 do_sys_open+0x3c0/0x580 fs/open.c:1070 do_syscall_64+0xb7/0x560 arch/x86/entry/common.c:301 entry_SYSCALL_64_after_hwframe+0x49/0xbe
It turns out the fault was caused by a bug in the HID Logitech driver, which violates the requirement that every pathway calling hid_hw_start() must also call hid_hw_stop(). This patch fixes the bug by making sure the requirement is met.
--- drivers/hid/hid-lg.c | 10 ++++++---- drivers/hid/hid-lg4ff.c | 1 - 2 files changed, 6 insertions(+), 5 deletions(-)
drivers/hid/hid-lg.c +6 -4
@@ -763,7 +763,7 @@ static int lg_probe(struct hid_device *hif (!buf) { ret = -ENOMEM ; - goto err_free; + goto err_stop; } ret = hid_hw_raw_request(hdev, buf[0], buf, sizeof(cbuf),
@@ -795,9 +795,12 @@ static int lg_probe(struct hid_device *h ret =lg4ff_init (hdev);if (ret) - goto err_free; + goto err_stop;return 0 ; + +err_stop: +hid_hw_stop (hdev); err_free:kfree (drv_data);return ret;
@@ -808,8 +811,7 @@ static void lg_remove(struct hid_devicestruct lg_drv_data *drv_data =hid_get_drvdata (hdev);if (drv_data->quirks &LG_FF4 )lg4ff_deinit (hdev); -else -hid_hw_stop (hdev); +hid_hw_stop (hdev);kfree (drv_data); }
drivers/hid/hid-lg4ff.c +0 -1
@@ -1483,7 +1483,6 @@ int lg4ff_deinit(struct hid_device *hid) } }#endif -hid_hw_stop (hid); drv_data->device_props =NULL ;kfree (entry);
Greg Kroah-Hartman
maintainerPATCH 10/63 HID: hidraw: Fix invalid read in hidraw_ioctl
In reply to Greg Kroah-HartmanFrom: Alan Stern <[email protected]>
commit 416dacb819f59180e4d86a5550052033ebb6d72c upstream.
The syzbot fuzzer has reported a pair of problems in the hidraw_ioctl() function: slab-out-of-bounds read and use-after-free read. An example of the first:
BUG: KASAN: slab-out-of-bounds in strlen+0x79/0x90 lib/string.c:525 Read of size 1 at addr ffff8881c8035f38 by task syz-executor.4/2833 CPU: 1 PID: 2833 Comm: syz-executor.4 Not tainted 5.3.0-rc2+ #1 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0xca/0x13e lib/dump_stack.c:113 print_address_description+0x6a/0x32c mm/kasan/report.c:351 __kasan_report.cold+0x1a/0x33 mm/kasan/report.c:482 kasan_report+0xe/0x12 mm/kasan/common.c:612 strlen+0x79/0x90 lib/string.c:525 strlen include/linux/string.h:281 [inline] hidraw_ioctl+0x245/0xae0 drivers/hid/hidraw.c:446 vfs_ioctl fs/ioctl.c:46 [inline] file_ioctl fs/ioctl.c:509 [inline] do_vfs_ioctl+0xd2d/0x1330 fs/ioctl.c:696 ksys_ioctl+0x9b/0xc0 fs/ioctl.c:713 __do_sys_ioctl fs/ioctl.c:720 [inline] __se_sys_ioctl fs/ioctl.c:718 [inline] __x64_sys_ioctl+0x6f/0xb0 fs/ioctl.c:718 do_syscall_64+0xb7/0x580 arch/x86/entry/common.c:296 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x459829 Code: fd b7 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f8 48 89 f7
48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 cb b7 fb ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007f7a68f6dc78 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 0000000000459829
RDX: 0000000000000000 RSI: 0000000080404805 RDI: 0000000000000004
RBP: 000000000075bf20 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 00007f7a68f6e6d4
R13: 00000000004c21de R14: 00000000004d5620 R15: 00000000ffffffff
The two problems have the same cause: hidraw_ioctl() fails to test whether the device has been removed. This patch adds the missing test.
--- drivers/hid/hidraw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hid/hidraw.c +1 -1
@@ -378,7 +378,7 @@ static long hidraw_ioctl(struct file *fimutex_lock (&minors_lock); dev = hidraw_table[minor]; -if (!dev) { +if (!dev || !dev->exist) { ret = -ENODEV ; goto out; }
Greg Kroah-Hartman
maintainerPATCH 11/63 HID: Add quirk for HP X500 PIXART OEM mouse
In reply to Greg Kroah-HartmanFrom: Sebastian Parschauer <[email protected]>
commit 2acf40f0454d41b8d51c95d317283c20c931164d upstream.
The PixArt OEM mice are known for disconnecting every minute in runlevel 1 or 3 if they are not always polled. So add quirk ALWAYS_POLL for this one as well.
Ville Viinikka (viinikv) reported and tested the quirk.
--- drivers/hid/hid-ids.h | 1 + drivers/hid/hid-quirks.c | 1 + 2 files changed, 2 insertions(+)
drivers/hid/hid-ids.h +1 -0
@@ -559,6 +559,7 @@#define USB_PRODUCT_ID_HP_LOGITECH_OEM_USB_OPTICAL_MOUSE_0B4A 0x0b4a#define USB_PRODUCT_ID_HP_PIXART_OEM_USB_OPTICAL_MOUSE 0x134a#define USB_PRODUCT_ID_HP_PIXART_OEM_USB_OPTICAL_MOUSE_094A 0x094a +#define USB_PRODUCT_ID_HP_PIXART_OEM_USB_OPTICAL_MOUSE_0941 0x0941#define USB_PRODUCT_ID_HP_PIXART_OEM_USB_OPTICAL_MOUSE_0641 0x0641#define USB_VENDOR_ID_HUION 0x256c
drivers/hid/hid-quirks.c +1 -0
@@ -94,6 +94,7 @@ static const struct hid_device_id hid_qu { HID_USB_DEVICE(USB_VENDOR_ID_HP, USB_PRODUCT_ID_HP_LOGITECH_OEM_USB_OPTICAL_MOUSE_0B4A), HID_QUIRK_ALWAYS_POLL }, { HID_USB_DEVICE(USB_VENDOR_ID_HP, USB_PRODUCT_ID_HP_PIXART_OEM_USB_OPTICAL_MOUSE), HID_QUIRK_ALWAYS_POLL }, { HID_USB_DEVICE(USB_VENDOR_ID_HP, USB_PRODUCT_ID_HP_PIXART_OEM_USB_OPTICAL_MOUSE_094A), HID_QUIRK_ALWAYS_POLL }, + { HID_USB_DEVICE(USB_VENDOR_ID_HP, USB_PRODUCT_ID_HP_PIXART_OEM_USB_OPTICAL_MOUSE_0941), HID_QUIRK_ALWAYS_POLL }, { HID_USB_DEVICE(USB_VENDOR_ID_HP, USB_PRODUCT_ID_HP_PIXART_OEM_USB_OPTICAL_MOUSE_0641), HID_QUIRK_ALWAYS_POLL }, { HID_USB_DEVICE(USB_VENDOR_ID_IDEACOM, USB_DEVICE_ID_IDEACOM_IDC6680), HID_QUIRK_MULTI_INPUT }, { HID_USB_DEVICE(USB_VENDOR_ID_INNOMEDIA, USB_DEVICE_ID_INNEX_GENESIS_ATARI), HID_QUIRK_MULTI_INPUT },
Greg Kroah-Hartman
maintainerPATCH 12/63 mtd: cfi_cmdset_0002: Use chip_good() to retry in do_write_oneword()
In reply to Greg Kroah-HartmanFrom: Tokunori Ikegami <[email protected]>
commit 37c673ade35c707d50583b5b25091ff8ebdeafd7 upstream.
As reported by the OpenWRT team, write requests sometimes fail on some platforms.
Currently to check the state chip_ready() is used correctly as described by the flash memory S29GL256P11TFI01 datasheet.
Also chip_good() is used to check if the write is succeeded and it was implemented by the commit fb4a90bfcd6d8 ("[MTD] CFI-0002 - Improve error checking").
But actually the write failure is caused on some platforms and also it can be fixed by using chip_good() to check the state and retry instead. Also it seems that it is caused after repeated about 1,000 times to retry the write one word with the reset command.
By using chip_good() to check the state to be done it can be reduced the retry with reset.
It is depended on the actual flash chip behavior so the root cause is unknown.
--- drivers/mtd/chips/cfi_cmdset_0002.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-)
drivers/mtd/chips/cfi_cmdset_0002.c +12 -6
@@ -1627,29 +1627,35 @@ static int __xipram do_write_oneword(strcontinue ; } -if (time_after (jiffies, timeo) && !chip_ready (map, adr)){ +/* +* We check "time_after" and "!chip_good" before checking +* "chip_good" to avoid the failure due to scheduling. +*/ +if (time_after (jiffies, timeo) && !chip_good (map, adr, datum)) {xip_enable (map, chip, adr);printk (KERN_WARNING "MTD %s(): software timeout\n" , __func__);xip_disable (map, chip, adr); + ret = -EIO ;break ; } -if (chip_ready (map, adr)) +if (chip_good (map, adr, datum))break ;/* Latency issues. Drop the lock, wait a while and retry */ UDELAY (map, chip, adr,1 ); } +/* Did we succeed? */ -if (!chip_good (map, adr, datum)) { +if (ret) {/* reset on all failures. */ map_write (map,CMD (0xF0 ), chip->start);/* FIXME - should have reset delay before continuing */ -if (++retry_cnt <=MAX_RETRIES ) +if (++retry_cnt <=MAX_RETRIES ) { + ret =0 ; goto retry; - - ret = -EIO ; + } }xip_enable (map, chip, adr); op_done:
Greg Kroah-Hartman
maintainerPATCH 13/63 crypto: talitos - fix missing break in switch statement
In reply to Greg Kroah-HartmanFrom: Gustavo A. R. Silva <[email protected]>
commit 5fc194ea6d34dfad9833d3043ce41d6c52aff39a upstream.
Add missing break statement in order to prevent the code from falling through to case CRYPTO_ALG_TYPE_AHASH.
--- drivers/crypto/talitos.c | 1 + 1 file changed, 1 insertion(+)
drivers/crypto/talitos.c +1 -0
@@ -3124,6 +3124,7 @@ static int talitos_remove(struct platforbreak ;case CRYPTO_ALG_TYPE_AEAD :crypto_unregister_aead (&t_alg->algt.alg.aead); +break ;case CRYPTO_ALG_TYPE_AHASH :crypto_unregister_ahash (&t_alg->algt.alg.hash);break ;
Greg Kroah-Hartman
maintainerPATCH 14/63 CIFS: fix deadlock in cached root handling
In reply to Greg Kroah-HartmanFrom: Aurelien Aptel <[email protected]>
commit 7e5a70ad88b1e6f6d9b934b2efb41afff496820f upstream.
Prevent deadlock between open_shroot() and cifs_mark_open_files_invalid() by releasing the lock before entering SMB2_open, taking it again after and checking if we still need to use the result.
--- fs/cifs/smb2ops.c | 44 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+)
fs/cifs/smb2ops.c +44 -0
@@ -553,7 +553,50 @@ int open_shroot(unsigned int xid, struct oparams.fid = pfid; oparams.reconnect = false; +/* +* We do not hold the lock for the open because in case +* SMB2_open needs to reconnect, it will end up calling +* cifs_mark_open_files_invalid() which takes the lock again +* thus causing a deadlock +*/ +mutex_unlock (&tcon->crfid.fid_mutex); rc =SMB2_open (xid, &oparams, &srch_path, &oplock,NULL ,NULL ,NULL ); +mutex_lock (&tcon->crfid.fid_mutex); + +/* +* Now we need to check again as the cached root might have +* been successfully re-opened from a concurrent process +*/ + +if (tcon->crfid.is_valid) { +/* work was already done */ + +/* stash fids for close() later */ +struct cifs_fid fid = { + .persistent_fid = pfid->persistent_fid, + .volatile_fid = pfid->volatile_fid, + }; + +/* +* Caller expects this func to set pfid to a valid +* cached root, so we copy the existing one and get a +* reference +*/ +memcpy (pfid, tcon->crfid.fid,sizeof (*pfid)); +kref_get (&tcon->crfid.refcount); + +mutex_unlock (&tcon->crfid.fid_mutex); + +if (rc ==0 ) { +/* close extra handle outside of critical section */ +SMB2_close (xid, tcon, fid.persistent_fid, + fid.volatile_fid); + } +return 0 ; + } + +/* Cached root is still invalid, continue normaly */ +if (rc ==0 ) {memcpy (tcon->crfid.fid, pfid,sizeof (struct cifs_fid )); tcon->crfid.tcon = tcon;
@@ -561,6 +604,7 @@ int open_shroot(unsigned int xid, structkref_init (&tcon->crfid.refcount);kref_get (&tcon->crfid.refcount); } +mutex_unlock (&tcon->crfid.fid_mutex);return rc; }
Greg Kroah-Hartman
maintainerPATCH 15/63 net/mlx5e: Set ECN for received packets using CQE indication
In reply to Greg Kroah-HartmanFrom: Natali Shechtman <[email protected]>
[ Upstream commit f007c13d4ad62f494c83897eda96437005df4a91 ]
In multi-host (MH) NIC scheme, a single HW port serves multiple hosts or sockets on the same host.
The HW uses a mechanism in the PCIe buffer which monitors the amount of consumed PCIe buffers per host.
On a certain configuration, under congestion,
the HW emulates a switch doing ECN marking on packets using ECN indication on the completion descriptor (CQE).
The driver needs to set the ECN bits on the packet SKB, such that the network stack can react on that, this commit does that.
Needed by downstream patch which fixes a mlx5 checksum issue.
--- drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 35 ++++++++++++++++++--- drivers/net/ethernet/mellanox/mlx5/core/en_stats.c | 3 + drivers/net/ethernet/mellanox/mlx5/core/en_stats.h | 2 + 3 files changed, 35 insertions(+), 5 deletions(-)
drivers/net/ethernet/mellanox/mlx5/core/en_rx.c +30 -5
@@ -37,6 +37,7 @@#include <net/busy_poll.h> #include <net/ip6_checksum.h> #include <net/page_pool.h> +#include <net/inet_ecn.h> #include "en.h" #include "en_tc.h" #include "eswitch.h"
@@ -688,12 +689,29 @@ static inline void mlx5e_skb_set_hash(stskb_set_hash (skb,be32_to_cpu (cqe->rss_hash_result), ht); } -static inline bool is_last_ethertype_ip (struct sk_buff *skb,int *network_depth) +static inline bool is_last_ethertype_ip (struct sk_buff *skb,int *network_depth, +__be16 *proto) { -__be16 ethertype = ((struct ethhdr *)skb->data)->h_proto; + *proto = ((struct ethhdr *)skb->data)->h_proto; + *proto =__vlan_get_protocol (skb, *proto, network_depth); +return (*proto ==htons (ETH_P_IP ) || *proto ==htons (ETH_P_IPV6 )); +} + +static inline void mlx5e_enable_ecn (struct mlx5e_rq *rq,struct sk_buff *skb) +{ +int network_depth =0 ; +__be16 proto; +void *ip; +int rc; - ethertype =__vlan_get_protocol (skb, ethertype, network_depth); -return (ethertype ==htons (ETH_P_IP ) || ethertype ==htons (ETH_P_IPV6 )); +if (unlikely (!is_last_ethertype_ip (skb, &network_depth, &proto))) +return ; + + ip = skb->data + network_depth; + rc = ((proto ==htons (ETH_P_IP )) ?IP_ECN_set_ce ((struct iphdr *)ip) : +IP6_ECN_set_ce (skb, (struct ipv6hdr *)ip)); + + rq->stats->ecn_mark += !!rc; }static u32 mlx5e_get_fcs (const struct sk_buff *skb)
@@ -717,6 +735,7 @@ static inline void mlx5e_handle_csum(str {struct mlx5e_rq_stats *stats = rq->stats;int network_depth =0 ; +__be16 proto;if (unlikely (!(netdev->features &NETIF_F_RXCSUM ))) goto csum_none;
@@ -738,7 +757,7 @@ static inline void mlx5e_handle_csum(strif (short_frame (skb->len)) goto csum_unnecessary; -if (likely (is_last_ethertype_ip (skb, &network_depth))) { +if (likely (is_last_ethertype_ip (skb, &network_depth, &proto))) { skb->ip_summed =CHECKSUM_COMPLETE ; skb->csum =csum_unfold ((__force __sum16 )cqe->check_sum);if (network_depth >ETH_HLEN )
@@ -775,6 +794,8 @@ csum_none: stats->csum_none++; } +#define MLX5E_CE_BIT_MASK 0x80 + static inline void mlx5e_build_rx_skb(struct mlx5_cqe64 *cqe, u32 cqe_bcnt, struct mlx5e_rq *rq,
@@ -819,6 +840,10 @@ static inline void mlx5e_build_rx_skb(st skb->mark =be32_to_cpu (cqe->sop_drop_qpn) &MLX5E_TC_FLOW_ID_MASK ;mlx5e_handle_csum (netdev, cqe, rq, skb, !!lro_num_seg); +/* checking CE bit in cqe - MSB in ml_path field */ +if (unlikely (cqe->ml_path &MLX5E_CE_BIT_MASK )) +mlx5e_enable_ecn (rq, skb); + skb->protocol =eth_type_trans (skb, netdev); }
drivers/net/ethernet/mellanox/mlx5/core/en_stats.c +3 -0
@@ -53,6 +53,7 @@ static const struct counter_desc sw_stat { MLX5E_DECLARE_STAT(struct mlx5e_sw_stats, rx_lro_packets) }, { MLX5E_DECLARE_STAT(struct mlx5e_sw_stats, rx_lro_bytes) }, + { MLX5E_DECLARE_STAT(struct mlx5e_sw_stats, rx_ecn_mark) }, { MLX5E_DECLARE_STAT(struct mlx5e_sw_stats, rx_removed_vlan_packets) }, { MLX5E_DECLARE_STAT(struct mlx5e_sw_stats, rx_csum_unnecessary) }, { MLX5E_DECLARE_STAT(struct mlx5e_sw_stats, rx_csum_none) },
@@ -144,6 +145,7 @@ void mlx5e_grp_sw_update_stats(struct ml s->rx_bytes += rq_stats->bytes; s->rx_lro_packets += rq_stats->lro_packets; s->rx_lro_bytes += rq_stats->lro_bytes; + s->rx_ecn_mark += rq_stats->ecn_mark; s->rx_removed_vlan_packets += rq_stats->removed_vlan_packets; s->rx_csum_none += rq_stats->csum_none; s->rx_csum_complete += rq_stats->csum_complete;
@@ -1144,6 +1146,7 @@ static const struct counter_desc rq_stat { MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, xdp_redirect) }, { MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, lro_packets) }, { MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, lro_bytes) }, + { MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, ecn_mark) }, { MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, removed_vlan_packets) }, { MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, wqe_err) }, { MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, mpwqe_filler_cqes) },
drivers/net/ethernet/mellanox/mlx5/core/en_stats.h +2 -0
@@ -66,6 +66,7 @@ struct mlx5e_sw_stats {u64 tx_nop;u64 rx_lro_packets;u64 rx_lro_bytes; +u64 rx_ecn_mark;u64 rx_removed_vlan_packets;u64 rx_csum_unnecessary;u64 rx_csum_none;
@@ -184,6 +185,7 @@ struct mlx5e_rq_stats {u64 csum_none;u64 lro_packets;u64 lro_bytes; +u64 ecn_mark;u64 removed_vlan_packets;u64 xdp_drop;u64 xdp_redirect;
Greg Kroah-Hartman
maintainerPATCH 16/63 net/mlx5e: dont set CHECKSUM_COMPLETE on SCTP packets
In reply to Greg Kroah-HartmanFrom: Alaa Hleihel <[email protected]>
[ Upstream commit fe1dc069990c1f290ef6b99adb46332c03258f38 ]
CHECKSUM_COMPLETE is not applicable to SCTP protocol. Setting it for SCTP packets leads to CRC32c validation failure.
--- drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
drivers/net/ethernet/mellanox/mlx5/core/en_rx.c +11 -0
@@ -725,6 +725,14 @@ static u32 mlx5e_get_fcs(const struct skreturn __get_unaligned_cpu32 (fcs_bytes); } +static u8 get_ip_proto (struct sk_buff *skb,__be16 proto) +{ +void *ip_p = skb->data +sizeof (struct ethhdr ); + +return (proto ==htons (ETH_P_IP )) ? ((struct iphdr *)ip_p)->protocol : + ((struct ipv6hdr *)ip_p)->nexthdr; +} +#define short_frame (size) ((size) <= ETH_ZLEN + ETH_FCS_LEN) static inline void mlx5e_handle_csum(struct net_device *netdev,
@@ -758,6 +766,9 @@ static inline void mlx5e_handle_csum(str goto csum_unnecessary;if (likely (is_last_ethertype_ip (skb, &network_depth, &proto))) { +if (unlikely (get_ip_proto (skb, proto) ==IPPROTO_SCTP )) + goto csum_unnecessary; + skb->ip_summed =CHECKSUM_COMPLETE ; skb->csum =csum_unfold ((__force __sum16 )cqe->check_sum);if (network_depth >ETH_HLEN )
Greg Kroah-Hartman
maintainerPATCH 17/63 mlx5: fix get_ip_proto()
In reply to Greg Kroah-HartmanFrom: Cong Wang <[email protected]>
[ Upstream commit ef6fcd455278c2be3032a346cc66d9dd9866b787 ]
IP header is not necessarily located right after struct ethhdr, there could be multiple 802.1Q headers in between, this is why we call __vlan_get_protocol().
--- drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/ethernet/mellanox/mlx5/core/en_rx.c +3 -3
@@ -725,9 +725,9 @@ static u32 mlx5e_get_fcs(const struct skreturn __get_unaligned_cpu32 (fcs_bytes); } -static u8 get_ip_proto (struct sk_buff *skb,__be16 proto) +static u8 get_ip_proto (struct sk_buff *skb,int network_depth,__be16 proto) { -void *ip_p = skb->data +sizeof (struct ethhdr ); +void *ip_p = skb->data + network_depth;return (proto ==htons (ETH_P_IP )) ? ((struct iphdr *)ip_p)->protocol : ((struct ipv6hdr *)ip_p)->nexthdr;
@@ -766,7 +766,7 @@ static inline void mlx5e_handle_csum(str goto csum_unnecessary;if (likely (is_last_ethertype_ip (skb, &network_depth, &proto))) { -if (unlikely (get_ip_proto (skb, proto) ==IPPROTO_SCTP )) +if (unlikely (get_ip_proto (skb, network_depth, proto) ==IPPROTO_SCTP )) goto csum_unnecessary; skb->ip_summed =CHECKSUM_COMPLETE ;
Greg Kroah-Hartman
maintainerPATCH 18/63 net/mlx5e: Allow reporting of checksum unnecessary
In reply to Greg Kroah-HartmanFrom: Or Gerlitz <[email protected]>
[ Upstream commit b856df28f9230a47669efbdd57896084caadb2b3 ]
Currently we practically never report checksum unnecessary, because for all IP packets we take the checksum complete path.
Enable non-default runs with reprorting checksum unnecessary, using an ethtool private flag. This can be useful for performance evals and other explorations.
Required by downstream patch which fixes XDP checksum.
--- drivers/net/ethernet/mellanox/mlx5/core/en.h | 3 ++ drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c | 27 +++++++++++++++++++ drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 4 ++ drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 3 ++ 4 files changed, 37 insertions(+)
drivers/net/ethernet/mellanox/mlx5/core/en.h +3 -0
@@ -210,6 +210,7 @@ static const char mlx5e_priv_flags[][ETH"tx_cqe_moder" ,"rx_cqe_compress" ,"rx_striding_rq" , + "rx_no_csum_complete", }; enum mlx5e_priv_flag {
@@ -217,6 +218,7 @@ enum mlx5e_priv_flag {MLX5E_PFLAG_TX_CQE_BASED_MODER = (1 <<1 ),MLX5E_PFLAG_RX_CQE_COMPRESS = (1 <<2 ),MLX5E_PFLAG_RX_STRIDING_RQ = (1 <<3 ), + MLX5E_PFLAG_RX_NO_CSUM_COMPLETE = (1 << 4), };#define MLX5E_SET_PFLAG (params, pflag, enable) \
@@ -298,6 +300,7 @@ struct mlx5e_dcbx_dp {enum {MLX5E_RQ_STATE_ENABLED ,MLX5E_RQ_STATE_AM , +MLX5E_RQ_STATE_NO_CSUM_COMPLETE , };struct mlx5e_cq {
drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c +27 -0
@@ -1510,6 +1510,27 @@ static int set_pflag_rx_striding_rq(strureturn 0 ; } +static int set_pflag_rx_no_csum_complete (struct net_device *netdev,bool enable) +{ +struct mlx5e_priv *priv =netdev_priv (netdev); +struct mlx5e_channels *channels = &priv->channels; +struct mlx5e_channel *c; +int i; + +if (!test_bit (MLX5E_STATE_OPENED , &priv->state)) +return 0 ; + +for (i =0 ; i < channels->num; i++) { + c = channels->c[i]; +if (enable) +__set_bit (MLX5E_RQ_STATE_NO_CSUM_COMPLETE , &c->rq.state); +else +__clear_bit (MLX5E_RQ_STATE_NO_CSUM_COMPLETE , &c->rq.state); + } + +return 0 ; +} + static int mlx5e_handle_pflag(struct net_device *netdev, u32 wanted_flags, enum mlx5e_priv_flag flag,
@@ -1561,6 +1582,12 @@ static int mlx5e_set_priv_flags(struct n err =mlx5e_handle_pflag (netdev, pflags,MLX5E_PFLAG_RX_STRIDING_RQ , set_pflag_rx_striding_rq); +if (err) + goto out; + + err =mlx5e_handle_pflag (netdev, pflags, +MLX5E_PFLAG_RX_NO_CSUM_COMPLETE , + set_pflag_rx_no_csum_complete); out:mutex_unlock (&priv->state_lock);
drivers/net/ethernet/mellanox/mlx5/core/en_main.c +4 -0
@@ -934,6 +934,9 @@ static int mlx5e_open_rq(struct mlx5e_chif (params->rx_dim_enabled)__set_bit (MLX5E_RQ_STATE_AM , &c->rq.state); +if (params->pflags &MLX5E_PFLAG_RX_NO_CSUM_COMPLETE ) +__set_bit (MLX5E_RQ_STATE_NO_CSUM_COMPLETE , &c->rq.state); +return 0 ; err_destroy_rq:
@@ -4533,6 +4536,7 @@ void mlx5e_build_nic_params(struct mlx5_ params->rx_cqe_compress_def =slow_pci_heuristic (mdev);MLX5E_SET_PFLAG (params,MLX5E_PFLAG_RX_CQE_COMPRESS , params->rx_cqe_compress_def); +MLX5E_SET_PFLAG (params,MLX5E_PFLAG_RX_NO_CSUM_COMPLETE , false);/* RQ */ /* Prefer Striding RQ, unless any of the following holds:
drivers/net/ethernet/mellanox/mlx5/core/en_rx.c +3 -0
@@ -754,6 +754,9 @@ static inline void mlx5e_handle_csum(strreturn ; } +if (unlikely (test_bit (MLX5E_RQ_STATE_NO_CSUM_COMPLETE , &rq->state))) + goto csum_unnecessary; +/* CQE csum doesn't cover padding octets in short ethernet * frames. And the pad field is appended prior to calculating * and appending the FCS field.
Greg Kroah-Hartman
maintainerPATCH 19/63 net/mlx5e: XDP, Avoid checksum complete when XDP prog is loaded
In reply to Greg Kroah-HartmanFrom: Saeed Mahameed <[email protected]>
[ Upstream commit 5d0bb3bac4b9f6c22280b04545626fdfd99edc6b ]
XDP programs might change packets data contents which will make the reported skb checksum (checksum complete) invalid.
When XDP programs are loaded/unloaded set/clear rx RQs MLX5E_RQ_STATE_NO_CSUM_COMPLETE flag.
--- drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c | 3 ++- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 6 +++++- drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 3 ++- 3 files changed, 9 insertions(+), 3 deletions(-)
drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c +2 -1
@@ -1517,7 +1517,8 @@ static int set_pflag_rx_no_csum_completestruct mlx5e_channel *c;int i; -if (!test_bit (MLX5E_STATE_OPENED , &priv->state)) +if (!test_bit (MLX5E_STATE_OPENED , &priv->state) || + priv->channels.params.xdp_prog)return 0 ;for (i =0 ; i < channels->num; i++) {
drivers/net/ethernet/mellanox/mlx5/core/en_main.c +5 -1
@@ -934,7 +934,11 @@ static int mlx5e_open_rq(struct mlx5e_chif (params->rx_dim_enabled)__set_bit (MLX5E_RQ_STATE_AM , &c->rq.state); -if (params->pflags &MLX5E_PFLAG_RX_NO_CSUM_COMPLETE ) +/* We disable csum_complete when XDP is enabled since +* XDP programs might manipulate packets which will render +* skb->checksum incorrect. +*/ +if (MLX5E_GET_PFLAG (params,MLX5E_PFLAG_RX_NO_CSUM_COMPLETE ) || c->xdp)__set_bit (MLX5E_RQ_STATE_NO_CSUM_COMPLETE , &c->rq.state);return 0 ;
drivers/net/ethernet/mellanox/mlx5/core/en_rx.c +2 -1
@@ -754,7 +754,8 @@ static inline void mlx5e_handle_csum(strreturn ; } -if (unlikely (test_bit (MLX5E_RQ_STATE_NO_CSUM_COMPLETE , &rq->state))) +/* True when explicitly set via priv flag, or XDP prog is loaded */ +if (test_bit (MLX5E_RQ_STATE_NO_CSUM_COMPLETE , &rq->state)) goto csum_unnecessary;/* CQE csum doesn't cover padding octets in short ethernet
Greg Kroah-Hartman
maintainerPATCH 20/63 net/mlx5e: Rx, Fixup skb checksum for packets with tail padding
In reply to Greg Kroah-HartmanFrom: Saeed Mahameed <[email protected]>
[ Upstream commit 0aa1d18615c163f92935b806dcaff9157645233a ]
When an ethernet frame with ip payload is padded, the padding octets are not covered by the hardware checksum.
Prior to the cited commit, skb checksum was forced to be CHECKSUM_NONE when padding is detected. After it, the kernel will try to trim the padding bytes and subtract their checksum from skb->csum.
In this patch we fixup skb->csum for any ip packet with tail padding of any size, if any padding found.
FCS case is just one special case of this general purpose patch, hence, it is removed.
--- drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 79 +++++++++++++++++---- drivers/net/ethernet/mellanox/mlx5/core/en_stats.c | 6 + drivers/net/ethernet/mellanox/mlx5/core/en_stats.h | 4 + 3 files changed, 74 insertions(+), 15 deletions(-)
drivers/net/ethernet/mellanox/mlx5/core/en_rx.c +64 -15
@@ -714,17 +714,6 @@ static inline void mlx5e_enable_ecn(stru rq->stats->ecn_mark += !!rc; } -static u32 mlx5e_get_fcs (const struct sk_buff *skb) -{ -const void *fcs_bytes; -u32 _fcs_bytes; - - fcs_bytes =skb_header_pointer (skb, skb->len -ETH_FCS_LEN , -ETH_FCS_LEN , &_fcs_bytes); - -return __get_unaligned_cpu32 (fcs_bytes); -} -static u8 get_ip_proto (struct sk_buff *skb,int network_depth,__be16 proto) {void *ip_p = skb->data + network_depth;
@@ -735,6 +724,68 @@ static u8 get_ip_proto(struct sk_buff *s#define short_frame (size) ((size) <= ETH_ZLEN + ETH_FCS_LEN) +#define MAX_PADDING 8 + +static void +tail_padding_csum_slow (struct sk_buff *skb,int offset,int len, +struct mlx5e_rq_stats *stats) +{ + stats->csum_complete_tail_slow++; + skb->csum =csum_block_add (skb->csum, +skb_checksum (skb, offset, len,0 ), + offset); +} + +static void +tail_padding_csum (struct sk_buff *skb,int offset, +struct mlx5e_rq_stats *stats) +{ +u8 tail_padding[MAX_PADDING ]; +int len = skb->len - offset; +void *tail; + +if (unlikely (len >MAX_PADDING )) { +tail_padding_csum_slow (skb, offset, len, stats); +return ; + } + + tail =skb_header_pointer (skb, offset, len, tail_padding); +if (unlikely (!tail)) { +tail_padding_csum_slow (skb, offset, len, stats); +return ; + } + + stats->csum_complete_tail++; + skb->csum =csum_block_add (skb->csum,csum_partial (tail, len,0 ), offset); +} + +static void +mlx5e_skb_padding_csum (struct sk_buff *skb,int network_depth,__be16 proto, +struct mlx5e_rq_stats *stats) +{ +struct ipv6hdr *ip6; +struct iphdr *ip4; +int pkt_len; + +switch (proto) { +case htons (ETH_P_IP ): + ip4 = (struct iphdr *)(skb->data + network_depth); + pkt_len = network_depth +ntohs (ip4->tot_len); +break ; +case htons (ETH_P_IPV6 ): + ip6 = (struct ipv6hdr *)(skb->data + network_depth); + pkt_len = network_depth +sizeof (*ip6) +ntohs (ip6->payload_len); +break ; +default : +return ; + } + +if (likely (pkt_len >= skb->len)) +return ; + +tail_padding_csum (skb, pkt_len, stats); +} + static inline void mlx5e_handle_csum(struct net_device *netdev, struct mlx5_cqe64 *cqe, struct mlx5e_rq *rq,
@@ -783,10 +834,8 @@ static inline void mlx5e_handle_csum(str skb->csum =csum_partial (skb->data +ETH_HLEN , network_depth -ETH_HLEN , skb->csum); -if (unlikely (netdev->features &NETIF_F_RXFCS )) - skb->csum =csum_block_add (skb->csum, - (__force __wsum )mlx5e_get_fcs (skb), - skb->len -ETH_FCS_LEN ); + +mlx5e_skb_padding_csum (skb, network_depth, proto, stats); stats->csum_complete++;return ; }
drivers/net/ethernet/mellanox/mlx5/core/en_stats.c +6 -0
@@ -58,6 +58,8 @@ static const struct counter_desc sw_stat { MLX5E_DECLARE_STAT(struct mlx5e_sw_stats, rx_csum_unnecessary) }, { MLX5E_DECLARE_STAT(struct mlx5e_sw_stats, rx_csum_none) }, { MLX5E_DECLARE_STAT(struct mlx5e_sw_stats, rx_csum_complete) }, + { MLX5E_DECLARE_STAT(struct mlx5e_sw_stats, rx_csum_complete_tail) }, + { MLX5E_DECLARE_STAT(struct mlx5e_sw_stats, rx_csum_complete_tail_slow) }, { MLX5E_DECLARE_STAT(struct mlx5e_sw_stats, rx_csum_unnecessary_inner) }, { MLX5E_DECLARE_STAT(struct mlx5e_sw_stats, rx_xdp_drop) }, { MLX5E_DECLARE_STAT(struct mlx5e_sw_stats, rx_xdp_redirect) },
@@ -149,6 +151,8 @@ void mlx5e_grp_sw_update_stats(struct ml s->rx_removed_vlan_packets += rq_stats->removed_vlan_packets; s->rx_csum_none += rq_stats->csum_none; s->rx_csum_complete += rq_stats->csum_complete; + s->rx_csum_complete_tail += rq_stats->csum_complete_tail; + s->rx_csum_complete_tail_slow += rq_stats->csum_complete_tail_slow; s->rx_csum_unnecessary += rq_stats->csum_unnecessary; s->rx_csum_unnecessary_inner += rq_stats->csum_unnecessary_inner; s->rx_xdp_drop += rq_stats->xdp_drop;
@@ -1139,6 +1143,8 @@ static const struct counter_desc rq_stat { MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, packets) }, { MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, bytes) }, { MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, csum_complete) }, + { MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, csum_complete_tail) }, + { MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, csum_complete_tail_slow) }, { MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, csum_unnecessary) }, { MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, csum_unnecessary_inner) }, { MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, csum_none) },
drivers/net/ethernet/mellanox/mlx5/core/en_stats.h +4 -0
@@ -71,6 +71,8 @@ struct mlx5e_sw_stats {u64 rx_csum_unnecessary;u64 rx_csum_none;u64 rx_csum_complete; +u64 rx_csum_complete_tail; +u64 rx_csum_complete_tail_slow;u64 rx_csum_unnecessary_inner;u64 rx_xdp_drop;u64 rx_xdp_redirect;
@@ -180,6 +182,8 @@ struct mlx5e_rq_stats {u64 packets;u64 bytes;u64 csum_complete; +u64 csum_complete_tail; +u64 csum_complete_tail_slow;u64 csum_unnecessary;u64 csum_unnecessary_inner;u64 csum_none;
Greg Kroah-Hartman
maintainerPATCH 21/63 net/mlx5e: Rx, Check ip headers sanity
In reply to Greg Kroah-HartmanFrom: Saeed Mahameed <[email protected]>
[ Upstream commit 0318a7b7fcad9765931146efa7ca3a034194737c ]
In the two places is_last_ethertype_ip is being called, the caller will be looking inside the ip header, to be safe, add ip{4,6} header sanity check. And return true only on valid ip headers, i.e: the whole header is contained in the linear part of the skb.
Note: Such situation is very rare and hard to reproduce, since mlx5e allocates a large enough headroom to contain the largest header one can imagine.
--- drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
drivers/net/ethernet/mellanox/mlx5/core/en_rx.c +8 -1
@@ -694,7 +694,14 @@ static inline bool is_last_ethertype_ip( { *proto = ((struct ethhdr *)skb->data)->h_proto; *proto =__vlan_get_protocol (skb, *proto, network_depth); -return (*proto ==htons (ETH_P_IP ) || *proto ==htons (ETH_P_IPV6 )); + +if (*proto ==htons (ETH_P_IP )) +return pskb_may_pull (skb, *network_depth +sizeof (struct iphdr )); + +if (*proto ==htons (ETH_P_IPV6 )) +return pskb_may_pull (skb, *network_depth +sizeof (struct ipv6hdr )); + +return false; }static inline void mlx5e_enable_ecn (struct mlx5e_rq *rq,struct sk_buff *skb)
Greg Kroah-Hartman
maintainerPATCH 22/63 iwlwifi: mvm: send BCAST management frames to the right station
In reply to Greg Kroah-HartmanFrom: Emmanuel Grumbach <[email protected]>
commit 65c3b582ecab7a403efdf08babbf87fdbe27369c upstream.
Probe responses were sent to the multicast station while they should be routed to the broadcast station. This has no negative effect since the frame was still routed to the right queue, but it looked very fishy to send a frame to a (queue, station) tuple where 'queue' is not mapped to 'station'.
--- drivers/net/wireless/intel/iwlwifi/mvm/tx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/intel/iwlwifi/mvm/tx.c +1 -1
@@ -671,7 +671,7 @@ int iwl_mvm_tx_skb_non_sta(struct iwl_mvif (info.control.vif->type ==NL80211_IFTYPE_P2P_DEVICE || info.control.vif->type ==NL80211_IFTYPE_AP || info.control.vif->type ==NL80211_IFTYPE_ADHOC ) { -if (info.control.vif->type ==NL80211_IFTYPE_P2P_DEVICE ) +if (!ieee80211_is_data (hdr->frame_control)) sta_id = mvmvif->bcast_sta.sta_id;else sta_id = mvmvif->mcast_sta.sta_id;
Greg Kroah-Hartman
maintainerPATCH 23/63 iwlwifi: mvm: always init rs_fw with 20MHz bandwidth rates
In reply to Greg Kroah-HartmanFrom: Naftali Goldstein <[email protected]>
commit 2859de7637b541dc7191f4d3fce4a1adba80fb3e upstream.
As with the non-offloaded rs case, during assoc on the ap side the phy context is set to 20MHz until authorization of a client that supports wider channel-widths. Support this by sending the initial tlc_config_cmd with max supported channel width of 20MHz until authorization succeeds.
--- drivers/net/wireless/intel/iwlwifi/mvm/rs-fw.c | 5 +++-- drivers/net/wireless/intel/iwlwifi/mvm/rs.c | 2 +- drivers/net/wireless/intel/iwlwifi/mvm/rs.h | 2 +- 3 files changed, 5 insertions(+), 4 deletions(-)
drivers/net/wireless/intel/iwlwifi/mvm/rs-fw.c +3 -2
@@ -315,7 +315,7 @@ out: }void rs_fw_rate_init (struct iwl_mvm *mvm,struct ieee80211_sta *sta, -enum nl80211_band band) +enum nl80211_band band,bool update) {struct ieee80211_hw *hw = mvm->hw;struct iwl_mvm_sta *mvmsta =iwl_mvm_sta_from_mac80211 (sta);
@@ -324,7 +324,8 @@ void rs_fw_rate_init(struct iwl_mvm *mvmstruct ieee80211_supported_band *sband;struct iwl_tlc_config_cmd cfg_cmd = { .sta_id = mvmsta->sta_id, - .max_ch_width =rs_fw_bw_from_sta_bw (sta), + .max_ch_width = update ? +rs_fw_bw_from_sta_bw (sta) :RATE_MCS_CHAN_WIDTH_20 , .flags =cpu_to_le16 (rs_fw_set_config_flags (mvm, sta)), .chains =rs_fw_set_active_chains (iwl_mvm_get_valid_tx_ant (mvm)), .max_mpdu_len =cpu_to_le16 (sta->max_amsdu_len),
drivers/net/wireless/intel/iwlwifi/mvm/rs.c +1 -1
@@ -4113,7 +4113,7 @@ void iwl_mvm_rs_rate_init(struct iwl_mvm enum nl80211_band band, bool update) { if (iwl_mvm_has_tlc_offload(mvm)) - rs_fw_rate_init(mvm, sta, band); + rs_fw_rate_init(mvm, sta, band, update); elsers_drv_rate_init (mvm ,sta ,band ,update ); }
drivers/net/wireless/intel/iwlwifi/mvm/rs.h +1 -1
@@ -461,7 +461,7 @@ void rs_remove_sta_debugfs(void *mvm, vovoid iwl_mvm_rs_add_sta (struct iwl_mvm *mvm,struct iwl_mvm_sta *mvmsta);void rs_fw_rate_init (struct iwl_mvm *mvm,struct ieee80211_sta *sta, -enum nl80211_band band); +enum nl80211_band band,bool update);int rs_fw_tx_protection (struct iwl_mvm *mvm,struct iwl_mvm_sta *mvmsta,bool enable); void iwl_mvm_tlc_update_notif(struct iwl_mvm *mvm,
Greg Kroah-Hartman
maintainerPATCH 24/63 media: tvp5150: fix switch exit in set control handler
In reply to Greg Kroah-HartmanFrom: Marco Felsch <[email protected]>
commit 2d29bcc8c237874795175b2930fa9a45a115175a upstream.
The function only consists of a single switch case block without a default case. Unsupported control requests are indicated by the -EINVAL return code trough the last return statement at the end of the function. So exiting just the switch case block returns the -EINVAL error code but the hue control is supported and a zero should be returned instead.
Replace the break by a 'return 0' to fix this behaviour.
control handler")
--- drivers/media/i2c/tvp5150.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/i2c/tvp5150.c +1 -1
@@ -828,7 +828,7 @@ static int tvp5150_s_ctrl(struct v4l2_ctreturn 0 ;case V4L2_CID_HUE :tvp5150_write (sd,TVP5150_HUE_CTL , ctrl->val); -break ; +return 0 ;case V4L2_CID_TEST_PATTERN : decoder->enable = ctrl->val ? false : true;tvp5150_selmux (sd);
Greg Kroah-Hartman
maintainerPATCH 25/63 ASoC: Intel: cht_bsw_max98090_ti: Enable codec clock once and keep it enabled
In reply to Greg Kroah-HartmanFrom: Hans de Goede <[email protected]>
commit 4bcdec39c454c4e8f9512115bdcc3efec1ba5f55 upstream.
Users have been seeing sound stability issues with max98090 codecs since:
commit 648e921888ad ("clk: x86: Stop marking clocks as CLK_IS_CRITICAL")
At first that commit broke sound for Chromebook Swanky and Clapper models, the problem was that the machine-driver has been controlling the wrong clock on those models since support for them was added. This was hidden by clk-pmc-atom.c keeping the actual clk on unconditionally.
With the machine-driver controlling the proper clock, sound works again but we are seeing bug reports describing it as: low volume, "sounds like played at 10x speed" and instable.
When these issues are hit the following message is seen in dmesg:
"max98090 i2c-193C9890:00: PLL unlocked".
Attempts have been made to fix this by inserting a delay between enabling the clk and enabling and checking the pll, but this has not helped.
It seems that at least on boards which use pmc_plt_clk_0 as clock, if we ever disable the clk, the pll looses its lock and after that we get various issues.
This commit fixes this by enabling the clock once at probe time on these boards. In essence this restores the old behavior of clk-pmc-atom.c always keeping the clk on on these boards.
--- sound/soc/intel/boards/cht_bsw_max98090_ti.c | 47 +++++++++++++++++++++++---- 1 file changed, 41 insertions(+), 6 deletions(-)
sound/soc/intel/boards/cht_bsw_max98090_ti.c +41 -6
@@ -42,6 +42,7 @@ struct cht_mc_private {struct clk *mclk;struct snd_soc_jack jack;bool ts3a227e_present; +int quirks; }; static int platform_clock_control(struct snd_soc_dapm_widget *w,
@@ -53,6 +54,10 @@ static int platform_clock_control(structstruct cht_mc_private *ctx =snd_soc_card_get_drvdata (card);int ret; +/* See the comment in snd_cht_mc_probe() */ +if (ctx->quirks &QUIRK_PMC_PLT_CLK_0 ) +return 0 ; + codec_dai =snd_soc_card_get_codec_dai (card,CHT_CODEC_DAI );if (!codec_dai) {dev_err (card->dev,"Codec dai not found; Unable to set platform clock\n" );
@@ -222,6 +227,10 @@ static int cht_codec_init(struct snd_soc "jack detection gpios not added, error %d\n", ret); } +/* See the comment in snd_cht_mc_probe() */ +if (ctx->quirks &QUIRK_PMC_PLT_CLK_0 ) +return 0 ; +/* * The firmware might enable the clock at * boot (this information may or may not
@@ -420,16 +429,15 @@ static int snd_cht_mc_probe(struct platfint ret_val =0 ;struct cht_mc_private *drv;const char *mclk_name; -int quirks =0 ; - - dmi_id =dmi_first_match (cht_max98090_quirk_table); -if (dmi_id) - quirks = (unsigned long )dmi_id->driver_data; drv =devm_kzalloc (&pdev->dev,sizeof (*drv),GFP_KERNEL );if (!drv)return -ENOMEM ; + dmi_id =dmi_first_match (cht_max98090_quirk_table); +if (dmi_id) + drv->quirks = (unsigned long )dmi_id->driver_data; + drv->ts3a227e_present =acpi_dev_found ("104C227E" );if (!drv->ts3a227e_present) {/* no need probe TI jack detection chip */
@@ -446,7 +454,7 @@ static int snd_cht_mc_probe(struct platf snd_soc_card_cht.dev = &pdev->dev;snd_soc_card_set_drvdata (&snd_soc_card_cht, drv); -if (quirks &QUIRK_PMC_PLT_CLK_0 ) +if (drv->quirks &QUIRK_PMC_PLT_CLK_0 ) mclk_name ="pmc_plt_clk_0" ;else mclk_name ="pmc_plt_clk_3" ;
@@ -459,6 +467,21 @@ static int snd_cht_mc_probe(struct platfreturn PTR_ERR (drv->mclk); } +/* +* Boards which have the MAX98090's clk connected to clk_0 do not seem +* to like it if we muck with the clock. If we disable the clock when +* it is unused we get "max98090 i2c-193C9890:00: PLL unlocked" errors +* and the PLL never seems to lock again. +* So for these boards we enable it here once and leave it at that. +*/ +if (drv->quirks &QUIRK_PMC_PLT_CLK_0 ) { + ret_val =clk_prepare_enable (drv->mclk); +if (ret_val <0 ) { +dev_err (&pdev->dev,"MCLK enable error: %d\n" , ret_val); +return ret_val; + } + } + ret_val =devm_snd_soc_register_card (&pdev->dev, &snd_soc_card_cht);if (ret_val) { dev_err(&pdev->dev,
@@ -469,11 +492,23 @@ static int snd_cht_mc_probe(struct platfreturn ret_val; } +static int snd_cht_mc_remove (struct platform_device *pdev) +{ +struct snd_soc_card *card =platform_get_drvdata (pdev); +struct cht_mc_private *ctx =snd_soc_card_get_drvdata (card); + +if (ctx->quirks &QUIRK_PMC_PLT_CLK_0 ) +clk_disable_unprepare (ctx->mclk); + +return 0 ; +} +static struct platform_driver snd_cht_mc_driver = { .driver = { .name ="cht-bsw-max98090" , }, .probe = snd_cht_mc_probe, + .remove = snd_cht_mc_remove, };module_platform_driver (snd_cht_mc_driver)
Greg Kroah-Hartman
maintainerPATCH 26/63 ASoC: fsl: Fix of-node refcount unbalance in fsl_ssi_probe_from_dt()
In reply to Greg Kroah-HartmanFrom: Takashi Iwai <[email protected]>
commit 2757970f6d0d0a112247600b23d38c0c728ceeb3 upstream.
The node obtained from of_find_node_by_path() has to be unreferenced after the use, but we forgot it for the root node.
--- sound/soc/fsl/fsl_ssi.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
sound/soc/fsl/fsl_ssi.c +4 -2
@@ -1439,8 +1439,10 @@ static int fsl_ssi_probe_from_dt(struct* different name to register the device. */ if (!ssi->card_name[0 ] &&of_get_property (np,"codec-handle" ,NULL )) { - sprop =of_get_property (of_find_node_by_path ("/" ), -"compatible" ,NULL ); +struct device_node *root =of_find_node_by_path ("/" ); + + sprop =of_get_property (root,"compatible" ,NULL ); +of_node_put (root);/* Strip "fsl," in the compatible name if applicable */ p =strrchr (sprop,',' );if (p)
Greg Kroah-Hartman
maintainerPATCH 27/63 ALSA: usb-audio: Add Hiby device family to quirks for native DSD support
In reply to Greg Kroah-HartmanFrom: Ilya Pshonkin <[email protected]>
commit 029d2c0fd61eac74700fb4ffff36fc63bfff7e5e upstream.
This patch adds quirk VID ID for Hiby portable players family with native DSD playback support.
--- sound/usb/quirks.c | 1 + 1 file changed, 1 insertion(+)
sound/usb/quirks.c +1 -0
@@ -1449,6 +1449,7 @@ u64 snd_usb_interface_dsd_format_quirks(case 0x152a :/* Thesycon devices */ case 0x25ce :/* Mytek devices */ case 0x2ab6 :/* T+A devices */ +case 0xc502 :/* HiBy devices */ if (fp->dsd_raw)return SNDRV_PCM_FMTBIT_DSD_U32_BE ;break ;
Greg Kroah-Hartman
maintainerPATCH 28/63 ALSA: usb-audio: Add DSD support for EVGA NU Audio
In reply to Greg Kroah-HartmanFrom: Jussi Laako <[email protected]>
commit f41f900568d9ffd896cc941db7021eb14bd55910 upstream.
EVGA NU Audio is actually a USB audio device on a PCIexpress card, with it's own USB controller. It supports both PCM and DSD.
--- sound/usb/quirks.c | 1 + 1 file changed, 1 insertion(+)
sound/usb/quirks.c +1 -0
@@ -1449,6 +1449,7 @@ u64 snd_usb_interface_dsd_format_quirks(case 0x152a :/* Thesycon devices */ case 0x25ce :/* Mytek devices */ case 0x2ab6 :/* T+A devices */ +case 0x3842 :/* EVGA */ case 0xc502 :/* HiBy devices */ if (fp->dsd_raw)return SNDRV_PCM_FMTBIT_DSD_U32_BE ;
Greg Kroah-Hartman
maintainerPATCH 29/63 ALSA: dice: fix wrong packet parameter for Alesis iO26
In reply to Greg Kroah-HartmanFrom: Takashi Sakamoto <[email protected]>
commit 3a9236e97207f2469254b4098995159b80174d95 upstream.
At higher sampling rate (e.g. 192.0 kHz), Alesis iO26 transfers 4 data channels per data block in CIP.
Both iO14 and iO26 have the same contents in their configuration ROM. For this reason, ALSA Dice driver attempts to distinguish them according to the value of TX0_AUDIO register at probe callback. Although the way is valid at lower and middle sampling rate, it's lastly invalid at higher sampling rate because because the two models returns the same value for read transaction to the register.
In the most cases, users just plug-in the device and ALSA dice driver detects it. In the case, the device runs at lower sampling rate and the driver detects expectedly. For this reason, this commit leaves the way to detect as is.
--- sound/firewire/dice/dice-alesis.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/firewire/dice/dice-alesis.c +1 -1
@@ -15,7 +15,7 @@ alesis_io14_tx_pcm_chs[MAX_STREAMS][SND_static const unsigned int alesis_io26_tx_pcm_chs[MAX_STREAMS ][SND_DICE_RATE_MODE_COUNT ] = { - {10 ,10 ,8 },/* Tx0 = Analog + S/PDIF. */ + {10 ,10 ,4 },/* Tx0 = Analog + S/PDIF. */ {16 ,8 ,0 },/* Tx1 = ADAT1 + ADAT2. */ };
Greg Kroah-Hartman
maintainerPATCH 30/63 ALSA: hda - Add laptop imic fixup for ASUS M9V laptop
In reply to Greg Kroah-HartmanFrom: Shih-Yuan Lee (FourDollars) <[email protected]>
commit 7b485d175631be676424aedb8cd2f66d0c93da78 upstream.
The same fixup to enable laptop imic is needed for ASUS M9V with AD1986A codec like another HP machine.
--- sound/pci/hda/patch_analog.c | 1 + 1 file changed, 1 insertion(+)
sound/pci/hda/patch_analog.c +1 -0
@@ -370,6 +370,7 @@ static const struct hda_fixup ad1986a_fistatic const struct snd_pci_quirk ad1986a_fixup_tbl[] = {SND_PCI_QUIRK (0x103c ,0x30af ,"HP B2800" ,AD1986A_FIXUP_LAPTOP_IMIC ), +SND_PCI_QUIRK (0x1043 ,0x1153 ,"ASUS M9V" ,AD1986A_FIXUP_LAPTOP_IMIC ),SND_PCI_QUIRK (0x1043 ,0x1443 ,"ASUS Z99He" ,AD1986A_FIXUP_EAPD ),SND_PCI_QUIRK (0x1043 ,0x1447 ,"ASUS A8JN" ,AD1986A_FIXUP_EAPD ),SND_PCI_QUIRK_MASK (0x1043 ,0xff00 ,0x8100 ,"ASUS P5" ,AD1986A_FIXUP_3STACK ),
Greg Kroah-Hartman
maintainerPATCH 31/63 ALSA: hda - Apply AMD controller workaround for Raven platform
In reply to Greg Kroah-HartmanFrom: Takashi Iwai <[email protected]>
commit d2c63b7dfd06788a466d5ec8a850491f084c5fc2 upstream.
It's reported that the garbled sound on HP Envy x360 13z-ag000 (Ryzen Laptop) is fixed by the same workaround applied to other AMD chips. Update the driver_data entry for Raven (1022:15e3) to use the newly introduced preset, AZX_DCAPS_PRESET_AMD_SB. Since it already contains AZX_DCAPS_PM_RUNTIME, we can drop that bit, too.
--- sound/pci/hda/hda_intel.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
sound/pci/hda/hda_intel.c +1 -2
@@ -2662,8 +2662,7 @@ static const struct pci_device_id azx_id AZX_DCAPS_PM_RUNTIME },/* AMD Raven */ { PCI_DEVICE(0x1022, 0x15e3), - .driver_data =AZX_DRIVER_GENERIC |AZX_DCAPS_PRESET_ATI_SB | - AZX_DCAPS_PM_RUNTIME }, + .driver_data = AZX_DRIVER_GENERIC | AZX_DCAPS_PRESET_AMD_SB }, /* ATI HDMI */ { PCI_DEVICE(0x1002, 0x0002), .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS },
Greg Kroah-Hartman
maintainerPATCH 32/63 objtool: Clobber user CFLAGS variable
In reply to Greg Kroah-HartmanFrom: Josh Poimboeuf <[email protected]>
commit f73b3cc39c84220e6dccd463b5c8279b03514646 upstream.
If the build user has the CFLAGS variable set in their environment, objtool blindly appends to it, which can cause unexpected behavior.
Clobber CFLAGS to ensure consistent objtool compilation behavior.
--- tools/objtool/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/objtool/Makefile +1 -1
@@ -35,7 +35,7 @@ INCLUDES := -I$(srctree)/tools/include \ -I$(srctree)/tools/arch/$(HOSTARCH)/include/uapi \ -I$(srctree)/tools/objtool/arch/$(ARCH)/include WARNINGS := $(EXTRA_WARNINGS) -Wno-switch-default -Wno-switch-enum -Wno-packed -CFLAGS += -Werror $(WARNINGS) $(KBUILD_HOSTCFLAGS) -g $(INCLUDES) $(LIBELF_FLAGS) +CFLAGS := -Werror $(WARNINGS) $(KBUILD_HOSTCFLAGS) -g $(INCLUDES) $(LIBELF_FLAGS) LDFLAGS += $(LIBELF_LIBS) $(LIBSUBCMD) $(KBUILD_HOSTLDFLAGS) # Allow old libelf to be used:
Greg Kroah-Hartman
maintainerPATCH 33/63 tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations
In reply to Greg Kroah-HartmanFrom: Vadim Sukhomlinov <[email protected]>
commit db4d8cb9c9f2af71c4d087817160d866ed572cc9 upstream
TPM 2.0 Shutdown involve sending TPM2_Shutdown to TPM chip and disabling future TPM operations. TPM 1.2 behavior was different, future TPM operations weren't disabled, causing rare issues. This patch ensures that future TPM operations are disabled.
--- drivers/char/tpm/tpm-chip.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/char/tpm/tpm-chip.c +3 -0
@@ -187,12 +187,15 @@ static int tpm_class_shutdown(struct device *dev) { struct tpm_chip *chip = container_of(dev, struct tpm_chip, dev); +down_write (&chip->ops_sem);if (chip->flags &TPM_CHIP_FLAG_TPM2 ) {down_write (&chip->ops_sem);tpm2_shutdown (chip,TPM2_SU_CLEAR ); chip->ops =NULL ;up_write (&chip->ops_sem); } + chip->ops =NULL ; +up_write (&chip->ops_sem);return 0 ; }
Signature · 1 line
2.20.1
Re: [PATCH 4.19 33/63] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations
Quoted 16 lines
From: Vadim Sukhomlinov <[email protected]>
commit
db4d8cb9c9f2af71c4d087817160d866ed572cc9upstreamTPM 2.0 Shutdown involve sending
TPM2_Shutdownto TPM chip and disabling future TPM operations. TPM 1.2 behavior was different, future TPM operations weren't disabled, causing rare issues. This patch ensures that future TPM operations are disabled.drivers/char/tpm/tpm-chip.c +0
-0@@ -187,12 +187,15 @@ static int tpm_class_shutdown(struct device *dev) { struct tpm_chip *chip = container_of(dev, struct tpm_chip, dev);
drivers/char/tpm/tpm-chip.c static int tpm_class_shutdown(struct device *dev) · line 198
Quoted 10 lines
drivers/char/tpm/tpm-chip.c +3
-0+down_write (&chip->ops_sem);if (chip->flags &TPM_CHIP_FLAG_TPM2 ) {down_write (&chip->ops_sem);tpm2_shutdown (chip,TPM2_SU_CLEAR ); chip->ops =NULL ;up_write (&chip->ops_sem); } + chip->ops =NULL ; +up_write (&chip->ops_sem);
This is wrong, it takes &chip->ops_sem twice, that can't be good. db4d8cb9c9f2af71c4d087817160d866ed572cc9 does not have that problem.
Best regards,
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Sasha Levin
maintainerRe: [PATCH 4.19 33/63] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations
Quoted 17 lines · Pavel Machek
Quoted 17 lines
From: Vadim Sukhomlinov <[email protected]>
commit
db4d8cb9c9f2af71c4d087817160d866ed572cc9upstreamTPM 2.0 Shutdown involve sending
TPM2_Shutdownto TPM chip and disabling future TPM operations. TPM 1.2 behavior was different, future TPM operations weren't disabled, causing rare issues. This patch ensures that future TPM operations are disabled.drivers/char/tpm/tpm-chip.c +0
-0@@ -187,12 +187,15 @@ static int tpm_class_shutdown(struct device *dev) { struct tpm_chip *chip = container_of(dev, struct tpm_chip, dev);
Quoted 13 lines
drivers/char/tpm/tpm-chip.c static int tpm_class_shutdown(struct device *dev) · line 198
Quoted 9 lines
drivers/char/tpm/tpm-chip.c +3
-0+down_write (&chip->ops_sem);if (chip->flags &TPM_CHIP_FLAG_TPM2 ) {down_write (&chip->ops_sem);tpm2_shutdown (chip,TPM2_SU_CLEAR ); chip->ops =NULL ;up_write (&chip->ops_sem); } + chip->ops =NULL ; +up_write (&chip->ops_sem);This is wrong, it takes
&chip->ops_semtwice, that can't be good.db4d8cb9c9f2af71c4d087817160d866ed572cc9does not have that problem.
I agree. I've dropped it from 4.19 and 4.14.
Jarkko, can you take a look at this again please?
--
Thanks,
Sasha
Re: [PATCH 4.19 33/63] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations
Quoted 32 lines · Sasha Levin
Quoted 17 lines · Pavel Machek
Quoted 17 lines
From: Vadim Sukhomlinov <[email protected]>
commit
db4d8cb9c9f2af71c4d087817160d866ed572cc9upstreamTPM 2.0 Shutdown involve sending
TPM2_Shutdownto TPM chip and disabling future TPM operations. TPM 1.2 behavior was different, future TPM operations weren't disabled, causing rare issues. This patch ensures that future TPM operations are disabled.drivers/char/tpm/tpm-chip.c +0
-0@@ -187,12 +187,15 @@ static int tpm_class_shutdown(struct device *dev) { struct tpm_chip *chip = container_of(dev, struct tpm_chip, dev);Quoted 13 lines
drivers/char/tpm/tpm-chip.c static int tpm_class_shutdown(struct device *dev) · line 198
Quoted 9 lines
drivers/char/tpm/tpm-chip.c +3
-0+down_write (&chip->ops_sem);if (chip->flags &TPM_CHIP_FLAG_TPM2 ) {down_write (&chip->ops_sem);tpm2_shutdown (chip,TPM2_SU_CLEAR ); chip->ops =NULL ;up_write (&chip->ops_sem); } + chip->ops =NULL ; +up_write (&chip->ops_sem);This is wrong, it takes
&chip->ops_semtwice, that can't be good.db4d8cb9c9f2af71c4d087817160d866ed572cc9does not have that problem.
Quoted 3 lines
I agree. I've dropped it from 4.19 and 4.14.
Jarkko, can you take a look at this again please?
Pavel, thank you for spotting that one, phew!
I'll do an update.
/Jarkko
Greg Kroah-Hartman
maintainerPATCH 34/63 pinctrl: sprd: Use define directive for sprd_pinconf_params values
In reply to Greg Kroah-HartmanFrom: Nathan Chancellor <[email protected]>
[ Upstream commit 957063c924736d4341e5d588757b9f31e8f6fa24 ]
Clang warns when one enumerated type is implicitly converted to another:
drivers/pinctrl/sprd/pinctrl-sprd.c:845:19: warning: implicit conversion from enumeration type 'enum sprd_pinconf_params' to different enumeration type 'enum pin_config_param' [-Wenum-conversion]
{"sprd,control", SPRD_PIN_CONFIG_CONTROL, 0},
~ ^~~~~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/sprd/pinctrl-sprd.c:846:22: warning: implicit conversion
from enumeration type 'enum sprd_pinconf_params' to different
enumeration type 'enum pin_config_param' [-Wenum-conversion]
{"sprd,sleep-mode", SPRD_PIN_CONFIG_SLEEP_MODE, 0},
~ ^~~~~~~~~~~~~~~~~~~~~~~~~~It is expected that pinctrl drivers can extend pin_config_param because of the gap between PIN_CONFIG_END and PIN_CONFIG_MAX so this conversion isn't an issue. Most drivers that take advantage of this define the PIN_CONFIG variables as constants, rather than enumerated values. Do the same thing here so that Clang no longer warns.
--- drivers/pinctrl/sprd/pinctrl-sprd.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/pinctrl/sprd/pinctrl-sprd.c +2 -4
@@ -159,10 +159,8 @@ struct sprd_pinctrl {struct sprd_pinctrl_soc_info *info; }; -enum sprd_pinconf_params { -SPRD_PIN_CONFIG_CONTROL =PIN_CONFIG_END +1 , -SPRD_PIN_CONFIG_SLEEP_MODE =PIN_CONFIG_END +2 , -}; +#define SPRD_PIN_CONFIG_CONTROL (PIN_CONFIG_END + 1) +#define SPRD_PIN_CONFIG_SLEEP_MODE (PIN_CONFIG_END + 2)static int sprd_pinctrl_get_id_by_name (struct sprd_pinctrl *sprd_pctl,const char *name)
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 35/63 power: supply: sysfs: ratelimit property read error message
In reply to Greg Kroah-HartmanFrom: David Lechner <[email protected]>
[ Upstream commit 87a2b65fc855e6be50f791c2ebbb492541896827 ]
This adds rate limiting to the message that is printed when reading a power supply property via sysfs returns an error. This will prevent userspace applications from unintentionally dDOSing the system by continuously reading a property that returns an error.
--- drivers/power/supply/power_supply_sysfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/power/supply/power_supply_sysfs.c +2 -1
@@ -131,7 +131,8 @@ static ssize_t power_supply_show_property(struct device *dev,dev_dbg (dev,"driver has no data for `%s' property\n" , attr->attr.name); else if (ret != -ENODEV && ret != -EAGAIN) -dev_err (dev,"driver failed to report `%s' property: %zd\n" , +dev_err_ratelimited (dev, +"driver failed to report `%s' property: %zd\n" , attr->attr.name, ret);return ret; }
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 36/63 locking/lockdep: Add debug_locks check in __lock_downgrade()
In reply to Greg Kroah-HartmanFrom: Waiman Long <[email protected]>
[ Upstream commit 513e1073d52e55b8024b4f238a48de7587c64ccf ]
Tetsuo Handa had reported he saw an incorrect "downgrading a read lock" warning right after a previous lockdep warning. It is likely that the previous warning turned off lock debugging causing the lockdep to have inconsistency states leading to the lock downgrade warning.
Fix that by add a check for debug_locks at the beginning of __lock_downgrade().
--- kernel/locking/lockdep.c | 3 +++ 1 file changed, 3 insertions(+)
kernel/locking/lockdep.c +3 -0
@@ -3567,6 +3567,9 @@ __lock_set_class(struct lockdep_map *lock, const char *name,unsigned int depth;int i; +if (unlikely (!debug_locks)) +return 0 ; + depth = curr->lockdep_depth;/* * This function is about (re)setting the class of a held lock,
Signature · 1 line
2.20.1
Re: [PATCH 4.19 36/63] locking/lockdep: Add debug_locks check in __lock_downgrade()
Quoted 11 lines · Greg Kroah-Hartman
From: Waiman Long <[email protected]>
[ Upstream commit
513e1073d52e55b8024b4f238a48de7587c64ccf]Tetsuo Handa had reported he saw an incorrect "downgrading a read lock" warning right after a previous lockdep warning. It is likely that the previous warning turned off lock debugging causing the lockdep to have inconsistency states leading to the lock downgrade warning.
Fix that by add a check for
debug_locksat the beginning of__lock_downgrade().
Please drop "[PATCH 4.19 36/63] locking/lockdep: Add debug_locks check in __lock_downgrade()". We had a revert patch shown below in the past.
"[PATCH 4.19 37/63] locking/lockdep: Add debug_locks check in __lock_downgrade() - again" seems the correct patch.
On 2019/04/25 17:08, [email protected] wrote:>
Quoted 59 lines
This is a note to let you know that I've just added the patch titled
Revert "locking/lockdep: Add
debug_lockscheck in__lock_downgrade()"to the 4.19-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summaryThe filename of the patch is:
revert-locking-lockdep-add-debug_locks-check-in-__lock_downgrade.patch
and it can be found in the queue-4.19 subdirectory.If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
7f437eec35a20f40d9ff82ae1c072b211c29e8e0Mon Sep 17 00:00:00 2001From: Greg Kroah-Hartman <[email protected]>
Date: Thu, 25 Apr 2019 10:00:43 +0200
Subject: Revert "locking/lockdep: Adddebug_lockscheck in__lock_downgrade()"From: Greg Kroah-Hartman <[email protected]>
This reverts commit
0e0f7b30721233ce610bde2395a8e58ff7771475which was commit71492580571467fb7177aade19c18ce7486267f5upstream.Tetsuo rightly points out that the backport here is incorrect, as it touches the
__lock_set_classfunction instead of the intended__lock_downgradefunction.Reported-by Tetsuo Handa <[email protected]>Cc Waiman Long <[email protected]>Cc Peter Zijlstra (Intel) <[email protected]>Cc Andrew Morton <[email protected]>Cc Linus Torvalds <[email protected]>Cc Paul E. McKenney <[email protected]>Cc Peter Zijlstra <[email protected]>Cc Thomas Gleixner <[email protected]>Cc Will Deacon <[email protected]>Cc Ingo Molnar <[email protected]>Cc Sasha Levin <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>--- kernel/locking/lockdep.c | 3 --- 1 file changed, 3 deletions(-)kernel/locking/lockdep.c +0
-3@@ -3567,9 +3567,6 @@ __lock_set_class(struct lockdep_map *locunsigned int depth;int i; -if (unlikely (!debug_locks)) -return 0 ; - depth = curr->lockdep_depth;/* * This function is about (re)setting the class of a held lock,
Sasha Levin
maintainerRe: [PATCH 4.19 36/63] locking/lockdep: Add debug_locks check in __lock_downgrade()
Quoted 10 lines · Tetsuo Handa
Quoted 9 lines · Greg Kroah-Hartman
From: Waiman Long <[email protected]>
[ Upstream commit
513e1073d52e55b8024b4f238a48de7587c64ccf]Tetsuo Handa had reported he saw an incorrect "downgrading a read lock" warning right after a previous lockdep warning. It is likely that the previous warning turned off lock debugging causing the lockdep to have inconsistency states leading to the lock downgrade warning.
Quoted 5 lines
Quoted 2 lines
Fix that by add a check for
debug_locksat the beginning of__lock_downgrade().Please drop "[PATCH 4.19 36/63] locking/lockdep: Add
debug_lockscheck in__lock_downgrade()". We had a revert patch shown below in the past.
We had a revert in the stable trees, but that revert was incorrect.
Take a look at commit 513e1073d52e55 upstream, it patches __lock_set_class() (even though the subject line says __lock_downgrade()). So this is not a backporting error as the revert said it is, but is rather the intended location to be patched.
If this is actually wrong, then it should be addressed upstream first.
--
Thanks,
Sasha
Re: [PATCH 4.19 36/63] locking/lockdep: Add debug_locks check in __lock_downgrade()
Quoted 17 lines · Sasha Levin
Quoted 10 lines · Tetsuo Handa
Quoted 9 lines · Greg Kroah-Hartman
From: Waiman Long <[email protected]>
[ Upstream commit
513e1073d52e55b8024b4f238a48de7587c64ccf]Tetsuo Handa had reported he saw an incorrect "downgrading a read lock" warning right after a previous lockdep warning. It is likely that the previous warning turned off lock debugging causing the lockdep to have inconsistency states leading to the lock downgrade warning.
Quoted 5 lines
Quoted 2 lines
Fix that by add a check for
debug_locksat the beginning of__lock_downgrade().Please drop "[PATCH 4.19 36/63] locking/lockdep: Add
debug_lockscheck in__lock_downgrade()". We had a revert patch shown below in the past.
Quoted 9 lines
We had a revert in the stable trees, but that revert was incorrect.
Take a look at commit
513e1073d52e55upstream, it patches__lock_set_class()(even though the subject line says__lock_downgrade()). So this is not a backporting error as the revert said it is, but is rather the intended location to be patched.If this is actually wrong, then it should be addressed upstream first.
Hmm, upstream has two commits with same author, same date, same subject, different hash, different content. I couldn't find from https://lkml.kernel.org/r/[email protected] that we want to patch both __lock_set_class() and __lock_downgrade(), but I found that the tip-bot has patched __lock_downgrade() on "2019-01-21 11:29" and __lock_set_class() on "2019-02-04 8:56". Seems that we by error patched both functions, though patching both functions should be harmless...
64aa348ed kernel/lockdep.c (Peter Zijlstra 2008-08-11 09:30:21 +0200 4115) static int
00ef9f734 kernel/lockdep.c (Peter Zijlstra 2008-12-04 09:00:17 +0100 4116) __lock_set_class(struct lockdep_map *lock, const char *name,
00ef9f734 kernel/lockdep.c (Peter Zijlstra 2008-12-04 09:00:17 +0100 4117) struct lock_class_key *key, unsigned int subclass,
00ef9f734 kernel/lockdep.c (Peter Zijlstra 2008-12-04 09:00:17 +0100 4118) unsigned long ip)
64aa348ed kernel/lockdep.c (Peter Zijlstra 2008-08-11 09:30:21 +0200 4119) {
64aa348ed kernel/lockdep.c (Peter Zijlstra 2008-08-11 09:30:21 +0200 4120) struct task_struct *curr = current;
8c8889d8e kernel/locking/lockdep.c (Imre Deak 2019-05-24 23:15:08 +0300 4121) unsigned int depth, merged = 0;
41c2c5b86 kernel/locking/lockdep.c (J. R. Okajima 2017-02-03 01:38:15 +0900 4122) struct held_lock *hlock;
64aa348ed kernel/lockdep.c (Peter Zijlstra 2008-08-11 09:30:21 +0200 4123) struct lock_class *class;
64aa348ed kernel/lockdep.c (Peter Zijlstra 2008-08-11 09:30:21 +0200 4124) int i;
64aa348ed kernel/lockdep.c (Peter Zijlstra 2008-08-11 09:30:21 +0200 4125)
513e1073d kernel/locking/lockdep.c (Waiman Long 2019-01-09 23:03:25 -0500 4126) if (unlikely(!debug_locks))
513e1073d kernel/locking/lockdep.c (Waiman Long 2019-01-09 23:03:25 -0500 4127) return 0;
513e1073d kernel/locking/lockdep.c (Waiman Long 2019-01-09 23:03:25 -0500 4128)6419c4af7 kernel/locking/lockdep.c (J. R. Okajima 2017-02-03 01:38:17 +0900 4162) static int __lock_downgrade(struct lockdep_map *lock, unsigned long ip)
6419c4af7 kernel/locking/lockdep.c (J. R. Okajima 2017-02-03 01:38:17 +0900 4163) {
6419c4af7 kernel/locking/lockdep.c (J. R. Okajima 2017-02-03 01:38:17 +0900 4164) struct task_struct *curr = current;
8c8889d8e kernel/locking/lockdep.c (Imre Deak 2019-05-24 23:15:08 +0300 4165) unsigned int depth, merged = 0;
6419c4af7 kernel/locking/lockdep.c (J. R. Okajima 2017-02-03 01:38:17 +0900 4166) struct held_lock *hlock;
6419c4af7 kernel/locking/lockdep.c (J. R. Okajima 2017-02-03 01:38:17 +0900 4167) int i;
6419c4af7 kernel/locking/lockdep.c (J. R. Okajima 2017-02-03 01:38:17 +0900 4168)
714925805 kernel/locking/lockdep.c (Waiman Long 2019-01-09 23:03:25 -0500 4169) if (unlikely(!debug_locks))
714925805 kernel/locking/lockdep.c (Waiman Long 2019-01-09 23:03:25 -0500 4170) return 0;
714925805 kernel/locking/lockdep.c (Waiman Long 2019-01-09 23:03:25 -0500 4171)commit 513e1073d52e55b8024b4f238a48de7587c64ccf
Author: Waiman Long <[email protected]> Date: Wed Jan 9 23:03:25 2019 -0500
locking/lockdep: Add debug_locks check in __lock_downgrade()
commit 71492580571467fb7177aade19c18ce7486267f5
Author: Waiman Long <[email protected]> Date: Wed Jan 9 23:03:25 2019 -0500
locking/lockdep: Add debug_locks check in __lock_downgrade()
Sasha Levin
maintainerRe: [PATCH 4.19 36/63] locking/lockdep: Add debug_locks check in __lock_downgrade()
Quoted 25 lines · Tetsuo Handa
Quoted 24 lines · Sasha Levin
Quoted 10 lines · Tetsuo Handa
Quoted 9 lines · Greg Kroah-Hartman
From: Waiman Long <[email protected]>
[ Upstream commit
513e1073d52e55b8024b4f238a48de7587c64ccf]Tetsuo Handa had reported he saw an incorrect "downgrading a read lock" warning right after a previous lockdep warning. It is likely that the previous warning turned off lock debugging causing the lockdep to have inconsistency states leading to the lock downgrade warning.
Quoted 5 lines
Quoted 2 lines
Fix that by add a check for
debug_locksat the beginning of__lock_downgrade().Please drop "[PATCH 4.19 36/63] locking/lockdep: Add
debug_lockscheck in__lock_downgrade()". We had a revert patch shown below in the past.We had a revert in the stable trees, but that revert was incorrect.
Take a look at commit
513e1073d52e55upstream, it patches__lock_set_class()(even though the subject line says__lock_downgrade()). So this is not a backporting error as the revert said it is, but is rather the intended location to be patched.
Quoted 8 lines
Quoted 2 lines
If this is actually wrong, then it should be addressed upstream first.
Hmm, upstream has two commits with same author, same date, same subject, different hash, different content. I couldn't find from https://lkml.kernel.org/r/[email protected] that we want to patch both
__lock_set_class()and__lock_downgrade(), but I found that the tip-bot has patched__lock_downgrade()on "2019-01-21 11:29" and__lock_set_class()on "2019-02-04 8:56". Seems that we by error patched both functions, though patching both functions should be harmless...
Right, there's a lot of confusion between the duplicate subject lines and what this patch actually does. My point was that this is an upstream issue rather than a stable issue, we're just aligning with upstream here.
--
Thanks,
Sasha
Re: [PATCH 4.19 36/63] locking/lockdep: Add debug_locks check in __lock_downgrade()
In reply to Tetsuo HandaQuoted 61 lines · Tetsuo Handa
Quoted 15 lines · Sasha Levin
Quoted 10 lines · Tetsuo Handa
Quoted 9 lines · Greg Kroah-Hartman
From: Waiman Long <[email protected]>
[ Upstream commit
513e1073d52e55b8024b4f238a48de7587c64ccf]Tetsuo Handa had reported he saw an incorrect "downgrading a read lock" warning right after a previous lockdep warning. It is likely that the previous warning turned off lock debugging causing the lockdep to have inconsistency states leading to the lock downgrade warning.
Quoted 4 lines
Quoted 2 lines
Fix that by add a check for
debug_locksat the beginning of__lock_downgrade().Please drop "[PATCH 4.19 36/63] locking/lockdep: Add
debug_lockscheck in__lock_downgrade()". We had a revert patch shown below in the past.Quoted 9 lines
We had a revert in the stable trees, but that revert was incorrect.
Take a look at commit
513e1073d52e55upstream, it patches__lock_set_class()(even though the subject line says__lock_downgrade()). So this is not a backporting error as the revert said it is, but is rather the intended location to be patched.If this is actually wrong, then it should be addressed upstream first.
Hmm, upstream has two commits with same author, same date, same subject, different hash, different content. I couldn't find from https://lkml.kernel.org/r/[email protected] that we want to patch both
__lock_set_class()and__lock_downgrade(), but I found that the tip-bot has patched__lock_downgrade()on "2019-01-21 11:29" and__lock_set_class()on "2019-02-04 8:56". Seems that we by error patched both functions, though patching both functions should be harmless...64aa348ed kernel/lockdep.c (Peter Zijlstra 2008-08-11 09:30:21 +0200 4115) static int 00ef9f734 kernel/lockdep.c (Peter Zijlstra 2008-12-04 09:00:17 +0100 4116) __lock_set_class(struct lockdep_map *lock, const char *name, 00ef9f734 kernel/lockdep.c (Peter Zijlstra 2008-12-04 09:00:17 +0100 4117) struct lock_class_key *key, unsigned int subclass, 00ef9f734 kernel/lockdep.c (Peter Zijlstra 2008-12-04 09:00:17 +0100 4118) unsigned long ip) 64aa348ed kernel/lockdep.c (Peter Zijlstra 2008-08-11 09:30:21 +0200 4119) { 64aa348ed kernel/lockdep.c (Peter Zijlstra 2008-08-11 09:30:21 +0200 4120) struct task_struct *curr = current; 8c8889d8e kernel/locking/lockdep.c (Imre Deak 2019-05-24 23:15:08 +0300 4121) unsigned int depth, merged = 0; 41c2c5b86 kernel/locking/lockdep.c (J. R. Okajima 2017-02-03 01:38:15 +0900 4122) struct held_lock *hlock; 64aa348ed kernel/lockdep.c (Peter Zijlstra 2008-08-11 09:30:21 +0200 4123) struct lock_class *class; 64aa348ed kernel/lockdep.c (Peter Zijlstra 2008-08-11 09:30:21 +0200 4124) int i; 64aa348ed kernel/lockdep.c (Peter Zijlstra 2008-08-11 09:30:21 +0200 4125) 513e1073d kernel/locking/lockdep.c (Waiman Long 2019-01-09 23:03:25 -0500 4126) if (unlikely(!debug_locks)) 513e1073d kernel/locking/lockdep.c (Waiman Long 2019-01-09 23:03:25 -0500 4127) return 0; 513e1073d kernel/locking/lockdep.c (Waiman Long 2019-01-09 23:03:25 -0500 4128)6419c4af7 kernel/locking/lockdep.c (J. R. Okajima 2017-02-03 01:38:17 +0900 4162) static int __lock_downgrade(struct lockdep_map *lock, unsigned long ip) 6419c4af7 kernel/locking/lockdep.c (J. R. Okajima 2017-02-03 01:38:17 +0900 4163) { 6419c4af7 kernel/locking/lockdep.c (J. R. Okajima 2017-02-03 01:38:17 +0900 4164) struct task_struct *curr = current; 8c8889d8e kernel/locking/lockdep.c (Imre Deak 2019-05-24 23:15:08 +0300 4165) unsigned int depth, merged = 0; 6419c4af7 kernel/locking/lockdep.c (J. R. Okajima 2017-02-03 01:38:17 +0900 4166) struct held_lock *hlock; 6419c4af7 kernel/locking/lockdep.c (J. R. Okajima 2017-02-03 01:38:17 +0900 4167) int i; 6419c4af7 kernel/locking/lockdep.c (J. R. Okajima 2017-02-03 01:38:17 +0900 4168) 714925805 kernel/locking/lockdep.c (Waiman Long 2019-01-09 23:03:25 -0500 4169) if (unlikely(!debug_locks)) 714925805 kernel/locking/lockdep.c (Waiman Long 2019-01-09 23:03:25 -0500 4170) return 0; 714925805 kernel/locking/lockdep.c (Waiman Long 2019-01-09 23:03:25 -0500 4171)commit
513e1073d52e55b8024b4f238a48de7587c64ccfAuthor: Waiman Long <[email protected]> Date: Wed Jan 9 23:03:25 2019 -0500
Quoted 8 lines
locking/lockdep: Add
debug_lockscheck in__lock_downgrade()commit
71492580571467fb7177aade19c18ce7486267f5Author: Waiman Long <[email protected]> Date: Wed Jan 9 23:03:25 2019 -0500locking/lockdep: Add
debug_lockscheck in__lock_downgrade()
As I had said before, it looks like the git-apply mixed up the location due to the fact that the hunks are exactly the same for both locations. So if the patch to be applied does not have the right line number, it will get applied to the wrong location first.
Cheers,
Longman
Sasha Levin
maintainerRe: [PATCH 4.19 36/63] locking/lockdep: Add debug_locks check in __lock_downgrade()
Quoted 68 lines · Waiman Long
Quoted 67 lines · Tetsuo Handa
Quoted 15 lines · Sasha Levin
Quoted 10 lines · Tetsuo Handa
Quoted 9 lines · Greg Kroah-Hartman
From: Waiman Long <[email protected]>
[ Upstream commit
513e1073d52e55b8024b4f238a48de7587c64ccf]Tetsuo Handa had reported he saw an incorrect "downgrading a read lock" warning right after a previous lockdep warning. It is likely that the previous warning turned off lock debugging causing the lockdep to have inconsistency states leading to the lock downgrade warning.
Quoted 4 lines
Quoted 2 lines
Fix that by add a check for
debug_locksat the beginning of__lock_downgrade().Please drop "[PATCH 4.19 36/63] locking/lockdep: Add
debug_lockscheck in__lock_downgrade()". We had a revert patch shown below in the past.Quoted 9 lines
We had a revert in the stable trees, but that revert was incorrect.
Take a look at commit
513e1073d52e55upstream, it patches__lock_set_class()(even though the subject line says__lock_downgrade()). So this is not a backporting error as the revert said it is, but is rather the intended location to be patched.If this is actually wrong, then it should be addressed upstream first.
Hmm, upstream has two commits with same author, same date, same subject, different hash, different content. I couldn't find from https://lkml.kernel.org/r/[email protected] that we want to patch both
__lock_set_class()and__lock_downgrade(), but I found that the tip-bot has patched__lock_downgrade()on "2019-01-21 11:29" and__lock_set_class()on "2019-02-04 8:56". Seems that we by error patched both functions, though patching both functions should be harmless...64aa348ed kernel/lockdep.c (Peter Zijlstra 2008-08-11 09:30:21 +0200 4115) static int 00ef9f734 kernel/lockdep.c (Peter Zijlstra 2008-12-04 09:00:17 +0100 4116) __lock_set_class(struct lockdep_map *lock, const char *name, 00ef9f734 kernel/lockdep.c (Peter Zijlstra 2008-12-04 09:00:17 +0100 4117) struct lock_class_key *key, unsigned int subclass, 00ef9f734 kernel/lockdep.c (Peter Zijlstra 2008-12-04 09:00:17 +0100 4118) unsigned long ip) 64aa348ed kernel/lockdep.c (Peter Zijlstra 2008-08-11 09:30:21 +0200 4119) { 64aa348ed kernel/lockdep.c (Peter Zijlstra 2008-08-11 09:30:21 +0200 4120) struct task_struct *curr = current; 8c8889d8e kernel/locking/lockdep.c (Imre Deak 2019-05-24 23:15:08 +0300 4121) unsigned int depth, merged = 0; 41c2c5b86 kernel/locking/lockdep.c (J. R. Okajima 2017-02-03 01:38:15 +0900 4122) struct held_lock *hlock; 64aa348ed kernel/lockdep.c (Peter Zijlstra 2008-08-11 09:30:21 +0200 4123) struct lock_class *class; 64aa348ed kernel/lockdep.c (Peter Zijlstra 2008-08-11 09:30:21 +0200 4124) int i; 64aa348ed kernel/lockdep.c (Peter Zijlstra 2008-08-11 09:30:21 +0200 4125) 513e1073d kernel/locking/lockdep.c (Waiman Long 2019-01-09 23:03:25 -0500 4126) if (unlikely(!debug_locks)) 513e1073d kernel/locking/lockdep.c (Waiman Long 2019-01-09 23:03:25 -0500 4127) return 0; 513e1073d kernel/locking/lockdep.c (Waiman Long 2019-01-09 23:03:25 -0500 4128)6419c4af7 kernel/locking/lockdep.c (J. R. Okajima 2017-02-03 01:38:17 +0900 4162) static int __lock_downgrade(struct lockdep_map *lock, unsigned long ip) 6419c4af7 kernel/locking/lockdep.c (J. R. Okajima 2017-02-03 01:38:17 +0900 4163) { 6419c4af7 kernel/locking/lockdep.c (J. R. Okajima 2017-02-03 01:38:17 +0900 4164) struct task_struct *curr = current; 8c8889d8e kernel/locking/lockdep.c (Imre Deak 2019-05-24 23:15:08 +0300 4165) unsigned int depth, merged = 0; 6419c4af7 kernel/locking/lockdep.c (J. R. Okajima 2017-02-03 01:38:17 +0900 4166) struct held_lock *hlock; 6419c4af7 kernel/locking/lockdep.c (J. R. Okajima 2017-02-03 01:38:17 +0900 4167) int i; 6419c4af7 kernel/locking/lockdep.c (J. R. Okajima 2017-02-03 01:38:17 +0900 4168) 714925805 kernel/locking/lockdep.c (Waiman Long 2019-01-09 23:03:25 -0500 4169) if (unlikely(!debug_locks)) 714925805 kernel/locking/lockdep.c (Waiman Long 2019-01-09 23:03:25 -0500 4170) return 0; 714925805 kernel/locking/lockdep.c (Waiman Long 2019-01-09 23:03:25 -0500 4171)commit
513e1073d52e55b8024b4f238a48de7587c64ccfAuthor: Waiman Long <[email protected]> Date: Wed Jan 9 23:03:25 2019 -0500locking/lockdep: Add
debug_lockscheck in__lock_downgrade()commit
71492580571467fb7177aade19c18ce7486267f5Author: Waiman Long <[email protected]> Date: Wed Jan 9 23:03:25 2019 -0500
Quoted 6 lines
Quoted 2 lines
locking/lockdep: Add
debug_lockscheck in__lock_downgrade()As I had said before, it looks like the git-apply mixed up the location due to the fact that the hunks are exactly the same for both locations. So if the patch to be applied does not have the right line number, it will get applied to the wrong location first.
I very much agree, my point is that *both* patches are upstream right now, and if one of those patches is wrong then it should be reverted upstream, and we'd be happy to take the revert.
--
Thanks,
Sasha
Re: [PATCH 4.19 36/63] locking/lockdep: Add debug_locks check in __lock_downgrade()
Quoted 108 lines · Sasha Levin
Quoted 107 lines · Waiman Long
Quoted 106 lines · Tetsuo Handa
Quoted 19 lines · Sasha Levin
Quoted 13 lines · Tetsuo Handa
Quoted 12 lines · Greg Kroah-Hartman
From: Waiman Long <[email protected]>
[ Upstream commit
513e1073d52e55b8024b4f238a48de7587c64ccf]Tetsuo Handa had reported he saw an incorrect "downgrading a read lock"
warning right after a previous lockdep warning. It is likely that the
previous warning turned off lock debugging causing the lockdep to have
inconsistency states leading to the lock downgrade warning.Quoted 5 lines
Quoted 2 lines
Fix that by add a check for
debug_locksat the beginning of__lock_downgrade().Please drop "[PATCH 4.19 36/63] locking/lockdep: Add
debug_lockscheck in__lock_downgrade()".
We had a revert patch shown below in the past.Quoted 9 lines
We had a revert in the stable trees, but that revert was incorrect.
Take a look at commit
513e1073d52e55upstream, it patches__lock_set_class()(even though the subject line says__lock_downgrade()). So this is not a backporting error as the revert said it is, but is rather the intended location to be patched.If this is actually wrong, then it should be addressed upstream first.
Hmm, upstream has two commits with same author, same date, same subject, different hash, different content.
I couldn't find from
https://lkml.kernel.org/r/[email protected]
that
we want to patch both__lock_set_class()and__lock_downgrade(), but I found that the tip-bot has patched__lock_downgrade()on "2019-01-21 11:29" and__lock_set_class()on "2019-02-04 8:56".
Seems that we by error patched both functions, though patching both functions should be harmless...
64aa348edkernel/lockdep.c (Peter Zijlstra2008-08-11 09:30:21 +0200 4115) static int 00ef9f734 kernel/lockdep.c (Peter Zijlstra 2008-12-04 09:00:17 +0100 4116) __lock_set_class(struct lockdep_map *lock, const char *name, 00ef9f734 kernel/lockdep.c (Peter Zijlstra 2008-12-04 09:00:17 +0100 4117) struct lock_class_key *key, unsigned int subclass, 00ef9f734 kernel/lockdep.c (Peter Zijlstra 2008-12-04 09:00:17 +0100 4118) unsigned long ip) 64aa348ed kernel/lockdep.c (Peter Zijlstra 2008-08-11 09:30:21 +0200 4119) { 64aa348ed kernel/lockdep.c (Peter Zijlstra 2008-08-11 09:30:21 +0200 4120) struct task_struct *curr = current; 8c8889d8e kernel/locking/lockdep.c (Imre Deak 2019-05-24 23:15:08 +0300 4121) unsigned int depth, merged = 0; 41c2c5b86 kernel/locking/lockdep.c (J. R. Okajima 2017-02-03 01:38:15 +0900 4122) struct held_lock *hlock; 64aa348ed kernel/lockdep.c (Peter Zijlstra 2008-08-11 09:30:21 +0200 4123) struct lock_class *class; 64aa348ed kernel/lockdep.c (Peter Zijlstra 2008-08-11 09:30:21 +0200 4124) int i; 64aa348ed kernel/lockdep.c (Peter Zijlstra 2008-08-11 09:30:21 +0200 4125) 513e1073d kernel/locking/lockdep.c (Waiman Long 2019-01-09 23:03:25 -0500 4126) if (unlikely(!debug_locks)) 513e1073d kernel/locking/lockdep.c (Waiman Long 2019-01-09 23:03:25 -0500 4127) return 0; 513e1073d kernel/locking/lockdep.c (Waiman Long 2019-01-09 23:03:25 -0500 4128)
6419c4af7kernel/locking/lockdep.c(J. R. Okajima2017-02-03 01:38:17 +0900 4162) static int __lock_downgrade(struct lockdep_map *lock, unsigned long ip) 6419c4af7 kernel/locking/lockdep.c (J. R. Okajima 2017-02-03 01:38:17 +0900 4163) { 6419c4af7 kernel/locking/lockdep.c (J. R. Okajima 2017-02-03 01:38:17 +0900 4164) struct task_struct *curr = current; 8c8889d8e kernel/locking/lockdep.c (Imre Deak 2019-05-24 23:15:08 +0300 4165) unsigned int depth, merged = 0; 6419c4af7 kernel/locking/lockdep.c (J. R. Okajima 2017-02-03 01:38:17 +0900 4166) struct held_lock *hlock; 6419c4af7 kernel/locking/lockdep.c (J. R. Okajima 2017-02-03 01:38:17 +0900 4167) int i; 6419c4af7 kernel/locking/lockdep.c (J. R. Okajima 2017-02-03 01:38:17 +0900 4168) 714925805 kernel/locking/lockdep.c (Waiman Long 2019-01-09 23:03:25 -0500 4169) if (unlikely(!debug_locks)) 714925805 kernel/locking/lockdep.c (Waiman Long 2019-01-09 23:03:25 -0500 4170) return 0; 714925805 kernel/locking/lockdep.c (Waiman Long 2019-01-09 23:03:25 -0500 4171)commit
513e1073d52e55b8024b4f238a48de7587c64ccf
Author: Waiman Long <[email protected]>
Date: Wed Jan 9 23:03:25 2019 -0500locking/lockdep: Add
debug_lockscheck in__lock_downgrade()commit
71492580571467fb7177aade19c18ce7486267f5
Author: Waiman Long <[email protected]>
Date: Wed Jan 9 23:03:25 2019 -0500locking/lockdep: Add
debug_lockscheck in__lock_downgrade()
Quoted 8 lines
Quoted 4 lines
As I had said before, it looks like the git-apply mixed up the location due to the fact that the hunks are exactly the same for both locations. So if the patch to be applied does not have the right line number, it will get applied to the wrong location first.
I very much agree, my point is that *both* patches are upstream right now, and if one of those patches is wrong then it should be reverted upstream, and we'd be happy to take the revert.
The patch itself shouldn't do any harm even if it is applied to the wrong function. So there is no urgency to revert it.
Cheers,
Longman
Greg Kroah-Hartman
maintainerRe: [PATCH 4.19 36/63] locking/lockdep: Add debug_locks check in __lock_downgrade()
In reply to Tetsuo HandaQuoted 10 lines · Tetsuo Handa
Quoted 9 lines · Greg Kroah-Hartman
From: Waiman Long <[email protected]>
[ Upstream commit
513e1073d52e55b8024b4f238a48de7587c64ccf]Tetsuo Handa had reported he saw an incorrect "downgrading a read lock" warning right after a previous lockdep warning. It is likely that the previous warning turned off lock debugging causing the lockdep to have inconsistency states leading to the lock downgrade warning.
Quoted 5 lines
Quoted 2 lines
Fix that by add a check for
debug_locksat the beginning of__lock_downgrade().Please drop "[PATCH 4.19 36/63] locking/lockdep: Add
debug_lockscheck in__lock_downgrade()". We had a revert patch shown below in the past.
Ugh, I missed that, thanks.
Quoted 1 line
"[PATCH 4.19 37/63] locking/lockdep: Add
debug_lockscheck in__lock_downgrade()- again" seems the correct patch.
Ok, will keep that one. And will drop the "again" part of that subject line, had to add that to make quilt happy :(
thanks for the review.
greg k-h
Greg Kroah-Hartman
maintainerPATCH 37/63 locking/lockdep: Add debug_locks check in __lock_downgrade() - again
In reply to Greg Kroah-HartmanFrom: Waiman Long <[email protected]>
[ Upstream commit 71492580571467fb7177aade19c18ce7486267f5 ]
Tetsuo Handa had reported he saw an incorrect "downgrading a read lock" warning right after a previous lockdep warning. It is likely that the previous warning turned off lock debugging causing the lockdep to have inconsistency states leading to the lock downgrade warning.
Fix that by add a check for debug_locks at the beginning of __lock_downgrade().
--- kernel/locking/lockdep.c | 3 +++ 1 file changed, 3 insertions(+)
kernel/locking/lockdep.c +3 -0
@@ -3608,6 +3608,9 @@ static int __lock_downgrade(struct lockdep_map *lock, unsigned long ip)unsigned int depth;int i; +if (unlikely (!debug_locks)) +return 0 ; + depth = curr->lockdep_depth;/* * This function is about (re)setting the class of a held lock,
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 38/63 scsi: qla2xxx: Turn off IOCB timeout timer on IOCB completion
In reply to Greg Kroah-HartmanFrom: Quinn Tran <[email protected]>
[ Upstream commit e112761a4f1dcbe9fb9f43f46de7be69d6963b0d ]
Turn off IOCB timeout timer on IOCB completion instead of turning it off in a deferred task. This prevent false alarm if the deferred task is stalled out.
--- drivers/scsi/qla2xxx/qla_gs.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/scsi/qla2xxx/qla_gs.c +5 -3
@@ -4225,10 +4225,13 @@ static void qla2x00_async_gpnft_gnnft_sp_done(void *s, int res)return ; } -if (cmd ==GPN_FT_CMD ) +if (cmd ==GPN_FT_CMD ) { +del_timer (&sp->u.iocb_cmd.timer); e =qla2x00_alloc_work (vha,QLA_EVT_GPNFT_DONE ); -else + }else { e =qla2x00_alloc_work (vha,QLA_EVT_GNNFT_DONE ); + } +if (!e) {/* please ignore kernel warning. Otherwise, we have mem leak. */ if (sp->u.iocb_cmd.u.ctarg.req) {
@@ -4357,7 +4360,6 @@ void qla24xx_async_gpnft_done(scsi_qla_host_t *vha, srb_t *sp) {ql_dbg (ql_dbg_disc, vha,0xffff ,"%s enter\n" , __func__); -del_timer (&sp->u.iocb_cmd.timer);qla24xx_async_gnnft (vha, sp, sp->gen2); }
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 39/63 scsi: qla2xxx: Remove all rports if fabric scan retry fails
In reply to Greg Kroah-HartmanFrom: Quinn Tran <[email protected]>
[ Upstream commit 9ba1cb25c151de306d64647e545d34af64f30c19 ]
When all fabric scan retries fail, remove all RPorts, DMA resources for the command. Otherwise we have stale Rports.
--- drivers/scsi/qla2xxx/qla_gs.c | 128 +++++++++++++++++----------------- 1 file changed, 64 insertions(+), 64 deletions(-)
drivers/scsi/qla2xxx/qla_gs.c +64 -64
@@ -4045,6 +4045,41 @@ void qla24xx_async_gnnft_done(scsi_qla_host_t *vha, srb_t *sp) } } +static int qla2x00_post_gnnft_gpnft_done_work (struct scsi_qla_host *vha, +srb_t *sp,int cmd) +{ +struct qla_work_evt *e; + +if (cmd !=QLA_EVT_GPNFT_DONE && cmd !=QLA_EVT_GNNFT_DONE ) +return QLA_PARAMETER_ERROR ; + + e =qla2x00_alloc_work (vha, cmd); +if (!e) +return QLA_FUNCTION_FAILED ; + + e->u.iosb.sp = sp; + +return qla2x00_post_work (vha, e); +} + +static int qla2x00_post_nvme_gpnft_done_work (struct scsi_qla_host *vha, +srb_t *sp,int cmd) +{ +struct qla_work_evt *e; + +if (cmd !=QLA_EVT_GPNFT ) +return QLA_PARAMETER_ERROR ; + + e =qla2x00_alloc_work (vha, cmd); +if (!e) +return QLA_FUNCTION_FAILED ; + + e->u.gpnft.fc4_type =FC4_TYPE_NVME ; + e->u.gpnft.sp = sp; + +return qla2x00_post_work (vha, e); +} +static void qla2x00_find_free_fcp_nvme_slot (struct scsi_qla_host *vha,struct srb *sp) {
@@ -4145,22 +4180,36 @@ static void qla2x00_async_gpnft_gnnft_sp_done(void *s, int res) {struct srb *sp = s;struct scsi_qla_host *vha = sp->vha; -struct qla_work_evt *e;struct ct_sns_req *ct_req = (struct ct_sns_req *)sp->u.iocb_cmd.u.ctarg.req;u16 cmd =be16_to_cpu (ct_req->command);u8 fc4_type = sp->gen2;unsigned long flags; +int rc;/* gen2 field is holding the fc4type */ ql_dbg (ql_dbg_disc, vha,0xffff ,"Async done-%s res %x FC4Type %x\n" , sp->name, res, sp->gen2); + sp->rc = res;if (res) {unsigned long flags; +const char *name = sp->name; + +/* +* We are in an Interrupt context, queue up this +* sp for GNNFT_DONE work. This will allow all +* the resource to get freed up. +*/ + rc =qla2x00_post_gnnft_gpnft_done_work (vha, sp, +QLA_EVT_GNNFT_DONE ); +if (rc) { +/* Cleanup here to prevent memory leak */ +qla24xx_sp_unmap (vha, sp); + sp->free (sp); + } - sp->free (sp);spin_lock_irqsave (&vha->work_lock, flags); vha->scan.scan_flags &= ~SF_SCANNING ; vha->scan.scan_retry++;
@@ -4171,9 +4220,9 @@ static void qla2x00_async_gpnft_gnnft_sp_done(void *s, int res)set_bit (LOOP_RESYNC_NEEDED , &vha->dpc_flags);qla2xxx_wake_dpc (vha); }else { -ql_dbg (ql_dbg_disc, sp->vha,0xffff , -"Async done-%s rescan failed on all retries\n" , - sp->name); +ql_dbg (ql_dbg_disc, vha,0xffff , +"Async done-%s rescan failed on all retries.\n" , + name); }return ; }
@@ -4188,80 +4237,31 @@ static void qla2x00_async_gpnft_gnnft_sp_done(void *s, int res) vha->scan.scan_flags &= ~SF_SCANNING ;spin_unlock_irqrestore (&vha->work_lock, flags); - e =qla2x00_alloc_work (vha,QLA_EVT_GPNFT ); -if (!e) { -/* -* please ignore kernel warning. Otherwise, -* we have mem leak. -*/ -if (sp->u.iocb_cmd.u.ctarg.req) { -dma_free_coherent (&vha->hw->pdev->dev, - sp->u.iocb_cmd.u.ctarg.req_allocated_size, - sp->u.iocb_cmd.u.ctarg.req, - sp->u.iocb_cmd.u.ctarg.req_dma); - sp->u.iocb_cmd.u.ctarg.req =NULL ; - } -if (sp->u.iocb_cmd.u.ctarg.rsp) { -dma_free_coherent (&vha->hw->pdev->dev, - sp->u.iocb_cmd.u.ctarg.rsp_allocated_size, - sp->u.iocb_cmd.u.ctarg.rsp, - sp->u.iocb_cmd.u.ctarg.rsp_dma); - sp->u.iocb_cmd.u.ctarg.rsp =NULL ; - } - -ql_dbg (ql_dbg_disc, vha,0xffff , -"Async done-%s unable to alloc work element\n" , - sp->name); - sp->free (sp); + sp->rc = res; + rc =qla2x00_post_nvme_gpnft_done_work (vha, sp,QLA_EVT_GPNFT ); +if (!rc) { +qla24xx_sp_unmap (vha, sp);set_bit (LOCAL_LOOP_UPDATE , &vha->dpc_flags);set_bit (LOOP_RESYNC_NEEDED , &vha->dpc_flags);return ; } - e->u.gpnft.fc4_type =FC4_TYPE_NVME ; - sp->rc = res; - e->u.gpnft.sp = sp; - -qla2x00_post_work (vha, e); -return ; }if (cmd ==GPN_FT_CMD ) {del_timer (&sp->u.iocb_cmd.timer); - e =qla2x00_alloc_work (vha,QLA_EVT_GPNFT_DONE ); + rc =qla2x00_post_gnnft_gpnft_done_work (vha, sp, +QLA_EVT_GPNFT_DONE ); }else { - e =qla2x00_alloc_work (vha,QLA_EVT_GNNFT_DONE ); + rc =qla2x00_post_gnnft_gpnft_done_work (vha, sp, +QLA_EVT_GNNFT_DONE ); } -if (!e) { -/* please ignore kernel warning. Otherwise, we have mem leak. */ -if (sp->u.iocb_cmd.u.ctarg.req) { -dma_free_coherent (&vha->hw->pdev->dev, - sp->u.iocb_cmd.u.ctarg.req_allocated_size, - sp->u.iocb_cmd.u.ctarg.req, - sp->u.iocb_cmd.u.ctarg.req_dma); - sp->u.iocb_cmd.u.ctarg.req =NULL ; - } -if (sp->u.iocb_cmd.u.ctarg.rsp) { -dma_free_coherent (&vha->hw->pdev->dev, - sp->u.iocb_cmd.u.ctarg.rsp_allocated_size, - sp->u.iocb_cmd.u.ctarg.rsp, - sp->u.iocb_cmd.u.ctarg.rsp_dma); - sp->u.iocb_cmd.u.ctarg.rsp =NULL ; - } - -ql_dbg (ql_dbg_disc, vha,0xffff , -"Async done-%s unable to alloc work element\n" , - sp->name); - sp->free (sp); +if (rc) { +qla24xx_sp_unmap (vha, sp);set_bit (LOCAL_LOOP_UPDATE , &vha->dpc_flags);set_bit (LOOP_RESYNC_NEEDED , &vha->dpc_flags);return ; } - - sp->rc = res; - e->u.iosb.sp = sp; - -qla2x00_post_work (vha, e); }/*
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 40/63 scsi: qla2xxx: Return switch command on a timeout
In reply to Greg Kroah-HartmanFrom: Himanshu Madhani <[email protected]>
[ Upstream commit ef801f07e7b3cc1786d8ab1b4fdf069cc2a136d2 ]
This patch fixes commit bcc71cc3cde1 ("scsi: qla2xxx: Fix for double free of SRB structure") which placed code in wrong routines.
Also updated the use of WARN_ON() to WARN_ON_ONCE() to prevent flooding log messages.
--- drivers/scsi/qla2xxx/qla_init.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-)
drivers/scsi/qla2xxx/qla_init.c +5 -6
@@ -54,7 +54,7 @@ qla2x00_sp_timeout(struct timer_list *t)unsigned long flags;struct qla_hw_data *ha = sp->vha->hw; -WARN_ON (irqs_disabled ()); +WARN_ON_ONCE (irqs_disabled ());spin_lock_irqsave (&ha->hardware_lock, flags); req = sp->qpair->req; req->outstanding_cmds[sp->handle] =NULL ;
@@ -796,6 +796,9 @@ qla24xx_async_gnl_sp_done(void *s, int res) sp->name, res, sp->u.iocb_cmd.u.mbx.in_mb[1 ], sp->u.iocb_cmd.u.mbx.in_mb[2]); +if (res ==QLA_FUNCTION_TIMEOUT ) +return ; +memset (&ea,0 ,sizeof (ea)); ea.sp = sp; ea.rc = res;
@@ -979,17 +982,13 @@ void qla24xx_async_gpdb_sp_done(void *s, int res)"Async done-%s res %x, WWPN %8phC mb[1]=%x mb[2]=%x \n" , sp->name, res, fcport->port_name, mb[1], mb[2]); - fcport->flags &= ~(FCF_ASYNC_SENT |FCF_ASYNC_ACTIVE ); - -if (res ==QLA_FUNCTION_TIMEOUT ) -return ; -if (res ==QLA_FUNCTION_TIMEOUT ) {dma_pool_free (sp->vha->hw->s_dma_pool, sp->u.iocb_cmd.u.mbx.in, sp->u.iocb_cmd.u.mbx.in_dma);return ; } + fcport->flags &= ~(FCF_ASYNC_SENT |FCF_ASYNC_ACTIVE );memset (&ea,0 ,sizeof (ea)); ea.event =FCME_GPDB_DONE ; ea.fcport = fcport;
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 41/63 Revert "drm/amd/powerplay: Enable/Disable NBPSTATE on On/OFF of UVD"
In reply to Greg Kroah-HartmanFrom: Shirish S <[email protected]>
[ Upstream commit 00fedbe629bfc0a51c07b6e665265ce31d8b6f3c ]
This reverts commit dbd8299c32f6f413f6cfe322fe0308f3cfc577e8.
Reason for revert:
This patch sends msg PPSMC_MSG_DisableLowMemoryPstate(0x002e) in wrong of sequence to SMU which is before PPSMC_MSG_UVDPowerON (0x0008). This leads to SMU failing to service the request as it is dependent on UVD to be powered ON, since it accesses UVD registers.
This msg should ideally be sent only when the UVD is about to decode a 4k video.
--- drivers/gpu/drm/amd/powerplay/hwmgr/smu8_hwmgr.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/gpu/drm/amd/powerplay/hwmgr/smu8_hwmgr.c +1 -4
@@ -1222,17 +1222,14 @@ static int smu8_dpm_force_dpm_level(struct pp_hwmgr *hwmgr,static int smu8_dpm_powerdown_uvd (struct pp_hwmgr *hwmgr) { -if (PP_CAP (PHM_PlatformCaps_UVDPowerGating)) { -smu8_nbdpm_pstate_enable_disable (hwmgr, true, true); +if (PP_CAP (PHM_PlatformCaps_UVDPowerGating))return smum_send_msg_to_smc (hwmgr, PPSMC_MSG_UVDPowerOFF); - }return 0 ; }static int smu8_dpm_powerup_uvd (struct pp_hwmgr *hwmgr) {if (PP_CAP (PHM_PlatformCaps_UVDPowerGating)) { -smu8_nbdpm_pstate_enable_disable (hwmgr, false, true); return smum_send_msg_to_smc_with_parameter( hwmgr, PPSMC_MSG_UVDPowerON,
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 42/63 bpf: libbpf: retry loading program on EAGAIN
In reply to Greg Kroah-HartmanFrom: Lorenz Bauer <[email protected]>
[ Upstream commit 86edaed379632e216a97e6bcef9f498b64522d50 ]
Commit c3494801cd17 ("bpf: check pending signals while verifying programs") makes it possible for the BPF_PROG_LOAD to fail with EAGAIN. Retry unconditionally in this case.
--- tools/lib/bpf/bpf.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-)
tools/lib/bpf/bpf.c +14 -3
@@ -75,6 +75,17 @@ static inline int sys_bpf(enum bpf_cmd cmd, union bpf_attr *attr,return syscall (__NR_bpf, cmd, attr, size); } +static inline int sys_bpf_prog_load (union bpf_attr *attr,unsigned int size) +{ +int fd; + +do { + fd =sys_bpf (BPF_PROG_LOAD , attr, size); + }while (fd <0 && errno ==EAGAIN ); + +return fd; +} +int bpf_create_map_xattr (const struct bpf_create_map_attr *create_attr) {__u32 name_len = create_attr->name ?strlen (create_attr->name) :0 ;
@@ -218,7 +229,7 @@ int bpf_load_program_xattr(const struct bpf_load_program_attr *load_attr,memcpy (attr.prog_name, load_attr->name,min (name_len,BPF_OBJ_NAME_LEN -1 )); - fd =sys_bpf (BPF_PROG_LOAD , &attr,sizeof (attr)); + fd =sys_bpf_prog_load (&attr,sizeof (attr));if (fd >=0 || !log_buf || !log_buf_sz)return fd;
@@ -227,7 +238,7 @@ int bpf_load_program_xattr(const struct bpf_load_program_attr *load_attr, attr.log_size = log_buf_sz; attr.log_level =1 ; log_buf[0 ] =0 ; -return sys_bpf (BPF_PROG_LOAD , &attr,sizeof (attr)); +return sys_bpf_prog_load (&attr,sizeof (attr)); } int bpf_load_program(enum bpf_prog_type type, const struct bpf_insn *insns,
@@ -268,7 +279,7 @@ int bpf_verify_program(enum bpf_prog_type type, const struct bpf_insn *insns, attr.kern_version = kern_version; attr.prog_flags = strict_alignment ?BPF_F_STRICT_ALIGNMENT :0 ; -return sys_bpf (BPF_PROG_LOAD , &attr,sizeof (attr)); +return sys_bpf_prog_load (&attr,sizeof (attr)); } int bpf_map_update_elem(int fd, const void *key, const void *value,
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 43/63 irqchip/gic-v3-its: Fix LPI release for Multi-MSI devices
In reply to Greg Kroah-HartmanFrom: Marc Zyngier <[email protected]>
[ Upstream commit c9c96e30ecaa0aafa225aa1a5392cb7db17c7a82 ]
When allocating a range of LPIs for a Multi-MSI capable device, this allocation extended to the closest power of 2.
But on the release path, the interrupts are released one by one. This results in not releasing the "extra" range, leaking the its_device. Trying to reprobe the device will then fail.
Fix it by releasing the LPIs the same way we allocate them.
--- drivers/irqchip/irq-gic-v3-its.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)
drivers/irqchip/irq-gic-v3-its.c +4 -5
@@ -2514,14 +2514,13 @@ static void its_irq_domain_free(struct irq_domain *domain, unsigned int virq,struct its_node *its = its_dev->its;int i; +bitmap_release_region (its_dev->event_map.lpi_map, +its_get_event_id (irq_domain_get_irq_data (domain, virq)), +get_count_order (nr_irqs)); +for (i =0 ; i < nr_irqs; i++) {struct irq_data *data =irq_domain_get_irq_data (domain, virq + i); -u32 event =its_get_event_id (data); - -/* Mark interrupt index as unused */ -clear_bit (event, its_dev->event_map.lpi_map); -/* Nuke the entry in the domain */ irq_domain_reset_irq_data (data); }
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 44/63 f2fs: check all the data segments against all node ones
In reply to Greg Kroah-HartmanFrom: Surbhi Palande <[email protected]>
[ Upstream commit 1166c1f2f69117ad254189ca781287afa6e550b6 ]
As a part of the sanity checking while mounting, distinct segment number assignment to data and node segments is verified. Fixing a small bug in this verification between node and data segments. We need to check all the data segments with all the node segments.
--- fs/f2fs/super.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
fs/f2fs/super.c +2 -2
@@ -2413,11 +2413,11 @@ int f2fs_sanity_check_ckpt(struct f2fs_sb_info *sbi) } }for (i =0 ; i <NR_CURSEG_NODE_TYPE ; i++) { -for (j = i; j <NR_CURSEG_DATA_TYPE ; j++) { +for (j =0 ; j <NR_CURSEG_DATA_TYPE ; j++) {if (le32_to_cpu (ckpt->cur_node_segno[i]) ==le32_to_cpu (ckpt->cur_data_segno[j])) {f2fs_msg (sbi->sb,KERN_ERR , -"Data segment (%u) and Data segment (%u)" +"Node segment (%u) and Data segment (%u)" " has the same segno: %u" , i, j,le32_to_cpu (ckpt->cur_node_segno[i]));return 1 ;
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 45/63 PCI: hv: Avoid use of hv_pci_dev->pci_slot after freeing it
In reply to Greg Kroah-HartmanFrom: Dexuan Cui <[email protected]>
[ Upstream commit 533ca1feed98b0bf024779a14760694c7cb4d431 ]
The slot must be removed before the pci_dev is removed, otherwise a panic can happen due to use-after-free.
--- drivers/pci/controller/pci-hyperv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/controller/pci-hyperv.c +1 -1
@@ -2706,8 +2706,8 @@ static int hv_pci_remove(struct hv_device *hdev)/* Remove the bus from PCI's point of view. */ pci_lock_rescan_remove ();pci_stop_root_bus (hbus->pci_bus); -pci_remove_root_bus (hbus->pci_bus);hv_pci_remove_slots (hbus); +pci_remove_root_bus (hbus->pci_bus);pci_unlock_rescan_remove (); hbus->state = hv_pcibus_removed; }
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 46/63 bcache: remove redundant LIST_HEAD(journal) from run_cache_set()
In reply to Greg Kroah-HartmanFrom: Coly Li <[email protected]>
[ Upstream commit cdca22bcbc64fc83dadb8d927df400a8d86ddabb ]
Commit 95f18c9d1310 ("bcache: avoid potential memleak of list of journal_replay(s) in the CACHE_SYNC branch of run_cache_set") forgets to remove the original define of LIST_HEAD(journal), which makes the change no take effect. This patch removes redundant variable LIST_HEAD(journal) from run_cache_set(), to make Shenghui's fix working.
--- drivers/md/bcache/super.c | 1 - 1 file changed, 1 deletion(-)
drivers/md/bcache/super.c +0 -1
@@ -1768,7 +1768,6 @@ static int run_cache_set(struct cache_set *c)set_gc_sectors (c);if (CACHE_SYNC (&c->sb)) { -LIST_HEAD (journal);struct bkey *k;struct jset *j;
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 47/63 initramfs: dont free a non-existent initrd
In reply to Greg Kroah-HartmanFrom: Steven Price <[email protected]>
[ Upstream commit 5d59aa8f9ce972b472201aed86e904bb75879ff0 ]
Since commit 54c7a8916a88 ("initramfs: free initrd memory if opening /initrd.image fails"), the kernel has unconditionally attempted to free the initrd even if it doesn't exist.
In the non-existent case this causes a boot-time splat if CONFIG_DEBUG_VIRTUAL is enabled due to a call to virt_to_phys() with a NULL address.
Instead we should check that the initrd actually exists and only attempt to free it if it does.
--- init/initramfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
init/initramfs.c +1 -1
@@ -524,7 +524,7 @@ static void __init free_initrd(void)unsigned long crashk_start = (unsigned long )__va (crashk_res.start);unsigned long crashk_end = (unsigned long )__va (crashk_res.end);#endif -if (do_retain_initrd) +if (do_retain_initrd || !initrd_start) goto skip;#ifdef CONFIG_KEXEC_CORE
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 48/63 blk-mq: change gfp flags to GFP_NOIO in blk_mq_realloc_hw_ctxs
In reply to Greg Kroah-HartmanFrom: Jianchao Wang <[email protected]>
[ Upstream commit 5b202853ffbc54b29f23c4b1b5f3948efab489a2 ]
blk_mq_realloc_hw_ctxs could be invoked during update hw queues. At the momemt, IO is blocked. Change the gfp flags from GFP_KERNEL to GFP_NOIO to avoid forever hang during memory allocation in blk_mq_realloc_hw_ctxs.
--- block/blk-core.c | 2 +- block/blk-flush.c | 6 +++--- block/blk-mq.c | 17 ++++++++++------- block/blk.h | 2 +- 4 files changed, 15 insertions(+), 12 deletions(-)
block/blk-core.c +1 -1
@@ -1165,7 +1165,7 @@ int blk_init_allocated_queue(struct request_queue *q) {WARN_ON_ONCE (q->mq_ops); - q->fq =blk_alloc_flush_queue (q,NUMA_NO_NODE , q->cmd_size); + q->fq =blk_alloc_flush_queue (q,NUMA_NO_NODE , q->cmd_size,GFP_KERNEL );if (!q->fq)return -ENOMEM ;
block/blk-flush.c +3 -3
@@ -566,12 +566,12 @@ int blkdev_issue_flush(struct block_device *bdev, gfp_t gfp_mask,EXPORT_SYMBOL (blkdev_issue_flush);struct blk_flush_queue *blk_alloc_flush_queue (struct request_queue *q, -int node,int cmd_size) +int node,int cmd_size,gfp_t flags) {struct blk_flush_queue *fq;int rq_sz =sizeof (struct request ); - fq =kzalloc_node (sizeof (*fq),GFP_KERNEL , node); + fq =kzalloc_node (sizeof (*fq), flags, node);if (!fq) goto fail;
@@ -579,7 +579,7 @@ struct blk_flush_queue *blk_alloc_flush_queue(struct request_queue *q,spin_lock_init (&fq->mq_flush_lock); rq_sz =round_up (rq_sz + cmd_size,cache_line_size ()); - fq->flush_rq =kzalloc_node (rq_sz,GFP_KERNEL , node); + fq->flush_rq =kzalloc_node (rq_sz, flags, node);if (!fq->flush_rq) goto fail_rq;
block/blk-mq.c +10 -7
@@ -2198,12 +2198,12 @@ static int blk_mq_init_hctx(struct request_queue *q,* runtime */ hctx->ctxs =kmalloc_array_node (nr_cpu_ids,sizeof (void *), -GFP_KERNEL , node); +GFP_NOIO | __GFP_NOWARN | __GFP_NORETRY, node);if (!hctx->ctxs) goto unregister_cpu_notifier; -if (sbitmap_init_node (&hctx->ctx_map, nr_cpu_ids,ilog2 (8 ),GFP_KERNEL , - node)) +if (sbitmap_init_node (&hctx->ctx_map, nr_cpu_ids,ilog2 (8 ), +GFP_NOIO | __GFP_NOWARN | __GFP_NORETRY, node)) goto free_ctxs; hctx->nr_ctx =0 ;
@@ -2216,7 +2216,8 @@ static int blk_mq_init_hctx(struct request_queue *q, set->ops->init_hctx(hctx, set->driver_data, hctx_idx)) goto free_bitmap; - hctx->fq =blk_alloc_flush_queue (q, hctx->numa_node, set->cmd_size); + hctx->fq =blk_alloc_flush_queue (q, hctx->numa_node, set->cmd_size, +GFP_NOIO | __GFP_NOWARN | __GFP_NORETRY);if (!hctx->fq) goto exit_hctx;
@@ -2530,12 +2531,14 @@ static void blk_mq_realloc_hw_ctxs(struct blk_mq_tag_set *set, node =blk_mq_hw_queue_to_node (q->mq_map, i); hctxs[i] =kzalloc_node (blk_mq_hw_ctx_size (set), -GFP_KERNEL , node); +GFP_NOIO | __GFP_NOWARN | __GFP_NORETRY, + node);if (!hctxs[i])break ; -if (!zalloc_cpumask_var_node (&hctxs[i]->cpumask,GFP_KERNEL , - node)) { +if (!zalloc_cpumask_var_node (&hctxs[i]->cpumask, +GFP_NOIO | __GFP_NOWARN | __GFP_NORETRY, + node)) {kfree (hctxs[i]); hctxs[i] =NULL ;break ;
block/blk.h +1 -1
@@ -124,7 +124,7 @@ static inline void __blk_get_queue(struct request_queue *q) }struct blk_flush_queue *blk_alloc_flush_queue (struct request_queue *q, -int node,int cmd_size); +int node,int cmd_size,gfp_t flags);void blk_free_flush_queue (struct blk_flush_queue *q); int blk_init_rl(struct request_list *rl, struct request_queue *q,
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 49/63 blk-mq: move cancel of requeue_work to the front of blk_exit_queue
In reply to Greg Kroah-HartmanFrom: zhengbin <[email protected]>
[ Upstream commit e26cc08265dda37d2acc8394604f220ef412299d ]
blk_exit_queue will free elevator_data, while blk_mq_requeue_work will access it. Move cancel of requeue_work to the front of blk_exit_queue to avoid use-after-free.
blk_exit_queue blk_mq_requeue_work
__elevator_exit blk_mq_run_hw_queues
blk_mq_exit_sched blk_mq_run_hw_queue
dd_exit_queue blk_mq_hctx_has_pending
kfree(elevator_data) blk_mq_sched_has_work
dd_has_work
--- block/blk-mq.c | 2 -- block/blk-sysfs.c | 3 +++ 2 files changed, 3 insertions(+), 2 deletions(-)
block/blk-mq.c +0 -2
@@ -2461,8 +2461,6 @@ void blk_mq_release(struct request_queue *q)struct blk_mq_hw_ctx *hctx;unsigned int i; -cancel_delayed_work_sync (&q->requeue_work); -/* hctx kobj stays in hctx */ queue_for_each_hw_ctx (q, hctx, i) {if (!hctx)
block/blk-sysfs.c +3 -0
@@ -836,6 +836,9 @@ static void __blk_release_queue(struct work_struct *work)blk_free_queue_stats (q->stats); +if (q->mq_ops) +cancel_delayed_work_sync (&q->requeue_work); +blk_exit_rl (q, &q->root_rl);if (q->queue_tags)
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 50/63 Revert "f2fs: avoid out-of-range memory access"
In reply to Greg Kroah-HartmanFrom: Chao Yu <[email protected]>
[ Upstream commit a37d0862d17411edb67677a580a6f505ec2225f6 ]
As Pavel Machek reported:
"We normally use -EUCLEAN to signal filesystem corruption. Plus, it is good idea to report it to the syslog and mark filesystem as "needing fsck" if filesystem can do that."
Still we need improve the original patch with:
- use unlikely keyword
- add message print
- return EUCLEAN
However, after rethink this patch, I don't think we should add such condition check here as below reasons:
- We have already checked the field in f2fs_sanity_check_ckpt(),
- If there is fs corrupt or security vulnerability, there is nothing to guarantee the field is integrated after the check, unless we do the check before each of its use, however no filesystem does that.
- We only have similar check for bitmap, which was added due to there is bitmap corruption happened on f2fs' runtime in product.
- There are so many key fields in SB/CP/NAT did have such check after f2fs_sanity_check_{sb,cp,..}.
So I propose to revert this unneeded check.
This reverts commit 56f3ce675103e3fb9e631cfb4131fc768bc23e9a.
--- fs/f2fs/segment.c | 5 ----- 1 file changed, 5 deletions(-)
fs/f2fs/segment.c +0 -5
@@ -3261,11 +3261,6 @@ static int read_compacted_summaries(struct f2fs_sb_info *sbi) seg_i =CURSEG_I (sbi, i); segno =le32_to_cpu (ckpt->cur_data_segno[i]); blk_off =le16_to_cpu (ckpt->cur_data_blkoff[i]); -if (blk_off >ENTRIES_IN_SUM ) { -f2fs_bug_on (sbi,1 ); -f2fs_put_page (page,1 ); -return -EFAULT ; - } seg_i->next_segno = segno;reset_curseg (sbi, i,0 ); seg_i->alloc_type = ckpt->alloc_type[i];
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 51/63 dm zoned: fix invalid memory access
In reply to Greg Kroah-HartmanFrom: Mikulas Patocka <[email protected]>
[ Upstream commit 0c8e9c2d668278652af028c3cc068c65f66342f4 ]
Commit 75d66ffb48efb30f2dd42f041ba8b39c5b2bd115 ("dm zoned: properly handle backing device failure") triggers a coverity warning:
*** CID 1452808: Memory - illegal accesses (USE_AFTER_FREE) /drivers/md/dm-zoned-target.c: 137 in dmz_submit_bio()
131 clone->bi_private = bioctx;
132
133 bio_advance(bio, clone->bi_iter.bi_size);
134
135 refcount_inc(&bioctx->ref);
136 generic_make_request(clone);
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
CID 1452808: Memory - illegal accesses (
USE_AFTER_FREE) Dereferencing freed pointer "clone".
137 if (clone->bi_status == BLK_STS_IOERR)
138 return -EIO;
139
140 if (bio_op(bio) == REQ_OP_WRITE && dmz_is_seq(zone))
141 zone->wp_block += nr_blocks;
142
The "clone" bio may be processed and freed before the check "clone->bi_status == BLK_STS_IOERR" - so this check can access invalid memory.
--- drivers/md/dm-zoned-target.c | 2 -- 1 file changed, 2 deletions(-)
drivers/md/dm-zoned-target.c +0 -2
@@ -133,8 +133,6 @@ static int dmz_submit_bio(struct dmz_target *dmz, struct dm_zone *zone,atomic_inc (&bioctx->ref);generic_make_request (clone); -if (clone->bi_status ==BLK_STS_IOERR ) -return -EIO ;if (bio_op (bio) ==REQ_OP_WRITE &&dmz_is_seq (zone)) zone->wp_block += nr_blocks;
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 52/63 net/ibmvnic: Fix missing { in __ibmvnic_reset
In reply to Greg Kroah-HartmanFrom: Michal Suchanek <[email protected]>
[ Upstream commit c8dc55956b09b53ccffceb6e3146981210e27821 ]
Commit 1c2977c09499 ("net/ibmvnic: free reset work of removed device from queue") adds a } without corresponding { causing build break.
--- drivers/net/ethernet/ibm/ibmvnic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/ibm/ibmvnic.c +1 -1
@@ -1999,7 +1999,7 @@ static void __ibmvnic_reset(struct work_struct *work) rwi =get_next_rwi (adapter);while (rwi) {if (adapter->state ==VNIC_REMOVING || - adapter->state ==VNIC_REMOVED ) + adapter->state ==VNIC_REMOVED ) {kfree (rwi); rc =EBUSY ;break ;
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 53/63 f2fs: fix to do sanity check on segment bitmap of LFS curseg
In reply to Greg Kroah-HartmanFrom: Chao Yu <[email protected]>
[ Upstream commit c854f4d681365498f53ba07843a16423625aa7e9 ]
As Jungyeon Reported in bugzilla:
https://bugzilla.kernel.org/show_bug.cgi?id=203233
- Reproduces
gcc poc_13.c
./run.sh f2fs
- Kernel messages
F2FS-fs (sdb): Bitmap was wrongly set, blk:4608
kernel BUG at fs/f2fs/segment.c:2133!
RIP: 0010:update_sit_entry+0x35d/0x3e0 Call Trace: f2fs_allocate_data_block+0x16c/0x5a0 do_write_page+0x57/0x100 f2fs_do_write_node_page+0x33/0xa0 __write_node_page+0x270/0x4e0 f2fs_sync_node_pages+0x5df/0x670 f2fs_write_checkpoint+0x364/0x13a0 f2fs_sync_fs+0xa3/0x130 f2fs_do_sync_file+0x1a6/0x810 do_fsync+0x33/0x60 __x64_sys_fsync+0xb/0x10 do_syscall_64+0x43/0x110 entry_SYSCALL_64_after_hwframe+0x44/0xa9
The testcase fails because that, in fuzzed image, current segment was allocated with LFS type, its .next_blkoff should point to an unused block address, but actually, its bitmap shows it's not. So during allocation, f2fs crash when setting bitmap.
Introducing sanity_check_curseg() to check such inconsistence of current in-used segment.
--- fs/f2fs/segment.c | 39 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 39 insertions(+)
fs/f2fs/segment.c +39 -0
@@ -4098,6 +4098,41 @@ static int build_dirty_segmap(struct f2fs_sb_info *sbi)return init_victim_secmap (sbi); } +static int sanity_check_curseg (struct f2fs_sb_info *sbi) +{ +int i; + +/* +* In LFS/SSR curseg, .next_blkoff should point to an unused blkaddr; +* In LFS curseg, all blkaddr after .next_blkoff should be unused. +*/ +for (i =0 ; i <NO_CHECK_TYPE ; i++) { +struct curseg_info *curseg =CURSEG_I (sbi, i); +struct seg_entry *se =get_seg_entry (sbi, curseg->segno); +unsigned int blkofs = curseg->next_blkoff; + +if (f2fs_test_bit (blkofs, se->cur_valid_map)) + goto out; + +if (curseg->alloc_type ==SSR ) +continue ; + +for (blkofs +=1 ; blkofs < sbi->blocks_per_seg; blkofs++) { +if (!f2fs_test_bit (blkofs, se->cur_valid_map)) +continue ; +out: +f2fs_msg (sbi->sb,KERN_ERR , +"Current segment's next free block offset is " +"inconsistent with bitmap, logtype:%u, " +"segno:%u, type:%u, next_blkoff:%u, blkofs:%u" , + i, curseg->segno, curseg->alloc_type, + curseg->next_blkoff, blkofs); +return -EINVAL ; + } + } +return 0 ; +} +/* * Update min, max modified time for cost-benefit GC algorithm */
@@ -4193,6 +4228,10 @@ int f2fs_build_segment_manager(struct f2fs_sb_info *sbi)if (err)return err; + err =sanity_check_curseg (sbi); +if (err) +return err; +init_min_max_mtime (sbi);return 0 ; }
Signature · 1 line
2.20.1
Re: [PATCH 4.19 53/63] f2fs: fix to do sanity check on segment bitmap of LFS curseg
Hi!
fs/f2fs/segment.c static int build_dirty_segmap(struct f2fs_sb_info *sbi) · line 4131
Quoted 12 lines
fs/f2fs/segment.c +12
-0+for (blkofs +=1 ; blkofs < sbi->blocks_per_seg; blkofs++) { +if (!f2fs_test_bit (blkofs, se->cur_valid_map)) +continue ; +out: +f2fs_msg (sbi->sb,KERN_ERR , +"Current segment's next free block offset is " +"inconsistent with bitmap, logtype:%u, " +"segno:%u, type:%u, next_blkoff:%u, blkofs:%u" , + i, curseg->segno, curseg->alloc_type, + curseg->next_blkoff, blkofs); +return -EINVAL ; + }
So this is detecting filesystem corruption, right? Should it be -EUCLEAN?
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Re: [PATCH 4.19 53/63] f2fs: fix to do sanity check on segment bitmap of LFS curseg
Hello,
Quoted 18 lines · Pavel Machek
Hi!
fs/f2fs/segment.c static int build_dirty_segmap(struct f2fs_sb_info *sbi) · line 4131
Quoted 12 lines
fs/f2fs/segment.c +12
-0+for (blkofs +=1 ; blkofs < sbi->blocks_per_seg; blkofs++) { +if (!f2fs_test_bit (blkofs, se->cur_valid_map)) +continue ; +out: +f2fs_msg (sbi->sb,KERN_ERR , +"Current segment's next free block offset is " +"inconsistent with bitmap, logtype:%u, " +"segno:%u, type:%u, next_blkoff:%u, blkofs:%u" , + i, curseg->segno, curseg->alloc_type, + curseg->next_blkoff, blkofs); +return -EINVAL ; + }So this is detecting filesystem corruption, right? Should it be
-EUCLEAN?
Was fixed in another commit 10f966bbf521 ("f2fs: use generic EFSBADCRC/EFSCORRUPTED"). :)
Thanks,
Quoted 3 lines
Pavel
Re: [PATCH 4.19 53/63] f2fs: fix to do sanity check on segment bitmap of LFS curseg
Quoted 22 lines · Chao Yu
Hello,
Quoted 18 lines · Pavel Machek
Hi!
fs/f2fs/segment.c static int build_dirty_segmap(struct f2fs_sb_info *sbi) · line 4131
Quoted 12 lines
fs/f2fs/segment.c +12
-0+for (blkofs +=1 ; blkofs < sbi->blocks_per_seg; blkofs++) { +if (!f2fs_test_bit (blkofs, se->cur_valid_map)) +continue ; +out: +f2fs_msg (sbi->sb,KERN_ERR , +"Current segment's next free block offset is " +"inconsistent with bitmap, logtype:%u, " +"segno:%u, type:%u, next_blkoff:%u, blkofs:%u" , + i, curseg->segno, curseg->alloc_type, + curseg->next_blkoff, blkofs); +return -EINVAL ; + }So this is detecting filesystem corruption, right? Should it be
-EUCLEAN?
Quoted 2 lines
Was fixed in another commit
10f966bbf521("f2fs: use generic EFSBADCRC/EFSCORRUPTED"). :)
I've queued up a backport of this for 5.2, 4.19, and 4.14, thanks!.
--
Thanks,
Sasha
Greg Kroah-Hartman
maintainerPATCH 54/63 drm: Flush output polling on shutdown
In reply to Greg Kroah-HartmanFrom: Chris Wilson <[email protected]>
[ Upstream commit 3b295cb1a411d9c82bbfaa66bc17a8508716ed07 ]
We need to mark the output polling as disabled to prevent concurrent irqs from queuing new work as shutdown the probe -- causing that work to execute after we have freed the structs:
<4> [341.846490] DEBUG_LOCKS_WARN_ON(mutex_is_locked(lock))
<4> [341.846497] WARNING: CPU: 3 PID: 3300 at kernel/locking/mutex-debug.c:103 mutex_destroy+0x49/0x50
<4> [341.846508] Modules linked in: i915(-) vgem thunderbolt snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic mei_hdcp x86_pkg_temp_thermal coretemp crct10dif_pclmul crc32_pclmul ghash_clmulni_intel snd_hda_codec snd_hwdep snd_hda_core snd_pcm mcs7830 btusb usbnet btrtl mii btbcm btintel bluetooth ecdh_generic ecc mei_me mei prime_numbers i2c_hid pinctrl_sunrisepoint pinctrl_intel [last unloaded: i915]
<4> [341.846546] CPU: 3 PID: 3300 Comm: i915_module_loa Tainted: G U 5.2.0-rc2-CI-CI_DRM_6175+ #1
<4> [341.846553] Hardware name: Dell Inc. XPS 13 9360/0823VW, BIOS 2.9.0 07/09/2018
<4> [341.846560] RIP: 0010:mutex_destroy+0x49/0x50
<4> [341.846565] Code: 00 00 5b c3 e8 a8 9f 3b 00 85 c0 74 ed 8b 05 3e 55 23 01 85 c0 75 e3 48 c7 c6 00 d0 08 82 48 c7 c7 a8 aa 07 82 e8 e7 08 fa ff <0f> 0b eb cc 0f 1f 00 48 b8 11 11 11 11 11 11 11 11 48 89 76 20 48
<4> [341.846578] RSP: 0018:ffffc900006cfdb0 EFLAGS: 00010286
<4> [341.846583] RAX: 0000000000000000 RBX: ffff88826759a168 RCX: 0000000000000000
<4> [341.846589] RDX: 0000000000000002 RSI: 0000000000000000 RDI: ffffffff8112844c
<4> [341.846595] RBP: ffff8882708fa548 R08: 0000000000000000 R09: 0000000000039600
<4> [341.846601] R10: 0000000000000000 R11: 0000000000000ce4 R12: ffffffffa07de1e0
<4> [341.846607] R13: 0000000000000000 R14: 0000000000000000 R15: ffffffffa07de2d0
<4> [341.846613] FS: 00007f62b5ae0e40(0000) GS:ffff888276380000(0000) knlGS:0000000000000000
<4> [341.846620] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
<4> [341.846626] CR2: 000055a4e064f4a0 CR3: 0000000266b16006 CR4: 00000000003606e0
<4> [341.846632] Call Trace:
<4> [341.846639] drm_fb_helper_fini.part.17+0xb3/0x100 <4> [341.846682] intel_fbdev_fini+0x20/0x80 [i915] <4> [341.846722] intel_modeset_cleanup+0x9a/0x140 [i915] <4> [341.846750] i915_driver_unload+0xa3/0x100 [i915] <4> [341.846778] i915_pci_remove+0x19/0x30 [i915] <4> [341.846784] pci_device_remove+0x36/0xb0 <4> [341.846790] device_release_driver_internal+0xd3/0x1b0 <4> [341.846795] driver_detach+0x3f/0x80 <4> [341.846800] bus_remove_driver+0x53/0xd0 <4> [341.846805] pci_unregister_driver+0x25/0xa0 <4> [341.846843] i915_exit+0x16/0x1c [i915] <4> [341.846849] __se_sys_delete_module+0x162/0x210 <4> [341.846855] ? trace_hardirqs_off_thunk+0x1a/0x1c <4> [341.846859] ? do_syscall_64+0xd/0x1c0 <4> [341.846864] do_syscall_64+0x55/0x1c0 <4> [341.846869] entry_SYSCALL_64_after_hwframe+0x49/0xbe
<4> [341.846875] RIP: 0033:0x7f62b51871b7
<4> [341.846881] Code: 73 01 c3 48 8b 0d d1 8c 2c 00 f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 b8 b0 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d a1 8c 2c 00 f7 d8 64 89 01 48 <4> [341.846897] RSP: 002b:00007ffe7a227138 EFLAGS: 00000206 ORIG_RAX: 00000000000000b0
<4> [341.846904] RAX: ffffffffffffffda RBX: 00007ffe7a2272b0 RCX: 00007f62b51871b7
<4> [341.846910] RDX: 0000000000000001 RSI: 0000000000000800 RDI: 0000557cd6b55948
<4> [341.846916] RBP: 0000557cd6b558e0 R08: 0000557cd6b5594c R09: 00007ffe7a227160
<4> [341.846922] R10: 00007ffe7a226134 R11: 0000000000000206 R12: 0000000000000000
<4> [341.846927] R13: 00007ffe7a227820 R14: 0000000000000000 R15: 0000000000000000
<4> [341.846936] irq event stamp: 3547847
<4> [341.846940] hardirqs last enabled at (3547847): [<ffffffff819aad2c>] _raw_spin_unlock_irqrestore+0x4c/0x60
<4> [341.846949] hardirqs last disabled at (3547846): [<ffffffff819aab9d>] _raw_spin_lock_irqsave+0xd/0x50
<4> [341.846957] softirqs last enabled at (3547376): [<ffffffff81c0033a>] __do_softirq+0x33a/0x4b9
<4> [341.846966] softirqs last disabled at (3547367): [<ffffffff810b6379>] irq_exit+0xa9/0xc0
<4> [341.846973] WARNING: CPU: 3 PID: 3300 at kernel/locking/mutex-debug.c:103 mutex_destroy+0x49/0x50
<4> [341.846980] ---[ end trace ba94ca8952ba970e ]---
<7> [341.866547] [drm:intel_dp_detect [i915]] MST support? port A: no, sink: no, modparam: yes
<7> [341.890480] [drm:drm_add_display_info] non_desktop set to 0
<7> [341.890530] [drm:drm_add_edid_modes] ELD: no CEA Extension found
<7> [341.890537] [drm:drm_add_display_info] non_desktop set to 0
<7> [341.890578] [drm:drm_helper_probe_single_connector_modes] [CONNECTOR:86:eDP-1] probed modes :
<7> [341.890589] [drm:drm_mode_debug_printmodeline] Modeline "3200x1800": 60 373250 3200 3248 3280 3360 1800 1803 1808 1852 0x48 0xa
<7> [341.890602] [drm:drm_mode_debug_printmodeline] Modeline "3200x1800": 48 298600 3200 3248 3280 3360 1800 1803 1808 1852 0x40 0xa
<4> [341.890628] general protection fault: 0000 [#1] PREEMPT SMP PTI
<4> [341.890636] CPU: 0 PID: 508 Comm: kworker/0:4 Tainted: G U W 5.2.0-rc2-CI-CI_DRM_6175+ #1
<4> [341.890646] Hardware name: Dell Inc. XPS 13 9360/0823VW, BIOS 2.9.0 07/09/2018
<4> [341.890655] Workqueue: events output_poll_execute
<4> [341.890663] RIP: 0010:drm_setup_crtcs+0x13e/0xbe0
<4> [341.890669] Code: 00 41 8b 44 24 58 85 c0 0f 8e f9 01 00 00 44 8b 6c 24 20 44 8b 74 24 28 31 db 31 ed 49 8b 44 24 60 48 63 d5 44 89 ee 83 c5 01 <48> 8b 04 d0 44 89 f2 48 8b 38 48 8b 87 88 01 00 00 48 8b 40 20 e8 <4> [341.890686] RSP: 0018:ffffc9000033fd40 EFLAGS: 00010202
<4> [341.890692] RAX: 6b6b6b6b6b6b6b6b RBX: 0000000000000002 RCX: 0000000000000000
<4> [341.890700] RDX: 0000000000000001 RSI: 0000000000000c80 RDI: 00000000ffffffff
<4> [341.890707] RBP: 0000000000000002 R08: 0000000000000000 R09: 0000000000000000
<4> [341.890715] R10: 0000000000000c80 R11: 0000000000000000 R12: ffff888267599fe8
<4> [341.890722] R13: 0000000000000c80 R14: 0000000000000708 R15: 0000000000000007
<4> [341.890730] FS: 0000000000000000(0000) GS:ffff888276200000(0000) knlGS:0000000000000000
<4> [341.890739] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
<4> [341.890745] CR2: 000055a4e064f4a0 CR3: 000000026d234003 CR4: 00000000003606f0
<4> [341.890752] Call Trace:
<4> [341.890760] drm_fb_helper_hotplug_event.part.24+0x89/0xb0 <4> [341.890768] drm_kms_helper_hotplug_event+0x21/0x30 <4> [341.890774] output_poll_execute+0x9d/0x1a0 <4> [341.890782] process_one_work+0x245/0x610 <4> [341.890790] worker_thread+0x37/0x380 <4> [341.890796] ? process_one_work+0x610/0x610 <4> [341.890802] kthread+0x119/0x130 <4> [341.890808] ? kthread_park+0x80/0x80 <4> [341.890815] ret_from_fork+0x3a/0x50
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109964
--- drivers/gpu/drm/drm_probe_helper.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
drivers/gpu/drm/drm_probe_helper.c +8 -1
@@ -581,6 +581,9 @@ static void output_poll_execute(struct work_struct *work)enum drm_connector_status old_status;bool repoll = false, changed; +if (!dev->mode_config.poll_enabled) +return ; +/* Pick up any changes detected by the probe functions. */ changed = dev->mode_config.delayed_event; dev->mode_config.delayed_event = false;
@@ -735,7 +738,11 @@ EXPORT_SYMBOL(drm_kms_helper_poll_init);*/ void drm_kms_helper_poll_fini (struct drm_device *dev) { -drm_kms_helper_poll_disable (dev); +if (!dev->mode_config.poll_enabled) +return ; + + dev->mode_config.poll_enabled = false; +cancel_delayed_work_sync (&dev->mode_config.output_poll_work); }EXPORT_SYMBOL (drm_kms_helper_poll_fini);
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 55/63 net: dont warn in inet diag when IPV6 is disabled
In reply to Greg Kroah-HartmanFrom: Stephen Hemminger <[email protected]>
[ Upstream commit 1e64d7cbfdce4887008314d5b367209582223f27 ]
If IPV6 was disabled, then ss command would cause a kernel warning because the command was attempting to dump IPV6 socket information. The fix is to just remove the warning.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=202249
--- net/ipv4/raw_diag.c | 3 --- 1 file changed, 3 deletions(-)
net/ipv4/raw_diag.c +0 -3
@@ -23,9 +23,6 @@ raw_get_hashinfo(const struct inet_diag_req_v2 *r)return &raw_v6_hashinfo;#endif }else { -pr_warn_once ("Unexpected inet family %d\n" , - r->sdiag_family); -WARN_ON_ONCE (1 );return ERR_PTR (-EINVAL ); } }
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 56/63 Bluetooth: btrtl: HCI reset on close for Realtek BT chip
In reply to Greg Kroah-HartmanFrom: Jian-Hong Pan <[email protected]>
[ Upstream commit 7af3f558aca74f2ee47b173f1c27f6bb9a5b5561 ]
Realtek RTL8822BE BT chip on ASUS X420FA cannot be turned on correctly after on-off several times. Bluetooth daemon sets BT mode failed when this issue happens. Scanning must be active while turning off for this bug to be hit.
bluetoothd[1576]: Failed to set mode: Failed (0x03)
If BT is turned off, then turned on again, it works correctly again.
According to the vendor driver, the HCI_QUIRK_RESET_ON_CLOSE flag is set during probing. So, this patch makes Realtek's BT reset on close to fix this issue.
--- drivers/bluetooth/btrtl.c | 20 ++++++++++++++++++++ drivers/bluetooth/btrtl.h | 6 ++++++ drivers/bluetooth/btusb.c | 1 + 3 files changed, 27 insertions(+)
drivers/bluetooth/btrtl.c +20 -0
@@ -639,6 +639,26 @@ int btrtl_setup_realtek(struct hci_dev *hdev) }EXPORT_SYMBOL_GPL (btrtl_setup_realtek); +int btrtl_shutdown_realtek (struct hci_dev *hdev) +{ +struct sk_buff *skb; +int ret; + +/* According to the vendor driver, BT must be reset on close to avoid +* firmware crash. +*/ + skb =__hci_cmd_sync (hdev,HCI_OP_RESET ,0 ,NULL ,HCI_INIT_TIMEOUT ); +if (IS_ERR (skb)) { + ret =PTR_ERR (skb); +bt_dev_err (hdev,"HCI reset during shutdown failed" ); +return ret; + } +kfree_skb (skb); + +return 0 ; +} +EXPORT_SYMBOL_GPL (btrtl_shutdown_realtek); +static unsigned int btrtl_convert_baudrate (u32 device_baudrate) {switch (device_baudrate) {
drivers/bluetooth/btrtl.h +6 -0
@@ -65,6 +65,7 @@ void btrtl_free(struct btrtl_device_info *btrtl_dev);int btrtl_download_firmware (struct hci_dev *hdev,struct btrtl_device_info *btrtl_dev);int btrtl_setup_realtek (struct hci_dev *hdev); +int btrtl_shutdown_realtek (struct hci_dev *hdev); int btrtl_get_uart_settings(struct hci_dev *hdev, struct btrtl_device_info *btrtl_dev, unsigned int *controller_baudrate,
@@ -93,6 +94,11 @@ static inline int btrtl_setup_realtek(struct hci_dev *hdev)return -EOPNOTSUPP ; } +static inline int btrtl_shutdown_realtek (struct hci_dev *hdev) +{ +return -EOPNOTSUPP ; +} + static inline int btrtl_get_uart_settings(struct hci_dev *hdev, struct btrtl_device_info *btrtl_dev, unsigned int *controller_baudrate,
drivers/bluetooth/btusb.c +1 -0
@@ -3128,6 +3128,7 @@ static int btusb_probe(struct usb_interface *intf,#ifdef CONFIG_BT_HCIBTUSB_RTL if (id->driver_info &BTUSB_REALTEK ) { hdev->setup = btrtl_setup_realtek; + hdev->shutdown = btrtl_shutdown_realtek;/* Realtek devices lose their updated firmware over suspend, * but the USB hub doesn't notice any status change.
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 57/63 ACPI: video: Add new hw_changes_brightness quirk, set it on PB Easynote MZ35
In reply to Greg Kroah-HartmanFrom: Hans de Goede <[email protected]>
[ Upstream commit 4f7f96453b462b3de0fa18d18fe983960bb5ee7f ]
Some machines change the brightness themselves when a brightness hotkey gets pressed, despite us telling them not to. This causes the brightness to go two steps up / down when the hotkey is pressed. This is esp. a problem on older machines with only a few brightness levels.
This commit adds a new hw_changes_brightness quirk which makes acpi_video_device_notify() only call backlight_force_update(..., BACKLIGHT_UPDATE_HOTKEY) and not do anything else, notifying userspace that the brightness was changed and leaving it at that fixing the dual step problem.
--- drivers/acpi/acpi_video.c | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+)
drivers/acpi/acpi_video.c +37 -0
@@ -73,6 +73,12 @@ module_param(report_key_events, int, 0644);MODULE_PARM_DESC (report_key_events,"0: none, 1: output changes, 2: brightness changes, 3: all" ); +static int hw_changes_brightness =-1 ; +module_param (hw_changes_brightness, int,0644 ); +MODULE_PARM_DESC (hw_changes_brightness, +"Set this to 1 on buggy hw which changes the brightness itself when " +"a hotkey is pressed: -1: auto, 0: normal 1: hw-changes-brightness" ); +/* * Whether the struct acpi_video_device_attrib::device_id_scheme bit should be * assumed even if not actually set.
@@ -418,6 +424,14 @@ static int video_set_report_key_events(const struct dmi_system_id *id)return 0 ; } +static int video_hw_changes_brightness ( +const struct dmi_system_id *d) +{ +if (hw_changes_brightness ==-1 ) + hw_changes_brightness =1 ; +return 0 ; +} +static const struct dmi_system_id video_dmi_table[] = {/* * Broken _BQC workaround http://bugzilla.kernel.org/show_bug.cgi?id=13121
@@ -542,6 +556,21 @@ static const struct dmi_system_id video_dmi_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "Vostro V131"), }, }, +/* +* Some machines change the brightness themselves when a brightness +* hotkey gets pressed, despite us telling them not to. In this case +* acpi_video_device_notify() should only call backlight_force_update( +* BACKLIGHT_UPDATE_HOTKEY) and not do anything else. +*/ + { + /* https://bugzilla.kernel.org/show_bug.cgi?id=204077 */ + .callback = video_hw_changes_brightness, + .ident = "Packard Bell EasyNote MZ35", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Packard Bell"), + DMI_MATCH(DMI_PRODUCT_NAME, "EasyNote MZ35"), + }, + }, {} };
@@ -1625,6 +1654,14 @@ static void acpi_video_device_notify(acpi_handle handle, u32 event, void *data) bus = video_device->video; input = bus->input; +if (hw_changes_brightness >0 ) { +if (video_device->backlight) +backlight_force_update (video_device->backlight, +BACKLIGHT_UPDATE_HOTKEY ); +acpi_notifier_call_chain (device, event,0 ); +return ; + } +switch (event) {case ACPI_VIDEO_NOTIFY_CYCLE_BRIGHTNESS :/* Cycle brightness */ brightness_switch_event (video_device, event);
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 58/63 drm/nouveau/disp/nv50-: fix center/aspect-corrected scaling
In reply to Greg Kroah-HartmanFrom: Ilia Mirkin <[email protected]>
[ Upstream commit 533f4752407543f488a9118d817b8c504352b6fb ]
Previously center scaling would get scaling applied to it (when it was only supposed to center the image), and aspect-corrected scaling did not always correctly pick whether to reduce width or height for a particular combination of inputs/outputs.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110660
--- drivers/gpu/drm/nouveau/dispnv50/head.c | 28 +++++++++++++++++++++---- 1 file changed, 24 insertions(+), 4 deletions(-)
drivers/gpu/drm/nouveau/dispnv50/head.c +24 -4
@@ -169,14 +169,34 @@ nv50_head_atomic_check_view(struct nv50_head_atom *armh,*/ switch (mode) {case DRM_MODE_SCALE_CENTER : - asyh->view.oW =min ((u16 )umode->hdisplay, asyh->view.oW); - asyh->view.oH =min ((u16 )umode_vdisplay, asyh->view.oH); -/* fall-through */ +/* NOTE: This will cause scaling when the input is +* larger than the output. +*/ + asyh->view.oW =min (asyh->view.iW, asyh->view.oW); + asyh->view.oH =min (asyh->view.iH, asyh->view.oH); +break ;case DRM_MODE_SCALE_ASPECT : -if (asyh->view.oH < asyh->view.oW) { +/* Determine whether the scaling should be on width or on +* height. This is done by comparing the aspect ratios of the +* sizes. If the output AR is larger than input AR, that means +* we want to change the width (letterboxed on the +* left/right), otherwise on the height (letterboxed on the +* top/bottom). +* +* E.g. 4:3 (1.333) AR image displayed on a 16:10 (1.6) AR +* screen will have letterboxes on the left/right. However a +* 16:9 (1.777) AR image on that same screen will have +* letterboxes on the top/bottom. +* +* inputAR = iW / iH; outputAR = oW / oH +* outputAR > inputAR is equivalent to oW * iH > iW * oH +*/ +if (asyh->view.oW * asyh->view.iH > asyh->view.iW * asyh->view.oH) { +/* Recompute output width, i.e. left/right letterbox */ u32 r = (asyh->view.iW <<19 ) / asyh->view.iH; asyh->view.oW = ((asyh->view.oH * r) + (r /2 )) >>19 ; }else { +/* Recompute output height, i.e. top/bottom letterbox */ u32 r = (asyh->view.iH <<19 ) / asyh->view.iW; asyh->view.oH = ((asyh->view.oW * r) + (r /2 )) >>19 ; }
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 59/63 xfs: dont crash on null attr fork xfs_bmapi_read
In reply to Greg Kroah-HartmanFrom: Darrick J. Wong <[email protected]>
[ Upstream commit 8612de3f7ba6e900465e340516b8313806d27b2d ]
Zorro Lang reported a crash in generic/475 if we try to inactivate a corrupt inode with a NULL attr fork (stack trace shortened somewhat):
RIP: 0010:xfs_bmapi_read+0x311/0xb00 [xfs] RSP: 0018:ffff888047f9ed68 EFLAGS: 00010202 RAX: dffffc0000000000 RBX: ffff888047f9f038 RCX: 1ffffffff5f99f51 RDX: 0000000000000002 RSI: 0000000000000008 RDI: 0000000000000012 RBP: ffff888002a41f00 R08: ffffed10005483f0 R09: ffffed10005483ef R10: ffffed10005483ef R11: ffff888002a41f7f R12: 0000000000000004 R13: ffffe8fff53b5768 R14: 0000000000000005 R15: 0000000000000001 FS: 00007f11d44b5b80(0000) GS:ffff888114200000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 0000000000ef6000 CR3: 000000002e176003 CR4: 00000000001606e0 Call Trace: xfs_dabuf_map.constprop.18+0x696/0xe50 [xfs] xfs_da_read_buf+0xf5/0x2c0 [xfs] xfs_da3_node_read+0x1d/0x230 [xfs] xfs_attr_inactive+0x3cc/0x5e0 [xfs] xfs_inactive+0x4c8/0x5b0 [xfs] xfs_fs_destroy_inode+0x31b/0x8e0 [xfs] destroy_inode+0xbc/0x190 xfs_bulkstat_one_int+0xa8c/0x1200 [xfs] xfs_bulkstat_one+0x16/0x20 [xfs] xfs_bulkstat+0x6fa/0xf20 [xfs] xfs_ioc_bulkstat+0x182/0x2b0 [xfs] xfs_file_ioctl+0xee0/0x12a0 [xfs] do_vfs_ioctl+0x193/0x1000 ksys_ioctl+0x60/0x90 __x64_sys_ioctl+0x6f/0xb0 do_syscall_64+0x9f/0x4d0 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x7f11d39a3e5b
The "obvious" cause is that the attr ifork is null despite the inode claiming an attr fork having at least one extent, but it's not so obvious why we ended up with an inode in that state.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=204031
--- fs/xfs/libxfs/xfs_bmap.c | 29 +++++++++++++++++++++-------- 1 file changed, 21 insertions(+), 8 deletions(-)
fs/xfs/libxfs/xfs_bmap.c +21 -8
@@ -3841,15 +3841,28 @@ xfs_bmapi_read(XFS_STATS_INC (mp, xs_blk_mapr); ifp =XFS_IFORK_PTR (ip, whichfork); +if (!ifp) { +/* No CoW fork? Return a hole. */ +if (whichfork ==XFS_COW_FORK ) { + mval->br_startoff = bno; + mval->br_startblock =HOLESTARTBLOCK ; + mval->br_blockcount = len; + mval->br_state =XFS_EXT_NORM ; + *nmap =1 ; +return 0 ; + } -/* No CoW fork? Return a hole. */ -if (whichfork ==XFS_COW_FORK && !ifp) { - mval->br_startoff = bno; - mval->br_startblock =HOLESTARTBLOCK ; - mval->br_blockcount = len; - mval->br_state =XFS_EXT_NORM ; - *nmap =1 ; -return 0 ; +/* +* A missing attr ifork implies that the inode says we're in +* extents or btree format but failed to pass the inode fork +* verifier while trying to load it. Treat that as a file +* corruption too. +*/ +#ifdef DEBUG +xfs_alert (mp,"%s: inode %llu missing fork %d" , + __func__, ip->i_ino, whichfork); +#endif /* DEBUG */ +return -EFSCORRUPTED ; }if (!(ifp->if_flags &XFS_IFEXTENTS )) {
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 60/63 netfilter: nft_socket: fix erroneous socket assignment
In reply to Greg Kroah-HartmanFrom: Fernando Fernandez Mancera <[email protected]>
[ Upstream commit 039b1f4f24ecc8493b6bb9d70b4b78750d1b35c2 ]
The socket assignment is wrong, see skb_orphan():
When skb->destructor callback is not set, but skb->sk is set, this hits BUG().
--- net/netfilter/nft_socket.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
net/netfilter/nft_socket.c +3 -3
@@ -47,9 +47,6 @@ static void nft_socket_eval(const struct nft_expr *expr,return ; } -/* So that subsequent socket matching not to require other lookups. */ - skb->sk = sk; -switch (priv->key) {case NFT_SOCKET_TRANSPARENT :nft_reg_store8 (dest,inet_sk_transparent (sk));
@@ -66,6 +63,9 @@ static void nft_socket_eval(const struct nft_expr *expr,WARN_ON (1 ); regs->verdict.code =NFT_BREAK ; } + +if (sk != skb->sk) +sock_gen_put (sk); }static const struct nla_policy nft_socket_policy[NFTA_SOCKET_MAX +1 ] = {
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 61/63 Bluetooth: btrtl: Additional Realtek 8822CE Bluetooth devices
In reply to Greg Kroah-HartmanFrom: Jian-Hong Pan <[email protected]>
[ Upstream commit 6d0762b19c5963ff9e178e8af3626532ee04d93d ]
The ASUS X412FA laptop contains a Realtek RTL8822CE device with an associated BT chip using a USB ID of 04ca:4005. This ID is added to the driver.
The /sys/kernel/debug/usb/devices portion for this device is:
T: Bus=01 Lev=01 Prnt=01 Port=09 Cnt=04 Dev#= 4 Spd=12 MxCh= 0 D: Ver= 1.00 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs= 1 P: Vendor=04ca ProdID=4005 Rev= 0.00 S: Manufacturer=Realtek S: Product=Bluetooth Radio S: SerialNumber=00e04c000001 C:* #Ifs= 2 Cfg#= 1 Atr=a0 MxPwr=500mA I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=81(I) Atr=03(Int.) MxPS= 16 Ivl=1ms E: Ad=02(O) Atr=02(Bulk) MxPS= 64 Ivl=0ms E: Ad=82(I) Atr=02(Bulk) MxPS= 64 Ivl=0ms I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 0 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 0 Ivl=1ms I: If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 9 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 9 Ivl=1ms I: If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 17 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 17 Ivl=1ms I: If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 25 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 25 Ivl=1ms I: If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 33 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 33 Ivl=1ms I: If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb E: Ad=03(O) Atr=01(Isoc) MxPS= 49 Ivl=1ms E: Ad=83(I) Atr=01(Isoc) MxPS= 49 Ivl=1ms
--- drivers/bluetooth/btusb.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/bluetooth/btusb.c +3 -0
@@ -391,6 +391,9 @@ static const struct usb_device_id blacklist_table[] = { { USB_DEVICE(0x13d3, 0x3526), .driver_info = BTUSB_REALTEK }, { USB_DEVICE(0x0b05, 0x185c), .driver_info = BTUSB_REALTEK }, + /* Additional Realtek 8822CE Bluetooth devices */ + { USB_DEVICE(0x04ca, 0x4005), .driver_info = BTUSB_REALTEK }, + /* Silicon Wave based devices */ { USB_DEVICE(0x0c10, 0x0000), .driver_info = BTUSB_SWAVE },
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 62/63 net_sched: check cops->tcf_block in tc_bind_tclass()
In reply to Greg Kroah-HartmanFrom: Cong Wang <[email protected]>
[ Upstream commit 8b142a00edcf8422ca48b8de88d286efb500cb53 ]
At least sch_red and sch_tbf don't implement ->tcf_block() while still have a non-zero tc "class".
Instead of adding nop implementations to each of such qdisc's, we can just relax the check of cops->tcf_block() in tc_bind_tclass(). They don't support TC filter anyway.
--- net/sched/sch_api.c | 2 ++ 1 file changed, 2 insertions(+)
net/sched/sch_api.c +2 -0
@@ -1831,6 +1831,8 @@ static void tc_bind_tclass(struct Qdisc *q, u32 portid, u32 clid, cl = cops->find (q, portid);if (!cl)return ; +if (!cops->tcf_block) +return ; block = cops->tcf_block (q, cl,NULL );if (!block)return ;
Signature · 1 line
2.20.1
Greg Kroah-Hartman
maintainerPATCH 63/63 net/rds: An rds_sock is added too early to the hash table
In reply to Greg Kroah-HartmanFrom: Ka-Cheong Poon <[email protected]>
[ Upstream commit c5c1a030a7dbf8dd4e1fa4405ae9a89dc1d2a8db ]
In rds_bind(), an rds_sock is added to the RDS bind hash table before rs_transport is set. This means that the socket can be found by the receive code path when rs_transport is NULL. And the receive code path de-references rs_transport for congestion update check. This can cause a panic. An rds_sock should not be added to the bind hash table before all the needed fields are set.
--- net/rds/bind.c | 40 ++++++++++++++++++---------------------- 1 file changed, 18 insertions(+), 22 deletions(-)
net/rds/bind.c +18 -22
@@ -1,5 +1,5 @@/* -* Copyright (c) 2006, 2018 Oracle and/or its affiliates. All rights reserved. +* Copyright (c) 2006, 2019 Oracle and/or its affiliates. All rights reserved. * * This software is available to you under a choice of one of two * licenses. You may choose to be licensed under the terms of the GNU
@@ -239,34 +239,30 @@ int rds_bind(struct socket *sock, struct sockaddr *uaddr, int addr_len) goto out; } -sock_set_flag (sk,SOCK_RCU_FREE ); - ret =rds_add_bound (rs, binding_addr, &port, scope_id); -if (ret) - goto out; - -if (rs->rs_transport) {/* previously bound */ +/* The transport can be set using SO_RDS_TRANSPORT option before the +* socket is bound. +*/ +if (rs->rs_transport) { trans = rs->rs_transport;if (trans->laddr_check (sock_net (sock->sk), binding_addr, scope_id) !=0 ) { ret = -ENOPROTOOPT ; -rds_remove_bound (rs); - }else { - ret =0 ; + goto out; } - goto out; - } - trans =rds_trans_get_preferred (sock_net (sock->sk), binding_addr, - scope_id); -if (!trans) { - ret = -EADDRNOTAVAIL ; -rds_remove_bound (rs); -pr_info_ratelimited ("RDS: %s could not find a transport for %pI6c, load rds_tcp or rds_rdma?\n" , - __func__, binding_addr); - goto out; + }else { + trans =rds_trans_get_preferred (sock_net (sock->sk), + binding_addr, scope_id); +if (!trans) { + ret = -EADDRNOTAVAIL ; +pr_info_ratelimited ("RDS: %s could not find a transport for %pI6c, load rds_tcp or rds_rdma?\n" , + __func__, binding_addr); + goto out; + } + rs->rs_transport = trans; } - rs->rs_transport = trans; - ret =0 ; +sock_set_flag (sk,SOCK_RCU_FREE ); + ret =rds_add_bound (rs, binding_addr, &port, scope_id); out:release_sock (sk);
Signature · 1 line
2.20.1
stable-rc/linux-4.19.y boot: 80 boots: 1 failed, 78 passed with 1 conflict (v4.19.75-64-gb52c75f7b978)
stable-rc/linux-4.19.y boot: 80 boots: 1 failed, 78 passed with 1 conflict (v4.19.75-64-gb52c75f7b978)
Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.19.y/kernel/v4.19.75-64-gb52c75f7b978/
Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.19.y/kernel/v4.19.75-64-gb52c75f7b978/
Tree: stable-rc
Branch: linux-4.19.y
Git Describe: v4.19.75-64-gb52c75f7b978
Git Commit: b52c75f7b9785d0d0e6bf145787ed2fc99f5483c
Git URL: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
Tested: 43 unique boards, 15 SoC families, 13 builds out of 206
Boot Regressions Detected:
arm:
tegra_defconfig:
gcc-8:
tegra124-nyan-big:
lab-collabora: new failure (last pass: v4.19.75-33-gdab8e08e7087)Boot Failure Detected:
arm:
tegra_defconfig:
gcc-8:
tegra124-nyan-big: 1 failed lab
Conflicting Boot Failure Detected: (These likely are not failures as other labs are reporting PASS. Needs review.)
arm:
exynos_defconfig:
exynos5422-odroidxu3:
lab-collabora: PASS (gcc-8)
lab-baylibre: FAIL (gcc-8)
---
For more info write to <[email protected]>
Quoted 8 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.19.76 release. There are 63 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Tue 01 Oct 2019 01:47:47 PM UTC. Anything received after that time might be too late.
Build results:
total: 156 pass: 156 fail: 0 Qemu test results: total: 390 pass: 390 fail: 0
Guenter
Quoted 9 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.19.76 release. There are 63 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Tue 01 Oct 2019 01:47:47 PM UTC. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 9 lines
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.76-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-4.19.y
and the diffstat can be found below.thanks,
greg k-h
Compiled and booted on my test system. No dmesg regressions.
thanks,
-- Shuah
Quoted 7 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.19.76 release. There are 63 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Tue 01 Oct 2019 01:47:47 PM UTC. Anything received after that time might be too late.
Results from Linaro’s test farm.
No regressions on arm64, arm, x86_64, and i386.
Summary
------------------------------------------------------------------------
kernel: 4.19.76-rc1
git repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
git branch: linux-4.19.y
git commit: b52c75f7b9785d0d0e6bf145787ed2fc99f5483c
git describe: v4.19.75-64-gb52c75f7b978
Test details: https://qa-reports.linaro.org/lkft/linux-stable-rc-4.19-oe/build/v4.19.75-64-gb52c75f7b978
No regressions (compared to build v4.19.75)
No fixes (compared to build v4.19.75)
Ran 23641 total tests in the following environments and test suites.
Environments
--------------
- dragonboard-410c - arm64
- hi6220-hikey - arm64
- i386
- juno-r2 - arm64
- qemu_arm
- qemu_arm64
- qemu_i386
- qemu_x86_64
- x15 - arm
- x86_64
Test Suites
-----------
* build
* install-android-platform-tools-r2600
* kselftest
* libhugetlbfs
* ltp-cap_bounds-tests
* ltp-commands-tests
* ltp-containers-tests
* ltp-cpuhotplug-tests
* ltp-cve-tests
* ltp-dio-tests
* ltp-fcntl-locktests-tests
* ltp-filecaps-tests
* ltp-fs_bind-tests
* ltp-fs_perms_simple-tests
* ltp-fsx-tests
* ltp-hugetlb-tests
* ltp-io-tests
* ltp-ipc-tests
* ltp-math-tests
* ltp-mm-tests
* ltp-nptl-tests
* ltp-pty-tests
* ltp-sched-tests
* ltp-securebits-tests
* ltp-syscalls-tests
* ltp-timers-tests
* perf
* spectre-meltdown-checker-test
* v4l2-compliance
* ltp-fs-tests
* network-basic-tests
* ltp-open-posix-tests
* kvm-unit-tests
* ssuite
* kselftest-vsyscall-mode-native
* kselftest-vsyscall-mode-none
Signature · 2 lines
Linaro LKFT https://lkft.linaro.org
Jon Hunter
maintainerQuoted 9 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.19.76 release. There are 63 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Tue 01 Oct 2019 01:47:47 PM UTC. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
Quoted 8 lines
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.76-rc1.gzor in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.gitlinux-4.19.y
and the diffstat can be found below.thanks,
greg k-h
All tests are passing for Tegra ...
Test results for stable-v4.19:
12 builds: 12 pass, 0 fail
22 boots: 22 pass, 0 fail
32 tests: 32 pass, 0 failLinux version: 4.19.76-g555161ee1b7a
Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,
tegra194-p2972-0000, tegra20-ventana,
tegra210-p2371-2180, tegra30-cardhu-a04Cheers
Jon
Signature · 1 line
nvpublic