Skip to contentSkip to conversation

spl: Introduce SPL_DM_GPIO Kconfig define

PATCH Superseded Lukasz Majewski 2 participants 8 messages Sep 29, 2019 – Dec 27, 2019

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 spl: Introduce SPL_DM_GPIO Kconfig define

This define indicates if DM_GPIO shall be supported in SPL. This allows proper operation of DM converted GPIO drivers in SPL, which use boards.

---

Changes in v2:
- Add dependency on DM_GPIO

 common/spl/Kconfig | 6 ++++++
 1 file changed, 6 insertions(+)
common/spl/Kconfig +6 -0
index f467eca2be..e3df8efa7e 100644
@@ -452,6 +452,12 @@ config SPL_DMA_SUPPORT
 	  the CPU moving the data. Enable this option to build the drivers
 	  in drivers/dma as part of an SPL build.
 
+config SPL_DM_GPIO
+	bool "Support Driver Model GPIO drivers"
+	depends on SPL_GPIO_SUPPORT && DM_GPIO
+	help
+	  Enable support for Driver Model based GPIO drivers in SPL.
+
 config SPL_DRIVERS_MISC_SUPPORT
 	bool "Support misc drivers"
 	help
Signature · 1 line
2.20.1
#1 lore raw

PATCH v2 1/1 spl: Introduce SPL_DM_GPIO Kconfig define

Dear Tom,

Quoted 10 lines

This define indicates if DM_GPIO shall be supported in SPL. This allows proper operation of DM converted GPIO drivers in SPL, which use boards.

---

Changes in v2:
- Add dependency on DM_GPIO

Tom, are there any issues preventing this patch from being applied to -master?

Quoted 11 lines
 common/spl/Kconfig | 6 ++++++
 1 file changed, 6 insertions(+)
common/spl/Kconfig +0 -0
index f467eca2be..e3df8efa7e 100644
@@ -452,6 +452,12 @@ config SPL_DMA_SUPPORT
 	  the CPU moving the data. Enable this option to build the

drivers in drivers/dma as part of an SPL build.

common/spl/Kconfig config SPL_DMA_SUPPORT · line 463

Quoted 9 lines
common/spl/Kconfig +6 -0
+config SPL_DM_GPIO
+	bool "Support Driver Model GPIO drivers"
+	depends on SPL_GPIO_SUPPORT && DM_GPIO
+	help
+	  Enable support for Driver Model based GPIO drivers in SPL.
+
 config SPL_DRIVERS_MISC_SUPPORT
 	bool "Support misc drivers"
 	help

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191009/7d626b05/attachment.sig>

#2 lore raw

PATCH v2 1/1 spl: Introduce SPL_DM_GPIO Kconfig define

Hi Lukasz,

Quoted 10 lines · Lukasz Majewski

Dear Tom,

Quoted 7 lines

This define indicates if DM_GPIO shall be supported in SPL. This allows proper operation of DM converted GPIO drivers in SPL, which use boards.

---

Quoted 6 lines
Quoted 3 lines

Changes in v2:
- Add dependency on DM_GPIO

Tom, are there any issues preventing this patch from being applied to -master?

This does not actually define DM_GPIO anywhere though, so this is unused.

As it happens I sent a similar patch[1], but it doesn't work. I'll try again.

Quoted 12 lines
Quoted 12 lines
 common/spl/Kconfig | 6 ++++++
 1 file changed, 6 insertions(+)
common/spl/Kconfig +0 -0
index f467eca2be..e3df8efa7e 100644
@@ -452,6 +452,12 @@ config SPL_DMA_SUPPORT
        the CPU moving the data. Enable this option to build the

drivers in drivers/dma as part of an SPL build.

Quoted 10 lines

common/spl/Kconfig config SPL_DMA_SUPPORT · line 463

Quoted 9 lines
common/spl/Kconfig +6 -0
+config SPL_DM_GPIO
+     bool "Support Driver Model GPIO drivers"
+     depends on SPL_GPIO_SUPPORT && DM_GPIO
+     help
+       Enable support for Driver Model based GPIO drivers in SPL.
+
 config SPL_DRIVERS_MISC_SUPPORT
      bool "Support misc drivers"
      help

Regards,
SImon

[1] http://patchwork.ozlabs.org/patch/1167276/

#3 lore raw

PATCH v2 1/1 spl: Introduce SPL_DM_GPIO Kconfig define

Hi Simon,

Quoted 17 lines

Hi Lukasz,

Quoted 14 lines · Lukasz Majewski

Dear Tom,

Quoted 10 lines

This define indicates if DM_GPIO shall be supported in SPL. This allows proper operation of DM converted GPIO drivers in SPL, which use boards.

---

Changes in v2:
- Add dependency on DM_GPIO

Quoted 5 lines
Quoted 2 lines

Tom, are there any issues preventing this patch from being applied to -master?

This does not actually define DM_GPIO anywhere though, so this is unused.

The goal of this patch is to introduce in Kconfig a CONFIG_SPL_DM_GPIO. This define would be needed anyway, no matter if you perform the changes from [1].

This Kconfig define is necessary for the XEA board (i.MX28 based one), which uses OF_PLATDATA in SPL excessively to fit into size constraints.

To be more precise the mxs_gpio.c driver uses
#if CONFIG_IS_ENABLED(DM_GPIO) to provide DM GPIO support in SPL with OF_PLATDATA.

Quoted 3 lines

As it happens I sent a similar patch[1], but it doesn't work. I'll try again.

It would be great if we could have [1] not causing build breaks. However, for my used case it would be enough to have the Kconfig definition of CONFIG_SPL_DM_GPIO (as I'm using OF_PLATDATA) with it.

Simon, if you don't have time to do the fix for [1] I would opt for pulling this patch (to just add proper Kconfig define).

Quoted 24 lines
Quoted 13 lines
Quoted 13 lines
 
 common/spl/Kconfig | 6 ++++++
 1 file changed, 6 insertions(+)
common/spl/Kconfig +0 -0
index f467eca2be..e3df8efa7e 100644
@@ -452,6 +452,12 @@ config SPL_DMA_SUPPORT
        the CPU moving the data. Enable this option to build the

drivers in drivers/dma as part of an SPL build.

Quoted 10 lines

common/spl/Kconfig config SPL_DMA_SUPPORT · line 463

Quoted 9 lines
common/spl/Kconfig +6 -0
+config SPL_DM_GPIO
+     bool "Support Driver Model GPIO drivers"
+     depends on SPL_GPIO_SUPPORT && DM_GPIO
+     help
+       Enable support for Driver Model based GPIO drivers in SPL.
+
 config SPL_DRIVERS_MISC_SUPPORT
      bool "Support misc drivers"
      help  
Quoted 4 lines

Regards,
SImon

[1] http://patchwork.ozlabs.org/patch/1167276/

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191014/36b1bf8f/attachment.sig>

#4 lore raw

PATCH v2 1/1 spl: Introduce SPL_DM_GPIO Kconfig define

Hi Lukasz,

Quoted 42 lines · Lukasz Majewski

Hi Simon,

Quoted 17 lines

Hi Lukasz,

Quoted 14 lines · Lukasz Majewski

Dear Tom,

Quoted 10 lines

This define indicates if DM_GPIO shall be supported in SPL. This allows proper operation of DM converted GPIO drivers in SPL, which use boards.

---

Changes in v2:
- Add dependency on DM_GPIO

Quoted 5 lines
Quoted 2 lines

Tom, are there any issues preventing this patch from being applied to -master?

This does not actually define DM_GPIO anywhere though, so this is unused.

The goal of this patch is to introduce in Kconfig a CONFIG_SPL_DM_GPIO. This define would be needed anyway, no matter if you perform the changes from [1].

This Kconfig define is necessary for the XEA board (i.MX28 based one), which uses OF_PLATDATA in SPL excessively to fit into size constraints.

To be more precise the mxs_gpio.c driver uses
#if CONFIG_IS_ENABLED(DM_GPIO) to provide DM GPIO support in SPL with OF_PLATDATA.

Quoted 3 lines

As it happens I sent a similar patch[1], but it doesn't work. I'll try again.

Quoted 6 lines

It would be great if we could have [1] not causing build breaks. However, for my used case it would be enough to have the Kconfig definition of CONFIG_SPL_DM_GPIO (as I'm using OF_PLATDATA) with it.

Simon, if you don't have time to do the fix for [1] I would opt for pulling this patch (to just add proper Kconfig define).

I have had a crack at this here:

https://gitlab.denx.de/u-boot/custodians/u-boot-dm/commit/a6d15bbd9e4e7684dd47d21817df85915f28cbab

I expect to send this series along with this patch at the end of this week.

Quoted 25 lines
Quoted 25 lines
Quoted 24 lines
Quoted 23 lines


 common/spl/Kconfig | 6 ++++++
 1 file changed, 6 insertions(+)
common/spl/Kconfig +0 -0
index f467eca2be..e3df8efa7e 100644
@@ -452,6 +452,12 @@ config SPL_DMA_SUPPORT
        the CPU moving the data. Enable this option to build the

drivers in drivers/dma as part of an SPL build.

common/spl/Kconfig +6 -0
+config SPL_DM_GPIO
+     bool "Support Driver Model GPIO drivers"
+     depends on SPL_GPIO_SUPPORT && DM_GPIO
+     help
+       Enable support for Driver Model based GPIO drivers in SPL.
+
 config SPL_DRIVERS_MISC_SUPPORT
      bool "Support misc drivers"
      help
Quoted 5 lines
Quoted 4 lines

Regards,
SImon

[1] http://patchwork.ozlabs.org/patch/1167276/

Regards,
Simon

#5 lore raw

PATCH v2 1/1 spl: Introduce SPL_DM_GPIO Kconfig define

Hi Simon,

Quoted 54 lines

Hi Lukasz,

Quoted 44 lines · Lukasz Majewski

Hi Simon,

Quoted 18 lines

Hi Lukasz,

Quoted 14 lines · Lukasz Majewski

Dear Tom,

Quoted 10 lines

This define indicates if DM_GPIO shall be supported in SPL. This allows proper operation of DM converted GPIO drivers in SPL, which use boards.

---

Changes in v2:
- Add dependency on DM_GPIO

Quoted 5 lines
Quoted 2 lines

Tom, are there any issues preventing this patch from being applied to -master?

This does not actually define DM_GPIO anywhere though, so this is unused.

The goal of this patch is to introduce in Kconfig a CONFIG_SPL_DM_GPIO. This define would be needed anyway, no matter if you perform the changes from [1].

This Kconfig define is necessary for the XEA board (i.MX28 based one), which uses OF_PLATDATA in SPL excessively to fit into size constraints.

To be more precise the mxs_gpio.c driver uses
#if CONFIG_IS_ENABLED(DM_GPIO) to provide DM GPIO support in SPL with OF_PLATDATA.

Quoted 3 lines

As it happens I sent a similar patch[1], but it doesn't work. I'll try again.

Quoted 6 lines

It would be great if we could have [1] not causing build breaks. However, for my used case it would be enough to have the Kconfig definition of CONFIG_SPL_DM_GPIO (as I'm using OF_PLATDATA) with it.

Simon, if you don't have time to do the fix for [1] I would opt for pulling this patch (to just add proper Kconfig define).

Quoted 6 lines

I have had a crack at this here:

https://gitlab.denx.de/u-boot/custodians/u-boot-dm/commit/a6d15bbd9e4e7684dd47d21817df85915f28cbab

I expect to send this series along with this patch at the end of this week.

If I may ask - have you made any progress on this?

Quoted 26 lines
Quoted 26 lines
Quoted 26 lines
Quoted 25 lines
Quoted 24 lines
 
 
 
 common/spl/Kconfig | 6 ++++++
 1 file changed, 6 insertions(+)
common/spl/Kconfig +0 -0
index f467eca2be..e3df8efa7e 100644
@@ -452,6 +452,12 @@ config SPL_DMA_SUPPORT
        the CPU moving the data. Enable this option to build

the drivers in drivers/dma as part of an SPL build.

common/spl/Kconfig +5 -0
+config SPL_DM_GPIO
+     bool "Support Driver Model GPIO drivers"
+     depends on SPL_GPIO_SUPPORT && DM_GPIO
+     help
+       Enable support for Driver Model based GPIO drivers in

SPL. +
config SPL_DRIVERS_MISC_SUPPORT
bool "Support misc drivers"
help

Quoted 8 lines
Quoted 5 lines
Quoted 4 lines

Regards,
SImon

[1] http://patchwork.ozlabs.org/patch/1167276/

Regards,
Simon

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191117/ea4e4fa1/attachment.sig>

#6 lore raw

PATCH v2 1/1 spl: Introduce SPL_DM_GPIO Kconfig define

Hi Simon,

Quoted 58 lines

Hi Simon,

Quoted 56 lines

Hi Lukasz,

Quoted 51 lines · Lukasz Majewski

Hi Simon,

Quoted 18 lines

Hi Lukasz,

Quoted 14 lines · Lukasz Majewski

Dear Tom,

Quoted 10 lines

This define indicates if DM_GPIO shall be supported in SPL. This allows proper operation of DM converted GPIO drivers in SPL, which use boards.

---

Changes in v2:
- Add dependency on DM_GPIO

Quoted 5 lines
Quoted 2 lines

Tom, are there any issues preventing this patch from being applied to -master?

This does not actually define DM_GPIO anywhere though, so this is unused.

The goal of this patch is to introduce in Kconfig a CONFIG_SPL_DM_GPIO. This define would be needed anyway, no matter if you perform the changes from [1].

This Kconfig define is necessary for the XEA board (i.MX28 based one), which uses OF_PLATDATA in SPL excessively to fit into size constraints.

To be more precise the mxs_gpio.c driver uses
#if CONFIG_IS_ENABLED(DM_GPIO) to provide DM GPIO support in SPL with OF_PLATDATA.

Quoted 3 lines

As it happens I sent a similar patch[1], but it doesn't work. I'll try again.

It would be great if we could have [1] not causing build breaks. However, for my used case it would be enough to have the Kconfig definition of CONFIG_SPL_DM_GPIO (as I'm using OF_PLATDATA) with it.

Simon, if you don't have time to do the fix for [1] I would opt for pulling this patch (to just add proper Kconfig define).

Quoted 8 lines
Quoted 6 lines

I have had a crack at this here:

https://gitlab.denx.de/u-boot/custodians/u-boot-dm/commit/a6d15bbd9e4e7684dd47d21817df85915f28cbab

I expect to send this series along with this patch at the end of this week.

If I may ask - have you made any progress on this?

In fact it blocks some i.MX28 related code (board to be precise) from sending it upstream as converted drivers expect SPL_DM_GPIO to be defined in Kconfig.

In fact I do just need following code:
https://patchwork.ozlabs.org/patch/1169013/

If you have some difficulties to solve (on e.g. other archs) then maybe it would be enough to pull the above patch?

Quoted 38 lines
Quoted 27 lines
Quoted 27 lines
Quoted 27 lines
Quoted 26 lines
Quoted 25 lines
  
   
   
   
 common/spl/Kconfig | 6 ++++++
 1 file changed, 6 insertions(+)
common/spl/Kconfig +0 -0
index f467eca2be..e3df8efa7e 100644
@@ -452,6 +452,12 @@ config SPL_DMA_SUPPORT
        the CPU moving the data. Enable this option to build

the drivers in drivers/dma as part of an SPL build.

common/spl/Kconfig +5 -0
+config SPL_DM_GPIO
+     bool "Support Driver Model GPIO drivers"
+     depends on SPL_GPIO_SUPPORT && DM_GPIO
+     help
+       Enable support for Driver Model based GPIO drivers

in SPL. +
config SPL_DRIVERS_MISC_SUPPORT
bool "Support misc drivers"
help

Quoted 8 lines
Quoted 5 lines
Quoted 4 lines

Regards,
SImon

[1] http://patchwork.ozlabs.org/patch/1167276/

Regards,
Simon

Best regards,

Quoted 8 lines

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email:
lukma at denx.de

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191117/cdbcf15b/attachment.sig>

#7 lore raw

PATCH v2 1/1 spl: Introduce SPL_DM_GPIO Kconfig define

Hi Lukasz,

Quoted 74 lines · Lukasz Majewski

Hi Simon,

Quoted 58 lines

Hi Simon,

Quoted 56 lines

Hi Lukasz,

Quoted 51 lines · Lukasz Majewski

Hi Simon,

Quoted 18 lines

Hi Lukasz,

Quoted 14 lines · Lukasz Majewski

Dear Tom,

Quoted 10 lines

This define indicates if DM_GPIO shall be supported in SPL. This allows proper operation of DM converted GPIO drivers in SPL, which use boards.

---

Changes in v2:
- Add dependency on DM_GPIO

Quoted 5 lines
Quoted 2 lines

Tom, are there any issues preventing this patch from being applied to -master?

This does not actually define DM_GPIO anywhere though, so this is unused.

The goal of this patch is to introduce in Kconfig a CONFIG_SPL_DM_GPIO. This define would be needed anyway, no matter if you perform the changes from [1].

This Kconfig define is necessary for the XEA board (i.MX28 based one), which uses OF_PLATDATA in SPL excessively to fit into size constraints.

To be more precise the mxs_gpio.c driver uses
#if CONFIG_IS_ENABLED(DM_GPIO) to provide DM GPIO support in SPL with OF_PLATDATA.

Quoted 3 lines

As it happens I sent a similar patch[1], but it doesn't work. I'll try again.

It would be great if we could have [1] not causing build breaks. However, for my used case it would be enough to have the Kconfig definition of CONFIG_SPL_DM_GPIO (as I'm using OF_PLATDATA) with it.

Simon, if you don't have time to do the fix for [1] I would opt for pulling this patch (to just add proper Kconfig define).

Quoted 8 lines
Quoted 6 lines

I have had a crack at this here:

https://gitlab.denx.de/u-boot/custodians/u-boot-dm/commit/a6d15bbd9e4e7684dd47d21817df85915f28cbab

I expect to send this series along with this patch at the end of this week.

If I may ask - have you made any progress on this?

In fact it blocks some i.MX28 related code (board to be precise) from sending it upstream as converted drivers expect SPL_DM_GPIO to be defined in Kconfig.

Quoted 5 lines

In fact I do just need following code:
https://patchwork.ozlabs.org/patch/1169013/

If you have some difficulties to solve (on e.g. other archs) then maybe it would be enough to pull the above patch?

Just getting back to this, but see U-Boot next which has the full patch now.

Regards,
Simon