Disallow colons in the parameter of "-accel"
PATCH v2 1/1 Disallow colons in the parameter of "-accel"
Everybody who used something like "-machine accel=kvm:tcg" in the past might be tempted to specify a similar list with the -accel parameter, too, for example "-accel kvm:tcg". However, this is not how this options is thought to be used, since each "-accel" should only take care of one specific accelerator.
In the long run, we really should rework the "-accel" code completely, so that it does not set "-machine accel=..." anymore internally, but is completely independent from "-machine". For the short run, let's make sure that users cannot use "-accel xyz:tcg", so that we avoid that we have to deal with such cases in the wild later.
---
v2:
- Reword the message a little bit (as suggested by Paolo)
- Fix the cdrom-test - it already contained a bad usage of -accel
tests/cdrom-test.c | 2 +- vl.c | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-)
tests/cdrom-test.c +1 -1
@@ -120,7 +120,7 @@ static void test_cdboot(gconstpointer data) {QTestState *qts; - qts =qtest_initf ("-accel kvm:tcg -no-shutdown %s%s" , (const char *)data, + qts =qtest_initf ("-M accel=kvm:tcg -no-shutdown %s%s" , (const char *)data, isoimage);boot_sector_test (qts);qtest_quit (qts);
vl.c +5 -0
@@ -3554,6 +3554,11 @@ int main(int argc, char **argv, char **envp)g_slist_free (accel_list);exit (0 ); } +if (optarg &&strchr (optarg,':' )) { +error_report ("Don't use ':' with -accel, " +"use -M accel=... for now instead" ); +exit (1 ); + } opts =qemu_opts_create (qemu_find_opts ("machine" ),NULL , false, &error_abort);qemu_opt_set (opts,"accel" , optarg, &error_abort);
Signature · 1 line
2.18.1
Patchew URL: https://patchew.org/QEMU/[email protected]/
Patchew URL: https://patchew.org/QEMU/[email protected]/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally.
=== TEST SCRIPT BEGIN ===
#! /bin/bash
export ARCH=x86_64
make docker-image-fedora V=1 NETWORK=1
time make docker-test-mingw@fedora J=14 NETWORK=1
=== TEST SCRIPT END ===
The full log is available at
http://patchew.org/logs/[email protected]/testing.docker-mingw@fedora/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to [email protected]