Skip to contentSkip to conversation

drm/i915/tc: Implement the TC cold exit sequence

PATCH Superseded José Roberto de Souza 3 participants 9 messages Oct 1, 2019 – Oct 22, 2019

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915/tc: Implement the TC cold exit sequence

This is required for legacy/static TC ports as IOM is not aware of the connection and will not trigger the TC cold exit.

BSpec: 21750
BSpsc: 49294

---
 drivers/gpu/drm/i915/display/intel_tc.c | 34 ++++++++++++++++++++-----
 drivers/gpu/drm/i915/i915_reg.h         |  1 +
 2 files changed, 29 insertions(+), 6 deletions(-)
drivers/gpu/drm/i915/display/intel_tc.c +28 -6
index 7773169b7331..09b78027bdd5 100644
@@ -7,6 +7,7 @@
 #include "intel_display.h"
 #include "intel_display_types.h"
 #include "intel_dp_mst.h"
+#include "intel_sideband.h"
 #include "intel_tc.h"
 
 static const char *tc_port_mode_name(enum tc_port_mode mode)
@@ -169,6 +170,22 @@ static void tc_port_fixup_legacy_flag(struct intel_digital_port *dig_port,
 	dig_port->tc_legacy_port = !dig_port->tc_legacy_port;
 }
 
+static int tc_cold_exit_request(struct drm_i915_private *dev_priv)
+{
+	int ret;
+
+	do {
+		ret = sandybridge_pcode_write_timeout(dev_priv,
+						      ICL_PCODE_EXIT_TCCOLD, 0,
+						      250, 1);
+
+	} while (ret == -EAGAIN);
+
+	DRM_DEBUG_KMS("tccold exit %s\n", ret == 0 ? "succeeded" : "failed");
+
+	return ret;
+}
+
 static u32 tc_port_live_status_mask(struct intel_digital_port *dig_port)
 {
 	struct drm_i915_private *i915 = to_i915(dig_port->base.base.dev);
@@ -177,13 +194,21 @@ static u32 tc_port_live_status_mask(struct intel_digital_port *dig_port)
 	u32 mask = 0;
 	u32 val;
 
+	if (intel_uncore_read(uncore, SDEISR) & SDE_TC_HOTPLUG_ICP(tc_port))
+		mask |= BIT(TC_PORT_LEGACY);
+
 	val = intel_uncore_read(uncore,
 				PORT_TX_DFLEXDPSP(dig_port->tc_phy_fia));
 
 	if (val == 0xffffffff) {
-		DRM_DEBUG_KMS("Port %s: PHY in TCCOLD, nothing connected\n",
-			      dig_port->tc_port_name);
-		return mask;
+		if (mask)
+			tc_cold_exit_request(i915);
+
+		if (val == 0xffffffff) {
+			DRM_DEBUG_KMS("Port %s: PHY in TCCOLD, nothing connected\n",
+				      dig_port->tc_port_name);
+			return mask;
+		}
 	}
 
 	if (val & TC_LIVE_STATE_TBT(dig_port->tc_phy_fia_idx))
@@ -191,9 +216,6 @@ static u32 tc_port_live_status_mask(struct intel_digital_port *dig_port)
 	if (val & TC_LIVE_STATE_TC(dig_port->tc_phy_fia_idx))
 		mask |= BIT(TC_PORT_DP_ALT);
 
-	if (intel_uncore_read(uncore, SDEISR) & SDE_TC_HOTPLUG_ICP(tc_port))
-		mask |= BIT(TC_PORT_LEGACY);
-
 	/* The sink can be connected only in a single mode. */
 	if (!WARN_ON(hweight32(mask) > 1))
 		tc_port_fixup_legacy_flag(dig_port, mask);
drivers/gpu/drm/i915/i915_reg.h +1 -0
index 058aa5ca8b73..35c3724b7fef 100644
@@ -8860,6 +8860,7 @@ enum {
 #define     ICL_PCODE_MEM_SS_READ_QGV_POINT_INFO(point)	(((point) << 16) | (0x1 << 8))
 #define   GEN6_PCODE_READ_D_COMP		0x10
 #define   GEN6_PCODE_WRITE_D_COMP		0x11
+#define   ICL_PCODE_EXIT_TCCOLD			0x12
 #define   HSW_PCODE_DE_WRITE_FREQ_REQ		0x17
 #define   DISPLAY_IPS_CONTROL			0x19
             /* See also IPS_CTL */
Signature · 6 lines
2.23.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

✗ Fi.CI.BAT: failure for drm/i915/tc: Implement the TC cold exit sequence

== Series Details ==

== Series Details ==

Series: drm/i915/tc: Implement the TC cold exit sequence
URL : https://patchwork.freedesktop.org/series/67426/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_6979 -> Patchwork_14595
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_14595 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_14595, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14595/index.html

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_14595:

### IGT changes ###

#### Possible regressions ####

* igt@runner@aborted:
- fi-bsw-n3050: NOTRUN -> [FAIL][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14595/fi-bsw-n3050/igt@[email protected]

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* igt@gem_sync@basic-store-all:
- {fi-tgl-u2}: NOTRUN -> [FAIL][2]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14595/fi-tgl-u2/igt@[email protected]

* igt@i915_selftest@live_requests:
- {fi-tgl-u2}: NOTRUN -> [DMESG-FAIL][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14595/fi-tgl-u2/igt@i915_selftest@live_requests.html

Known issues
------------

Here are the changes found in Patchwork_14595 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_selftest@live_hangcheck:
- fi-bsw-n3050: [PASS][4] -> [INCOMPLETE][5] ([fdo#105876])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6979/fi-bsw-n3050/igt@i915_selftest@live_hangcheck.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14595/fi-bsw-n3050/igt@i915_selftest@live_hangcheck.html

#### Possible fixes ####

* igt@debugfs_test@read_all_entries:
- {fi-tgl-u2}: [DMESG-WARN][6] ([fdo#111600]) -> [PASS][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6979/fi-tgl-u2/igt@debugfs_test@read_all_entries.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14595/fi-tgl-u2/igt@debugfs_test@read_all_entries.html

* igt@gem_sync@basic-each:
- {fi-tgl-u2}: [INCOMPLETE][8] ([fdo#111647]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6979/fi-tgl-u2/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14595/fi-tgl-u2/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#105876]: https://bugs.freedesktop.org/show_bug.cgi?id=105876
[fdo#111600]: https://bugs.freedesktop.org/show_bug.cgi?id=111600
[fdo#111647]: https://bugs.freedesktop.org/show_bug.cgi?id=111647

Participating hosts (15 -> 43)
------------------------------

Additional (28): fi-kbl-soraka fi-bdw-gvtdvm fi-icl-u2 fi-apl-guc fi-snb-2520m fi-icl-u3 fi-skl-lmem fi-blb-e6850 fi-icl-guc fi-byt-n2820 fi-skl-6600u fi-hsw-4770r fi-bxt-dsi fi-cml-s fi-glk-dsi fi-bwr-2160 fi-ilk-650 fi-kbl-7500u fi-gdg-551 fi-elk-e7500 fi-skl-6700k2 fi-hsw-peppy fi-cfl-guc fi-whl-u fi-kbl-x1275 fi-cfl-8109u fi-skl-iommu fi-kbl-8809g

Build changes
-------------

* CI: CI-20190529 -> None
* Linux: CI_DRM_6979 -> Patchwork_14595

CI-20190529: 20190529
CI_DRM_6979: 46637a3b58ef5e2c0fb6e53b7c50bba8f5de3455 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5208: c0131b4f132acf287d9d05b0f5078003d3159e1c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14595: a6ecce8d8ab2cdeff30b89cc0a8289dc8c414145 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

a6ecce8d8ab2 drm/i915/tc: Implement the TC cold exit sequence

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14595/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw

✓ Fi.CI.BAT: success for drm/i915/tc: Implement the TC cold exit sequence (rev2)

In reply to José Roberto de Souza
== Series Details ==

== Series Details ==

Series: drm/i915/tc: Implement the TC cold exit sequence (rev2)
URL : https://patchwork.freedesktop.org/series/67426/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_6979 -> Patchwork_14598
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14598/index.html

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_14598:

### IGT changes ###

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* igt@gem_sync@basic-all:
- {fi-tgl-u2}: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6979/fi-tgl-u2/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14598/fi-tgl-u2/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

Participating hosts (15 -> 43)
------------------------------

Additional (28): fi-kbl-soraka fi-bdw-gvtdvm fi-icl-u2 fi-apl-guc fi-snb-2520m fi-icl-u3 fi-skl-lmem fi-blb-e6850 fi-byt-n2820 fi-icl-guc fi-skl-6600u fi-hsw-4770r fi-bxt-dsi fi-cml-s fi-byt-j1900 fi-glk-dsi fi-ilk-650 fi-kbl-7500u fi-gdg-551 fi-elk-e7500 fi-skl-6700k2 fi-hsw-peppy fi-cfl-guc fi-whl-u fi-kbl-x1275 fi-cfl-8109u fi-skl-iommu fi-kbl-8809g

Build changes
-------------

* CI: CI-20190529 -> None
* Linux: CI_DRM_6979 -> Patchwork_14598

CI-20190529: 20190529
CI_DRM_6979: 46637a3b58ef5e2c0fb6e53b7c50bba8f5de3455 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5208: c0131b4f132acf287d9d05b0f5078003d3159e1c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14598: 811c4fd9bfd814ea3f9be9f0f8f4cf7c5e6b03d0 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

811c4fd9bfd8 drm/i915/tc: Implement the TC cold exit sequence

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14598/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw

✗ Fi.CI.IGT: failure for drm/i915/tc: Implement the TC cold exit sequence (rev2)

In reply to José Roberto de Souza
== Series Details ==

== Series Details ==

Series: drm/i915/tc: Implement the TC cold exit sequence (rev2)
URL : https://patchwork.freedesktop.org/series/67426/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_6979_full -> Patchwork_14598_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_14598_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_14598_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_14598_full:

### IGT changes ###

#### Possible regressions ####

* igt@gem_pipe_control_store_loop@reused-buffer:
- shard-skl: [PASS][1] -> [TIMEOUT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6979/shard-skl5/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14598/shard-skl8/igt@[email protected]

Known issues
------------

Here are the changes found in Patchwork_14598_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_ctx_isolation@bcs0-s3:
- shard-apl: [PASS][3] -> [DMESG-WARN][4] ([fdo#108566]) +5 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6979/shard-apl4/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14598/shard-apl1/igt@[email protected]

* igt@gem_ctx_isolation@vcs0-s3:
- shard-kbl: [PASS][5] -> [DMESG-WARN][6] ([fdo#108566])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6979/shard-kbl1/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14598/shard-kbl7/igt@[email protected]

* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#110841])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6979/shard-iclb6/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14598/shard-iclb2/igt@[email protected]

* igt@gem_eio@in-flight-contexts-1us:
- shard-hsw: [PASS][9] -> [FAIL][10] ([fdo#105957])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6979/shard-hsw5/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14598/shard-hsw7/igt@[email protected]

* igt@gem_eio@in-flight-suspend:
- shard-glk: [PASS][11] -> [CRASH][12] ([fdo#111559])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6979/shard-glk6/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14598/shard-glk8/igt@[email protected]

* igt@gem_exec_async@concurrent-writes-bsd:
- shard-iclb: [PASS][13] -> [SKIP][14] ([fdo#111325]) +5 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6979/shard-iclb6/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14598/shard-iclb4/igt@[email protected]

* igt@gem_tiled_swapping@non-threaded:
- shard-kbl: [PASS][15] -> [DMESG-WARN][16] ([fdo#108686])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6979/shard-kbl2/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14598/shard-kbl6/igt@[email protected]

* igt@gem_userptr_blits@map-fixed-invalidate-busy:
- shard-glk: [PASS][17] -> [DMESG-WARN][18] ([fdo#111870]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6979/shard-glk5/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14598/shard-glk3/igt@[email protected]

* igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
- shard-snb: [PASS][19] -> [DMESG-WARN][20] ([fdo#111870]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6979/shard-snb1/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14598/shard-snb1/igt@[email protected]

* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy:
- shard-apl: [PASS][21] -> [DMESG-WARN][22] ([fdo#109385] / [fdo#111870])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6979/shard-apl3/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14598/shard-apl1/igt@[email protected]

* igt@gem_userptr_blits@sync-unmap:
- shard-skl: [PASS][23] -> [DMESG-WARN][24] ([fdo#111870])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6979/shard-skl1/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14598/shard-skl7/igt@[email protected]

* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-skl: [PASS][25] -> [INCOMPLETE][26] ([fdo#104108])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6979/shard-skl10/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14598/shard-skl6/igt@[email protected]

* igt@kms_cursor_crc@pipe-b-cursor-128x128-onscreen:
- shard-skl: [PASS][27] -> [FAIL][28] ([fdo#103232])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6979/shard-skl2/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14598/shard-skl4/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
- shard-iclb: [PASS][29] -> [FAIL][30] ([fdo#103167]) +7 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6979/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14598/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite.html

* igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-mmap-cpu:
- shard-iclb: [PASS][31] -> [INCOMPLETE][32] ([fdo#106978] / [fdo#107713])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6979/shard-iclb8/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-mmap-cpu.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14598/shard-iclb1/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-mmap-cpu.html

* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b-frame-sequence:
- shard-skl: [PASS][33] -> [FAIL][34] ([fdo#103191])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6979/shard-skl2/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14598/shard-skl4/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
- shard-skl: [PASS][35] -> [FAIL][36] ([fdo#108145])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6979/shard-skl2/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14598/shard-skl4/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][37] -> [FAIL][38] ([fdo#108145] / [fdo#110403])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6979/shard-skl1/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14598/shard-skl7/igt@[email protected]

* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][39] -> [SKIP][40] ([fdo#109441]) +2 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6979/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14598/shard-iclb5/igt@kms_psr@psr2_sprite_plane_move.html

* igt@prime_busy@hang-bsd2:
- shard-iclb: [PASS][41] -> [SKIP][42] ([fdo#109276]) +21 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6979/shard-iclb4/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14598/shard-iclb5/igt@[email protected]

#### Possible fixes ####

* igt@gem_close@many-handles-one-vma:
- shard-snb: [INCOMPLETE][43] ([fdo#105411]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6979/shard-snb5/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14598/shard-snb7/igt@[email protected]

* igt@gem_eio@unwedge-stress:
- shard-snb: [FAIL][45] ([fdo#109661]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6979/shard-snb4/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14598/shard-snb2/igt@[email protected]

* igt@gem_exec_schedule@wide-bsd:
- shard-iclb: [SKIP][47] ([fdo#111325]) -> [PASS][48] +4 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6979/shard-iclb2/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14598/shard-iclb5/igt@[email protected]

* igt@gem_userptr_blits@dmabuf-sync:
- shard-skl: [DMESG-WARN][49] ([fdo#111870]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6979/shard-skl5/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14598/shard-skl3/igt@[email protected]

* igt@gem_userptr_blits@dmabuf-unsync:
- shard-kbl: [DMESG-WARN][51] ([fdo#111870]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6979/shard-kbl2/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14598/shard-kbl1/igt@[email protected]

* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup:
- shard-glk: [DMESG-WARN][53] ([fdo#111870]) -> [PASS][54] +1 similar issue
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6979/shard-glk4/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14598/shard-glk5/igt@[email protected]

* igt@gem_userptr_blits@sync-unmap:
- shard-iclb: [DMESG-WARN][55] ([fdo#111870]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6979/shard-iclb8/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14598/shard-iclb4/igt@[email protected]

* igt@i915_selftest@live_gem_contexts:
- shard-hsw: [DMESG-FAIL][57] ([fdo#111692]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6979/shard-hsw4/igt@i915_selftest@live_gem_contexts.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14598/shard-hsw6/igt@i915_selftest@live_gem_contexts.html

* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-skl: [FAIL][59] ([fdo#102670]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6979/shard-skl10/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14598/shard-skl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html

* igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-render:
- shard-iclb: [INCOMPLETE][61] ([fdo#107713]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6979/shard-iclb7/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14598/shard-iclb7/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-apl: [DMESG-WARN][63] ([fdo#108566]) -> [PASS][64] +6 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6979/shard-apl4/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14598/shard-apl3/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
- shard-iclb: [FAIL][65] ([fdo#103167]) -> [PASS][66] +5 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6979/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14598/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html

* igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-cpu:
- shard-skl: [FAIL][67] ([fdo#103167]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6979/shard-skl4/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14598/shard-skl9/igt@[email protected]

* igt@kms_plane@plane-panning-bottom-right-pipe-a-planes:
- shard-skl: [FAIL][69] ([fdo#103166]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6979/shard-skl4/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14598/shard-skl9/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: [FAIL][71] ([fdo#108145]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6979/shard-skl4/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14598/shard-skl9/igt@[email protected]

* igt@kms_plane_lowres@pipe-a-tiling-y:
- shard-iclb: [FAIL][73] ([fdo#103166]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6979/shard-iclb6/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14598/shard-iclb4/igt@[email protected]

* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [SKIP][75] ([fdo#109642] / [fdo#111068]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6979/shard-iclb6/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14598/shard-iclb2/igt@[email protected]

* igt@kms_psr@psr2_cursor_plane_onoff:
- shard-iclb: [SKIP][77] ([fdo#109441]) -> [PASS][78] +2 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6979/shard-iclb8/igt@kms_psr@psr2_cursor_plane_onoff.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14598/shard-iclb2/igt@kms_psr@psr2_cursor_plane_onoff.html

* igt@kms_vblank@pipe-b-query-forked-hang:
- shard-hsw: [INCOMPLETE][79] ([fdo#103540]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6979/shard-hsw8/igt@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14598/shard-hsw6/igt@[email protected]

* igt@perf@polling:
- shard-skl: [FAIL][81] ([fdo#110728]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6979/shard-skl2/igt@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14598/shard-skl3/igt@[email protected]

* igt@perf@short-reads:
- shard-kbl: [FAIL][83] ([fdo#103183]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6979/shard-kbl1/igt@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14598/shard-kbl2/igt@[email protected]

* igt@prime_vgem@fence-wait-bsd2:
- shard-iclb: [SKIP][85] ([fdo#109276]) -> [PASS][86] +17 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6979/shard-iclb8/igt@[email protected]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14598/shard-iclb2/igt@[email protected]

#### Warnings ####

* igt@gem_ctx_isolation@vcs1-nonpriv:
- shard-iclb: [FAIL][87] ([fdo#111329]) -> [SKIP][88] ([fdo#109276])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6979/shard-iclb4/igt@[email protected]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14598/shard-iclb6/igt@[email protected]

* igt@gem_mocs_settings@mocs-reset-bsd2:
- shard-iclb: [FAIL][89] ([fdo#111330]) -> [SKIP][90] ([fdo#109276]) +2 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6979/shard-iclb1/igt@[email protected]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14598/shard-iclb8/igt@[email protected]

* igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
- shard-apl: [DMESG-WARN][91] ([fdo#109385]) -> [DMESG-WARN][92] ([fdo#109385] / [fdo#111870]) +1 similar issue
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6979/shard-apl7/igt@[email protected]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14598/shard-apl7/igt@[email protected]

* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [SKIP][93] ([fdo#109349]) -> [DMESG-WARN][94] ([fdo#107724])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6979/shard-iclb1/igt@[email protected]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14598/shard-iclb2/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#102670]: https://bugs.freedesktop.org/show_bug.cgi?id=102670
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103183]: https://bugs.freedesktop.org/show_bug.cgi?id=103183
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#105957]: https://bugs.freedesktop.org/show_bug.cgi?id=105957
[fdo#106978]: https://bugs.freedesktop.org/show_bug.cgi?id=106978
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109385]: https://bugs.freedesktop.org/show_bug.cgi?id=109385
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#109661]: https://bugs.freedesktop.org/show_bug.cgi?id=109661
[fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
[

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14598/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw
In reply to José Roberto de Souza
Quoted 54 lines · José Roberto de Souza

This is required for legacy/static TC ports as IOM is not aware of the connection and will not trigger the TC cold exit.

BSpec: 21750
BSpsc: 49294

---
 drivers/gpu/drm/i915/display/intel_tc.c | 34 ++++++++++++++++++++-----
 drivers/gpu/drm/i915/i915_reg.h         |  1 +
 2 files changed, 29 insertions(+), 6 deletions(-)
drivers/gpu/drm/i915/display/intel_tc.c +19 -0
index 7773169b7331..09b78027bdd5 100644
@@ -7,6 +7,7 @@
 #include "intel_display.h"
 #include "intel_display_types.h"
 #include "intel_dp_mst.h"
+#include "intel_sideband.h"
 #include "intel_tc.h"
 
 static const char *tc_port_mode_name(enum tc_port_mode mode)
@@ -169,6 +170,22 @@ static void tc_port_fixup_legacy_flag(struct intel_digital_port *dig_port,
 	dig_port->tc_legacy_port = !dig_port->tc_legacy_port;
 }
 
+static int tc_cold_exit_request(struct drm_i915_private *dev_priv)
+{
+	int ret;
+
+	do {
+		ret = sandybridge_pcode_write_timeout(dev_priv,
+						      ICL_PCODE_EXIT_TCCOLD, 0,
+						      250, 1);
+
+	} while (ret == -EAGAIN);
+
+	DRM_DEBUG_KMS("tccold exit %s\n", ret == 0 ? "succeeded" : "failed");
+
+	return ret;
+}
+
 static u32 tc_port_live_status_mask(struct intel_digital_port *dig_port)
 {
 	struct drm_i915_private *i915 = to_i915(dig_port->base.base.dev);
@@ -177,13 +194,21 @@ static u32 tc_port_live_status_mask(struct intel_digital_port *dig_port)
 	u32 mask = 0;
 	u32 val;
 
+	if (intel_uncore_read(uncore, SDEISR) & SDE_TC_HOTPLUG_ICP(tc_port))
+		mask |= BIT(TC_PORT_LEGACY);

drivers/gpu/drm/i915/display/intel_tc.c static u32 tc_port_live_status_mask(struct intel_digital_port *dig_port) · line 205

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_tc.c +3 -3
+
 	val = intel_uncore_read(uncore,
 				PORT_TX_DFLEXDPSP(dig_port->tc_phy_fia));
 
 	if (val == 0xffffffff) {
-		DRM_DEBUG_KMS("Port %s: PHY in TCCOLD, nothing connected\n",
-			      dig_port->tc_port_name);
-		return mask;
+		if (mask)
+			tc_cold_exit_request(i915);

The semantic of the mbox command this needs is inherently racy on systems with preemption, the instruction to use it is:

"""
Issue GT Driver mailbox command to exit TCCOLD, then complete steps b-d within 500 milliseconds to prevent re-entry.
"""

We'd have to reach the point where we enable the AUX power in 500ms, which can't be guaranteed. Moreover TCCOLD could be entered just after reading PORT_TX_DFLEXDPSP, so we may not detect it.

What we can do - after discussing with HW folks - is to first request AUX power and then issue the mbox command, which prevents TCCOLD re-entry until releasing the AUX power request. This also needs ignoring the timeout of the AUX power enabling ACK, since it will only be ACKed after exiting TCCOLD.

So I think we should block TCCOLD this way in __intel_tc_port_lock():

	if tc_link_refcount==0:
		intel_display_power_get(POWER_DOMAIN_AUX_<port>)
		tc_cold_exit_request()
		if intel_tc_port_needs_reset():
			intel_tc_port_reset_mode()
		if tc_mode != LEGACY:
			intel_display_power_put(POWER_DOMAIN_AUX_<port>)

then unblock TCCOLD in intel_tc_port_unlock():

	if tc_link_refcount==0 and tc_mode == LEGACY:
		intel_display_power_put(POWER_DOMAIN_AUX_<port>)
Quoted 34 lines
drivers/gpu/drm/i915/display/intel_tc.c +6 -3
+
+		if (val == 0xffffffff) {
+			DRM_DEBUG_KMS("Port %s: PHY in TCCOLD, nothing connected\n",
+				      dig_port->tc_port_name);
+			return mask;
+		}
 	}
 
 	if (val & TC_LIVE_STATE_TBT(dig_port->tc_phy_fia_idx))
@@ -191,9 +216,6 @@ static u32 tc_port_live_status_mask(struct intel_digital_port *dig_port)
 	if (val & TC_LIVE_STATE_TC(dig_port->tc_phy_fia_idx))
 		mask |= BIT(TC_PORT_DP_ALT);
 
-	if (intel_uncore_read(uncore, SDEISR) & SDE_TC_HOTPLUG_ICP(tc_port))
-		mask |= BIT(TC_PORT_LEGACY);
-
 	/* The sink can be connected only in a single mode. */
 	if (!WARN_ON(hweight32(mask) > 1))
 		tc_port_fixup_legacy_flag(dig_port, mask);
drivers/gpu/drm/i915/i915_reg.h +1 -0
index 058aa5ca8b73..35c3724b7fef 100644
@@ -8860,6 +8860,7 @@ enum {
 #define     ICL_PCODE_MEM_SS_READ_QGV_POINT_INFO(point)	(((point) << 16) | (0x1 << 8))
 #define   GEN6_PCODE_READ_D_COMP		0x10
 #define   GEN6_PCODE_WRITE_D_COMP		0x11
+#define   ICL_PCODE_EXIT_TCCOLD			0x12
 #define   HSW_PCODE_DE_WRITE_FREQ_REQ		0x17
 #define   DISPLAY_IPS_CONTROL			0x19
             /* See also IPS_CTL */
Signature · 1 line
2.23.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw
Quoted 70 lines · Imre Deak
Quoted 68 lines · José Roberto de Souza

This is required for legacy/static TC ports as IOM is not aware of the connection and will not trigger the TC cold exit.

BSpec: 21750
BSpsc: 49294

---
 drivers/gpu/drm/i915/display/intel_tc.c | 34 ++++++++++++++++++++-
----
 drivers/gpu/drm/i915/i915_reg.h         |  1 +
 2 files changed, 29 insertions(+), 6 deletions(-)
drivers/gpu/drm/i915/display/intel_tc.c +17 -0
index 7773169b7331..09b78027bdd5 100644
@@ -7,6 +7,7 @@
 #include "intel_display.h"
 #include "intel_display_types.h"
 #include "intel_dp_mst.h"
+#include "intel_sideband.h"
 #include "intel_tc.h"
 
 static const char *tc_port_mode_name(enum tc_port_mode mode)
@@ -169,6 +170,22 @@ static void tc_port_fixup_legacy_flag(struct
 intel_digital_port *dig_port,
 	dig_port->tc_legacy_port = !dig_port->tc_legacy_port;
 }
 
+static int tc_cold_exit_request(struct drm_i915_private *dev_priv)
+{
+	int ret;
+
+	do {
+		ret = sandybridge_pcode_write_timeout(dev_priv,
+						      ICL_PCODE_EXIT_TC
 COLD, 0,
+						      250, 1);
+
+	} while (ret == -EAGAIN);
+
+	DRM_DEBUG_KMS("tccold exit %s\n", ret == 0 ? "succeeded" :
 "failed");
+
+	return ret;
+}
+

static u32 tc_port_live_status_mask(struct intel_digital_port
*dig_port)
{
struct drm_i915_private *i915 = to_i915(dig_port-

Quoted 1 line

base.base.dev);

drivers/gpu/drm/i915/display/intel_tc.c +3 -0
@@ -177,13 +194,21 @@ static u32 tc_port_live_status_mask(struct
 intel_digital_port *dig_port)
 	u32 mask = 0;
 	u32 val;
 
+	if (intel_uncore_read(uncore, SDEISR) &
 SDE_TC_HOTPLUG_ICP(tc_port))
+		mask |= BIT(TC_PORT_LEGACY);
+
 	val = intel_uncore_read(uncore,
 				PORT_TX_DFLEXDPSP(dig_port-
 >tc_phy_fia));
 
Quoted 7 lines

drivers/gpu/drm/i915/display/intel_tc.c static u32 tc_port_live_status_mask(struct intel_digital_port *dig_port) · line 205

Quoted 7 lines
drivers/gpu/drm/i915/display/intel_tc.c +2 -3
 	if (val == 0xffffffff) {
-		DRM_DEBUG_KMS("Port %s: PHY in TCCOLD, nothing
 connected\n",
-			      dig_port->tc_port_name);
-		return mask;
+		if (mask)
+			tc_cold_exit_request(i915);

Sorry for the delay, was OOO.

Quoted 15 lines

The semantic of the mbox command this needs is inherently racy on systems with preemption, the instruction to use it is:

"""
Issue GT Driver mailbox command to exit TCCOLD, then complete steps b-d
within 500 milliseconds to prevent re-entry.
"""

We'd have to reach the point where we enable the AUX power in 500ms, which can't be guaranteed. Moreover TCCOLD could be entered just after
reading PORT_TX_DFLEXDPSP, so we may not detect it.

Quoted 7 lines

What we can do - after discussing with HW folks - is to first request AUX power and then issue the mbox command, which prevents TCCOLD re-entry until releasing the AUX power request. This also needs ignoring
the timeout of the AUX power enabling ACK, since it will only be ACKed
after exiting TCCOLD.

Huum looks more robust indeed.

Quoted 6 lines

So I think we should block TCCOLD this way in __intel_tc_port_lock():

	if tc_link_refcount==0:
		intel_display_power_get(POWER_DOMAIN_AUX_<port>)
		tc_cold_exit_request()

So for non-legacy the IOM request to exit TCCOLD could have timed out at this point. But for most cases this will not happen, why not here read one FIA register and check if == 0xffffffff if so we call tc_cold_exit_request().

Quoted 4 lines
		if intel_tc_port_needs_reset():
			intel_tc_port_reset_mode()
		if tc_mode != LEGACY:
			intel_display_power_put(POWER_DOMAIN_AUX_<port>

Also why power_put() for non-legacy? a preemption could happen after lock() and cause a TCCOLD before the needed reads/writes to FIA is done.

Better remove this block and only power_put() when removing the last reference on intel_tc_port_unlock()

Quoted 38 lines

)

then unblock TCCOLD in intel_tc_port_unlock():

	if tc_link_refcount==0 and tc_mode == LEGACY:
		intel_display_power_put(POWER_DOMAIN_AUX_<port>)
Quoted 31 lines
drivers/gpu/drm/i915/display/intel_tc.c +3 -0
+
+		if (val == 0xffffffff) {
+			DRM_DEBUG_KMS("Port %s: PHY in TCCOLD, nothing

connected\n",

drivers/gpu/drm/i915/display/intel_tc.c +3 -3
+				      dig_port->tc_port_name);
+			return mask;
+		}
 	}
 
 	if (val & TC_LIVE_STATE_TBT(dig_port->tc_phy_fia_idx))
@@ -191,9 +216,6 @@ static u32 tc_port_live_status_mask(struct
 intel_digital_port *dig_port)
 	if (val & TC_LIVE_STATE_TC(dig_port->tc_phy_fia_idx))
 		mask |= BIT(TC_PORT_DP_ALT);
 
-	if (intel_uncore_read(uncore, SDEISR) &
 SDE_TC_HOTPLUG_ICP(tc_port))
-		mask |= BIT(TC_PORT_LEGACY);
-
 	/* The sink can be connected only in a single mode. */
drivers/gpu/drm/i915/display/intel_tc.c +0 -0
 	if (!WARN_ON(hweight32(mask) > 1))
 		tc_port_fixup_legacy_flag(dig_port, mask);
drivers/gpu/drm/i915/i915_reg.h +0 -0
index 058aa5ca8b73..35c3724b7fef 100644
@@ -8860,6 +8860,7 @@ enum {
 #define     ICL_PCODE_MEM_SS_READ_QGV_POINT_INFO(point)	(((poin
 t) << 16) | (0x1 << 8))
 #define   GEN6_PCODE_READ_D_COMP		0x10
Quoted 8 lines
Quoted 8 lines
drivers/gpu/drm/i915/i915_reg.h +1 -0
 #define   GEN6_PCODE_WRITE_D_COMP		0x11
+#define   ICL_PCODE_EXIT_TCCOLD			0x12
 #define   HSW_PCODE_DE_WRITE_FREQ_REQ		0x17
 #define   DISPLAY_IPS_CONTROL			0x19
             /* See also IPS_CTL */
Signature · 1 line
2.23.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#6 lore raw
Quoted 111 lines · Jose
Quoted 70 lines · Imre Deak
Quoted 68 lines · José Roberto de Souza

This is required for legacy/static TC ports as IOM is not aware of the connection and will not trigger the TC cold exit.

BSpec: 21750
BSpsc: 49294

---
 drivers/gpu/drm/i915/display/intel_tc.c | 34 ++++++++++++++++++++-
----
 drivers/gpu/drm/i915/i915_reg.h         |  1 +
 2 files changed, 29 insertions(+), 6 deletions(-)
drivers/gpu/drm/i915/display/intel_tc.c +17 -0
index 7773169b7331..09b78027bdd5 100644
@@ -7,6 +7,7 @@
 #include "intel_display.h"
 #include "intel_display_types.h"
 #include "intel_dp_mst.h"
+#include "intel_sideband.h"
 #include "intel_tc.h"
 
 static const char *tc_port_mode_name(enum tc_port_mode mode)
@@ -169,6 +170,22 @@ static void tc_port_fixup_legacy_flag(struct
 intel_digital_port *dig_port,
 	dig_port->tc_legacy_port = !dig_port->tc_legacy_port;
 }
 
+static int tc_cold_exit_request(struct drm_i915_private *dev_priv)
+{
+	int ret;
+
+	do {
+		ret = sandybridge_pcode_write_timeout(dev_priv,
+						      ICL_PCODE_EXIT_TC
 COLD, 0,
+						      250, 1);
+
+	} while (ret == -EAGAIN);
+
+	DRM_DEBUG_KMS("tccold exit %s\n", ret == 0 ? "succeeded" :
 "failed");
+
+	return ret;
+}
+

static u32 tc_port_live_status_mask(struct intel_digital_port
*dig_port)
{
struct drm_i915_private *i915 = to_i915(dig_port-

Quoted 1 line

base.base.dev);

drivers/gpu/drm/i915/display/intel_tc.c +3 -0
@@ -177,13 +194,21 @@ static u32 tc_port_live_status_mask(struct
 intel_digital_port *dig_port)
 	u32 mask = 0;
 	u32 val;
 
+	if (intel_uncore_read(uncore, SDEISR) &
 SDE_TC_HOTPLUG_ICP(tc_port))
+		mask |= BIT(TC_PORT_LEGACY);
+
 	val = intel_uncore_read(uncore,
 				PORT_TX_DFLEXDPSP(dig_port-
 >tc_phy_fia));
 
Quoted 7 lines

drivers/gpu/drm/i915/display/intel_tc.c static u32 tc_port_live_status_mask(struct intel_digital_port *dig_port) · line 205

Quoted 7 lines
drivers/gpu/drm/i915/display/intel_tc.c +2 -3
 	if (val == 0xffffffff) {
-		DRM_DEBUG_KMS("Port %s: PHY in TCCOLD, nothing
 connected\n",
-			      dig_port->tc_port_name);
-		return mask;
+		if (mask)
+			tc_cold_exit_request(i915);

Sorry for the delay, was OOO.

Quoted 15 lines

The semantic of the mbox command this needs is inherently racy on systems with preemption, the instruction to use it is:

"""
Issue GT Driver mailbox command to exit TCCOLD, then complete steps b-d
within 500 milliseconds to prevent re-entry.
"""

We'd have to reach the point where we enable the AUX power in 500ms, which can't be guaranteed. Moreover TCCOLD could be entered just after
reading PORT_TX_DFLEXDPSP, so we may not detect it.

Quoted 7 lines

What we can do - after discussing with HW folks - is to first request AUX power and then issue the mbox command, which prevents TCCOLD re-entry until releasing the AUX power request. This also needs ignoring
the timeout of the AUX power enabling ACK, since it will only be ACKed
after exiting TCCOLD.

Huum looks more robust indeed.

Quoted 3 lines

So I think we should block TCCOLD this way in __intel_tc_port_lock():

Quoted 8 lines
Quoted 3 lines
	if tc_link_refcount==0:
		intel_display_power_get(POWER_DOMAIN_AUX_<port>)
		tc_cold_exit_request()

So for non-legacy the IOM request to exit TCCOLD could have timed out at this point. But for most cases this will not happen, why not here read one FIA register and check if == 0xffffffff if so we call tc_cold_exit_request().

That would be racy, TCCOLD could be entered right after doing the FIA reg check. Getting the AUX power ref alone won't prevent a TCCOLD entry until the PCODE command has completed.

Quoted 9 lines
Quoted 5 lines
		if intel_tc_port_needs_reset():
			intel_tc_port_reset_mode()
		if tc_mode != LEGACY:
			intel_display_power_put(POWER_DOMAIN_AUX_<port>

Also why power_put() for non-legacy? a preemption could happen after lock() and cause a TCCOLD before the needed reads/writes to FIA is done.

The new PCODE command was only added for legacy and the AUX power reference makes a difference only in that mode. In DP-alt mode the DPCSSS.DPPMSTC flag prevents TCCOLD.

In TBT mode the TBT AUX power ref would not prevent TCCOLD. In that mode we don't access FIA regs afterwards and
"the TBT controller prevents TCCOLD while it uses the connection".

Quoted 42 lines

Better remove this block and only power_put() when removing the last reference on intel_tc_port_unlock()

Quoted 38 lines

)

then unblock TCCOLD in intel_tc_port_unlock():

	if tc_link_refcount==0 and tc_mode == LEGACY:
		intel_display_power_put(POWER_DOMAIN_AUX_<port>)
Quoted 31 lines
drivers/gpu/drm/i915/display/intel_tc.c +3 -0
+
+		if (val == 0xffffffff) {
+			DRM_DEBUG_KMS("Port %s: PHY in TCCOLD, nothing

connected\n",

drivers/gpu/drm/i915/display/intel_tc.c +3 -3
+				      dig_port->tc_port_name);
+			return mask;
+		}
 	}
 
 	if (val & TC_LIVE_STATE_TBT(dig_port->tc_phy_fia_idx))
@@ -191,9 +216,6 @@ static u32 tc_port_live_status_mask(struct
 intel_digital_port *dig_port)
 	if (val & TC_LIVE_STATE_TC(dig_port->tc_phy_fia_idx))
 		mask |= BIT(TC_PORT_DP_ALT);
 
-	if (intel_uncore_read(uncore, SDEISR) &
 SDE_TC_HOTPLUG_ICP(tc_port))
-		mask |= BIT(TC_PORT_LEGACY);
-
 	/* The sink can be connected only in a single mode. */
drivers/gpu/drm/i915/display/intel_tc.c +0 -0
 	if (!WARN_ON(hweight32(mask) > 1))
 		tc_port_fixup_legacy_flag(dig_port, mask);
drivers/gpu/drm/i915/i915_reg.h +0 -0
index 058aa5ca8b73..35c3724b7fef 100644
@@ -8860,6 +8860,7 @@ enum {
 #define     ICL_PCODE_MEM_SS_READ_QGV_POINT_INFO(point)	(((poin
 t) << 16) | (0x1 << 8))
 #define   GEN6_PCODE_READ_D_COMP		0x10
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
drivers/gpu/drm/i915/i915_reg.h +1 -0
 #define   GEN6_PCODE_WRITE_D_COMP		0x11
+#define   ICL_PCODE_EXIT_TCCOLD			0x12
 #define   HSW_PCODE_DE_WRITE_FREQ_REQ		0x17
 #define   DISPLAY_IPS_CONTROL			0x19
             /* See also IPS_CTL */
Signature · 1 line
2.23.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#7 lore raw
Quoted 145 lines · Imre Deak
Quoted 122 lines · Jose
Quoted 77 lines · Imre Deak
Quoted 75 lines · José Roberto de Souza

This is required for legacy/static TC ports as IOM is not aware of
the connection and will not trigger the TC cold exit.

BSpec: 21750
BSpsc: 49294

---
 drivers/gpu/drm/i915/display/intel_tc.c | 34
++++++++++++++++++++-
----
 drivers/gpu/drm/i915/i915_reg.h         |  1 +
 2 files changed, 29 insertions(+), 6 deletions(-)
drivers/gpu/drm/i915/display/intel_tc.c +1 -0
index 7773169b7331..09b78027bdd5 100644
@@ -7,6 +7,7 @@
 #include "intel_display.h"
 #include "intel_display_types.h"
 #include "intel_dp_mst.h"
+#include "intel_sideband.h"
 #include "intel_tc.h"
 
 static const char *tc_port_mode_name(enum tc_port_mode mode)
@@ -169,6 +170,22 @@ static void

tc_port_fixup_legacy_flag(struct
intel_digital_port *dig_port,

drivers/gpu/drm/i915/display/intel_tc.c +1 -0
 	dig_port->tc_legacy_port = !dig_port->tc_legacy_port;
 }
 
+static int tc_cold_exit_request(struct drm_i915_private

*dev_priv)

drivers/gpu/drm/i915/display/intel_tc.c +6 -0
+{
+	int ret;
+
+	do {
+		ret = sandybridge_pcode_write_timeout(dev_priv,
+						      ICL_PCODE

_EXIT_TC
COLD, 0,

drivers/gpu/drm/i915/display/intel_tc.c +5 -0
+						      250, 1);
+
+	} while (ret == -EAGAIN);
+
+	DRM_DEBUG_KMS("tccold exit %s\n", ret == 0 ?

"succeeded" :
"failed");

drivers/gpu/drm/i915/display/intel_tc.c +4 -0
+
+	return ret;
+}
+
 static u32 tc_port_live_status_mask(struct intel_digital_port

*dig_port)
{
struct drm_i915_private *i915 = to_i915(dig_port-

Quoted 1 line

base.base.dev);

drivers/gpu/drm/i915/display/intel_tc.c +0 -0
@@ -177,13 +194,21 @@ static u32

tc_port_live_status_mask(struct
intel_digital_port *dig_port)

drivers/gpu/drm/i915/display/intel_tc.c +1 -0
 	u32 mask = 0;
 	u32 val;
 
+	if (intel_uncore_read(uncore, SDEISR) &

SDE_TC_HOTPLUG_ICP(tc_port))

drivers/gpu/drm/i915/display/intel_tc.c +2 -0
+		mask |= BIT(TC_PORT_LEGACY);
+
 	val = intel_uncore_read(uncore,
 				PORT_TX_DFLEXDPSP(dig_port-
Quoted 1 line

tc_phy_fia));

Quoted 7 lines

drivers/gpu/drm/i915/display/intel_tc.c static u32 tc_port_live_status_mask(struct intel_digital_port *dig_port) · line 205

Quoted 7 lines
drivers/gpu/drm/i915/display/intel_tc.c +0 -1
 	if (val == 0xffffffff) {
-		DRM_DEBUG_KMS("Port %s: PHY in TCCOLD, nothing

connected\n",

drivers/gpu/drm/i915/display/intel_tc.c +2 -2
-			      dig_port->tc_port_name);
-		return mask;
+		if (mask)
+			tc_cold_exit_request(i915);

Sorry for the delay, was OOO.

Quoted 16 lines

The semantic of the mbox command this needs is inherently racy on systems with preemption, the instruction to use it is:

"""
Issue GT Driver mailbox command to exit TCCOLD, then complete steps
b-d
within 500 milliseconds to prevent re-entry.
"""

We'd have to reach the point where we enable the AUX power in 500ms,
which can't be guaranteed. Moreover TCCOLD could be entered just after
reading PORT_TX_DFLEXDPSP, so we may not detect it.

Quoted 8 lines

What we can do - after discussing with HW folks - is to first request
AUX power and then issue the mbox command, which prevents TCCOLD re-entry until releasing the AUX power request. This also needs ignoring
the timeout of the AUX power enabling ACK, since it will only be ACKed
after exiting TCCOLD.

Huum looks more robust indeed.

Quoted 6 lines

So I think we should block TCCOLD this way in
__intel_tc_port_lock():

	if tc_link_refcount==0:
		intel_display_power_get(POWER_DOMAIN_AUX_<port>)
		tc_cold_exit_request()
Quoted 6 lines

So for non-legacy the IOM request to exit TCCOLD could have timed out
at this point. But for most cases this will not happen, why not here
read one FIA register and check if == 0xffffffff if so we call tc_cold_exit_request().

That would be racy, TCCOLD could be entered right after doing the FIA reg check. Getting the AUX power ref alone won't prevent a TCCOLD entry
until the PCODE command has completed.

Quoted 9 lines
Quoted 4 lines
		if intel_tc_port_needs_reset():
			intel_tc_port_reset_mode()
		if tc_mode != LEGACY:
			intel_display_power_put(POWER_DOMAIN_AUX_<port>

Also why power_put() for non-legacy? a preemption could happen after
lock() and cause a TCCOLD before the needed reads/writes to FIA is done.

Quoted 8 lines

The new PCODE command was only added for legacy and the AUX power reference makes a difference only in that mode. In DP-alt mode the DPCSSS.DPPMSTC flag prevents TCCOLD.

In TBT mode the TBT AUX power ref would not prevent TCCOLD. In that mode
we don't access FIA regs afterwards and
"the TBT controller prevents TCCOLD while it uses the connection".

Makes sense, well the only doubt that I have is if getting POWER_DOMAIN_AUX_<port>_TBT will prevent TCCOLD for legacy and alt- mode, as at this point we still don't know if it is alt-mode, TBT or legacy(we know that is legacy but live status could be reporting something else tc_port_fixup_legacy_flag())

Quoted 45 lines
Quoted 45 lines

Better remove this block and only power_put() when removing the last
reference on intel_tc_port_unlock()

Quoted 40 lines

)

then unblock TCCOLD in intel_tc_port_unlock():

	if tc_link_refcount==0 and tc_mode == LEGACY:
		intel_display_power_put(POWER_DOMAIN_AUX_<port>)
Quoted 33 lines
drivers/gpu/drm/i915/display/intel_tc.c +3 -0
+
+		if (val == 0xffffffff) {
+			DRM_DEBUG_KMS("Port %s: PHY in TCCOLD,

nothing
connected\n",

drivers/gpu/drm/i915/display/intel_tc.c +3 -3
+				      dig_port->tc_port_name);
+			return mask;
+		}
 	}
 
 	if (val & TC_LIVE_STATE_TBT(dig_port->tc_phy_fia_idx))
@@ -191,9 +216,6 @@ static u32 tc_port_live_status_mask(struct
 intel_digital_port *dig_port)
 	if (val & TC_LIVE_STATE_TC(dig_port->tc_phy_fia_idx))
 		mask |= BIT(TC_PORT_DP_ALT);
 
-	if (intel_uncore_read(uncore, SDEISR) &
 SDE_TC_HOTPLUG_ICP(tc_port))
-		mask |= BIT(TC_PORT_LEGACY);
-
 	/* The sink can be connected only in a single mode. */
drivers/gpu/drm/i915/display/intel_tc.c +0 -0
 	if (!WARN_ON(hweight32(mask) > 1))
 		tc_port_fixup_legacy_flag(dig_port, mask);
drivers/gpu/drm/i915/i915_reg.h +0 -0
index 058aa5ca8b73..35c3724b7fef 100644
@@ -8860,6 +8860,7 @@ enum {
 #define     ICL_PCODE_MEM_SS_READ_QGV_POINT_INFO(point)	

(((poin
t) << 16) | (0x1 << 8))
#define GEN6_PCODE_READ_D_COMP 0x10

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
 #define   GEN6_PCODE_WRITE_D_COMP		0x11
+#define   ICL_PCODE_EXIT_TCCOLD			0x12
 #define   HSW_PCODE_DE_WRITE_FREQ_REQ		0x17
 #define   DISPLAY_IPS_CONTROL			0x19
             /* See also IPS_CTL */
Signature · 1 line
2.23.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#8 lore raw
Quoted 4 lines · Jose

[...]
Makes sense, well the only doubt that I have is if getting POWER_DOMAIN_AUX_<port>_TBT will prevent TCCOLD for legacy and alt- mode,

Why do we need to care about POWER_DOMAIN_AUX_<port>_TBT? It doesn't affect the TCCOLD state and we shouldn't get it here.

Quoted 3 lines

as at this point we still don't know if it is alt-mode, TBT or legacy(we know that is legacy but live status could be reporting something else tc_port_fixup_legacy_flag())

We enable the non-TBT AUX power and then drop after the mode is already known and it's other than legacy.

--Imre
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx