rdma: Relax requirement to have PID for HW objects
Subsystems (3)
PATCH 1/1 rdma: Relax requirement to have PID for HW objects
From: Leon Romanovsky <[email protected]>
RDMA has weak connection between PIDs and HW objects, because the latter tied to file descriptors for their lifetime management.
The outcome of such connection is that for the following scenario, the returned PID will be 0 (not-valid):
1. Create FD and context
2. Share it with ephemeral child
3. Create any object and exit that child
This flow was revealed in testing environment and of course real users are not running such scenario, because it makes no sense at all in RDMA world.
Let's do two changes in the code to support such workflow anyway:
1. Remove need to provide PID/kernel name. Code already supports it, just need to remove extra validation.
2. Ball-out in case PID is 0.
--- rdma/res-cmid.c | 5 +---- rdma/res-cq.c | 5 +---- rdma/res-mr.c | 5 +---- rdma/res-pd.c | 5 +---- rdma/res-qp.c | 5 +---- rdma/res.c | 3 +++ 6 files changed, 8 insertions(+), 20 deletions(-)
rdma/res-cmid.c +1 -4
@@ -120,11 +120,8 @@ static int res_cm_id_line(struct rd *rd, const char *name, int idx,char *comm =NULL ;if (!nla_line[RDMA_NLDEV_ATTR_RES_STATE ] || - !nla_line[RDMA_NLDEV_ATTR_RES_PS ] || - (!nla_line[RDMA_NLDEV_ATTR_RES_PID ] && - !nla_line[RDMA_NLDEV_ATTR_RES_KERN_NAME ])) { + !nla_line[RDMA_NLDEV_ATTR_RES_PS ])return MNL_CB_ERROR ; - }if (nla_line[RDMA_NLDEV_ATTR_PORT_INDEX ]) port =mnl_attr_get_u32 (nla_line[RDMA_NLDEV_ATTR_PORT_INDEX ]);
rdma/res-cq.c +1 -4
@@ -56,11 +56,8 @@ static int res_cq_line(struct rd *rd, const char *name, int idx,uint32_t cqe;if (!nla_line[RDMA_NLDEV_ATTR_RES_CQE ] || - !nla_line[RDMA_NLDEV_ATTR_RES_USECNT ] || - (!nla_line[RDMA_NLDEV_ATTR_RES_PID ] && - !nla_line[RDMA_NLDEV_ATTR_RES_KERN_NAME ])) { + !nla_line[RDMA_NLDEV_ATTR_RES_USECNT ])return MNL_CB_ERROR ; - } cqe =mnl_attr_get_u32 (nla_line[RDMA_NLDEV_ATTR_RES_CQE ]);
rdma/res-mr.c +1 -4
@@ -17,11 +17,8 @@ static int res_mr_line(struct rd *rd, const char *name, int idx,uint32_t mrn =0 ;uint32_t pid =0 ; -if (!nla_line[RDMA_NLDEV_ATTR_RES_MRLEN ] || - (!nla_line[RDMA_NLDEV_ATTR_RES_PID ] && - !nla_line[RDMA_NLDEV_ATTR_RES_KERN_NAME ])) { +if (!nla_line[RDMA_NLDEV_ATTR_RES_MRLEN ])return MNL_CB_ERROR ; - }if (nla_line[RDMA_NLDEV_ATTR_RES_RKEY ]) rkey =mnl_attr_get_u32 (nla_line[RDMA_NLDEV_ATTR_RES_RKEY ]);
rdma/res-pd.c +1 -4
@@ -17,11 +17,8 @@ static int res_pd_line(struct rd *rd, const char *name, int idx,uint32_t pdn =0 ;uint64_t users; -if (!nla_line[RDMA_NLDEV_ATTR_RES_USECNT ] || - (!nla_line[RDMA_NLDEV_ATTR_RES_PID ] && - !nla_line[RDMA_NLDEV_ATTR_RES_KERN_NAME ])) { +if (!nla_line[RDMA_NLDEV_ATTR_RES_USECNT ])return MNL_CB_ERROR ; - }if (nla_line[RDMA_NLDEV_ATTR_RES_LOCAL_DMA_LKEY ]) local_dma_lkey = mnl_attr_get_u32(
rdma/res-qp.c +1 -4
@@ -90,11 +90,8 @@ static int res_qp_line(struct rd *rd, const char *name, int idx,if (!nla_line[RDMA_NLDEV_ATTR_RES_LQPN ] || !nla_line[RDMA_NLDEV_ATTR_RES_SQ_PSN ] || !nla_line[RDMA_NLDEV_ATTR_RES_TYPE ] || - !nla_line[RDMA_NLDEV_ATTR_RES_STATE ] || - (!nla_line[RDMA_NLDEV_ATTR_RES_PID ] && - !nla_line[RDMA_NLDEV_ATTR_RES_KERN_NAME ])) { + !nla_line[RDMA_NLDEV_ATTR_RES_STATE ])return MNL_CB_ERROR ; - }if (nla_line[RDMA_NLDEV_ATTR_PORT_INDEX ]) port =mnl_attr_get_u32 (nla_line[RDMA_NLDEV_ATTR_PORT_INDEX ]);
rdma/res.c +3 -0
@@ -211,6 +211,9 @@ char *get_task_name(uint32_t pid)char *comm;FILE *f; +if (!pid) +return NULL ; +if (asprintf (&comm,"/proc/%d/comm" , pid) <0 )return NULL ;
Signature · 1 line
2.20.1
David Ahern
AppliedQuoted 22 lines · Leon Romanovsky
From: Leon Romanovsky <[email protected]>
RDMA has weak connection between PIDs and HW objects, because the latter tied to file descriptors for their lifetime management.
The outcome of such connection is that for the following scenario, the returned PID will be 0 (not-valid):
1. Create FD and context
2. Share it with ephemeral child
3. Create any object and exit that childThis flow was revealed in testing environment and of course real users are not running such scenario, because it makes no sense at all in RDMA world.
Let's do two changes in the code to support such workflow anyway:
1. Remove need to provide PID/kernel name. Code already supports it, just need to remove extra validation.
2. Ball-out in case PID is 0.
Quoted 9 lines
--- rdma/res-cmid.c | 5 +---- rdma/res-cq.c | 5 +---- rdma/res-mr.c | 5 +---- rdma/res-pd.c | 5 +---- rdma/res-qp.c | 5 +---- rdma/res.c | 3 +++ 6 files changed, 8 insertions(+), 20 deletions(-)
applied to iproute2-next