btrfs: fix uninitialized ret in ref-verify
PATCH 1/1 btrfs: fix uninitialized ret in ref-verify
Coverity caught a case where we could return with a uninitialized value in ret in process_leaf. This is actually pretty likely because we could very easily run into a block group item key and have a garbage value in ret and think there was an errror. Fix this by initializing ret to 0.
--- fs/btrfs/ref-verify.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/btrfs/ref-verify.c +1 -1
@@ -500,7 +500,7 @@ static int process_leaf(struct btrfs_root *root,struct btrfs_extent_data_ref *dref;struct btrfs_shared_data_ref *sref;u32 count; -int i =0 , tree_block_level =0 , ret; +int i =0 , tree_block_level =0 , ret =0 ;struct btrfs_key key;int nritems =btrfs_header_nritems (leaf);
Signature · 1 line
2.21.0
Quoted 7 lines · Josef Bacik
Coverity caught a case where we could return with a uninitialized value in ret in
process_leaf. This is actually pretty likely because we could very easily run into a block group item key and have a garbage value in ret and think there was an errror. Fix this by initializing ret to 0.Reported-by Colin Ian King <[email protected]>Signed-off-by Josef Bacik <[email protected]>
Added to misc-next, thanks.
Quoted 17 lines · Josef Bacik
Coverity caught a case where we could return with a uninitialized value in ret in
process_leaf. This is actually pretty likely because we could very easily run into a block group item key and have a garbage value in ret and think there was an errror. Fix this by initializing ret to 0.Reported-by Colin Ian King <[email protected]>Signed-off-by Josef Bacik <[email protected]>--- fs/btrfs/ref-verify.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)fs/btrfs/ref-verify.c +0
-0
fs/btrfs/ref-verify.c static int process_leaf(struct btrfs_root *root, · line 506
Quoted 8 lines
fs/btrfs/ref-verify.c +1
-1@@ -500,7 +500,7 @@ static int process_leaf(struct btrfs_root *root,struct btrfs_extent_data_ref *dref;struct btrfs_shared_data_ref *sref;u32 count; -int i =0 , tree_block_level =0 , ret; +int i =0 , tree_block_level =0 , ret =0 ;struct btrfs_key key;int nritems =btrfs_header_nritems (leaf);
Thanks Josef.