Skip to contentSkip to conversation

sh: kgdb: fix an implicit fallthrough warning

PATCH In review Bartosz Golaszewski 2 participants 2 messages Oct 2, 2019 – Oct 3, 2019 SuperH

lore
Share & tools
lore

Bartosz Golaszewski

author
#0 lore raw

PATCH 1/1 sh: kgdb: fix an implicit fallthrough warning

From: Bartosz Golaszewski <[email protected]>

The switch case in arch/sh/kernel/kgdb.c can fallthrough. Add an appropriate comment.

Signed-off-by Bartosz Golaszewski <[email protected]>
---
 arch/sh/kernel/kgdb.c | 1 +
 1 file changed, 1 insertion(+)
arch/sh/kernel/kgdb.c +1 -0
index 6d61f8cf4c13..0d5f3c9d52f3 100644
@@ -266,6 +266,7 @@ int kgdb_arch_handle_exception(int e_vector, int signo, int err_code,
 		ptr = &remcomInBuffer[1];
 		if (kgdb_hex2long(&ptr, &addr))
 			linux_regs->pc = addr;
+		/* fallthrough */
 	case 'D':
 	case 'k':
 		atomic_set(&kgdb_cpu_doing_single_step, -1);
Signature · 1 line
2.23.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

The switch case in arch/sh/kernel/kgdb.c can fallthrough. Add an appropriate comment.

Signed-off-by Bartosz Golaszewski <[email protected]>
Reviewed-by Daniel Thompson <[email protected]>
Quoted 19 lines
---
 arch/sh/kernel/kgdb.c | 1 +
 1 file changed, 1 insertion(+)
arch/sh/kernel/kgdb.c +1 -0
index 6d61f8cf4c13..0d5f3c9d52f3 100644
@@ -266,6 +266,7 @@ int kgdb_arch_handle_exception(int e_vector, int signo, int err_code,
 		ptr = &remcomInBuffer[1];
 		if (kgdb_hex2long(&ptr, &addr))
 			linux_regs->pc = addr;
+		/* fallthrough */
 	case 'D':
 	case 'k':
 		atomic_set(&kgdb_cpu_doing_single_step, -1);
Signature · 1 line
2.23.0