Skip to contentSkip to conversation

Update dynamic_debug grep check

PATCH New rasibley 3 participants 3 messages Oct 4, 2019 – Oct 7, 2019

lore
Share & tools
lore

rasibley

author
#0 lore raw

PATCH 1/1 Update dynamic_debug grep check

If running on debug kernel this check will fail on EDAC DEBUG messages, update grep to ignore such cases like this.

---
 testcases/kernel/tracing/dynamic_debug/dynamic_debug01.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
testcases/kernel/tracing/dynamic_debug/dynamic_debug01.sh +1 -1
index f39d67d0a..7f06c2488 100755
@@ -127,7 +127,7 @@ ddebug_test()
 	sed -i -e 1,`wc -l < ./dmesg.old`d ./dmesg.new
 	if grep -q -e "Kernel panic" -e "Oops" -e "general protection fault" \
 		-e "general protection handler: wrong gs" -e "\(XEN\) Panic" \
-		-e "fault" -e "warn" -e "BUG" ./dmesg.new ; then
+		-e "fault" -e "warn" -e "\<BUG\>" ./dmesg.new ; then
 		tst_res TFAIL "Issues found in dmesg!"
 	else
 		tst_res TPASS "Dynamic debug OK"
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 Update dynamic_debug grep check

Hi!

Quoted 2 lines

If running on debug kernel this check will fail on EDAC DEBUG messages, update grep to ignore such cases like this.

You are missing the Signed-off-by: line here, see:

https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#developer-s-certificate-of-origin-1-1

Otherwise the patch is Ok.

Quoted 23 lines
---
 testcases/kernel/tracing/dynamic_debug/dynamic_debug01.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
testcases/kernel/tracing/dynamic_debug/dynamic_debug01.sh +1 -1
index f39d67d0a..7f06c2488 100755
@@ -127,7 +127,7 @@ ddebug_test()
 	sed -i -e 1,`wc -l < ./dmesg.old`d ./dmesg.new
 	if grep -q -e "Kernel panic" -e "Oops" -e "general protection fault" \
 		-e "general protection handler: wrong gs" -e "\(XEN\) Panic" \
-		-e "fault" -e "warn" -e "BUG" ./dmesg.new ; then
+		-e "fault" -e "warn" -e "\<BUG\>" ./dmesg.new ; then
 		tst_res TFAIL "Issues found in dmesg!"
 	else
 		tst_res TPASS "Dynamic debug OK"
Signature · 5 lines
2.20.1


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
Signature · 2 lines
Cyril Hrubis
[email protected]
#2 lore raw

PATCH 1/1 Update dynamic_debug grep check

----- Original Message -----

Quoted 6 lines

From: "Cyril Hrubis" <[email protected]>
To: "rasibley" <[email protected]>
Cc: [email protected]
Sent: Monday, 7 October, 2019 4:03:21 PM
Subject: Re: [LTP] [PATCH] Update dynamic_debug grep check

Quoted 7 lines

Hi!

Quoted 2 lines

If running on debug kernel this check will fail on EDAC DEBUG messages, update grep to ignore such cases like this.

You are missing the Signed-off-by: line here, see:

https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#developer-s-certificate-of-origin-1-1

You can also use kernel scripts/checkpatch.pl.

Quoted 2 lines

Otherwise the patch is Ok.

Pushed with added Signed-off-by and tweaked commit message.

Thanks,
Jan