Skip to contentSkip to conversation

MAINTAINERS: Add Vladimir as a reviewer for bitmaps

PATCH Applied John Snow 2 participants 4 messages Oct 5, 2019 – Oct 9, 2019

lore
Share & tools
lore

John Snow

author
#0 lore raw

cover MAINTAINERS: Add Vladimir as a reviewer for bitmaps

Hi; I'll be going away on an extended trip this November and have made arrangements for reviews to be handled in my absence. I've asked Vladimir to take point on any reviews for patches he didn't author, and have asked Eric to take point on reviewing any of Vladimir's patches for this tree.

Because Virtuozzo contributes so heavily to this area, I've always liked to get Vladimir's approval on patches before merging them anyway, so this change formalizes the existing practice.

John Snow (1):
MAINTAINERS: Add Vladimir as a reviewer for bitmaps

 MAINTAINERS | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Signature · 1 line
2.21.0
author
#1 lore raw

PATCH 1/1 MAINTAINERS: Add Vladimir as a reviewer for bitmaps

I already try to make sure all bitmaps patches have been reviewed by both Red Hat and Virtuozzo anyway, so this formalizes the arrangement.

Fam meanwhile is no longer as active, so I am removing him as a co-maintainer simply to reflect the current practice.

---
 MAINTAINERS | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
MAINTAINERS +1 -2
index 21264eae9c4..87e80ae110c 100644
@@ -1818,8 +1818,8 @@ F: qapi/transaction.json
 T: git https://repo.or.cz/qemu/armbru.git block-next
 
 Dirty Bitmaps
-M: Fam Zheng <[email protected]>
 M: John Snow <[email protected]>
+R: Vladimir Sementsov-Ogievskiy <[email protected]>
 L: [email protected]
 S: Supported
 F: util/hbitmap.c
@@ -1828,7 +1828,6 @@ F: include/qemu/hbitmap.h
 F: include/block/dirty-bitmap.h
 F: tests/test-hbitmap.c
 F: docs/interop/bitmaps.rst
-T: git https://github.com/famz/qemu.git bitmaps
 T: git https://github.com/jnsnow/qemu.git bitmaps
 
 Character device backends
Signature · 1 line
2.21.0
Reviewed-by on v1 1/1
#2 lore raw
Quoted 7 lines · John Snow

I already try to make sure all bitmaps patches have been reviewed by both Red Hat and Virtuozzo anyway, so this formalizes the arrangement.

Fam meanwhile is no longer as active, so I am removing him as a co-maintainer simply to reflect the current practice.

Quoted 27 lines
---
  MAINTAINERS | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)
MAINTAINERS +1 -2
index 21264eae9c4..87e80ae110c 100644
@@ -1818,8 +1818,8 @@ F: qapi/transaction.json
  T: git https://repo.or.cz/qemu/armbru.git block-next
 
  Dirty Bitmaps
-M: Fam Zheng <[email protected]>
  M: John Snow <[email protected]>
+R: Vladimir Sementsov-Ogievskiy <[email protected]>
  L: [email protected]
  S: Supported
  F: util/hbitmap.c
@@ -1828,7 +1828,6 @@ F: include/qemu/hbitmap.h
  F: include/block/dirty-bitmap.h
  F: tests/test-hbitmap.c
  F: docs/interop/bitmaps.rst
-T: git https://github.com/famz/qemu.git bitmaps
  T: git https://github.com/jnsnow/qemu.git bitmaps
 
  Character device backends
Signature · 2 lines
Best regards,
Vladimir
author Applied
#3 lore raw
In reply to John Snow
Quoted 9 lines · John Snow

Hi; I'll be going away on an extended trip this November and have made arrangements for reviews to be handled in my absence. I've asked Vladimir to take point on any reviews for patches he didn't author, and have asked Eric to take point on reviewing any of Vladimir's patches for this tree.

Because Virtuozzo contributes so heavily to this area, I've always liked to get Vladimir's approval on patches before merging them anyway, so this change formalizes the existing practice.

Quoted 6 lines

John Snow (1):
MAINTAINERS: Add Vladimir as a reviewer for bitmaps

 MAINTAINERS | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Thanks, applied to my bitmaps tree:

https://github.com/jnsnow/qemu/commits/bitmaps
https://github.com/jnsnow/qemu.git

--js