Skip to contentSkip to conversation

Patch "clk: jz4740: Add TCU clock" has been added to the 4.4-stable tree

DISCUSSION Paul Cercueil 2 participants 2 messages Oct 6, 2019 1 message not in the archive Stable branch

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Paul Cercueil

author
#1 lore raw

Hi Sasha,

I think this patch shouldn't be added to the stable trees; it will cause the TCU clock to be managed by the clock framework and automatically gated after bootup since it has no client, causing a global system lockup. It's only really applicable to 5.3.

Thanks,
-Paul

Quoted 84 lines · Sasha Levin

This is a note to let you know that I've just added the patch titled

clk: jz4740: Add TCU clock

to the 4.4-stable tree which can be found at:

http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:

     clk-jz4740-add-tcu-clock.patch

and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

commit c72b7e327a8b4d3b870f76011f674134f9ac38f6

Author: Paul Cercueil <[email protected]>
Date:   Wed Jul 24 13:16:10 2019 -0400

clk: jz4740: Add TCU clock

[ Upstream commit 73dd11dc1a883d4c994d729dc9984f4890001157 ]

Add the missing TCU clock to the list of clocks supplied by the
CGU for
the JZ4740 SoC.

Signed-off-by Paul Cercueil <[email protected]>
Tested-by Mathieu Malaterre <[email protected]>
Tested-by Artur Rojek <[email protected]>
Acked-by Stephen Boyd <[email protected]>
Acked-by Rob Herring <[email protected]>
Signed-off-by Paul Burton <[email protected]>
Cc Ralf Baechle <[email protected]>
Cc James Hogan <[email protected]>
Cc Jonathan Corbet <[email protected]>
Cc Lee Jones <[email protected]>
Cc Arnd Bergmann <[email protected]>
Cc Daniel Lezcano <[email protected]>
Cc Thomas Gleixner <[email protected]>
Cc Michael Turquette <[email protected]>
Cc Jason Cooper <[email protected]>
Cc Marc Zyngier <[email protected]>
Cc Rob Herring <[email protected]>
Cc Mark Rutland <[email protected]>
Cc [email protected]
Cc [email protected]
Cc [email protected]
Cc [email protected]
Cc [email protected]
Cc [email protected]
Signed-off-by Sasha Levin <[email protected]>
drivers/clk/ingenic/jz4740-cgu.c +6 -0
index 305a26c2a800e..01b5b8b103888 100644
@@ -211,6 +211,12 @@ static const struct ingenic_cgu_clk_info 
 jz4740_cgu_clocks[] = {
 		.parents = { JZ4740_CLK_EXT, -1, -1, -1 },
 		.gate = { CGU_REG_CLKGR, 5 },
 	},
+
+	[JZ4740_CLK_TCU] = {
+		"tcu", CGU_CLK_GATE,
+		.parents = { JZ4740_CLK_EXT, -1, -1, -1 },
+		.gate = { CGU_REG_CLKGR, 1 },
+	},
 };

static void __init jz4740_cgu_init(struct device_node *np)

include/dt-bindings/clock/jz4740-cgu.h +1 -0
index 43153d3e9bd26..ff7c27bc98e37 100644
@@ -33,5 +33,6 @@
 #define JZ4740_CLK_ADC		19
 #define JZ4740_CLK_I2C		20
 #define JZ4740_CLK_AIC		21
+#define JZ4740_CLK_TCU		22
 
 #endif /* __DT_BINDINGS_CLOCK_JZ4740_CGU_H__ */
#2 lore raw
Quoted 6 lines · Paul Cercueil

Hi Sasha,

I think this patch shouldn't be added to the stable trees; it will cause the TCU clock to be managed by the clock framework and automatically gated after bootup since it has no client, causing a global system lockup. It's only really applicable to 5.3.

Now dropped from everywhere, thanks!

greg k-h