mtd: spi-nor: add support for en25qh16
Subsystems (2)
PATCH 1/1 mtd: spi-nor: add support for en25qh16
Tested on HiWiFi C526A
Datasheet is available at:
http://www.xinyahong.com/upLoad/product/month_1411/201411201256018276.pdf
--- drivers/mtd/spi-nor/spi-nor.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/mtd/spi-nor/spi-nor.c +2 -0
@@ -2179,6 +2179,8 @@ static const struct flash_info spi_nor_ids[] = { { "en25q64", INFO(0x1c3017, 0, 64 * 1024, 128, SECT_4K) }, { "en25q80a", INFO(0x1c3014, 0, 64 * 1024, 16, SECT_4K | SPI_NOR_DUAL_READ) }, + { "en25qh16", INFO(0x1c7015, 0, 64 * 1024, 32, + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, { "en25qh32", INFO(0x1c7016, 0, 64 * 1024, 64, 0) }, { "en25qh64", INFO(0x1c7017, 0, 64 * 1024, 128, SECT_4K | SPI_NOR_DUAL_READ) },
Signature · 6 lines
2.23.0 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
Hi, Deng,
Quoted 18 lines · Deng Qingfang
External E-Mail
Tested on HiWiFi C526A
Datasheet is available at:
http://www.xinyahong.com/upLoad/product/month_1411/201411201256018276.pdfSigned-off-by Deng Qingfang <[email protected]>--- drivers/mtd/spi-nor/spi-nor.c | 2 ++ 1 file changed, 2 insertions(+)drivers/mtd/spi-nor/spi-nor.c +0
-0
drivers/mtd/spi-nor/spi-nor.c static const struct flash_info spi_nor_ids[] = { · line 2183
Quoted 5 lines
drivers/mtd/spi-nor/spi-nor.c +2
-0@@ -2179,6 +2179,8 @@ static const struct flash_info spi_nor_ids[] = { { "en25q64", INFO(0x1c3017, 0, 64 * 1024, 128, SECT_4K) }, { "en25q80a", INFO(0x1c3014, 0, 64 * 1024, 16, SECT_4K | SPI_NOR_DUAL_READ) }, + { "en25qh16", INFO(0x1c7015, 0, 64 * 1024, 32, + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
Looks like this flash does not support the SPINOR_OP_READ_1_1_4 (6bh) opcode, so you can't specify the SPI_NOR_QUAD_READ flag.
SPINOR_OP_READ_1_4_4 will be discovered when parsing BFPT, and you'll use that instead.
Would you send a v2 to drop the SPI_NOR_QUAD_READ flag or do you want me to drop it when applying?
Cheers,
ta
drivers/mtd/spi-nor/spi-nor.c static const struct flash_info spi_nor_ids[] = { · line 2186
Quoted 4 lines
drivers/mtd/spi-nor/spi-nor.c +0
-0{ "en25qh32", INFO(0x1c7016, 0, 64 * 1024, 64, 0) }, { "en25qh64", INFO(0x1c7017, 0, 64 * 1024, 128, SECT_4K | SPI_NOR_DUAL_READ) },
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/