Skip to contentSkip to conversation

staging: rtl8723bs: Remove commented code

PATCH Superseded Javier F. Arias 2 participants 2 messages Oct 6, 2019 – Oct 7, 2019 Staging

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8723bs: Remove commented code

Remove commented code for a cleaner file. Issue found by checkpatch.

---
 drivers/staging/rtl8723bs/core/rtw_xmit.c | 11 -----------
 1 file changed, 11 deletions(-)
drivers/staging/rtl8723bs/core/rtw_xmit.c +0 -11
index 29acbb1ee869..3956c43a6468 100644
@@ -2689,18 +2689,7 @@ void wakeup_sta_to_xmit(struct adapter *padapter, struct sta_info *psta)
 		}
 
 		pxmitframe->attrib.triggered = 1;
-
-/*
-		spin_unlock_bh(&psta->sleep_q.lock);
-		if (rtw_hal_xmit(padapter, pxmitframe) == true)
-		{
-			rtw_os_xmit_complete(padapter, pxmitframe);
-		}
-		spin_lock_bh(&psta->sleep_q.lock);
-*/
 		rtw_hal_xmitframe_enqueue(padapter, pxmitframe);
-
-
 	}
 
 	if (psta->sleepq_len == 0) {
Signature · 1 line
2.20.1
#1 lore raw
Quoted 1 line · Javier F. Arias

Remove commented code for a cleaner file. Issue found by checkpatch.

This also removes some blank lines. It would be better to do only onething at a time, and in any case to mention everything that is done in the commit log.

julia

Quoted 37 lines
---
 drivers/staging/rtl8723bs/core/rtw_xmit.c | 11 -----------
 1 file changed, 11 deletions(-)
drivers/staging/rtl8723bs/core/rtw_xmit.c +0 -12
index 29acbb1ee869..3956c43a6468 100644
@@ -2689,18 +2689,7 @@ void wakeup_sta_to_xmit(struct adapter *padapter, struct sta_info *psta)
 		}
 
 		pxmitframe->attrib.triggered = 1;
-
-/*
-		spin_unlock_bh(&psta->sleep_q.lock);
-		if (rtw_hal_xmit(padapter, pxmitframe) == true)
-		{
-			rtw_os_xmit_complete(padapter, pxmitframe);
-		}
-		spin_lock_bh(&psta->sleep_q.lock);
-*/
 		rtw_hal_xmitframe_enqueue(padapter, pxmitframe);
-
-
 	}
 
 	if (psta->sleepq_len == 0) {
--

2.20.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191006224551.GA3551%40gmail.com.