media: vimc: Fix error return code in vimc_register_devices()
Subsystems (2)
PATCH 1/1 media: vimc: Fix error return code in vimc_register_devices()
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function.
Fixes f13d5f361959 ("media: vimc: Collapse component structure into a single monolithic driver")
Signed-off-by Wei Yongjun <[email protected]>
--- drivers/media/platform/vimc/vimc-core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/media/platform/vimc/vimc-core.c +3 -1
@@ -202,8 +202,10 @@ static int vimc_register_devices(struct vimc_device *vimc) vimc->ent_devs =kmalloc_array (vimc->pipe_cfg->num_ents,sizeof (*vimc->ent_devs),GFP_KERNEL ); -if (!vimc->ent_devs) +if (!vimc->ent_devs) { + ret = -ENOMEM ; goto err_v4l2_unregister; + }/* Invoke entity config hooks to initialize and register subdevs */ ret =vimc_add_subdevs (vimc);
Hi,
Quoted 5 lines · Wei Yongjun
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function.
Fixes f13d5f361959 ("media: vimc: Collapse component structure into a single monolithic driver")Signed-off-by Wei Yongjun <[email protected]>
Acked-by Helen Koike <[email protected]>
Thank you
Helen
Quoted 23 lines
--- drivers/media/platform/vimc/vimc-core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)drivers/media/platform/vimc/vimc-core.c +3
-1@@ -202,8 +202,10 @@ static int vimc_register_devices(struct vimc_device *vimc) vimc->ent_devs =kmalloc_array (vimc->pipe_cfg->num_ents,sizeof (*vimc->ent_devs),GFP_KERNEL ); -if (!vimc->ent_devs) +if (!vimc->ent_devs) { + ret = -ENOMEM ; goto err_v4l2_unregister; + }/* Invoke entity config hooks to initialize and register subdevs */ ret =vimc_add_subdevs (vimc);