Skip to contentSkip to conversation

usb: dwc3: dwc3-meson-g12a.c: use devm_platform_ioremap_resource()

PATCH Kevin Hilman 3 participants 3 messages Oct 8, 2019 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

Kevin Hilman

author maintainer Reviewed-by
#1 lore raw
In reply to a message not in the archive
Quoted 4 lines · Saurav Girepunje

Use the new helper that wraps the calls to platform_get_resource() and devm_ioremap_resource() together in dwc3_meson_g12a_probe().

Quoted 28 lines
---
 drivers/usb/dwc3/dwc3-meson-g12a.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/usb/dwc3/dwc3-meson-g12a.c +1 -3
index bca7e92a10e9..d73ccd9e1366 100644
@@ -386,7 +386,6 @@ static int dwc3_meson_g12a_probe(struct platform_device *pdev)
 	struct device		*dev = &pdev->dev;
 	struct device_node	*np = dev->of_node;
 	void __iomem *base;
-	struct resource *res;
 	enum phy_mode otg_id;
 	int ret, i, irq;
 
@@ -394,8 +393,7 @@ static int dwc3_meson_g12a_probe(struct platform_device *pdev)
 	if (!priv)
 		return -ENOMEM;
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	base = devm_ioremap_resource(dev, res);
+	base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(base))
 		return PTR_ERR(base);
 
Signature · 1 line
2.20.1
#2 lore raw

Hi Saurav,

Quoted 7 lines · Kevin Hilman
Quoted 4 lines · Saurav Girepunje

Use the new helper that wraps the calls to platform_get_resource() and devm_ioremap_resource() together in dwc3_meson_g12a_probe().

the following commit is already in mainline:

commit c6e4999cd930b8bd11dd8d4767e871b47f502845

Author: YueHaibing <[email protected]>
Date:   Fri Aug 2 21:04:08 2019 +0800

usb: dwc3: meson-g12a: use devm_platform_ioremap_resource() to simplify code

Martin

#3 lore raw
Quoted 12 lines · Martin Blumenstingl

Hi Saurav,

Quoted 7 lines · Kevin Hilman
Quoted 4 lines · Saurav Girepunje

Use the new helper that wraps the calls to platform_get_resource() and devm_ioremap_resource() together in dwc3_meson_g12a_probe().

the following commit is already in mainline:

Quoted 7 lines

commit c6e4999cd930b8bd11dd8d4767e871b47f502845

Author: YueHaibing <[email protected]>
Date:   Fri Aug 2 21:04:08 2019 +0800

usb: dwc3: meson-g12a: use devm_platform_ioremap_resource() to simplify code

Martin

Ok...Thanks for the information.