Skip to contentSkip to conversation

configs/imx6-sabresd_qt5: Move from mdev to eudev

PATCH New Fabio Estevam 3 participants 12 messages Oct 9, 2019 – Oct 16, 2019 Arm i.MX and Layerscape

lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH v2 1/4 configs/imx6-sabresd_qt5: Move from mdev to eudev

Since commit cf66a67112cd706d2e7 ("package/glmark2: drm support needs udev") udev is needed when the drm flavor is used.

Move from mdev to eudev in order to fix the following glmark2 build failure:

Unknown flavor: . Supported flavors are dispmanx-glesv2, drm-gl, drm-glesv2, mir-gl, mir-glesv2, wayland-gl, wayland-glesv2, win32-gl, win32-glesv2, x11-gl, x11-glesv2

---
Changes since v1:
- Fix Subject and commit log: from mdev to eudev

 configs/imx6-sabresd_qt5_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configs/imx6-sabresd_qt5_defconfig +1 -1
index 4616f57eae..a2925bd056 100644
@@ -95,4 +95,4 @@ BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_VIDEOPARSERS=y
 BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_KMS=y
 
 # For automatic kernel module loading
-BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV=y
+BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_EUDEV=y
Signature · 1 line
2.17.1
author reviewer
#1 lore raw

PATCH v2 2/4 configs/imx6-sabresd_qt5: Select the KMSRO gallium driver

After migrating to Mesa 19.2 the imx-drm_dri.so is no longer installed unless the kmsro gallium driver is selected, so explicitly select BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_KMSRO to fix the problem.

---
Changes since v1:
- None

 configs/imx6-sabresd_qt5_defconfig | 1 +
 1 file changed, 1 insertion(+)
configs/imx6-sabresd_qt5_defconfig +1 -0
index a2925bd056..887e53dc21 100644
@@ -48,6 +48,7 @@ BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
 # GL driver
 BR2_PACKAGE_MESA3D=y
 BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_ETNAVIV=y
+BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_KMSRO=y
 BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_SWRAST=y
 BR2_PACKAGE_MESA3D_OPENGL_ES=y
 
Signature · 1 line
2.17.1
author reviewer
#7 lore raw

PATCH v2 3/4 imx6-sabresd/readme.txt: Improve Qt5 Cinematic Demo instructions

In reply to Fabio Estevam

QT_QPA_EGLFS_ALWAYS_SET_MODE=1 needs to be exported, otherwise the Qt5 Cinematic demo throws a storm of the following messages:

Could not queue DRM page flip on screen LVDS1 (Invalid argument)

Improve the instructions by mentioning such requirement.

---
Changes since v1:
- None

 board/freescale/imx6-sabresd/readme.txt | 1 +
 1 file changed, 1 insertion(+)
board/freescale/imx6-sabresd/readme.txt +1 -0
index f09ff5caf4..292dab72c4 100644
@@ -80,6 +80,7 @@ Running kmscube application:
 Running Qt5 Cinematic Demo:
 
 # export QT_QPA_EGLFS_KMS_CONFIG=/root/sabresd.json
+# export QT_QPA_EGLFS_ALWAYS_SET_MODE=1
 # /usr/share/Qt5/CinematicExperience/Qt5_CinematicExperience
 
 Running gl2mark benchmark:
Signature · 1 line
2.17.1
author reviewer
#9 lore raw

PATCH v2 4/4 configs/imx6-sabresd: Bump U-Boot and kernel versions

In reply to Fabio Estevam

Bump U-Boot to 2019.10 and kernel to 5.3.4 version.

---
Changes since v1:
- None

 configs/imx6-sabresd_defconfig     | 8 ++++----
 configs/imx6-sabresd_qt5_defconfig | 8 ++++----
 2 files changed, 8 insertions(+), 8 deletions(-)
configs/imx6-sabresd_defconfig +4 -4
index c2924b2e39..0d070e47f8 100644
@@ -4,8 +4,8 @@ BR2_ARM_ENABLE_NEON=y
 BR2_ARM_ENABLE_VFP=y
 BR2_ARM_FPU_VFPV3=y
 
-# Linux headers same as kernel, a 4.19 series
-BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_19=y
+# Linux headers same as kernel, a 5.3 series
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_3=y
 
 # System
 BR2_TARGET_GENERIC_GETTY_PORT="ttymxc0"
@@ -24,7 +24,7 @@ BR2_TARGET_ROOTFS_EXT2_4=y
 BR2_TARGET_UBOOT=y
 BR2_TARGET_UBOOT_BOARDNAME="mx6sabresd"
 BR2_TARGET_UBOOT_CUSTOM_VERSION=y
-BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2018.05"
+BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2019.10"
 BR2_TARGET_UBOOT_FORMAT_IMG=y
 BR2_TARGET_UBOOT_SPL=y
 BR2_TARGET_UBOOT_SPL_NAME="SPL"
@@ -32,7 +32,7 @@ BR2_TARGET_UBOOT_SPL_NAME="SPL"
 # Kernel
 BR2_LINUX_KERNEL=y
 BR2_LINUX_KERNEL_CUSTOM_VERSION=y
-BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.19.16"
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.3.4"
 BR2_LINUX_KERNEL_DEFCONFIG="imx_v6_v7"
 BR2_LINUX_KERNEL_DTS_SUPPORT=y
 BR2_LINUX_KERNEL_INTREE_DTS_NAME="imx6q-sabresd imx6dl-sabresd imx6qp-sabresd"
configs/imx6-sabresd_qt5_defconfig +4 -4
index 887e53dc21..7a541951ae 100644
@@ -4,8 +4,8 @@ BR2_ARM_ENABLE_NEON=y
 BR2_ARM_ENABLE_VFP=y
 BR2_ARM_FPU_VFPV3=y
 
-# Linux headers same as kernel, a 4.19 series
-BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_19=y
+# Linux headers same as kernel, a 5.3 series
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_3=y
 
 # Additional features needed for packages
 BR2_TOOLCHAIN_BUILDROOT_WCHAR=y
@@ -30,7 +30,7 @@ BR2_ROOTFS_OVERLAY="board/freescale/imx6-sabresd/rootfs_overlay"
 BR2_TARGET_UBOOT=y
 BR2_TARGET_UBOOT_BOARDNAME="mx6sabresd"
 BR2_TARGET_UBOOT_CUSTOM_VERSION=y
-BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2018.05"
+BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2019.10"
 BR2_TARGET_UBOOT_FORMAT_IMG=y
 BR2_TARGET_UBOOT_SPL=y
 BR2_TARGET_UBOOT_SPL_NAME="SPL"
@@ -38,7 +38,7 @@ BR2_TARGET_UBOOT_SPL_NAME="SPL"
 # Kernel
 BR2_LINUX_KERNEL=y
 BR2_LINUX_KERNEL_CUSTOM_VERSION=y
-BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.19.16"
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.3.4"
 BR2_LINUX_KERNEL_DEFCONFIG="imx_v6_v7"
 BR2_LINUX_KERNEL_DTS_SUPPORT=y
 BR2_LINUX_KERNEL_INTREE_DTS_NAME="imx6q-sabresd imx6dl-sabresd imx6qp-sabresd"
Signature · 1 line
2.17.1
#11 lore raw

PATCH v2 1/4 configs/imx6-sabresd_qt5: Move from mdev to eudev

In reply to Fabio Estevam
Quoted 10 lines · On Wed, 9 Oct 2019 14:00:01 -0300 Fabio Estevam <[email protected]> wrote:

Since commit cf66a67112cd706d2e7 ("package/glmark2: drm support needs udev") udev is needed when the drm flavor is used.

Move from mdev to eudev in order to fix the following glmark2 build failure:

Unknown flavor: . Supported flavors are dispmanx-glesv2, drm-gl, drm-glesv2, mir-gl, mir-glesv2, wayland-gl, wayland-glesv2, win32-gl, win32-glesv2, x11-gl, x11-glesv2

Quoted 5 lines

---
Changes since v1:
- Fix Subject and commit log: from mdev to eudev

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH v2 2/4 configs/imx6-sabresd_qt5: Select the KMSRO gallium driver

In reply to Fabio Estevam
Quoted 1 line · On Wed, 9 Oct 2019 14:00:02 -0300 Fabio Estevam <[email protected]> wrote:

+BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_KMSRO=y

I don't think this is the correct fix. mesa3d itself should be fixed to not require explicitly enabling this option. If BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_ETNAVIV=y is enabled, then you want the etnaviv driver, it should be there.

Quoted 1 line

BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_SWRAST=y

BTW, why do you need this ?

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#8 lore raw

PATCH v2 3/4 imx6-sabresd/readme.txt: Improve Qt5 Cinematic Demo instructions

In reply to Fabio Estevam
Quoted 11 lines · On Wed, 9 Oct 2019 14:00:03 -0300 Fabio Estevam <[email protected]> wrote:

QT_QPA_EGLFS_ALWAYS_SET_MODE=1 needs to be exported, otherwise the Qt5 Cinematic demo throws a storm of the following messages:

Could not queue DRM page flip on screen LVDS1 (Invalid argument)

Improve the instructions by mentioning such requirement.

---
Changes since v1:
- None

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#10 lore raw

PATCH v2 4/4 configs/imx6-sabresd: Bump U-Boot and kernel versions

In reply to Fabio Estevam
Quoted 77 lines · On Wed, 9 Oct 2019 14:00:04 -0300 Fabio Estevam <[email protected]> wrote:

Bump U-Boot to 2019.10 and kernel to 5.3.4 version.

---
Changes since v1:
- None

 configs/imx6-sabresd_defconfig     | 8 ++++----
 configs/imx6-sabresd_qt5_defconfig | 8 ++++----
 2 files changed, 8 insertions(+), 8 deletions(-)
configs/imx6-sabresd_defconfig +4 -4
index c2924b2e39..0d070e47f8 100644
@@ -4,8 +4,8 @@ BR2_ARM_ENABLE_NEON=y
 BR2_ARM_ENABLE_VFP=y
 BR2_ARM_FPU_VFPV3=y
 
-# Linux headers same as kernel, a 4.19 series
-BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_19=y
+# Linux headers same as kernel, a 5.3 series
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_3=y
 
 # System
 BR2_TARGET_GENERIC_GETTY_PORT="ttymxc0"
@@ -24,7 +24,7 @@ BR2_TARGET_ROOTFS_EXT2_4=y
 BR2_TARGET_UBOOT=y
 BR2_TARGET_UBOOT_BOARDNAME="mx6sabresd"
 BR2_TARGET_UBOOT_CUSTOM_VERSION=y
-BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2018.05"
+BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2019.10"
 BR2_TARGET_UBOOT_FORMAT_IMG=y
 BR2_TARGET_UBOOT_SPL=y
 BR2_TARGET_UBOOT_SPL_NAME="SPL"
@@ -32,7 +32,7 @@ BR2_TARGET_UBOOT_SPL_NAME="SPL"
 # Kernel
 BR2_LINUX_KERNEL=y
 BR2_LINUX_KERNEL_CUSTOM_VERSION=y
-BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.19.16"
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.3.4"
 BR2_LINUX_KERNEL_DEFCONFIG="imx_v6_v7"
 BR2_LINUX_KERNEL_DTS_SUPPORT=y
 BR2_LINUX_KERNEL_INTREE_DTS_NAME="imx6q-sabresd imx6dl-sabresd imx6qp-sabresd"
configs/imx6-sabresd_qt5_defconfig +4 -4
index 887e53dc21..7a541951ae 100644
@@ -4,8 +4,8 @@ BR2_ARM_ENABLE_NEON=y
 BR2_ARM_ENABLE_VFP=y
 BR2_ARM_FPU_VFPV3=y
 
-# Linux headers same as kernel, a 4.19 series
-BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_19=y
+# Linux headers same as kernel, a 5.3 series
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_3=y
 
 # Additional features needed for packages
 BR2_TOOLCHAIN_BUILDROOT_WCHAR=y
@@ -30,7 +30,7 @@ BR2_ROOTFS_OVERLAY="board/freescale/imx6-sabresd/rootfs_overlay"
 BR2_TARGET_UBOOT=y
 BR2_TARGET_UBOOT_BOARDNAME="mx6sabresd"
 BR2_TARGET_UBOOT_CUSTOM_VERSION=y
-BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2018.05"
+BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2019.10"
 BR2_TARGET_UBOOT_FORMAT_IMG=y
 BR2_TARGET_UBOOT_SPL=y
 BR2_TARGET_UBOOT_SPL_NAME="SPL"
@@ -38,7 +38,7 @@ BR2_TARGET_UBOOT_SPL_NAME="SPL"
 # Kernel
 BR2_LINUX_KERNEL=y
 BR2_LINUX_KERNEL_CUSTOM_VERSION=y
-BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.19.16"
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.3.4"
 BR2_LINUX_KERNEL_DEFCONFIG="imx_v6_v7"
 BR2_LINUX_KERNEL_DTS_SUPPORT=y
 BR2_LINUX_KERNEL_INTREE_DTS_NAME="imx6q-sabresd imx6dl-sabresd imx6qp-sabresd"
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
author reviewer
#3 lore raw

PATCH v2 2/4 configs/imx6-sabresd_qt5: Select the KMSRO gallium driver

In reply to Thomas Petazzoni

Hi Thomas,

Quoted 8 lines
Quoted 1 line · Fabio Estevam

+BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_KMSRO=y

I don't think this is the correct fix. mesa3d itself should be fixed to not require explicitly enabling this option. If BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_ETNAVIV=y is enabled, then you want the etnaviv driver, it should be there.

Yes, it seems we currently have a bug in mesa, which does not install imx-drm_dri.so without BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_KMSRO being selected.

Quoted 3 lines
Quoted 1 line

BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_SWRAST=y

BTW, why do you need this ?

Yes, I can remove it.

Thanks

#4 lore raw

PATCH v2 2/4 configs/imx6-sabresd_qt5: Select the KMSRO gallium driver

Quoted 7 lines · Fabio Estevam

Hi Thomas,

Quoted 4 lines
Quoted 1 line · Fabio Estevam

+BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_KMSRO=y

Quoted 8 lines
Quoted 4 lines

I don't think this is the correct fix. mesa3d itself should be fixed to not require explicitly enabling this option. If BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_ETNAVIV=y is enabled, then you want the etnaviv driver, it should be there.

Yes, it seems we currently have a bug in mesa, which does not install imx-drm_dri.so without BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_KMSRO being selected.

I think it is a valid choice to not have it. For example, you might be interested in only having the GPU for offscreen rendering. So if you do want the drm driver to bridge to the display, I think you should just enable kmsro.

Erico

#5 lore raw

PATCH v2 2/4 configs/imx6-sabresd_qt5: Select the KMSRO gallium driver

Quoted 4 lines · On Fri, 11 Oct 2019 15:15:16 +0200 Erico Nunes <[email protected]> wrote:

I think it is a valid choice to not have it. For example, you might be interested in only having the GPU for offscreen rendering. So if you do want the drm driver to bridge to the display, I think you should just enable kmsro.

Ah, OK, indeed that makes sense. I'll revive Fabio's patch then.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
author reviewer
#6 lore raw

PATCH v2 2/4 configs/imx6-sabresd_qt5: Select the KMSRO gallium driver

Hi Thomas,

Quoted 10 lines · Thomas Petazzoni
Quoted 4 lines · On Fri, 11 Oct 2019 15:15:16 +0200 Erico Nunes <[email protected]> wrote:

I think it is a valid choice to not have it. For example, you might be interested in only having the GPU for offscreen rendering. So if you do want the drm driver to bridge to the display, I think you should just enable kmsro.

Ah, OK, indeed that makes sense. I'll revive Fabio's patch then.

Do you want me to resend this patch?