ARM: dts: imx6qdl-zii-rdu2: Fix accelerometer interrupt-names
Subsystems (2)
Fabio Estevam
reviewerPATCH 1/1 ARM: dts: imx6qdl-zii-rdu2: Fix accelerometer interrupt-names
According to Documentation/devicetree/bindings/iio/accel/mma8452.txt, the correct interrupt-names are "INT1" and "INT2", so fix them accordingly.
---
Hi Lucas/Andrey,
I don't have access to this board, so please test it if you have a chance.
I realized this after debugging a mma8451 issue on sabreauto board and looking at other dts with mma8451 support.
Thanks
arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi +1 -1
@@ -358,7 +358,7 @@ compatible = "fsl,mma8451"; reg = <0x1c>; interrupt-parent = <&gpio1>; - interrupt-names = "int1", "int2"; + interrupt-names = "INT1", "INT2"; interrupts = <18 IRQ_TYPE_LEVEL_LOW>, <20 IRQ_TYPE_LEVEL_LOW>; };
Signature · 7 lines
2.17.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 11 lines · Fabio Estevam
According to
Documentation/devicetree/bindings/iio/accel/mma8452.txt, the correct interrupt-names are "INT1" and "INT2", so fix them accordingly.Signed-off-by Fabio Estevam <[email protected]>---
Hi Lucas/Andrey,I don't have access to this board, so please test it if you have a chance.
Will do. The binding documentation is actually a bit misleading since it makes it sounds like configuring both interrupts is a meaningful option, whereas in reality the driver will always use only one line. I've been meaning to submit a patch to re-word the documentation, maybe this is a good reminder that I need to do so. Do you mind if I re-spin a v2 of this patch and modify it to specify only a single IRQ line?
Thanks,
Andrey Smirnov
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Fabio Estevam
reviewerHi Andrey,
Quoted 7 lines · Andrey Smirnov
Will do. The binding documentation is actually a bit misleading since it makes it sounds like configuring both interrupts is a meaningful option, whereas in reality the driver will always use only one line. I've been meaning to submit a patch to re-word the documentation, maybe this is a good reminder that I need to do so. Do you mind if I re-spin a v2 of this patch and modify it to specify only a single IRQ line?
Please re-spin it.
Thanks
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel