checkpatch: comparisons with a constant on the left
Hi Joe,
I noticed that this code
#if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 18, 0)
triggers checkpatch's warning:
"WARNING: Comparisons should place the constant on
the right side of the test"
Both LINUX_VERSION_CODE and KERNEL_VERSION are constants, so I'm wondering if it's worth it to improve that check a tiny bit.
E.g. something utterly trivial:
---
scripts/checkpatch.pl +1 -0
@@ -4855,6 +4855,7 @@ sub process { my $to = $4; my $newcomp = $comp; if ($lead !~ /(?:$Operators|\.)\s*$/ && + $to !~ /^KERNEL_VERSION.*/ && $to !~ /^(?:Constant|[A-Z_][A-Z0-9_]*)$/ && WARN("CONSTANT_COMPARISON", "Comparisons should place the constant on the right side of the test\n" . $herecurr) &&
---
I'm sure you'll have a better idea.
-ss
Joe Perches
maintainerQuoted 1 line · Sergey Senozhatsky
Hi Joe,
Hi Sergey.
Quoted 4 lines
I noticed that this code
#if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 18, 0)
Quoted 8 lines
triggers checkpatch's warning:
"WARNING: Comparisons should place the constant on
the right side of the test"Both
LINUX_VERSION_CODEandKERNEL_VERSIONare constants, so I'm wondering if it's worth it to improve that check a tiny bit.
Probably not.
My preference is for people to ignore checkpatch message bleats when they don't make overall sense.
checkpatch thinks anything that uses a form like "name(<args...>)" is a function.
Quoted 1 line
I'm sure you'll have a better idea.
I suggest reversing the test if it really bothers you.
# if KERNEL_VERSION(4.18.0) < LINUX_VERSION_CODE
but then again just using LINUX_VERSION_CODE emits a warning message, so it's better to remove whatever is in the block anyway... <smile>
cheers, Joe
Quoted 4 lines · Joe Perches
Quoted 1 line · Sergey Senozhatsky
Hi Joe,
Hi Sergey.
Hi Joe,
For some reason your reply triggered gmail spam filter; took me a while to notice and "recover" it from spam folder.
[..]
Quoted 11 lines
Quoted 3 lines
Both
LINUX_VERSION_CODEandKERNEL_VERSIONare constants, so I'm wondering if it's worth it to improve that check a tiny bit.Probably not.
My preference is for people to ignore checkpatch message bleats when they don't make overall sense.
checkpatch thinks anything that uses a form like "name(<args...>)" is a function.
For example, DMA_BIT_MASK(xxx) can look like a function call yet still be a compile time constant.
Another example could be ARRAY_SIZE(xxx), I guess.
[..]
Quoted 3 lines
but then again just using
LINUX_VERSION_CODEemits a warning message, so it's better to remove whatever is in the block anyway... <smile>
That's certainly right. LINUX_VERSION_CODE should not be in the code, I agree. I was thinking more about 'const vs const' comparison in general, less about particular LINUX_VERSION_CODE case.
-ss