Skip to contentSkip to conversation

staging: wfx: fix potential vulnerability to spectre

PATCH Superseded Jerome Pouiller 1 participant 1 message Oct 11, 2019 Staging

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 staging: wfx: fix potential vulnerability to spectre

From: Jérôme Pouiller <[email protected]>

array_index_nospec() should be applied after a bound check.

Fixes 9bca45f3d692 ("staging: wfx: allow to send 802.11 frames")

---
v2: cut down commit-id to 12 characters

 drivers/staging/wfx/wfx.h | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/wfx/wfx.h +1 -0
index 489836837b0a..4c0f2836015c 100644
@@ -138,6 +138,7 @@ static inline struct wfx_vif *wdev_to_wvif(struct wfx_dev *wdev, int vif_id)
 		dev_dbg(wdev->dev, "requesting non-existent vif: %d\n", vif_id);
 		return NULL;
 	}
+	vif_id = array_index_nospec(vif_id, ARRAY_SIZE(wdev->vif));
 	if (!wdev->vif[vif_id]) {
 		dev_dbg(wdev->dev, "requesting non-allocated vif: %d\n", vif_id);
 		return NULL;
Signature · 1 line
2.20.1