Skip to contentSkip to conversation

fs: include internal.h for missing declarations

PATCH In review Ben Dooks 2 participants 2 messages Oct 11, 2019 – Oct 15, 2019 VFS

lore
Share & tools
lore

Ben Dooks

author
#0 lore raw

PATCH 1/1 fs: include internal.h for missing declarations

The declarations of __block_write_begin_int and guard_bio_eod are needed from internal.h so include it to fix the following sparse warnings:

fs/buffer.c:1930:5: warning: symbol '__block_write_begin_int' was not declared. Should it be static? fs/buffer.c:2994:6: warning: symbol 'guard_bio_eod' was not declared. Should it be static?

---
Cc: Alexander Viro <[email protected]>
Cc: [email protected]
Cc: [email protected]

---
 fs/buffer.c | 2 ++
 1 file changed, 2 insertions(+)
fs/buffer.c +2 -0
index 86a38b979323..792f22a88e67 100644
@@ -48,6 +48,8 @@
 #include <linux/sched/mm.h>
 #include <trace/events/block.h>
 
+#include "internal.h"
+
 static int fsync_buffers_list(spinlock_t *lock, struct list_head *list);
 static int submit_bh_wbc(int op, int op_flags, struct buffer_head *bh,
 			 enum rw_hint hint, struct writeback_control *wbc);
Signature · 1 line
2.23.0
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Ben Dooks

The declarations of __block_write_begin_int and guard_bio_eod are needed from internal.h so include it to fix the following sparse warnings:

fs/buffer.c:1930:5: warning: symbol '__block_write_begin_int' was not declared. Should it be static? fs/buffer.c:2994:6: warning: symbol 'guard_bio_eod' was not declared. Should it be static?

OK, makes sense to keep declarations in sync with real functions. Thanks for the patch a feel free to add:

Honza

Quoted 24 lines

---
Cc: Alexander Viro <[email protected]>
Cc: [email protected]
Cc: [email protected]

---
 fs/buffer.c | 2 ++
 1 file changed, 2 insertions(+)
fs/buffer.c +2 -0
index 86a38b979323..792f22a88e67 100644
@@ -48,6 +48,8 @@
 #include <linux/sched/mm.h>
 #include <trace/events/block.h>
 
+#include "internal.h"
+
 static int fsync_buffers_list(spinlock_t *lock, struct list_head *list);
 static int submit_bh_wbc(int op, int op_flags, struct buffer_head *bh,
 			 enum rw_hint hint, struct writeback_control *wbc);
Signature · 1 line
2.23.0
Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR