Skip to contentSkip to conversation

iio: adc: mt6577_auxdac: use devm_platform_ioremap_resource

PATCH In review [email protected] 2 participants 3 messages Oct 13, 2019 – Nov 9, 2019

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

PATCH 1/1 iio: adc: mt6577_auxdac: use devm_platform_ioremap_resource

From: Jonathan Cameron <[email protected]>

Reduces boilerplate. Identified by coccinelle

CHECK drivers/iio/adc/mt6577_auxadc.c
drivers/iio/adc/mt6577_auxadc.c:257:1-18: WARNING: Use devm_platform_ioremap_resource for adc_dev -> reg_base

---
 drivers/iio/adc/mt6577_auxadc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/iio/adc/mt6577_auxadc.c +1 -3
index 7bbb64ca3b32..a4776d924f3a 100644
@@ -237,7 +237,6 @@ static int mt6577_auxadc_probe(struct platform_device *pdev)
 {
 	struct mt6577_auxadc_device *adc_dev;
 	unsigned long adc_clk_rate;
-	struct resource *res;
 	struct iio_dev *indio_dev;
 	int ret;
 
@@ -253,8 +252,7 @@ static int mt6577_auxadc_probe(struct platform_device *pdev)
 	indio_dev->channels = mt6577_auxadc_iio_channels;
 	indio_dev->num_channels = ARRAY_SIZE(mt6577_auxadc_iio_channels);
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	adc_dev->reg_base = devm_ioremap_resource(&pdev->dev, res);
+	adc_dev->reg_base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(adc_dev->reg_base)) {
 		dev_err(&pdev->dev, "failed to get auxadc base address\n");
 		return PTR_ERR(adc_dev->reg_base);
Signature · 1 line
2.23.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · On Sun, 2019-10-13 at 13:15 +0100, [email protected] wrote:

From: Jonathan Cameron <[email protected]>

Reduces boilerplate. Identified by coccinelle

CHECK drivers/iio/adc/mt6577_auxadc.c
drivers/iio/adc/mt6577_auxadc.c:257:1-18: WARNING: Use devm_platform_ioremap_resource for adc_dev -> reg_base

Quoted 31 lines
---
 drivers/iio/adc/mt6577_auxadc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/iio/adc/mt6577_auxadc.c +1 -3
index 7bbb64ca3b32..a4776d924f3a 100644
@@ -237,7 +237,6 @@ static int mt6577_auxadc_probe(struct platform_device
 *pdev)
 {
 	struct mt6577_auxadc_device *adc_dev;
 	unsigned long adc_clk_rate;
-	struct resource *res;
 	struct iio_dev *indio_dev;
 	int ret;
@@ -253,8 +252,7 @@ static int mt6577_auxadc_probe(struct platform_device
 *pdev)
 	indio_dev->channels = mt6577_auxadc_iio_channels;
 	indio_dev->num_channels = ARRAY_SIZE(mt6577_auxadc_iio_channels);
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	adc_dev->reg_base = devm_ioremap_resource(&pdev->dev, res);
+	adc_dev->reg_base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(adc_dev->reg_base)) {
 		dev_err(&pdev->dev, "failed to get auxadc base address\n");

return PTR_ERR(adc_dev->reg_base);

author maintainer Applied
#2 lore raw
Quoted 11 lines · Alexandru
Quoted 8 lines · On Sun, 2019-10-13 at 13:15 +0100, [email protected] wrote:

From: Jonathan Cameron <[email protected]>

Reduces boilerplate. Identified by coccinelle

CHECK drivers/iio/adc/mt6577_auxadc.c
drivers/iio/adc/mt6577_auxadc.c:257:1-18: WARNING: Use devm_platform_ioremap_resource for adc_dev -> reg_base

Applied.

Thanks,

Jonathan

Quoted 33 lines
Quoted 33 lines
---
 drivers/iio/adc/mt6577_auxadc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/iio/adc/mt6577_auxadc.c +1 -3
index 7bbb64ca3b32..a4776d924f3a 100644
@@ -237,7 +237,6 @@ static int mt6577_auxadc_probe(struct platform_device
 *pdev)
 {
 	struct mt6577_auxadc_device *adc_dev;
 	unsigned long adc_clk_rate;
-	struct resource *res;
 	struct iio_dev *indio_dev;
 	int ret;
@@ -253,8 +252,7 @@ static int mt6577_auxadc_probe(struct platform_device
 *pdev)
 	indio_dev->channels = mt6577_auxadc_iio_channels;
 	indio_dev->num_channels = ARRAY_SIZE(mt6577_auxadc_iio_channels);
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	adc_dev->reg_base = devm_ioremap_resource(&pdev->dev, res);
+	adc_dev->reg_base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(adc_dev->reg_base)) {
 		dev_err(&pdev->dev, "failed to get auxadc base address\n");

return PTR_ERR(adc_dev->reg_base);