Skip to contentSkip to conversation

iio: adc: cpcap-adc: Fix missing IRQF_ONESHOT as only threaded handler.

PATCH In review [email protected] 2 participants 3 messages Oct 13, 2019 – Oct 18, 2019 IIO

lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

PATCH 1/1 iio: adc: cpcap-adc: Fix missing IRQF_ONESHOT as only threaded handler.

From: Jonathan Cameron <[email protected]>

Coccinelle noticed:
CHECK drivers/iio/adc/cpcap-adc.c
drivers/iio/adc/cpcap-adc.c:1009:9-34: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT

As far as I can see this is a simple case of it should be specified but isn't.

---
 drivers/iio/adc/cpcap-adc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/cpcap-adc.c +1 -1
index 2d616cafe75f..5086a337f4c9 100644
@@ -1008,7 +1008,7 @@ static int cpcap_adc_probe(struct platform_device *pdev)
 
 	error = devm_request_threaded_irq(&pdev->dev, ddata->irq, NULL,
 					  cpcap_adc_irq_thread,
-					  IRQF_TRIGGER_NONE,
+					  IRQF_TRIGGER_NONE | IRQF_ONESHOT,
 					  "cpcap-adc", indio_dev);
 	if (error) {
 		dev_err(&pdev->dev, "could not get irq: %i\n",
Signature · 1 line
2.23.0
author maintainer
#2 lore raw
Quoted 11 lines · On Wed, 16 Oct 2019 10:24:47 -0700 Tony Lindgren <[email protected]> wrote:
Quoted 8 lines · * [email protected] <[email protected]> [191013 16:24]:

From: Jonathan Cameron <[email protected]>

Coccinelle noticed:
CHECK drivers/iio/adc/cpcap-adc.c
drivers/iio/adc/cpcap-adc.c:1009:9-34: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT

As far as I can see this is a simple case of it should be specified but isn't.

Applied to the togreg branch of iio.git and pushed out as testing for the autobulders to play with it

Thanks,

Jonathan