Skip to contentSkip to conversation

iio: adc: xilinix-xadc: use devm_platform_ioremap_resource

PATCH In review [email protected] 2 participants 3 messages Oct 13, 2019 – Oct 18, 2019

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

PATCH 1/1 iio: adc: xilinix-xadc: use devm_platform_ioremap_resource

From: Jonathan Cameron <[email protected]>

Reduces local boilerplate.
Suggested by coccinelle.
CHECK drivers/iio/adc/xilinx-xadc-core.c
drivers/iio/adc/xilinx-xadc-core.c:1184:1-11: WARNING: Use devm_platform_ioremap_resource for xadc -> base

Cc Manish Narani <[email protected]>
Cc Sven Van Asbroeck <[email protected]>
---
 drivers/iio/adc/xilinx-xadc-core.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/iio/adc/xilinx-xadc-core.c +1 -3
index 4fd389678dba..ec227b358cd6 100644
@@ -1150,7 +1150,6 @@ static int xadc_probe(struct platform_device *pdev)
 	const struct of_device_id *id;
 	struct iio_dev *indio_dev;
 	unsigned int bipolar_mask;
-	struct resource *mem;
 	unsigned int conf0;
 	struct xadc *xadc;
 	int ret;
@@ -1180,8 +1179,7 @@ static int xadc_probe(struct platform_device *pdev)
 	spin_lock_init(&xadc->lock);
 	INIT_DELAYED_WORK(&xadc->zynq_unmask_work, xadc_zynq_unmask_worker);
 
-	mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	xadc->base = devm_ioremap_resource(&pdev->dev, mem);
+	xadc->base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(xadc->base))
 		return PTR_ERR(xadc->base);
 
Signature · 1 line
2.23.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · On Sun, Oct 13, 2019 at 12:50 PM <[email protected]> wrote:

From: Jonathan Cameron <[email protected]>

Reduces local boilerplate.
Suggested by coccinelle.
CHECK drivers/iio/adc/xilinx-xadc-core.c
drivers/iio/adc/xilinx-xadc-core.c:1184:1-11: WARNING: Use devm_platform_ioremap_resource for xadc -> base

Quoted 6 lines
Cc Manish Narani <[email protected]>
Cc Sven Van Asbroeck <[email protected]>
---
 drivers/iio/adc/xilinx-xadc-core.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Looks good to me:

author maintainer Applied
#2 lore raw
Quoted 16 lines · On Mon, 14 Oct 2019 15:56:36 -0400 Sven Van Asbroeck <[email protected]>…
Quoted 8 lines · On Sun, Oct 13, 2019 at 12:50 PM <[email protected]> wrote:

From: Jonathan Cameron <[email protected]>

Reduces local boilerplate.
Suggested by coccinelle.
CHECK drivers/iio/adc/xilinx-xadc-core.c
drivers/iio/adc/xilinx-xadc-core.c:1184:1-11: WARNING: Use devm_platform_ioremap_resource for xadc -> base

Quoted 6 lines
Cc Manish Narani <[email protected]>
Cc Sven Van Asbroeck <[email protected]>
---
 drivers/iio/adc/xilinx-xadc-core.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)  
Quoted 3 lines

Looks good to me:

Applied,

Thanks,

Jonathan