Skip to contentSkip to conversation

sanity: check the format of SDK_VENDOR

PATCH New Ross Burton 1 participant 1 message Oct 14, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sanity: check the format of SDK_VENDOR

If SDK_VENDOR isn't formatted as -foosdk and is instead for example -foo-sdk then the triple that are constructed are not in fact triples, which results in mysterious compile errors.

Check in sanity.bbclass so this failure is detected early.

[ YOCTO #13573 ]

---
 meta/classes/sanity.bbclass | 5 +++++
 1 file changed, 5 insertions(+)
meta/classes/sanity.bbclass +5 -0
index 2d3f49eb1a7..705062bc864 100644
@@ -798,6 +798,11 @@ def check_sanity_everybuild(status, d):
         elif d.getVar('SDK_ARCH', False) == "${BUILD_ARCH}":
             status.addresult('SDKMACHINE is set, but SDK_ARCH has not been changed as a result - SDKMACHINE may have been set too late (e.g. in the distro configuration)\n')
 
+    # If SDK_VENDOR looks like "-my-sdk" then the triples are badly formed so fail early
+    sdkvendor = d.getVar("SDK_VENDOR")
+    if not (sdkvendor.startswith("-") and sdkvendor.count("-") == 1):
+        status.addresult("SDK_VENDOR should be of the form '-foosdk' with a single dash\n")
+
     check_supported_distro(d)
 
     omask = os.umask(0o022)
Signature · 1 line
2.20.1