media: imx.rst: Specify the sabreauto variant
Subsystems (3)
Fabio Estevam
reviewerPATCH v2 1/3 media: imx.rst: Specify the sabreauto variant
Improve the documentation by specifying that the instructions are related to the i.MX6Q sabreauto variant.
This avoids confusion if someone follows these steps on a i.MX6DL sabreauto, which has different numbering on the I2C bus and I2C muxes.
---
Changes since v1:
- New patch
Documentation/media/v4l-drivers/imx.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
Documentation/media/v4l-drivers/imx.rst +3 -3
@@ -515,10 +515,10 @@ Streaming can then begin independently on the capture device nodes be used to select any supported YUV pixelformat on the capture device nodes, including planar. -SabreAuto with ADV7180 decoder ------------------------------- +i.MX6Q SabreAuto with ADV7180 decoder +------------------------------------- -On the SabreAuto, an on-board ADV7180 SD decoder is connected to the +On the i.MX6Q SabreAuto, an on-board ADV7180 SD decoder is connected to the parallel bus input on the internal video mux to IPU1 CSI0. The following example configures a pipeline to capture from the ADV7180
Signature · 1 line
2.17.1
Fabio Estevam
reviewerPATCH v2 2/3 media: imx.rst: Provide a real example for the output format
In the i.MX6Q sabreauto pipeline example, it is better to provide a real example for the output format, so do it just like in the previous lines for consistency.
---
Changes since v1:
- Make this change as part of a single patch
Documentation/media/v4l-drivers/imx.rst | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
Documentation/media/v4l-drivers/imx.rst +1 -3
@@ -547,8 +547,6 @@ This example configures a pipeline to capture from the ADV7180 video decoder, assuming PAL 720x576 input signals, with Motion Compensated de-interlacing. The adv7180 must output sequential or alternating fields (field type 'seq-tb' for PAL, or 'alternate'). -$outputfmt can be any format supported by the ipu1_ic_prpvf entity -at its output pad: .. code-block:: none
@@ -565,7 +563,7 @@ at its output pad: media-ctl -V "'ipu1_csi0':1 [fmt:AYUV32/720x576]" media-ctl -V "'ipu1_vdic':2 [fmt:AYUV32/720x576 field:none]" media-ctl -V "'ipu1_ic_prp':2 [fmt:AYUV32/720x576 field:none]" - media-ctl -V "'ipu1_ic_prpvf':1 [fmt:$outputfmt field:none]" + media-ctl -V "'ipu1_ic_prpvf':1 [fmt:AYUV32/720x576 field:none]" Streaming can then begin on the capture device node at "ipu1_ic_prpvf capture". The v4l2-ctl tool can be used to select any
Signature · 1 line
2.17.1
Re: [PATCH v2 2/3] media: imx.rst: Provide a real example for the output format
Quoted 5 lines · Fabio Estevam
In the i.MX6Q sabreauto pipeline example, it is better to provide a real example for the output format, so do it just like in the previous lines for consistency.
Signed-off-by Fabio Estevam <[email protected]>
Quoted 29 lines
---
Changes since v1:
- Make this change as part of a single patchDocumentation/media/v4l-drivers/imx.rst | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)Documentation/media/v4l-drivers/imx.rst +1
-3@@ -547,8 +547,6 @@ This example configures a pipeline to capture from the ADV7180 video decoder, assuming PAL 720x576 input signals, with Motion Compensated de-interlacing. The adv7180 must output sequential or alternating fields (field type 'seq-tb' for PAL, or 'alternate'). -$outputfmt can be any format supported by the ipu1_ic_prpvf entity -at its output pad: .. code-block:: none@@ -565,7 +563,7 @@ at its output pad: media-ctl -V "'ipu1_csi0':1 [fmt:AYUV32/720x576]" media-ctl -V "'ipu1_vdic':2 [fmt:AYUV32/720x576 field:none]" media-ctl -V "'ipu1_ic_prp':2 [fmt:AYUV32/720x576 field:none]" - media-ctl -V "'ipu1_ic_prpvf':1 [fmt:$outputfmt field:none]" + media-ctl -V "'ipu1_ic_prpvf':1 [fmt:AYUV32/720x576 field:none]" Streaming can then begin on the capture device node at "ipu1_ic_prpvf capture". The v4l2-ctl tool can be used to select any
Fabio Estevam
reviewerPATCH v2 3/3 media: imx.rst: Provide instructions for the i.MX6DL sabreauto
In reply to Fabio EstevamThe i.MX6DL sabreauto has different numbering on the I2C bus and I2C muxes compared to the i.MX6Q as shown in the kernel log below:
[ 5.159423] imx-media: ipu1_csi0_mux:5 -> ipu1_csi0:0 [ 5.164618] imx-media: ipu1_csi1_mux:5 -> ipu1_csi1:0 [ 5.169953] imx-media: adv7180 4-0021:0 -> ipu1_csi0_mux:4
To avoid confusion, add an entry that shows how to setup the links and configure the pads that are specific to the i.MX6DL sabreauto.
---
Changes since v1:
- Add a new entry for the mx6dl sabreauto
Documentation/media/v4l-drivers/imx.rst | 57 +++++++++++++++++++++++++ 1 file changed, 57 insertions(+)
Documentation/media/v4l-drivers/imx.rst +57 -0
@@ -572,6 +572,63 @@ supported YUV or RGB pixelformat on the capture device node. This platform accepts Composite Video analog inputs to the ADV7180 on Ain1 (connector J42). +i.MX6DL SabreAuto with ADV7180 decoder +-------------------------------------- + +On the i.MX6DL SabreAuto, an on-board ADV7180 SD decoder is connected to the +parallel bus input on the internal video mux to IPU1 CSI0. + +The following example configures a pipeline to capture from the ADV7180 +video decoder, assuming NTSC 720x480 input signals, using simple +interweave (unconverted and without motion compensation). The adv7180 +must output sequential or alternating fields (field type 'seq-bt' for +NTSC, or 'alternate'): + +.. code-block:: none + + # Setup links + media-ctl -l "'adv7180 4-0021':0 -> 'ipu1_csi0_mux':4[1]" + media-ctl -l "'ipu1_csi0_mux':5 -> 'ipu1_csi0':0[1]" + media-ctl -l "'ipu1_csi0':2 -> 'ipu1_csi0 capture':0[1]" + # Configure pads + media-ctl -V "'adv7180 4-0021':0 [fmt:UYVY2X8/720x480 field:seq-bt]" + media-ctl -V "'ipu1_csi0_mux':5 [fmt:UYVY2X8/720x480]" + media-ctl -V "'ipu1_csi0':2 [fmt:AYUV32/720x480]" + # Configure "ipu1_csi0 capture" interface (assumed at /dev/video4) + v4l2-ctl -d4 --set-fmt-video=field=interlaced_bt + +Streaming can then begin on /dev/video4. The v4l2-ctl tool can also be +used to select any supported YUV pixelformat on /dev/video4. + +This example configures a pipeline to capture from the ADV7180 +video decoder, assuming PAL 720x576 input signals, with Motion +Compensated de-interlacing. The adv7180 must output sequential or +alternating fields (field type 'seq-tb' for PAL, or 'alternate'). + +.. code-block:: none + + # Setup links + media-ctl -l "'adv7180 4-0021':0 -> 'ipu1_csi0_mux':4[1]" + media-ctl -l "'ipu1_csi0_mux':5 -> 'ipu1_csi0':0[1]" + media-ctl -l "'ipu1_csi0':1 -> 'ipu1_vdic':0[1]" + media-ctl -l "'ipu1_vdic':2 -> 'ipu1_ic_prp':0[1]" + media-ctl -l "'ipu1_ic_prp':2 -> 'ipu1_ic_prpvf':0[1]" + media-ctl -l "'ipu1_ic_prpvf':1 -> 'ipu1_ic_prpvf capture':0[1]" + # Configure pads + media-ctl -V "'adv7180 3-0021':0 [fmt:UYVY2X8/720x576 field:seq-tb]" + media-ctl -V "'ipu1_csi0_mux':2 [fmt:UYVY2X8/720x576]" + media-ctl -V "'ipu1_csi0':1 [fmt:AYUV32/720x576]" + media-ctl -V "'ipu1_vdic':2 [fmt:AYUV32/720x576 field:none]" + media-ctl -V "'ipu1_ic_prp':2 [fmt:AYUV32/720x576 field:none]" + media-ctl -V "'ipu1_ic_prpvf':1 [fmt:AYUV32/720x576 field:none]" + +Streaming can then begin on the capture device node at +"ipu1_ic_prpvf capture". The v4l2-ctl tool can be used to select any +supported YUV or RGB pixelformat on the capture device node. + +This platform accepts Composite Video analog inputs to the ADV7180 on +Ain1 (connector J42). + SabreSD with MIPI CSI-2 OV5640 ------------------------------
Signature · 1 line
2.17.1
Re: [PATCH v2 3/3] media: imx.rst: Provide instructions for the i.MX6DL sabreauto
Hi Fabio,
Quoted 60 lines · Fabio Estevam
The i.MX6DL sabreauto has different numbering on the I2C bus and I2C muxes compared to the i.MX6Q as shown in the kernel log below:
[ 5.159423] imx-media: ipu1_csi0_mux:5 -> ipu1_csi0:0 [ 5.164618] imx-media: ipu1_csi1_mux:5 -> ipu1_csi1:0 [ 5.169953] imx-media: adv7180 4-0021:0 -> ipu1_csi0_mux:4To avoid confusion, add an entry that shows how to setup the links and configure the pads that are specific to the i.MX6DL sabreauto.
Signed-off-by Fabio Estevam <[email protected]>---
Changes since v1:
- Add a new entry for the mx6dl sabreautoDocumentation/media/v4l-drivers/imx.rst | 57 +++++++++++++++++++++++++ 1 file changed, 57 insertions(+)Documentation/media/v4l-drivers/imx.rst +34
-0@@ -572,6 +572,63 @@ supported YUV or RGB pixelformat on the capture device node. This platform accepts Composite Video analog inputs to the ADV7180 on Ain1 (connector J42). +i.MX6DL SabreAuto with ADV7180 decoder +-------------------------------------- + +On the i.MX6DL SabreAuto, an on-board ADV7180 SD decoder is connected to the +parallel bus input on the internal video mux to IPU1 CSI0. + +The following example configures a pipeline to capture from the ADV7180 +video decoder, assuming NTSC 720x480 input signals, using simple +interweave (unconverted and without motion compensation). The adv7180 +must output sequential or alternating fields (field type 'seq-bt' for +NTSC, or 'alternate'): + +.. code-block:: none + + # Setup links + media-ctl -l "'adv7180 4-0021':0 -> 'ipu1_csi0_mux':4[1]" + media-ctl -l "'ipu1_csi0_mux':5 -> 'ipu1_csi0':0[1]" + media-ctl -l "'ipu1_csi0':2 -> 'ipu1_csi0 capture':0[1]" + # Configure pads + media-ctl -V "'adv7180 4-0021':0 [fmt:UYVY2X8/720x480 field:seq-bt]" + media-ctl -V "'ipu1_csi0_mux':5 [fmt:UYVY2X8/720x480]" + media-ctl -V "'ipu1_csi0':2 [fmt:AYUV32/720x480]" + # Configure "ipu1_csi0 capture" interface (assumed at /dev/video4) + v4l2-ctl -d4 --set-fmt-video=field=interlaced_bt + +Streaming can then begin on /dev/video4. The v4l2-ctl tool can also be +used to select any supported YUV pixelformat on /dev/video4. + +This example configures a pipeline to capture from the ADV7180 +video decoder, assuming PAL 720x576 input signals, with Motion +Compensated de-interlacing. The adv7180 must output sequential or +alternating fields (field type 'seq-tb' for PAL, or 'alternate'). + +.. code-block:: none
Documentation/media/v4l-drivers/imx.rst supported YUV or RGB pixelformat on the capture device node. · line 618
Quoted 10 lines
Documentation/media/v4l-drivers/imx.rst +10
-0+ + # Setup links + media-ctl -l "'adv7180 4-0021':0 -> 'ipu1_csi0_mux':4[1]" + media-ctl -l "'ipu1_csi0_mux':5 -> 'ipu1_csi0':0[1]" + media-ctl -l "'ipu1_csi0':1 -> 'ipu1_vdic':0[1]" + media-ctl -l "'ipu1_vdic':2 -> 'ipu1_ic_prp':0[1]" + media-ctl -l "'ipu1_ic_prp':2 -> 'ipu1_ic_prpvf':0[1]" + media-ctl -l "'ipu1_ic_prpvf':1 -> 'ipu1_ic_prpvf capture':0[1]" + # Configure pads + media-ctl -V "'adv7180 3-0021':0 [fmt:UYVY2X8/720x576 field:seq-tb]"
should be "'adv7180 4-0021:0".
Documentation/media/v4l-drivers/imx.rst supported YUV or RGB pixelformat on the capture device node. · line 619
Quoted 1 line
Documentation/media/v4l-drivers/imx.rst +1
-0+ media-ctl -V "'ipu1_csi0_mux':2 [fmt:UYVY2X8/720x576]"
should be "'ipu1_csi0_mux':5".
Documentation/media/v4l-drivers/imx.rst supported YUV or RGB pixelformat on the capture device node. · line 623
Quoted 4 lines
Documentation/media/v4l-drivers/imx.rst +4
-0+ media-ctl -V "'ipu1_csi0':1 [fmt:AYUV32/720x576]" + media-ctl -V "'ipu1_vdic':2 [fmt:AYUV32/720x576 field:none]" + media-ctl -V "'ipu1_ic_prp':2 [fmt:AYUV32/720x576 field:none]" + media-ctl -V "'ipu1_ic_prpvf':1 [fmt:AYUV32/720x576 field:none]"
Please add (after above line):
# Configure "ipu1_ic_prpvf capture" interface (assumed at /dev/video1)
v4l2-ctl -d1 --set-fmt-video=field=none
Documentation/media/v4l-drivers/imx.rst supported YUV or RGB pixelformat on the capture device node. · line 628
Quoted 5 lines
Documentation/media/v4l-drivers/imx.rst +5
-0+ +Streaming can then begin on the capture device node at +"ipu1_ic_prpvf capture". The v4l2-ctl tool can be used to select any +supported YUV or RGB pixelformat on the capture device node. +
Please replace above paragraph with:
Streaming can then begin on /dev/video1. The v4l2-ctl tool can also be used to select any supported YUV pixelformat on /dev/video1.
If you don't mind while you are on this, can you please add this v4l2-ctl step to the i.MX6Q PAL example, it is missing there as well.
Steve
Quoted 6 lines
Documentation/media/v4l-drivers/imx.rst +3
-0+This platform accepts Composite Video analog inputs to the ADV7180 on +Ain1 (connector J42). + SabreSD with MIPI CSI-2 OV5640 ------------------------------
Fabio Estevam
reviewerRe: [PATCH v2 3/3] media: imx.rst: Provide instructions for the i.MX6DL sabreauto
Hi Steve,
Quoted 1 line · Steve Longerbeam
should be "'adv7180 4-0021:0".
Will fix it.
Quoted 1 line
should be "'ipu1_csi0_mux':5".
Will fix it.
Quoted 9 lines
Documentation/media/v4l-drivers/imx.rst supported YUV or RGB pixelformat on the capture device node. · line 623
Quoted 4 lines
Documentation/media/v4l-drivers/imx.rst +4
-0+ media-ctl -V "'ipu1_csi0':1 [fmt:AYUV32/720x576]" + media-ctl -V "'ipu1_vdic':2 [fmt:AYUV32/720x576 field:none]" + media-ctl -V "'ipu1_ic_prp':2 [fmt:AYUV32/720x576 field:none]" + media-ctl -V "'ipu1_ic_prpvf':1 [fmt:AYUV32/720x576 field:none]"Please add (after above line):
# Configure "
ipu1_ic_prpvfcapture" interface (assumed at/dev/video1)v4l2-ctl -d1 --set-fmt-video=field=none
Will add it and will change it to /dev/video2, which is the correct interface on imx6dl-sabreuto.
Quoted 2 lines
If you don't mind while you are on this, can you please add this v4l2-ctl step to the i.MX6Q PAL example, it is missing there as well.
Yes, I can add it.
What is the video device node for "ipu1_ic_prpvf capture" on the imx6q sabreauto?
Thanks
Fabio Estevam
reviewerRe: [PATCH v2 3/3] media: imx.rst: Provide instructions for the i.MX6DL sabreauto
Quoted 4 lines · Fabio Estevam
Yes, I can add it.
What is the video device node for "
ipu1_ic_prpvfcapture" on the imx6q sabreauto?
I managed to get access to a imx6q-sabreauto and it's /dev/video2.
Will send a new patch series soon.
Thanks
Quoted 8 lines · Fabio Estevam
Improve the documentation by specifying that the instructions are related to the i.MX6Q sabreauto variant.
This avoids confusion if someone follows these steps on a i.MX6DL sabreauto, which has different numbering on the I2C bus and I2C muxes.
Signed-off-by Fabio Estevam <[email protected]>
Quoted 25 lines
---
Changes since v1:
- New patchDocumentation/media/v4l-drivers/imx.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)Documentation/media/v4l-drivers/imx.rst +3
-3@@ -515,10 +515,10 @@ Streaming can then begin independently on the capture device nodes be used to select any supported YUV pixelformat on the capture device nodes, including planar. -SabreAuto with ADV7180 decoder ------------------------------- +i.MX6Q SabreAuto with ADV7180 decoder +------------------------------------- -On the SabreAuto, an on-board ADV7180 SD decoder is connected to the +On the i.MX6Q SabreAuto, an on-board ADV7180 SD decoder is connected to the parallel bus input on the internal video mux to IPU1 CSI0. The following example configures a pipeline to capture from the ADV7180