drm/msm/a5xx: Fix barrier usage in set_preempt_state()
Subsystems (3)
PATCH 1/1 drm/msm/a5xx: Fix barrier usage in set_preempt_state()
Because it is not a Rmw operation, atomic_set() is never serialized, and therefore the 'upgradable' smp_mb__{before,after}_atomic() calls that order the write to preempt_state are completely bogus.
This patch replaces these with smp_mb(), which seems like the original intent of when the code was written.
Signed-off-by Davidlohr Bueso <[email protected]>
--- drivers/gpu/drm/msm/adreno/a5xx_preempt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/msm/adreno/a5xx_preempt.c +2 -2
@@ -30,10 +30,10 @@ static inline void set_preempt_state(struct a5xx_gpu *gpu,* preemption or in the interrupt handler so barriers are needed * before... */ -smp_mb__before_atomic (); +smp_mb ();atomic_set (&gpu->preempt_state, new);/* ... and after*/ -smp_mb__after_atomic (); +smp_mb (); }/* Write the most recent wptr for the given ring into the hardware */
Signature · 6 lines
2.16.4 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Forgot to Cc lkml.
Quoted 32 lines · Davidlohr Bueso
Because it is not a Rmw operation,
atomic_set()is never serialized, and therefore the 'upgradable' smp_mb__{before,after}_atomic() calls that order the write topreempt_stateare completely bogus.This patch replaces these with
smp_mb(), which seems like the original intent of when the code was written.Signed-off-by Davidlohr Bueso <[email protected]>---
drivers/gpu/drm/msm/adreno/a5xx_preempt.c| 4 ++--1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/msm/adreno/a5xx_preempt.c +2
-2@@ -30,10 +30,10 @@ static inline void set_preempt_state(struct a5xx_gpu *gpu,* preemption or in the interrupt handler so barriers are needed * before... */ -smp_mb__before_atomic (); +smp_mb ();atomic_set (&gpu->preempt_state, new);/* ... and after*/ -smp_mb__after_atomic (); +smp_mb (); }/* Write the most recent wptr for the given ring into the hardware */ Signature · 1 line
2.16.4