Skip to contentSkip to conversation

:scripts: prune-kernel : prunning kernel generalize way

PATCH In review Bhaskar Chowdhury 2 participants 4 messages Oct 15, 2019 – Oct 16, 2019 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 :scripts: prune-kernel : prunning kernel generalize way

This patch will remove old kernels from system selective way.

---
 scripts/prune-kernel | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)
scripts/prune-kernel +8 -8
index 74143f229f84..28fae6c91218 100755
@@ -33,7 +33,7 @@ printf "\t\n Enlist the installed kernels \n\n\n"
 cd $boot_dir && pwd
 
 #Bash experts not recomend to run ls inside script,but you can by running that too
-# ls -1 vmlinuz-*
+# ls -1 vmlinuz-*
 
 #This is the recommended way , little complex but that's what people want to see!
 
@@ -42,10 +42,10 @@ find $boot_dir -name "vmlinuz-*" -type f -print0 -exec ls -1 {} \;
 printf "\n\n\n Well, we need to purge some kernel to gain some space.\n\n\n"
 
 
-printf "Please give the kernel version to remove: %s"
+printf "Please give the kernel version to remove: %s"
 read kernel_version
 
-remove_old_kernel
+remove_old_kernel
 
 printf "\n\n Remove associated modules too ... \n\n"
 
@@ -54,7 +54,7 @@ cd $modules_dir && pwd
 printf "\n\n\n Enlist the installed modules \n\n\n"
 
 #This is (-1) minus one not l(el)
-# ls -1
+# ls -1
 
 find $modules_dir -name "$kernel_version-*" -type f -print0 -exec ls -1 {} \;
 
@@ -66,14 +66,14 @@ rm -rf $modules_version
 printf "\n\n Done \n\n"
 
 printf "\n\n Want to remove another?[Yn] : %s"
-read response
+read response
 
 
 if [[ $response == "Y" ]]; then
- printf "Please give another version to remove : %s"
+ printf "Please give another version to remove : %s"
  read kernel_version
 
-remove_old_kernel
+remove_old_kernel
 
 elif [[ $response == "n" ]]; then
 
@@ -81,4 +81,4 @@ elif [[ $response == "n" ]]; then
 
 fi
 
-exit 0
+exit 0

--
2.21.0

#1 lore raw

Subject: s/prunning/pruning/
Subject: s/:scripts:/scripts:/

Quoted 1 line · Bhaskar Chowdhury

This patch will remove old kernels from system selective way.

in a selective way.

Quoted 66 lines
---
 scripts/prune-kernel | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)
scripts/prune-kernel +8 -9
index 74143f229f84..28fae6c91218 100755
@@ -33,7 +33,7 @@ printf "\t\n Enlist the installed kernels \n\n\n"
 cd $boot_dir && pwd
 
 #Bash experts not recomend to run ls inside script,but you can by running that too
-# ls -1 vmlinuz-*
+# ls -1 vmlinuz-*
 
 #This is the recommended way , little complex but that's what people want to see!
 
@@ -42,10 +42,10 @@ find $boot_dir -name "vmlinuz-*" -type f -print0 -exec ls -1 {} \;
 printf "\n\n\n Well, we need to purge some kernel to gain some space.\n\n\n"
 
 
-printf "Please give the kernel version to remove: %s"
+printf "Please give the kernel version to remove: %s"
 read kernel_version
 
-remove_old_kernel
+remove_old_kernel
 
 printf "\n\n Remove associated modules too ... \n\n"
 
@@ -54,7 +54,7 @@ cd $modules_dir && pwd
 printf "\n\n\n Enlist the installed modules \n\n\n"
 
 #This is (-1) minus one not l(el)
-# ls -1
+# ls -1
 
 find $modules_dir -name "$kernel_version-*" -type f -print0 -exec ls -1 {} \;
 
@@ -66,14 +66,14 @@ rm -rf $modules_version
 printf "\n\n Done \n\n"
 
 printf "\n\n Want to remove another?[Yn] : %s"
-read response
+read response
 
 
 if [[ $response == "Y" ]]; then
- printf "Please give another version to remove : %s"
+ printf "Please give another version to remove : %s"
  read kernel_version
 
-remove_old_kernel
+remove_old_kernel
 
 elif [[ $response == "n" ]]; then
 
@@ -81,4 +81,4 @@ elif [[ $response == "n" ]]; then
 
 fi
 
-exit 0
+exit 0
--
Quoted 2 lines

2.21.0

Trying to apply this patch with 'patch --verbose' says:

checking file scripts/prune-kernel
Using Plan A...
Hunk #1 FAILED at 33.
Hunk #2 FAILED at 42.
Hunk #3 FAILED at 54.
Hunk #4 FAILED at 66.
Hunk #5 FAILED at 81.
5 out of 5 hunks FAILED
Hmm... Ignoring the trailing garbage.
done

Those + and - lines with the same content don't make any sense.

And probably Cc: the author of the script:
J. Bruce Fields <[email protected]>

Signature · 1 line
~Randy
#2 lore raw
Quoted 91 lines · Randy Dunlap

Subject: s/prunning/pruning/
Subject: s/:scripts:/scripts:/

Quoted 1 line · Bhaskar Chowdhury

This patch will remove old kernels from system selective way.

in a selective way.

Quoted 66 lines
---
 scripts/prune-kernel | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)
scripts/prune-kernel +8 -9
index 74143f229f84..28fae6c91218 100755
@@ -33,7 +33,7 @@ printf "\t\n Enlist the installed kernels \n\n\n"
 cd $boot_dir && pwd
 
 #Bash experts not recomend to run ls inside script,but you can by running that too
-# ls -1 vmlinuz-*
+# ls -1 vmlinuz-*
 
 #This is the recommended way , little complex but that's what people want to see!
 
@@ -42,10 +42,10 @@ find $boot_dir -name "vmlinuz-*" -type f -print0 -exec ls -1 {} \;
 printf "\n\n\n Well, we need to purge some kernel to gain some space.\n\n\n"
 
 
-printf "Please give the kernel version to remove: %s"
+printf "Please give the kernel version to remove: %s"
 read kernel_version
 
-remove_old_kernel
+remove_old_kernel
 
 printf "\n\n Remove associated modules too ... \n\n"
 
@@ -54,7 +54,7 @@ cd $modules_dir && pwd
 printf "\n\n\n Enlist the installed modules \n\n\n"
 
 #This is (-1) minus one not l(el)
-# ls -1
+# ls -1
 
 find $modules_dir -name "$kernel_version-*" -type f -print0 -exec ls -1 {} \;
 
@@ -66,14 +66,14 @@ rm -rf $modules_version
 printf "\n\n Done \n\n"
 
 printf "\n\n Want to remove another?[Yn] : %s"
-read response
+read response
 
 
 if [[ $response == "Y" ]]; then
- printf "Please give another version to remove : %s"
+ printf "Please give another version to remove : %s"
  read kernel_version
 
-remove_old_kernel
+remove_old_kernel
 
 elif [[ $response == "n" ]]; then
 
@@ -81,4 +81,4 @@ elif [[ $response == "n" ]]; then
 
 fi
 
-exit 0
+exit 0
--
Quoted 2 lines

2.21.0

Trying to apply this patch with 'patch --verbose' says:

checking file scripts/prune-kernel
Using Plan A...
Hunk #1 FAILED at 33.
Hunk #2 FAILED at 42.
Hunk #3 FAILED at 54.
Hunk #4 FAILED at 66.
Hunk #5 FAILED at 81.
5 out of 5 hunks FAILED
Hmm... Ignoring the trailing garbage.
done

Quoted 7 lines

Those + and - lines with the same content don't make any sense.

And probably Cc: the author of the script:
J. Bruce Fields <[email protected]>

Signature · 1 line
~Randy

Thank you Randy, silly mistakes creeps in...my bad ...will correct that and resend.
BTW I haven't found Bruce's name anywhere...where did you get it? Or did I miss the obvious??

Ran against get_maintainers and it only throw a open list , no other names.So kinda, stump by that.

Time to redo it again...huh

Thanks,
Bhaskar

#3 lore raw
Quoted 97 lines · Bhaskar Chowdhury
Quoted 96 lines · Randy Dunlap

Subject: s/prunning/pruning/
Subject:  s/:scripts:/scripts:/

Quoted 1 line · Bhaskar Chowdhury

This patch will remove old kernels from system selective way.

                                                in a selective way.

Quoted 68 lines

---
 scripts/prune-kernel | 16 ++++++++--------

 1 file changed, 8 insertions(+), 8 deletions(-)
scripts/prune-kernel +0 -0
index 74143f229f84..28fae6c91218 100755
@@ -33,7 +33,7 @@ printf "\t\n Enlist the installed kernels \n\n\n"

 cd $boot_dir && pwd

 #Bash experts not recomend to run ls inside script,but you can by running that too

scripts/prune-kernel +1 -1
-# ls -1 vmlinuz-*
+# ls -1 vmlinuz-*

 #This is the recommended way , little complex but that's what people want to see!

scripts/prune-kernel +0 -0
@@ -42,10 +42,10 @@ find $boot_dir -name "vmlinuz-*" -type f -print0 -exec ls -1 {} \;

 printf "\n\n\n Well, we need to purge some kernel to gain some space.\n\n\n"

scripts/prune-kernel +1 -1
-printf "Please give the kernel version to remove: %s"
+printf "Please give the kernel version to remove: %s"

 read kernel_version

scripts/prune-kernel +1 -1
-remove_old_kernel
+remove_old_kernel

 printf "\n\n Remove associated modules too ... \n\n"

scripts/prune-kernel +0 -0
@@ -54,7 +54,7 @@ cd $modules_dir && pwd

 printf "\n\n\n Enlist the installed modules \n\n\n"

 #This is (-1) minus one not l(el)

scripts/prune-kernel +1 -1
-# ls -1
+# ls -1

 find $modules_dir -name "$kernel_version-*" -type f -print0 -exec ls -1 {} \;

scripts/prune-kernel +0 -0
@@ -66,14 +66,14 @@ rm -rf $modules_version

 printf "\n\n Done \n\n"

 printf "\n\n Want to remove another?[Yn] : %s"

scripts/prune-kernel +1 -1
-read response
+read response

 if [[ $response == "Y" ]]; then
- printf "Please give another version to remove : %s"
+ printf "Please give another version to remove : %s" read kernel_version

scripts/prune-kernel +1 -1
-remove_old_kernel
+remove_old_kernel

 elif [[ $response == "n" ]]; then

scripts/prune-kernel +0 -0
@@ -81,4 +81,4 @@ elif [[ $response == "n" ]]; then
 

 fi

scripts/prune-kernel +1 -1
-exit 0
+exit 0
Signature · 1 line
2.21.0

Trying to apply this patch with 'patch --verbose' says:

checking file scripts/prune-kernel
Using Plan A...
Hunk #1 FAILED at 33.
Hunk #2 FAILED at 42.
Hunk #3 FAILED at 54.
Hunk #4 FAILED at 66.
Hunk #5 FAILED at 81.
5 out of 5 hunks FAILED
Hmm...  Ignoring the trailing garbage.
done

Those + and - lines with the same content don't make any sense.

And probably Cc: the author of the script:
J. Bruce Fields <[email protected]>

Quoted 7 lines
Quoted 2 lines

--
~Randy

Thank you Randy, silly mistakes creeps in...my bad ...will correct that and resend.
BTW I haven't found Bruce's name anywhere...where did you get it? Or did I miss the obvious??

It's in the git repository history for this file.

Quoted 2 lines

Ran against get_maintainers and it only throw a open list , no other names.So kinda, stump by that.> Time to redo it again...huh

Signature · 1 line
~Randy