staging: rtl8188eu: rename variables to avoid mixed case
PATCH 1/3 staging: rtl8188eu: rename variables to avoid mixed case
Rename local variables to avoid mixed case.
max_AMPDU_len -> max_ampdu_lenmin_MPDU_spacing -> min_mpdu_spacing
Signed-off-by Michael Straube <[email protected]>
--- .../staging/rtl8188eu/core/rtw_wlan_util.c | 24 +++++++++---------- 1 file changed, 12 insertions(+), 12 deletions(-)
drivers/staging/rtl8188eu/core/rtw_wlan_util.c +12 -12
@@ -667,7 +667,7 @@ static void bwmode_update_check(struct adapter *padapter, struct ndis_802_11_varvoid HT_caps_handler (struct adapter *padapter,struct ndis_802_11_var_ie *pIE) {unsigned int i; -u8 max_AMPDU_len, min_MPDU_spacing; +u8 max_ampdu_len, min_mpdu_spacing;struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv;struct mlme_ext_info *pmlmeinfo = &pmlmeext->mlmext_info;struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
@@ -689,16 +689,16 @@ void HT_caps_handler(struct adapter *padapter, struct ndis_802_11_var_ie *pIE) }else {/* modify from fw by Thomas 2010/11/17 */ if ((pmlmeinfo->HT_caps.ampdu_params_info &0x3 ) > (pIE->data[i] &0x3 )) - max_AMPDU_len = pIE->data[i] &0x3 ; + max_ampdu_len = pIE->data[i] &0x3 ;else - max_AMPDU_len = pmlmeinfo->HT_caps.ampdu_params_info &0x3 ; + max_ampdu_len = pmlmeinfo->HT_caps.ampdu_params_info &0x3 ;if ((pmlmeinfo->HT_caps.ampdu_params_info &0x1c ) > (pIE->data[i] &0x1c )) - min_MPDU_spacing = pmlmeinfo->HT_caps.ampdu_params_info &0x1c ; + min_mpdu_spacing = pmlmeinfo->HT_caps.ampdu_params_info &0x1c ;else - min_MPDU_spacing = pIE->data[i] &0x1c ; + min_mpdu_spacing = pIE->data[i] &0x1c ; - pmlmeinfo->HT_caps.ampdu_params_info = max_AMPDU_len | min_MPDU_spacing; + pmlmeinfo->HT_caps.ampdu_params_info = max_ampdu_len | min_mpdu_spacing; } }
@@ -729,8 +729,8 @@ void HT_info_handler(struct adapter *padapter, struct ndis_802_11_var_ie *pIE)void HTOnAssocRsp (struct adapter *padapter) { -unsigned char max_AMPDU_len; -unsigned char min_MPDU_spacing; +unsigned char max_ampdu_len; +unsigned char min_mpdu_spacing;struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv;struct mlme_ext_info *pmlmeinfo = &pmlmeext->mlmext_info;
@@ -748,13 +748,13 @@ void HTOnAssocRsp(struct adapter *padapter)* AMPDU_para [1:0]:Max AMPDU Len => 0:8k , 1:16k, 2:32k, 3:64k * AMPDU_para [4:2]:Min MPDU Start Spacing */ - max_AMPDU_len = pmlmeinfo->HT_caps.ampdu_params_info &0x03 ; + max_ampdu_len = pmlmeinfo->HT_caps.ampdu_params_info &0x03 ; - min_MPDU_spacing = (pmlmeinfo->HT_caps.ampdu_params_info &0x1c ) >>2 ; + min_mpdu_spacing = (pmlmeinfo->HT_caps.ampdu_params_info &0x1c ) >>2 ; -rtw_hal_set_hwreg (padapter,HW_VAR_AMPDU_MIN_SPACE , (u8 *)(&min_MPDU_spacing)); +rtw_hal_set_hwreg (padapter,HW_VAR_AMPDU_MIN_SPACE , (u8 *)(&min_mpdu_spacing)); -rtw_hal_set_hwreg (padapter,HW_VAR_AMPDU_FACTOR , (u8 *)(&max_AMPDU_len)); +rtw_hal_set_hwreg (padapter,HW_VAR_AMPDU_FACTOR , (u8 *)(&max_ampdu_len)); }void ERP_IE_handler (struct adapter *padapter,struct ndis_802_11_var_ie *pIE)
Signature · 1 line
2.23.0
PATCH 2/3 staging: rtl8188eu: convert variables from unsigned char to u8
Convert the local variables max_ampdu_len and min_mpdu_spacing from unsigned char to u8 and remove unnecessary castings to u8 pointer.
Signed-off-by Michael Straube <[email protected]>
--- drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/staging/rtl8188eu/core/rtw_wlan_util.c +4 -4
@@ -729,8 +729,8 @@ void HT_info_handler(struct adapter *padapter, struct ndis_802_11_var_ie *pIE)void HTOnAssocRsp (struct adapter *padapter) { -unsigned char max_ampdu_len; -unsigned char min_mpdu_spacing; +u8 max_ampdu_len; +u8 min_mpdu_spacing;struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv;struct mlme_ext_info *pmlmeinfo = &pmlmeext->mlmext_info;
@@ -752,9 +752,9 @@ void HTOnAssocRsp(struct adapter *padapter) min_mpdu_spacing = (pmlmeinfo->HT_caps.ampdu_params_info &0x1c ) >>2 ; -rtw_hal_set_hwreg (padapter,HW_VAR_AMPDU_MIN_SPACE , (u8 *)(&min_mpdu_spacing)); +rtw_hal_set_hwreg (padapter,HW_VAR_AMPDU_MIN_SPACE , &min_mpdu_spacing); -rtw_hal_set_hwreg (padapter,HW_VAR_AMPDU_FACTOR , (u8 *)(&max_ampdu_len)); +rtw_hal_set_hwreg (padapter,HW_VAR_AMPDU_FACTOR , &max_ampdu_len); }void ERP_IE_handler (struct adapter *padapter,struct ndis_802_11_var_ie *pIE)
Signature · 1 line
2.23.0
PATCH 3/3 staging: rtl8188eu: remove blank lines
In reply to Michael StraubeRemove blank lines to reduce whitespace and improve readability.
Signed-off-by Michael Straube <[email protected]>
--- drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 2 -- 1 file changed, 2 deletions(-)
drivers/staging/rtl8188eu/core/rtw_wlan_util.c +0 -2
@@ -749,11 +749,9 @@ void HTOnAssocRsp(struct adapter *padapter)* AMPDU_para [4:2]:Min MPDU Start Spacing */ max_ampdu_len = pmlmeinfo->HT_caps.ampdu_params_info &0x03 ; - min_mpdu_spacing = (pmlmeinfo->HT_caps.ampdu_params_info &0x1c ) >>2 ;rtw_hal_set_hwreg (padapter,HW_VAR_AMPDU_MIN_SPACE , &min_mpdu_spacing); -rtw_hal_set_hwreg (padapter,HW_VAR_AMPDU_FACTOR , &max_ampdu_len); }
Signature · 1 line
2.23.0