staging: KPC2000: kpc2000_spi.c: Fix style issues (missing blank line)
PATCH 1/4 staging: KPC2000: kpc2000_spi.c: Fix style issues (missing blank line)
Resolved: "CHECK: Please use a blank line after.." from checkpatch.pl
---
Previous versions of these patches were not split into different patches, did not have different patch numbers and did not have the keyword staging.
drivers/staging/kpc2000/kpc2000_spi.c | 1 + 1 file changed, 1 insertion(+)
drivers/staging/kpc2000/kpc2000_spi.c +1 -0
@@ -50,6 +50,7 @@ static struct flash_platform_data p2kr0_spi0_pdata = { .nr_parts = ARRAY_SIZE(p2kr0_spi0_parts), .parts = p2kr0_spi0_parts, }; +static struct flash_platform_data p2kr0_spi1_pdata = { .name ="SPI1" , .nr_parts =ARRAY_SIZE (p2kr0_spi1_parts),
Signature · 1 line
2.20.1
PATCH 2/4 staging: KPC2000: kpc2000_spi.c: Fix style issues (alignment)
Resolved: "CHECK: Alignment should match open parenthesis" from checkpatch
---
Previous versions of these patches were not split into different patches, did not have different patch numbers and did not have the keyword staging.
drivers/staging/kpc2000/kpc2000_spi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/kpc2000/kpc2000_spi.c +1 -2
@@ -226,8 +226,7 @@ kp_spi_txrx_pio(struct spi_device *spidev, struct spi_transfer *transfer)kp_spi_write_reg (cs,KP_SPI_REG_TXDATA , val); processed++; } - } -else if (rx) { + }else if (rx) {for (i =0 ; i < c ; i++) {char test =0 ;
Signature · 1 line
2.20.1
Re: [PATCH 2/4] staging: KPC2000: kpc2000_spi.c: Fix style issues (alignment)
Quoted 2 lines · Chandra Annamaneni
Resolved: "CHECK: Alignment should match open parenthesis" from checkpatch
I think you accidentally copied the wrong commit message. This one and the next are the same. This description doesn't match the patch.
regards,
dan carpenter
PATCH 3/4 staging: KPC2000: kpc2000_spi.c: Fix style issues (alignment)
In reply to Chandra AnnamaneniResolved: "CHECK: Alignment should match open parenthesis" from checkpatch
---
Previous versions of these patches were not split into different patches, did not have different patch numbers and did not have the keyword staging.
drivers/staging/kpc2000/kpc2000_spi.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/staging/kpc2000/kpc2000_spi.c +7 -7
@@ -313,19 +313,19 @@ kp_spi_transfer_one_message(struct spi_master *master, struct spi_message *m)if (transfer->speed_hz >KP_SPI_CLK || (len && !(rx_buf || tx_buf))) {dev_dbg (kpspi->dev," transfer: %d Hz, %d %s%s, %d bpw\n" , - transfer->speed_hz, - len, - tx_buf ?"tx" :"" , - rx_buf ?"rx" :"" , - transfer->bits_per_word); + transfer->speed_hz, + len, + tx_buf ?"tx" :"" , + rx_buf ?"rx" :"" , + transfer->bits_per_word);dev_dbg (kpspi->dev," transfer -EINVAL\n" );return -EINVAL ; }if (transfer->speed_hz && transfer->speed_hz < (KP_SPI_CLK >>15 )) {dev_dbg (kpspi->dev,"speed_hz %d below minimum %d Hz\n" , - transfer->speed_hz, -KP_SPI_CLK >>15 ); + transfer->speed_hz, +KP_SPI_CLK >>15 );dev_dbg (kpspi->dev," speed_hz -EINVAL\n" );return -EINVAL ; }
Signature · 1 line
2.20.1
PATCH 4/4 staging: KPC2000: kpc2000_spi.c: Fix style issues (Unnecessary parenthesis)
In reply to Chandra AnnamaneniResolved: CHECK: Unnecessary parentheses around table[i]
---
Previous versions of these patches were not split into different patches, did not have different patch numbers and did not have the keyword staging.
drivers/staging/kpc2000/kpc2000_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/kpc2000/kpc2000_spi.c +1 -1
@@ -476,7 +476,7 @@ kp_spi_probe(struct platform_device *pldev)/* register the slave boards */ #define NEW_SPI_DEVICE_FROM_BOARD_INFO_TABLE (table) \ for (i = 0 ; i < ARRAY_SIZE(table) ; i++) { \ - spi_new_device(master, &(table[i])); \ + spi_new_device(master, &table[i]); \ }switch ((drvdata->card_id &0xFFFF0000 ) >>16 ) {
Signature · 1 line
2.20.1