debugfs: remove return value of debugfs_create_atomic_t()
Subsystems (2)
Greg Kroah-Hartman
maintainerPATCH 1/1 debugfs: remove return value of debugfs_create_atomic_t()
No one checks the return value of debugfs_create_atomic_t(), as it's not needed, so make the return value void, so that no one tries to do so in the future.
Signed-off-by Greg Kroah-Hartman <[email protected]>
--- Documentation/filesystems/debugfs.txt | 4 ++-- fs/debugfs/file.c | 9 ++++----- include/linux/debugfs.h | 13 ++++++------- 3 files changed, 12 insertions(+), 14 deletions(-)
Documentation/filesystems/debugfs.txt +2 -2
@@ -113,8 +113,8 @@ lower-case values, or 1 or 0. Any other input will be silently ignored. Also, atomic_t values can be placed in debugfs with: - struct dentry *debugfs_create_atomic_t(const char *name, umode_t mode, - struct dentry *parent, atomic_t *value) + void debugfs_create_atomic_t(const char *name, umode_t mode, + struct dentry *parent, atomic_t *value) A read of this file will get atomic_t values, and a write of this file will set atomic_t values.
fs/debugfs/file.c +4 -5
@@ -748,12 +748,11 @@ DEFINE_DEBUGFS_ATTRIBUTE(fops_atomic_t_wo, NULL, debugfs_atomic_t_set,* @value: a pointer to the variable that the file should read to and write * from. */ -struct dentry *debugfs_create_atomic_t (const char *name,umode_t mode, -struct dentry *parent,atomic_t *value) +void debugfs_create_atomic_t (const char *name,umode_t mode, +struct dentry *parent,atomic_t *value) { -return debugfs_create_mode_unsafe (name, mode, parent, value, - &fops_atomic_t, &fops_atomic_t_ro, - &fops_atomic_t_wo); +debugfs_create_mode_unsafe (name, mode, parent, value, &fops_atomic_t, + &fops_atomic_t_ro, &fops_atomic_t_wo); }EXPORT_SYMBOL_GPL (debugfs_create_atomic_t);
include/linux/debugfs.h +6 -7
@@ -117,8 +117,8 @@ void debugfs_create_x64(const char *name, umode_t mode, struct dentry *parent, u64 *value);void debugfs_create_size_t (const char *name,umode_t mode,struct dentry *parent,size_t *value); -struct dentry *debugfs_create_atomic_t (const char *name,umode_t mode, -struct dentry *parent,atomic_t *value); +void debugfs_create_atomic_t (const char *name,umode_t mode, +struct dentry *parent,atomic_t *value);struct dentry *debugfs_create_bool (const char *name,umode_t mode,struct dentry *parent,bool *value);
@@ -280,11 +280,10 @@ static inline void debugfs_create_size_t(const char *name, umode_t mode, struct dentry *parent, size_t *value) { } -static inline struct dentry *debugfs_create_atomic_t (const char *name,umode_t mode, -struct dentry *parent,atomic_t *value) -{ -return ERR_PTR (-ENODEV ); -} +static inline void debugfs_create_atomic_t (const char *name,umode_t mode, +struct dentry *parent, +atomic_t *value) +{ } static inline struct dentry *debugfs_create_bool(const char *name, umode_t mode, struct dentry *parent,
Signature · 1 line
2.23.0