Skip to contentSkip to conversation

scripts : mksysmap : NM variable missed the value,so fixed

PATCH In review Bhaskar Chowdhury 2 participants 3 messages Oct 17, 2019 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scripts : mksysmap : NM variable missed the value,so fixed

This patch will provide the missing value for NM variable.

---
TO all,
Adjusted the subject line, missed in previous one,sorry

 scripts/mksysmap | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/mksysmap +1 -1
index a35acc0d0b82..4b2f45c45f14 100755
@@ -40,5 +40,5 @@
 # 'W' or 'w'. __crc_ are 'A' and placed in the middle
 # so we just ignore them to let readprofile continue to work.
 # (At least sparc64 has __crc_ in the middle).
-
+NM=$(which nm)
 $NM -n $1 | grep -v '\( [aNUw] \)\|\(__crc_\)\|\( \$[adt]\)\|\( .L\)' > $2

--
2.21.0

#1 lore raw
Quoted 2 lines · Bhaskar Chowdhury

This patch will provide the missing value for NM variable.

Hi,

Does this patch fix some build error that you have encountered? If so, please describe it and how to cause it.

Quoted 13 lines

---
TO all,
Adjusted the subject line, missed in previous one,sorry

 scripts/mksysmap | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/mksysmap +0 -0
index a35acc0d0b82..4b2f45c45f14 100755

scripts/mksysmap line 43

Quoted 5 lines
scripts/mksysmap +1 -1
@@ -40,5 +40,5 @@
 # 'W' or 'w'. __crc_ are 'A' and placed in the middle
 # so we just ignore them to let readprofile continue to work.
 # (At least sparc64 has __crc_ in the middle).
-
+NM=$(which nm)

That's not the POSIX way to do that. It should be

NM=$(command -v nm)

But why is this needed at all?
The top-level Makefile exports the NM variable (and many more) to scripts that it calls.

Quoted 4 lines
scripts/mksysmap +0 -1
 $NM -n $1 | grep -v '\( [aNUw] \)\|\(__crc_\)\|\( \$[adt]\)\|\( .L\)' > $2
--

2.21.0

Signature · 1 line
~Randy
#2 lore raw
Quoted 9 lines · Randy Dunlap
Quoted 2 lines · Bhaskar Chowdhury

This patch will provide the missing value for NM variable.

Hi,

Does this patch fix some build error that you have encountered? If so, please describe it and how to cause it.

Okay, I tried to do that ,the script spit out not finding the nm. Now, the sole reason being I misread it in the first place.

Quoted 22 lines
Quoted 14 lines

---
TO all,
Adjusted the subject line, missed in previous one,sorry

 scripts/mksysmap | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/mksysmap +0 -0
index a35acc0d0b82..4b2f45c45f14 100755

scripts/mksysmap line 43

Quoted 5 lines
scripts/mksysmap +1 -1
@@ -40,5 +40,5 @@
 # 'W' or 'w'. __crc_ are 'A' and placed in the middle
 # so we just ignore them to let readprofile continue to work.
 # (At least sparc64 has __crc_ in the middle).
-
+NM=$(which nm)

That's not the POSIX way to do that. It should be

Quoted 6 lines

NM=$(command -v nm)

But why is this needed at all?
The top-level Makefile exports the NM variable (and many more) to scripts that it calls.

Misread it.

Quoted 5 lines
Quoted 4 lines
scripts/mksysmap +0 -1
 $NM -n $1 | grep -v '\( [aNUw] \)\|\(__crc_\)\|\( \$[adt]\)\|\( .L\)' > $2
--

2.21.0

Sorry about the noise. Thanks Randy for catch up lackluster stuff.

Quoted 4 lines
Signature · 2 lines
-- 
~Randy