staging: sm750sb: Edit CamelCase in dvi/sii164 files
Subsystems (2)
PATCH v4 1/1 staging: sm750sb: Edit CamelCase in dvi/sii164 files
Edits CamelCase naming in a group of dependent
sm750fb files. Issue found by checkpatch.
Removes hungarian notation as well as part of fix to CamelCase in a given word.
---
Changes in v4:
- Revert removal of dviInt function and global variable. The change will be part of a separate patch to handle the removal.
Changes in v3:
- Fix checkpatch warning for multiple blank lines that occured after deleting function and variable.
Changes in v2:
- Remove dviInt function and global variable because they are not used.
- Remove hungarion notation prefixes.
--- drivers/staging/sm750fb/ddk750_dvi.c | 68 ++++----- drivers/staging/sm750fb/ddk750_dvi.h | 80 +++++----- drivers/staging/sm750fb/ddk750_sii164.c | 185 ++++++++++++------------ drivers/staging/sm750fb/ddk750_sii164.h | 40 ++--- 4 files changed, 187 insertions(+), 186 deletions(-)
drivers/staging/sm750fb/ddk750_dvi.c +34 -34
@@ -11,50 +11,50 @@* function API. Please set the function pointer to NULL whenever the function * is not supported. */ -static struct dvi_ctrl_device g_dcftSupportedDviController[] = { +static struct dvi_ctrl_device dcft_supported_dvi_controller[] = { #ifdef DVI_CTRL_SII164 { - .pfnInit = sii164InitChip, - .pfnGetVendorId = sii164GetVendorID, - .pfnGetDeviceId = sii164GetDeviceID, + .init = sii164_init_chip, + .get_vendor_id = sii164_get_vendor_id, + .get_device_id = sii164_get_device_id, #ifdef SII164_FULL_FUNCTIONS - .pfnResetChip = sii164ResetChip, - .pfnGetChipString = sii164GetChipString, - .pfnSetPower = sii164SetPower, - .pfnEnableHotPlugDetection = sii164EnableHotPlugDetection, - .pfnIsConnected = sii164IsConnected, - .pfnCheckInterrupt = sii164CheckInterrupt, - .pfnClearInterrupt = sii164ClearInterrupt, + .reset_chip = sii164_reset_chip, + .get_chip_string = sii164_get_chip_string, + .set_power = sii164_set_power, + .enable_hot_plug_detection = sii164_enable_hot_plug_detection, + .is_connected = sii164_is_connected, + .check_interrupt = sii164_check_interrupt, + .clear_interrupt = sii164_clear_interrupt, #endif }, #endif }; -int dviInit (unsigned char edge_select, -unsigned char bus_select, -unsigned char dual_edge_clk_select, -unsigned char hsync_enable, -unsigned char vsync_enable, -unsigned char deskew_enable, -unsigned char deskew_setting, -unsigned char continuous_sync_enable, -unsigned char pll_filter_enable, -unsigned char pll_filter_value) +int dvi_init (unsigned char edge_select, +unsigned char bus_select, +unsigned char dual_edge_clk_select, +unsigned char hsync_enable, +unsigned char vsync_enable, +unsigned char deskew_enable, +unsigned char deskew_setting, +unsigned char continuous_sync_enable, +unsigned char pll_filter_enable, +unsigned char pll_filter_value) { -struct dvi_ctrl_device *pCurrentDviCtrl; +struct dvi_ctrl_device *current_dvi_ctrl; - pCurrentDviCtrl = g_dcftSupportedDviController; -if (pCurrentDviCtrl->pfnInit) { -return pCurrentDviCtrl->pfnInit (edge_select, - bus_select, - dual_edge_clk_select, - hsync_enable, - vsync_enable, - deskew_enable, - deskew_setting, - continuous_sync_enable, - pll_filter_enable, - pll_filter_value); + current_dvi_ctrl = dcft_supported_dvi_controller; +if (current_dvi_ctrl->init) { +return current_dvi_ctrl->init (edge_select, + bus_select, + dual_edge_clk_select, + hsync_enable, + vsync_enable, + deskew_enable, + deskew_setting, + continuous_sync_enable, + pll_filter_enable, + pll_filter_value); }return -1 ;/* error */ }
drivers/staging/sm750fb/ddk750_dvi.h +40 -40
94 lines not on this page · raw message
drivers/staging/sm750fb/ddk750_sii164.c +93 -92
363 lines not on this page · raw message
drivers/staging/sm750fb/ddk750_sii164.h +20 -20
@@ -16,28 +16,28 @@ enum sii164_hot_plug_mode { };/* Silicon Image SiI164 chip prototype */ -long sii164InitChip (unsigned char edgeSelect, -unsigned char busSelect, -unsigned char dualEdgeClkSelect, -unsigned char hsyncEnable, -unsigned char vsyncEnable, -unsigned char deskewEnable, -unsigned char deskewSetting, -unsigned char continuousSyncEnable, -unsigned char pllFilterEnable, -unsigned char pllFilterValue); - -unsigned short sii164GetVendorID (void ); -unsigned short sii164GetDeviceID (void ); +long sii164_init_chip (unsigned char edge_select, +unsigned char bus_select, +unsigned char dual_edge_clk_select, +unsigned char hsync_enable, +unsigned char vsync_enable, +unsigned char deskew_enable, +unsigned char deskew_setting, +unsigned char continuous_sync_enable, +unsigned char pll_filter_enable, +unsigned char pll_filter_value); + +unsigned short sii164_get_vendor_id (void ); +unsigned short sii164_get_device_id (void );#ifdef SII164_FULL_FUNCTIONS -void sii164ResetChip (void ); -char *sii164GetChipString (void ); -void sii164SetPower (unsigned char powerUp); -void sii164EnableHotPlugDetection (unsigned char enableHotPlug); -unsigned char sii164IsConnected (void ); -unsigned char sii164CheckInterrupt (void ); -void sii164ClearInterrupt (void ); +void sii164_reset_chip (void ); +char *sii164_get_chip_string (void ); +void sii164_set_power (unsigned char power_up); +void sii164_enable_hot_plug_detection (unsigned char enable_hot_plug); +unsigned char sii164_is_connected (void ); +unsigned char sii164_check_interrupt (void ); +void sii164_clear_interrupt (void );#endif /* * below register definition is used for
Signature · 1 line
2.17.1
Greg KH
maintainerRe: [Outreachy kernel] [PATCH v4] staging: sm750fb: Edit CamelCase in dvi/sii164 files
Quoted 7 lines · Jamal Shareef
Edits CamelCase naming in a group of dependent
sm750fb files. Issue found by checkpatch.Removes hungarian notation as well as part of fix to CamelCase in a given word.
Signed-off-by Jamal Shareef <[email protected]>
You have sent a bunch of these CamelCase fixes for this driver, yet I have no idea which ones are to be applied, nor in what order. Also I tried applying some of them, and the build breaks :(
So can you resend all of the outstanding ones, in a numbered patch series so I have a chance to get it right, after you test that they build properly?
thanks,
greg k-h