Skip to contentSkip to conversation

configs: spi: Miss the SPI_FLASH_BAR for ESPI

PATCH New Xiaowei Bao 3 participants 5 messages Oct 21, 2019 – Oct 25, 2019 SPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 configs: spi: Miss the SPI_FLASH_BAR for ESPI

Miss the SPI_FLASH_BAR for the ESPI controller of FSL.

---
 drivers/spi/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/spi/Kconfig +1 -0
index b8ca2bd..7003569 100644
@@ -367,6 +367,7 @@ config CF_SPI
 
 config FSL_ESPI
 	bool "Freescale eSPI driver"
+	imply SPI_FLASH_BAR
 	help
 	  Enable the Freescale eSPI driver. This driver can be used to
 	  access the SPI interface and SPI NOR flash on platforms embedding
Signature · 1 line
2.9.5
#1 lore raw

PATCH 1/1 configs: spi: Miss the SPI_FLASH_BAR for ESPI

Quoted 9 lines

-----Original Message-----
From: U-Boot <[email protected]> On Behalf Of Xiaowei Bao
Sent: Monday, October 21, 2019 2:32 PM
To: Jagdish Gediya <[email protected]>; jagan at amarulasolutions.com; u-boot at lists.denx.de
Cc: Xiaowei Bao <[email protected]>
Subject: [U-Boot] [PATCH] configs: spi: Miss the SPI_FLASH_BAR for ESPI

configs: spi: -> spi: Kconfig

I understand you are adding config, because you have missed it earlier. But better would be something like Miss->Add

ESPI -> FSL_ESPI

Quoted 17 lines

Miss the SPI_FLASH_BAR for the ESPI controller of FSL.

---
drivers/spi/Kconfig | 1 +

1 file changed, 1 insertion(+)
drivers/spi/Kconfig index b8ca2bd..7003569 renamed from drivers/spi/Kconfig +0 -0

100644

drivers/spi/Kconfig +0 -0
@@ -367,6 +367,7 @@ config CF_SPI
 

config FSL_ESPI
bool "Freescale eSPI driver"

drivers/spi/Kconfig +1 -0
+	imply SPI_FLASH_BAR
Quoted 4 lines

help
Enable the Freescale eSPI driver. This driver can be used to access the SPI interface and SPI NOR flash on platforms embedding
--

--priyankajain

#2 lore raw

PATCH 1/1 configs: spi: Miss the SPI_FLASH_BAR for ESPI

Quoted 20 lines

-----Original Message-----
From: Priyanka Jain <[email protected]>
Sent: 2019年10月22日 17:45
To: Xiaowei Bao <[email protected]>; Jagdish Gediya <[email protected]>; jagan at amarulasolutions.com;
u-boot at lists.denx.de
Cc: Xiaowei Bao <[email protected]>
Subject: RE: [U-Boot] [PATCH] configs: spi: Miss the SPI_FLASH_BAR for ESPI

Quoted 7 lines

-----Original Message-----
From: U-Boot <[email protected]> On Behalf Of Xiaowei Bao
Sent: Monday, October 21, 2019 2:32 PM
To: Jagdish Gediya <[email protected]>;
jagan at amarulasolutions.com; u-boot at lists.denx.de
Cc: Xiaowei Bao <[email protected]>
Subject: [U-Boot] [PATCH] configs: spi: Miss the SPI_FLASH_BAR for ESPI

Quoted 4 lines

configs: spi: -> spi: Kconfig

I understand you are adding config, because you have missed it earlier. But better would be something like Miss->Add

Thanks for your comments, this CONFIG option is missed by Jagan Teki, so I add it in Kconfig file, otherwise, the ESPI will not work in some PPC board.

Thanks
Xiaowei

Quoted 26 lines

ESPI -> FSL_ESPI

Quoted 18 lines

Miss the SPI_FLASH_BAR for the ESPI controller of FSL.

---
drivers/spi/Kconfig | 1 +

1 file changed, 1 insertion(+)
drivers/spi/Kconfig index renamed from drivers/spi/Kconfig +0 -0

b8ca2bd..7003569
100644

drivers/spi/Kconfig +0 -0
@@ -367,6 +367,7 @@ config CF_SPI
 

config FSL_ESPI
bool "Freescale eSPI driver"

drivers/spi/Kconfig +1 -0
+	imply SPI_FLASH_BAR
Quoted 4 lines

help
Enable the Freescale eSPI driver. This driver can be used to access the SPI interface and SPI NOR flash on platforms embedding
--

--priyankajain

#3 lore raw

PATCH 1/1 configs: spi: Miss the SPI_FLASH_BAR for ESPI

Quoted 21 lines · Xiaowei Bao
Quoted 21 lines

-----Original Message-----
From: Priyanka Jain <[email protected]>
Sent: 2019年10月22日 17:45
To: Xiaowei Bao <[email protected]>; Jagdish Gediya <[email protected]>; jagan at amarulasolutions.com;
u-boot at lists.denx.de
Cc: Xiaowei Bao <[email protected]>
Subject: RE: [U-Boot] [PATCH] configs: spi: Miss the SPI_FLASH_BAR for ESPI

Quoted 7 lines

-----Original Message-----
From: U-Boot <[email protected]> On Behalf Of Xiaowei Bao
Sent: Monday, October 21, 2019 2:32 PM
To: Jagdish Gediya <[email protected]>;
jagan at amarulasolutions.com; u-boot at lists.denx.de
Cc: Xiaowei Bao <[email protected]>
Subject: [U-Boot] [PATCH] configs: spi: Miss the SPI_FLASH_BAR for ESPI

Quoted 7 lines
Quoted 4 lines

configs: spi: -> spi: Kconfig

I understand you are adding config, because you have missed it earlier. But better would be something like Miss->Add

Thanks for your comments, this CONFIG option is missed by Jagan Teki, so I add it in Kconfig file, otherwise, the ESPI will not work in some PPC board.

Did I miss while moving around? please mark the commit where it missed it would help to track where the issue comes from.

#4 lore raw

PATCH 1/1 configs: spi: Miss the SPI_FLASH_BAR for ESPI

Quoted 41 lines

-----Original Message-----
From: Jagan Teki <[email protected]>
Sent: 2019年10月24日 3:40
To: Xiaowei Bao <[email protected]>
Cc: Priyanka Jain <[email protected]>; Jagdish Gediya <[email protected]>; u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCH] configs: spi: Miss the SPI_FLASH_BAR for ESPI

Quoted 29 lines · Xiaowei Bao
Quoted 28 lines

-----Original Message-----
From: Priyanka Jain <[email protected]>
Sent: 2019年10月22日 17:45
To: Xiaowei Bao <[email protected]>; Jagdish Gediya <[email protected]>; jagan at amarulasolutions.com; u-boot at lists.denx.de
Cc: Xiaowei Bao <[email protected]>
Subject: RE: [U-Boot] [PATCH] configs: spi: Miss the SPI_FLASH_BAR for ESPI

Quoted 9 lines

-----Original Message-----
From: U-Boot <[email protected]> On Behalf Of Xiaowei Bao
Sent: Monday, October 21, 2019 2:32 PM
To: Jagdish Gediya <[email protected]>;
jagan at amarulasolutions.com; u-boot at lists.denx.de
Cc: Xiaowei Bao <[email protected]>
Subject: [U-Boot] [PATCH] configs: spi: Miss the SPI_FLASH_BAR for ESPI

configs: spi: -> spi: Kconfig

I understand you are adding config, because you have missed it earlier. But better would be something like Miss->Add

Quoted 6 lines
Quoted 2 lines

Thanks for your comments, this CONFIG option is missed by Jagan Teki, so I add it in Kconfig file, otherwise, the ESPI will not work in some PPC

board.

Did I miss while moving around? please mark the commit where it missed it would help to track where the issue comes from.

Oh, sorry, it is missed by Vignesh R, the commit is 6d82517836418f984b7b4c05cf1427d7b49b1169

Thanks
Xiaowei