Skip to contentSkip to conversation

esas2r: unlock on error in esas2r_nvram_read_direct()

PATCH Applied Dan Carpenter 2 participants 2 messages Oct 22, 2019 – Oct 25, 2019

Subsystems (3)
SCSI Kernel janitors Atto expresssas SAS/SATA RAID SCSI driver
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 esas2r: unlock on error in esas2r_nvram_read_direct()

This error path is missing an unlock.

Fixes 26780d9e12ed ("[SCSI] esas2r: ATTO Technology ExpressSAS 6G SAS/SATA RAID Adapter Driver")
Signed-off-by Dan Carpenter <[email protected]>
---
 drivers/scsi/esas2r/esas2r_flash.c | 1 +
 1 file changed, 1 insertion(+)
drivers/scsi/esas2r/esas2r_flash.c +1 -0
index 7bd376d95ed5..b02ac389e6c6 100644
@@ -1197,6 +1197,7 @@ bool esas2r_nvram_read_direct(struct esas2r_adapter *a)
 	if (!esas2r_read_flash_block(a, a->nvram, FLS_OFFSET_NVR,
 				     sizeof(struct esas2r_sas_nvram))) {
 		esas2r_hdebug("NVRAM read failed, using defaults");
+		up(&a->nvram_semaphore);
 		return false;
 	}
Signature · 1 line
2.20.1
Applied
#1 lore raw

Dan,

Quoted 1 line

This error path is missing an unlock.

Applied to 5.5/scsi-queue, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering