Skip to contentSkip to conversation

xfs: add mising include of xfs_pnfs.h for missing declarations

PATCH In review Ben Dooks (Codethink) 2 participants 2 messages Oct 22, 2019 XFS filesystem

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfs: add mising include of xfs_pnfs.h for missing declarations

The xfs_pnfs.c file is missing an include of xfs_pnfs.h to add the prototypes of the functions it exports. Include this file to fix the following sparse warnings:

fs/xfs/xfs_pnfs.c:27:1: warning: symbol 'xfs_break_leased_layouts' was not declared. Should it be static? fs/xfs/xfs_pnfs.c:52:1: warning: symbol 'xfs_fs_get_uuid' was not declared. Should it be static? fs/xfs/xfs_pnfs.c:77:1: warning: symbol 'xfs_fs_map_blocks' was not declared. Should it be static? fs/xfs/xfs_pnfs.c:226:1: warning: symbol 'xfs_fs_commit_blocks' was not declared. Should it be static?

---
Cc: "Darrick J. Wong" <[email protected]>
Cc: [email protected]
Cc: [email protected]

---
 fs/xfs/xfs_pnfs.c | 1 +
 1 file changed, 1 insertion(+)
fs/xfs/xfs_pnfs.c +1 -0
index a339bd5fa260..b2f6f1e3d9c4 100644
@@ -12,6 +12,7 @@
 #include "xfs_trans.h"
 #include "xfs_bmap.h"
 #include "xfs_iomap.h"
+#include "xfs_pnfs.h"
 
 /*
  * Ensure that we do not have any outstanding pNFS layouts that can be used by
Signature · 1 line
2.23.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Ben Dooks (Codethink)

The xfs_pnfs.c file is missing an include of xfs_pnfs.h to add the prototypes of the functions it exports. Include this file to fix the following sparse warnings:

fs/xfs/xfs_pnfs.c:27:1: warning: symbol 'xfs_break_leased_layouts' was not declared. Should it be static? fs/xfs/xfs_pnfs.c:52:1: warning: symbol 'xfs_fs_get_uuid' was not declared. Should it be static? fs/xfs/xfs_pnfs.c:77:1: warning: symbol 'xfs_fs_map_blocks' was not declared. Should it be static? fs/xfs/xfs_pnfs.c:226:1: warning: symbol 'xfs_fs_commit_blocks' was not declared. Should it be static?

Looks ok,

--D

Quoted 23 lines

---
Cc: "Darrick J. Wong" <[email protected]>
Cc: [email protected]
Cc: [email protected]

---
 fs/xfs/xfs_pnfs.c | 1 +
 1 file changed, 1 insertion(+)
fs/xfs/xfs_pnfs.c +1 -0
index a339bd5fa260..b2f6f1e3d9c4 100644
@@ -12,6 +12,7 @@
 #include "xfs_trans.h"
 #include "xfs_bmap.h"
 #include "xfs_iomap.h"
+#include "xfs_pnfs.h"
 
 /*
  * Ensure that we do not have any outstanding pNFS layouts that can be used by
Signature · 1 line
2.23.0