Staging: comedi: Remove wrapper function declarartion
PATCH 1/7 Staging: comedi: Remove wrapper function declarartion
Remove wrapper function "comedi_buf_map_get" declaration as part of remove all wrappers in drivers/staging/comedi/TODO
--- drivers/staging/comedi/comedi_internal.h | 1 - 1 file changed, 1 deletion(-)
drivers/staging/comedi/comedi_internal.h +0 -1
@@ -28,7 +28,6 @@ int comedi_buf_alloc(struct comedi_device *dev, struct comedi_subdevice *s, unsigned long new_size);void comedi_buf_reset (struct comedi_subdevice *s);bool comedi_buf_is_mmapped (struct comedi_subdevice *s); -void comedi_buf_map_get (struct comedi_buf_map *bm);int comedi_buf_map_put (struct comedi_buf_map *bm);int comedi_buf_map_access (struct comedi_buf_map *bm,unsigned long offset,void *buf,int len,int write);
Signature · 1 line
2.17.1
Quoted 14 lines · Evan Chime
Remove wrapper function "
comedi_buf_map_get" declaration as part of remove all wrappers indrivers/staging/comedi/TODOSigned-off-by Evan Chime <[email protected]>--- drivers/staging/comedi/comedi_internal.h | 1 - 1 file changed, 1 deletion(-)drivers/staging/comedi/comedi_internal.h +0
-0
drivers/staging/comedi/comedi_internal.h int comedi_buf_alloc(struct comedi_device *dev, struct comedi_subdevice *s, · line 33
Quoted 7 lines
drivers/staging/comedi/comedi_internal.h +0
-1@@ -28,7 +28,6 @@ int comedi_buf_alloc(struct comedi_device *dev, struct comedi_subdevice *s, unsigned long new_size);void comedi_buf_reset (struct comedi_subdevice *s);bool comedi_buf_is_mmapped (struct comedi_subdevice *s); -void comedi_buf_map_get (struct comedi_buf_map *bm);int comedi_buf_map_put (struct comedi_buf_map *bm);int comedi_buf_map_access (struct comedi_buf_map *bm,unsigned long offset,void *buf,int len,int write);
Sorry, I don't really see the point of this patch series. For a start, the comedi_buf_map functions were added a long time after the TODO file was written. I can't even remember what the "remove all wrappers" line in the TODO file is referring to.
Besides that, as pointed out by Julia, the patches have been ordered in such a way as to break the build between the patches.
Signature · 4 lines
-=( Ian Abbott <[email protected]> || Web: www.mev.co.uk )=- -=( MEV Ltd. is a company registered in England & Wales. )=- -=( Registered number: 02862268. Registered address: )=- -=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=-
Hello Ian
Thanks for the reply. Got it
Kind Regards
Evan
Quoted 40 lines · Ian Abbott
Review
Quoted 9 lines · Evan Chime
Remove wrapper function "
comedi_buf_map_get" declaration as part of remove all wrappers indrivers/staging/comedi/TODOSigned-off-by Evan Chime <[email protected]>--- drivers/staging/comedi/comedi_internal.h | 1 - 1 file changed, 1 deletion(-)(quoted diff) +0
-0
b/drivers/staging/comedi/comedi_internal.hdrivers/staging/comedi/comedi_internal.h int comedi_buf_alloc(struct comedi_device *dev, struct
Quoted 4 lines
index
515f293a5d26..df3b1af109f7100644drivers/staging/comedi/comedi_internal.h +0
-0@@ -28,7 +28,6 @@ int comedi_buf_alloc(struct comedi_device *dev, struct
comedi_subdevice*s,drivers/staging/comedi/comedi_internal.h int comedi_buf_alloc(struct comedi_device *dev, struct comedi_subdevice *s,
Quoted 6 lines
drivers/staging/comedi/comedi_internal.h +0
-1unsigned long new_size);void comedi_buf_reset (struct comedi_subdevice *s);bool comedi_buf_is_mmapped (struct comedi_subdevice *s); -void comedi_buf_map_get (struct comedi_buf_map *bm);int comedi_buf_map_put (struct comedi_buf_map *bm); int comedi_buf_map_access(struct comedi_buf_map *bm, unsigned longoffset,
drivers/staging/comedi/comedi_internal.h int comedi_buf_alloc(struct comedi_device *dev, struct comedi_subdevice *s, · line 33
Quoted 2 lines
drivers/staging/comedi/comedi_internal.h +0
-0void *buf, int len, int write);Sorry, I don't really see the point of this patch series. For a start, the
comedi_buf_mapfunctions were added a long time after the TODO file was written. I can't even remember what the "remove all wrappers" line in the TODO file is referring to.Besides that, as pointed out by Julia, the patches have been ordered in such a way as to break the build between the patches.
--
-=( Ian Abbott <[email protected]> || Web: www.mev.co.uk )=- -=( MEV Ltd. is a company registered in England & Wales. )=-
-=( Registered number: 02862268. Registered address: )=-
-=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=-
So should we maybe email the names on the TODOs, next time, to clarify the tasks
Quoted 50 lines · evan chime
Hello Ian
Thanks for the reply. Got it
Kind Regards
EvanQuoted 40 lines · Ian Abbott
Review
Quoted 9 lines · Evan Chime
Remove wrapper function "
comedi_buf_map_get" declaration as part of remove all wrappers indrivers/staging/comedi/TODOSigned-off-by Evan Chime <[email protected]>--- drivers/staging/comedi/comedi_internal.h | 1 - 1 file changed, 1 deletion(-)(quoted diff) +0
-0
b/drivers/staging/comedi/comedi_internal.hdrivers/staging/comedi/comedi_internal.h int comedi_buf_alloc(struct comedi_device *dev,
Quoted 4 lines
index
515f293a5d26..df3b1af109f7100644drivers/staging/comedi/comedi_internal.h +0
-0@@ -28,7 +28,6 @@ int comedi_buf_alloc(struct comedi_device *dev,struct
comedi_subdevice*s,drivers/staging/comedi/comedi_internal.h int comedi_buf_alloc(struct comedi_device *dev, struct comedi_subdevice *s,
Quoted 6 lines
drivers/staging/comedi/comedi_internal.h +0
-1unsigned long new_size);void comedi_buf_reset (struct comedi_subdevice *s);bool comedi_buf_is_mmapped (struct comedi_subdevice *s); -void comedi_buf_map_get (struct comedi_buf_map *bm);int comedi_buf_map_put (struct comedi_buf_map *bm); int comedi_buf_map_access(struct comedi_buf_map *bm, unsigned longoffset,
drivers/staging/comedi/comedi_internal.h int comedi_buf_alloc(struct comedi_device *dev, struct comedi_subdevice *s, · line 33
Quoted 2 lines
drivers/staging/comedi/comedi_internal.h +0
-0void *buf, int len, int write);Sorry, I don't really see the point of this patch series. For a start, the
comedi_buf_mapfunctions were added a long time after the TODO file was written. I can't even remember what the "remove all wrappers" line in the TODO file is referring to.Besides that, as pointed out by Julia, the patches have been ordered in such a way as to break the build between the patches.
--
-=( Ian Abbott <[email protected]> || Web: www.mev.co.uk )=- -=( MEV Ltd. is a company registered in England & Wales. )=-
-=( Registered number: 02862268. Registered address: )=-
-=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=-
Quoted 2 lines · evan chime
So should we maybe email the names on the TODOs, next time, to clarify the tasks
Please don't top post.
julia
Quoted 71 lines
On Thu, 24 Oct 2019 at 10:53, evan chime <[email protected]> wrote:
Hello IanThanks for the reply. Got it
Kind Regards
EvanOn Thu, 24 Oct 2019 at 10:38, Ian Abbott <[email protected]> wrote:
On 24/10/2019 00:42, Evan Chime wrote:
> Remove wrapper function "comedi_buf_map_get" declaration > as part of remove all wrappers indrivers/staging/comedi/TODO
>
> Signed-off-by: Evan Chime <[email protected]>
> ---
> drivers/staging/comedi/comedi_internal.h | 1 - > 1 file changed, 1 deletion(-)
>
> diff --gita/drivers/staging/comedi/comedi_internal.hb/drivers/staging/comedi/comedi_internal.h
> index515f293a5d26..df3b1af109f7100644
> ---a/drivers/staging/comedi/comedi_internal.h
> +++b/drivers/staging/comedi/comedi_internal.h
> @@ -28,7 +28,6 @@ int comedi_buf_alloc(structcomedi_device*dev, structcomedi_subdevice*s,
> unsigned longnew_size);
> voidcomedi_buf_reset(struct comedi_subdevice *s); > boolcomedi_buf_is_mmapped(struct comedi_subdevice *s);
> -voidcomedi_buf_map_get(struct comedi_buf_map *bm); > intcomedi_buf_map_put(struct comedi_buf_map *bm); > int comedi_buf_map_access(structcomedi_buf_map*bm, unsigned long offset,
> void *buf, int len, int write); >Sorry, I don't really see the point of this patch series. For a start,
thecomedi_buf_mapfunctions were added a long time after the TODO file
was written. I can't even remember what the "remove all wrappers" line
in the TODO file is referring to.Besides that, as pointed out by Julia, the patches have been ordered in
such a way as to break the build between the patches.--
-=( Ian Abbott <[email protected]> || Web: www.mev.co.uk )=-
-=( MEV Ltd. is a company registered in England & Wales. )=-
-=( Registered number: 02862268. Registered address:
)=-
-=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=---
You received this message because you are subscribed to the Google Groups
"outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to [email protected].
To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CANR89jaTcgtXzkPH-O6vTNo CjQXyHSTe-zY35y%3DO9p9WBQ%3DX7A%40mail.gmail.com.
Hello Julia
Please what does it mean by don’t top the post? I normally do reply all from my gmail
Kind regards
Evan
Quoted 97 lines · Julia Lawall
Quoted 1 line · evan chime
So should we maybe email the names on the TODOs, next time, to clarify
the
Quoted 1 line
tasks
Please don't top post.
julia
Quoted 49 lines
On Thu, 24 Oct 2019 at 10:53, evan chime <[email protected]
wrote:
Hello IanThanks for the reply. Got it
Kind Regards
EvanOn Thu, 24 Oct 2019 at 10:38, Ian Abbott <[email protected]> wrote:
On 24/10/2019 00:42, Evan Chime wrote:
> Remove wrapper function "comedi_buf_map_get" declaration > as part of remove all wrappers indrivers/staging/comedi/TODO
>
> Signed-off-by: Evan Chime <[email protected]>
> ---
>drivers/staging/comedi/comedi_internal.h| 1 -
> 1 file changed, 1 deletion(-)
>
> diff --gita/drivers/staging/comedi/comedi_internal.hb/drivers/staging/comedi/comedi_internal.h
> index515f293a5d26..df3b1af109f7100644
> ---a/drivers/staging/comedi/comedi_internal.h
> +++b/drivers/staging/comedi/comedi_internal.h
> @@ -28,7 +28,6 @@ int comedi_buf_alloc(structcomedi_device*dev, structcomedi_subdevice*s,
> unsigned longnew_size);
> voidcomedi_buf_reset(struct comedi_subdevice *s);
> bool comedi_buf_is_mmapped(structcomedi_subdevice
*s);
> -voidcomedi_buf_map_get(struct comedi_buf_map *bm);
> intcomedi_buf_map_put(struct comedi_buf_map *bm);
> int comedi_buf_map_access(structcomedi_buf_map*bm,
unsigned long offset,
> void *buf, int len, int write);
>Sorry, I don't really see the point of this patch series. For a start,
thecomedi_buf_mapfunctions were added a long time after the TODO file
was written. I can't even remember what the "remove all wrappers" line
in the TODO file is referring to.Quoted 1 line
Besides that, as pointed out by Julia, the
<https://www.google.com/maps/search/Besides+that,+as+pointed+out+by+Julia,+the+?entry=gmail&source=g>patches
haveQuoted 13 lines
been ordered in such a way as to break the build between the patches. -- -=( Ian Abbott <[email protected]> || Web: www.mev.co.uk )=- -=( MEV Ltd. is a company registered in England & Wales. )=- -=( Registered number: 02862268. Registered address: )=- -=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=-Quoted 6 lines
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CANR89jaTcgtXzkPH-O6vTNo
Quoted 3 lines
CjQXyHSTe-zY35y%3DO9p9WBQ%3DX7A%40mail.gmail.com.
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/outreachy-kernel/alpine.DEB.2.21.1910242021470.2621%40hadrien
.
Quoted 4 lines · evan chime
Hello Julia
Please what does it mean by don’t top the post? I normally do reply all from my gmail
You should type your response under the text that you are responding to. That way the reader can understand exactly what you are talking about.
Please read through the tutorial again carefully.
julia
Quoted 116 lines
Kind regards
EvanOn Thu, 24 Oct 2019 at 19:22, Julia Lawall <[email protected]> wrote:
On Thu, 24 Oct 2019, evan chime wrote:
> So should we maybe email the names on the TODOs, next time, to clarify the
> tasksPlease don't top post.
julia
>
> On Thu, 24 Oct 2019 at 10:53, evan chime
<[email protected]>
> wrote:
> Hello Ian
>
> Thanks for the reply. Got it
>
> Kind Regards
> Evan
>
> On Thu, 24 Oct 2019 at 10:38, Ian Abbott <[email protected]>
wrote:
> On 24/10/2019 00:42, Evan Chime wrote:
> > Remove wrapper function "comedi_buf_map_get"
declaration
> > as part of remove all wrappers in
> drivers/staging/comedi/TODO
> >
> > Signed-off-by: Evan Chime
> <[email protected]>
> > ---
> > drivers/staging/comedi/comedi_internal.h | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --gita/drivers/staging/comedi/comedi_internal.h
> b/drivers/staging/comedi/comedi_internal.h
> > index515f293a5d26..df3b1af109f7100644
> > ---a/drivers/staging/comedi/comedi_internal.h
> > +++b/drivers/staging/comedi/comedi_internal.h
> > @@ -28,7 +28,6 @@ int comedi_buf_alloc(struct
> comedi_device *dev, structcomedi_subdevice*s,
> > unsigned longnew_size);
> > voidcomedi_buf_reset(struct comedi_subdevice *s);
> > bool comedi_buf_is_mmapped(structcomedi_subdevice
> *s);
> > -voidcomedi_buf_map_get(struct comedi_buf_map *bm);
> > intcomedi_buf_map_put(struct comedi_buf_map *bm);
> > int comedi_buf_map_access(structcomedi_buf_map*bm,
> unsigned long offset,
> > void *buf, int len, int
write);
> >
>
> Sorry, I don't really see the point of this patch
series.
> For a start,
> thecomedi_buf_mapfunctions were added a long time
after
> the TODO file
> was written. I can't even remember what the "remove all
> wrappers" line
> in the TODO file is referring to.
>
> Besides that, as pointed out by Julia, the patches have
> been ordered in
> such a way as to break the build between the patches.
>
> --
> -=( Ian Abbott <[email protected]> || Web: www.mev.co.uk
> )=-
> -=( MEV Ltd. is a company registered in England & Wales.
> )=-
> -=( Registered number: 02862268. Registered address:
> )=-
> -=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK.
> )=-
>
> --
> You received this message because you are subscribed to the
Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from
it, send an
> email to [email protected].
> To view this discussion on the webvisithttps://groups.google.com/d/msgid/outreachy-kernel/CANR89jaTcgtXzkPH-O 6vTNo
> CjQXyHSTe-zY35y%3DO9p9WBQ%3DX7A%40mail.gmail.com.
>
>--
You received this message because you are subscribed to the
Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from
it, send an email to
[email protected].
To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/alpine.DEB.2.21.19102420 21470.2621%40hadrien.--
You received this message because you are subscribed to the Google Groups
"outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to [email protected].
To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CANR89jYskb%3D4rJ6r%3DWF S2QZRonHFs9_oiHok7SqC5iWCnc4qBg%40mail.gmail.com.