Skip to contentSkip to conversation

Fix segmentation fault in trace-cmd record on invalid event hooks

PATCH New Slavomir Kaslev 1 participant 1 message Oct 24, 2019

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 Fix segmentation fault in trace-cmd record on invalid event hooks

Currently passing an invalid event hook to trace-cmd record causes a segmentation fault, e.g.

$ sudo trace-cmd record -e irq -H foobar
  Invalid hook format 'foobar'
  Segmentation fault

Fix this by checking the return value of tracecmd_create_event_hook().

---
Changes in v2:
- fixed commit message

 tracecmd/trace-record.c | 2 ++
 1 file changed, 2 insertions(+)
tracecmd/trace-record.c +2 -0
index c65731f..0596b63 100644
@@ -4632,6 +4632,8 @@ static void add_hook(struct buffer_instance *instance, const char *arg)
 	struct hook_list *hook;
 
 	hook = tracecmd_create_event_hook(arg);
+	if (!hook)
+		die("Failed to create event hook %s", arg);
 
 	hook->instance = instance;
 	hook->next = hooks;

--
2.20.1