Skip to contentSkip to conversation

xen: issue deprecation warning for 32-bit pv guest

PATCH In review Juergen Gross 3 participants 3 messages Oct 25, 2019 – Oct 28, 2019

Subsystems (2)
lore
Share & tools
lore

Juergen Gross

author maintainer
#0 lore raw

PATCH 1/1 xen: issue deprecation warning for 32-bit pv guest

Support for the kernel as Xen 32-bit PV guest will soon be removed. Issue a warning when booted as such.

---
 arch/x86/xen/enlighten_pv.c | 8 ++++++++
 1 file changed, 8 insertions(+)
arch/x86/xen/enlighten_pv.c +8 -0
index 58f79ab32358..5bfea374a160 100644
@@ -117,6 +117,14 @@ static void __init xen_banner(void)
 	printk(KERN_INFO "Xen version: %d.%d%s%s\n",
 	       version >> 16, version & 0xffff, extra.extraversion,
 	       xen_feature(XENFEAT_mmu_pt_update_preserve_ad) ? " (preserve-AD)" : "");
+
+#ifdef CONFIG_X86_32
+	pr_warn("WARNING! WARNING! WARNING! WARNING! WARNING! WARNING! WARNING!\n"
+		"Support for running as 32-bit PV-guest under Xen will soon be removed\n"
+		"from the Linux kernel!\n"
+		"Please use either a 64-bit kernel or switch to HVM or PVH mode!\n"
+		"WARNING! WARNING! WARNING! WARNING! WARNING! WARNING! WARNING!\n");
+#endif
 }
 
 static void __init xen_pv_init_platform(void)
Signature · 1 line
2.16.4
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Juergen Gross

Support for the kernel as Xen 32-bit PV guest will soon be removed. Issue a warning when booted as such.

Quoted 23 lines
---
 arch/x86/xen/enlighten_pv.c | 8 ++++++++
 1 file changed, 8 insertions(+)
arch/x86/xen/enlighten_pv.c +8 -0
index 58f79ab32358..5bfea374a160 100644
@@ -117,6 +117,14 @@ static void __init xen_banner(void)
 	printk(KERN_INFO "Xen version: %d.%d%s%s\n",
 	       version >> 16, version & 0xffff, extra.extraversion,
 	       xen_feature(XENFEAT_mmu_pt_update_preserve_ad) ? " (preserve-AD)" : "");
+
+#ifdef CONFIG_X86_32
+	pr_warn("WARNING! WARNING! WARNING! WARNING! WARNING! WARNING! WARNING!\n"
+		"Support for running as 32-bit PV-guest under Xen will soon be removed\n"
+		"from the Linux kernel!\n"
+		"Please use either a 64-bit kernel or switch to HVM or PVH mode!\n"
+		"WARNING! WARNING! WARNING! WARNING! WARNING! WARNING! WARNING!\n");
+#endif
 }
 
 static void __init xen_pv_init_platform(void)
#2 lore raw
In reply to Juergen Gross
Quoted 29 lines · Juergen Gross

Support for the kernel as Xen 32-bit PV guest will soon be removed. Issue a warning when booted as such.

---
arch/x86/xen/enlighten_pv.c | 8 ++++++++

1 file changed, 8 insertions(+)
arch/x86/xen/enlighten_pv.c +3 -0
index 58f79ab32358..5bfea374a160 100644
@@ -117,6 +117,14 @@ static void __init xen_banner(void)
 	printk(KERN_INFO "Xen version: %d.%d%s%s\n",
 	       version >> 16, version & 0xffff, extra.extraversion,
 	       xen_feature(XENFEAT_mmu_pt_update_preserve_ad) ? "
 (preserve-AD)" : "");
+
+#ifdef CONFIG_X86_32
+	pr_warn("WARNING! WARNING! WARNING! WARNING! WARNING! WARNING!

WARNING!\n"

arch/x86/xen/enlighten_pv.c +1 -0
+		"Support for running as 32-bit PV-guest under Xen will soon be

removed\n"

arch/x86/xen/enlighten_pv.c +4 -0
+		"from the Linux kernel!\n"
+		"Please use either a 64-bit kernel or switch to HVM or PVH mode!\n"
+		"WARNING! WARNING! WARNING! WARNING! WARNING! WARNING! WARNING!\n");
+#endif

}

Quoted 1 line

static void __init xen_pv_init_platform(void)

And there was much rejoicing.

Yaay.

Signature · 6 lines
Sent from my Android device with K-9 Mail. Please excuse my brevity.

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel