Skip to contentSkip to conversation

dwc3-generic: Don't fail probe if clk/reset entries are absent

PATCH New Vignesh Raghavendra 4 participants 5 messages Oct 25, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dwc3-generic: Don't fail probe if clk/reset entries are absent

Some boards don't populate clk/reset entries as these are are optional as per binding documentation. Therefore, don't fail driver probe if clk/reset entries are absent in DT.

This fixes fastboot failures seen due to enabling of CONFIG_CLK on AM57xx

Fixes e8e683d33b0c ("board: ti: am57xx-idk: Configure the CDCE913 clock synthesizer")
---
 drivers/usb/dwc3/dwc3-generic.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/usb/dwc3/dwc3-generic.c +2 -2
index 406bf0b3628b..d76cd7a4c5ca 100644
@@ -258,7 +258,7 @@ static int dwc3_glue_reset_init(struct udevice *dev,
 	int ret;
 
 	ret = reset_get_bulk(dev, &glue->resets);
-	if (ret == -ENOTSUPP)
+	if (ret == -ENOTSUPP || ret == -ENOENT)
 		return 0;
 	else if (ret)
 		return ret;
@@ -278,7 +278,7 @@ static int dwc3_glue_clk_init(struct udevice *dev,
 	int ret;
 
 	ret = clk_get_bulk(dev, &glue->clks);
-	if (ret == -ENOSYS)
+	if (ret == -ENOSYS || ret == -ENOENT)
 		return 0;
 	if (ret)
 		return ret;
Signature · 1 line
2.23.0
#1 lore raw

PATCH 1/1 dwc3-generic: Don't fail probe if clk/reset entries are absent

Quoted 9 lines · Vignesh Raghavendra

Some boards don't populate clk/reset entries as these are are optional as per binding documentation. Therefore, don't fail driver probe if clk/reset entries are absent in DT.

This fixes fastboot failures seen due to enabling of CONFIG_CLK on AM57xx

Fixes e8e683d33b0c ("board: ti: am57xx-idk: Configure the CDCE913 clock synthesizer")

Thanks for the patch.

Quoted 19 lines
---
  drivers/usb/dwc3/dwc3-generic.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/usb/dwc3/dwc3-generic.c +1 -1
index 406bf0b3628b..d76cd7a4c5ca 100644
@@ -258,7 +258,7 @@ static int dwc3_glue_reset_init(struct udevice *dev,
  	int ret;
 
  	ret = reset_get_bulk(dev, &glue->resets);
-	if (ret == -ENOTSUPP)
+	if (ret == -ENOTSUPP || ret == -ENOENT)
  		return 0;
  	else if (ret)
  		return ret;

drivers/usb/dwc3/dwc3-generic.c static int dwc3_glue_clk_init(struct udevice *dev, · line 284

Quoted 8 lines
drivers/usb/dwc3/dwc3-generic.c +1 -1
@@ -278,7 +278,7 @@ static int dwc3_glue_clk_init(struct udevice *dev,
  	int ret;
 
  	ret = clk_get_bulk(dev, &glue->clks);
-	if (ret == -ENOSYS)
+	if (ret == -ENOSYS || ret == -ENOENT)
  		return 0;
  	if (ret)
  		return ret;

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

#2 lore raw

PATCH 1/1 dwc3-generic: Don't fail probe if clk/reset entries are absent

In reply to Vignesh Raghavendra

Hi Vignesh,

Quoted 11 lines · Vignesh Raghavendra

Some boards don't populate clk/reset entries as these are are optional as per binding documentation. Therefore, don't fail driver probe if clk/reset entries are absent in DT.

This fixes fastboot failures seen due to enabling of CONFIG_CLK on AM57xx

Fixes e8e683d33b0c ("board: ti: am57xx-idk: Configure the CDCE913 clock synthesizer")

---

Quoted 28 lines
 drivers/usb/dwc3/dwc3-generic.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/usb/dwc3/dwc3-generic.c +2 -3
index 406bf0b3628b..d76cd7a4c5ca 100644
@@ -258,7 +258,7 @@ static int dwc3_glue_reset_init(struct udevice *dev,
        int ret;
 
        ret = reset_get_bulk(dev, &glue->resets);
-       if (ret == -ENOTSUPP)
+       if (ret == -ENOTSUPP || ret == -ENOENT)
                return 0;
        else if (ret)
                return ret;
@@ -278,7 +278,7 @@ static int dwc3_glue_clk_init(struct udevice *dev,
        int ret;
 
        ret = clk_get_bulk(dev, &glue->clks);
-       if (ret == -ENOSYS)
+       if (ret == -ENOSYS || ret == -ENOENT)
                return 0;
        if (ret)
                return ret;
--

2.23.0

#3 lore raw

PATCH 1/1 dwc3-generic: Don't fail probe if clk/reset entries are absent

+ Praneeth

Quoted 47 lines · Sam Protsenko

Hi Vignesh,

Quoted 11 lines · Vignesh Raghavendra

Some boards don't populate clk/reset entries as these are are optional as per binding documentation. Therefore, don't fail driver probe if clk/reset entries are absent in DT.

This fixes fastboot failures seen due to enabling of CONFIG_CLK on AM57xx

Fixes e8e683d33b0c ("board: ti: am57xx-idk: Configure the CDCE913 clock synthesizer")

---

Quoted 28 lines
 drivers/usb/dwc3/dwc3-generic.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/usb/dwc3/dwc3-generic.c +2 -3
index 406bf0b3628b..d76cd7a4c5ca 100644
@@ -258,7 +258,7 @@ static int dwc3_glue_reset_init(struct udevice *dev,
        int ret;
 
        ret = reset_get_bulk(dev, &glue->resets);
-       if (ret == -ENOTSUPP)
+       if (ret == -ENOTSUPP || ret == -ENOENT)
                return 0;
        else if (ret)
                return ret;
@@ -278,7 +278,7 @@ static int dwc3_glue_clk_init(struct udevice *dev,
        int ret;
 
        ret = clk_get_bulk(dev, &glue->clks);
-       if (ret == -ENOSYS)
+       if (ret == -ENOSYS || ret == -ENOENT)
                return 0;
        if (ret)
                return ret;
--

2.23.0

Applied
#4 lore raw

PATCH 1/1 dwc3-generic: Don't fail probe if clk/reset entries are absent

In reply to Vignesh Raghavendra
Quoted 5 lines · Vignesh Raghavendra

Some boards don't populate clk/reset entries as these are are optional as per binding documentation. Therefore, don't fail driver probe if clk/reset entries are absent in DT.

This fixes fastboot failures seen due to enabling of CONFIG_CLK on AM57xx

Applied, thanks.