staging: ks7010: Fix line ending with a '('
PATCH 1/1 staging: ks7010: Fix line ending with a '('
checkpatch.pl message:
"CHECK:OPEN_ENDED_LINE: Lines should not end with a '('"
--- drivers/staging/ks7010/ks_hostif.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/staging/ks7010/ks_hostif.c +2 -3
@@ -75,9 +75,8 @@ static void ks_wlan_hw_wakeup_task(struct work_struct *work)if (ps_status ==PS_SNOOZE ) {ks_wlan_hw_wakeup_request (priv); - time_left =wait_for_completion_interruptible_timeout ( - &priv->psstatus.wakeup_wait, -msecs_to_jiffies (20 )); + time_left =wait_for_completion_interruptible_timeout (&priv->psstatus.wakeup_wait, +msecs_to_jiffies (20 ));if (time_left <=0 ) {netdev_dbg (priv->net_dev,"wake up timeout or interrupted !!!\n" );schedule_work (&priv->wakeup_work);
Signature · 1 line
2.17.1
Greg KH
maintainerQuoted 13 lines · Frank A. Cancio Bello
checkpatch.pl message:
"CHECK:OPEN_ENDED_LINE: Lines should not end with a '('"Signed-off-by Frank A. Cancio Bello <[email protected]>--- drivers/staging/ks7010/ks_hostif.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)drivers/staging/ks7010/ks_hostif.c +0
-0
drivers/staging/ks7010/ks_hostif.c static void ks_wlan_hw_wakeup_task(struct work_struct *work) · line 79
Quoted 8 lines
drivers/staging/ks7010/ks_hostif.c +2
-3@@ -75,9 +75,8 @@ static void ks_wlan_hw_wakeup_task(struct work_struct *work)if (ps_status ==PS_SNOOZE ) {ks_wlan_hw_wakeup_request (priv); - time_left =wait_for_completion_interruptible_timeout ( - &priv->psstatus.wakeup_wait, -msecs_to_jiffies (20 )); + time_left =wait_for_completion_interruptible_timeout (&priv->psstatus.wakeup_wait, +msecs_to_jiffies (20 ));
And now you have created a line over 80 characters, so you can send a patch fixing that, and around you go :(
Just leave this as-is, it's fine now.
thanks,
greg k-h
Quoted 13 lines · Frank A. Cancio Bello
checkpatch.pl message:
"CHECK:OPEN_ENDED_LINE: Lines should not end with a '('"Signed-off-by Frank A. Cancio Bello <[email protected]>--- drivers/staging/ks7010/ks_hostif.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)drivers/staging/ks7010/ks_hostif.c +0
-0
drivers/staging/ks7010/ks_hostif.c static void ks_wlan_hw_wakeup_task(struct work_struct *work) · line 79
Quoted 8 lines
drivers/staging/ks7010/ks_hostif.c +2
-3@@ -75,9 +75,8 @@ static void ks_wlan_hw_wakeup_task(struct work_struct *work)if (ps_status ==PS_SNOOZE ) {ks_wlan_hw_wakeup_request (priv); - time_left =wait_for_completion_interruptible_timeout ( - &priv->psstatus.wakeup_wait, -msecs_to_jiffies (20 )); + time_left =wait_for_completion_interruptible_timeout (&priv->psstatus.wakeup_wait, +msecs_to_jiffies (20 ));
This doesn't seem like a good solution, since it massively violates the 80 character boundary. I don't think there is a good solution in this case.
julia
Quoted 11 lines
drivers/staging/ks7010/ks_hostif.c +0
-1if (time_left <=0 ) {netdev_dbg (priv->net_dev,"wake up timeout or interrupted !!!\n" );schedule_work (&priv->wakeup_work); --2.17.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191027060237.GA26854%40linux-kernel-dev.
Quoted 29 lines · Julia Lawall
Quoted 13 lines · Frank A. Cancio Bello
checkpatch.pl message:
"CHECK:OPEN_ENDED_LINE: Lines should not end with a '('"Signed-off-by Frank A. Cancio Bello <[email protected]>--- drivers/staging/ks7010/ks_hostif.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)drivers/staging/ks7010/ks_hostif.c +0
-0drivers/staging/ks7010/ks_hostif.c static void ks_wlan_hw_wakeup_task(struct work_struct *work) · line 79
Quoted 8 lines
drivers/staging/ks7010/ks_hostif.c +2
-3@@ -75,9 +75,8 @@ static void ks_wlan_hw_wakeup_task(struct work_struct *work)if (ps_status ==PS_SNOOZE ) {ks_wlan_hw_wakeup_request (priv); - time_left =wait_for_completion_interruptible_timeout ( - &priv->psstatus.wakeup_wait, -msecs_to_jiffies (20 )); + time_left =wait_for_completion_interruptible_timeout (&priv->psstatus.wakeup_wait, +msecs_to_jiffies (20 ));This doesn't seem like a good solution, since it massively violates the 80 character boundary. I don't think there is a good solution in this case.
Quoted 2 lines
julia
Thanks, both Greg and Julia for the quick response.
frank a.
Quoted 11 lines
Quoted 11 lines
drivers/staging/ks7010/ks_hostif.c +0
-1if (time_left <=0 ) {netdev_dbg (priv->net_dev,"wake up timeout or interrupted !!!\n" );schedule_work (&priv->wakeup_work); --2.17.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191027060237.GA26854%40linux-kernel-dev.