Skip to contentSkip to conversation

scsi: csiostor: Return value not required for csio_dfs_destroy.

PATCH Applied Saurav Girepunje 2 participants 2 messages Oct 28, 2019 – Nov 2, 2019 SCSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: csiostor: Return value not required for csio_dfs_destroy.

Only csio_hw_free() calling csio_dfs_destroy() and it is not checking return value. So remove the return from csio_dfs_destroy().

---
 drivers/scsi/csiostor/csio_init.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/scsi/csiostor/csio_init.c +1 -3
index a6dd704d7f2d..28b77fa8b015 100644
@@ -154,13 +154,11 @@ csio_dfs_create(struct csio_hw *hw)
 /*
  * csio_dfs_destroy - Destroys per-hw debugfs.
  */
-static int
+static void
 csio_dfs_destroy(struct csio_hw *hw)
 {
 	if (hw->debugfs_root)
 		debugfs_remove_recursive(hw->debugfs_root);
-
-	return 0;
 }
 
 /*
Signature · 1 line
2.20.1
#1 lore raw

Saurav,

Quoted 2 lines

Only csio_hw_free() calling csio_dfs_destroy() and it is not checking return value. So remove the return from csio_dfs_destroy().

Applied to 5.5/scsi-queue, thanks.

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering