Skip to contentSkip to conversation

isci: request.c: remove unneeded variable status

PATCH New Saurav Girepunje 1 participant 1 message Oct 28, 2019

Subsystems (2)
SCSI Intel C600 series SAS controller driver
lore
Share & tools
lore

Saurav Girepunje

author
#0 lore raw

PATCH 1/1 isci: request.c: remove unneeded variable status

status variable is not modified within function.

Signed-off-by Saurav Girepunje <[email protected]>
---
 drivers/scsi/isci/request.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)
drivers/scsi/isci/request.c +3 -6
index 343d24c7e788..6537fa880906 100644
@@ -1480,7 +1480,6 @@ static enum sci_status
 stp_request_pio_await_h2d_completion_tc_event(struct isci_request *ireq,
 					      u32 completion_code)
 {
-	enum sci_status status = SCI_SUCCESS;
 
 	switch (SCU_GET_COMPLETION_TL_STATUS(completion_code)) {
 	case SCU_MAKE_COMPLETION_STATUS(SCU_TASK_DONE_GOOD):

@@ -1500,7 +1499,7 @@ stp_request_pio_await_h2d_completion_tc_event(struct isci_request *ireq,
 		break;
 	}
 
-	return status;
+	return SCI_SUCCESS;
 }
 
 static enum sci_status

@@ -2103,7 +2102,6 @@ sci_io_request_frame_handler(struct isci_request *ireq,
 static enum sci_status stp_request_udma_await_tc_event(struct isci_request *ireq,
 						       u32 completion_code)
 {
-	enum sci_status status = SCI_SUCCESS;
 
 	switch (SCU_GET_COMPLETION_TL_STATUS(completion_code)) {
 	case SCU_MAKE_COMPLETION_STATUS(SCU_TASK_DONE_GOOD):

@@ -2148,13 +2146,12 @@ static enum sci_status stp_request_udma_await_tc_event(struct isci_request *ireq
 		break;
 	}
 
-	return status;
+	return SCI_SUCCESS;
 }
 
 static enum sci_status atapi_raw_completion(struct isci_request *ireq, u32 completion_code,
 						  enum sci_base_request_states next)
 {
-	enum sci_status status = SCI_SUCCESS;
 
 	switch (SCU_GET_COMPLETION_TL_STATUS(completion_code)) {
 	case SCU_MAKE_COMPLETION_STATUS(SCU_TASK_DONE_GOOD):

@@ -2174,7 +2171,7 @@ static enum sci_status atapi_raw_completion(struct isci_request *ireq, u32 compl
 		break;
 	}
 
-	return status;
+	return SCI_SUCCESS;
 }
 
 static enum sci_status atapi_data_tc_completion_handler(struct isci_request *ireq,
Signature · 1 line
2.20.1