Skip to contentSkip to conversation

powerpc: sysdev: xive: Fix use true/false for bool type

PATCH In review Saurav Girepunje 2 participants 2 messages Oct 29, 2019 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc: sysdev: xive: Fix use true/false for bool type

Use true/false for bool return type in xive_spapr_cleanup_queue function.

---
 arch/powerpc/sysdev/xive/spapr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/powerpc/sysdev/xive/spapr.c +1 -1
index 33c10749edec..74e3ffae0be6 100644
@@ -533,7 +533,7 @@ static void xive_spapr_cleanup_queue(unsigned int cpu, struct xive_cpu *xc,
 static bool xive_spapr_match(struct device_node *node)
 {
 	/* Ignore cascaded controllers for the moment */
-	return 1;
+	return true;
 }
 
 #ifdef CONFIG_SMP
Signature · 1 line
2.20.1
#1 lore raw

This is not actually a 'fix'

I suggest you to rephrase the subject in a different way and remove the word 'fix' from it.

Quoted 3 lines · Saurav Girepunje

Use true/false for bool return type in xive_spapr_cleanup_queue function.

How do you find this?

If you used a tool to find this, please mention it.

Thanks
--
Gustavo

Quoted 19 lines
---
 arch/powerpc/sysdev/xive/spapr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/powerpc/sysdev/xive/spapr.c +1 -1
index 33c10749edec..74e3ffae0be6 100644
@@ -533,7 +533,7 @@ static void xive_spapr_cleanup_queue(unsigned int cpu, struct xive_cpu *xc,
 static bool xive_spapr_match(struct device_node *node)
 {
 	/* Ignore cascaded controllers for the moment */
-	return 1;
+	return true;
 }
 
 #ifdef CONFIG_SMP