Skip to contentSkip to conversation

ceph_fill_trace(): add missing check in d_revalidate snapdir handling

PATCH New Al Viro 1 participant 1 message Oct 29, 2019

Subsystems (2)
lore
Share & tools
lore

Al Viro

author maintainer
#0 lore raw

PATCH 1/1 ceph_fill_trace(): add missing check in d_revalidate snapdir handling

we should not play with dcache without parent locked...

fs/ceph/inode.c +1 -0
index 9f135624ae47..c07407586ce8 100644
@@ -1434,6 +1434,7 @@ int ceph_fill_trace(struct super_block *sb, struct ceph_mds_request *req)
 		dout(" final dn %p\n", dn);
 	} else if ((req->r_op == CEPH_MDS_OP_LOOKUPSNAP ||
 		    req->r_op == CEPH_MDS_OP_MKSNAP) &&
+	           test_bit(CEPH_MDS_R_PARENT_LOCKED, &req->r_req_flags) &&
 		   !test_bit(CEPH_MDS_R_ABORTED, &req->r_req_flags)) {
 		struct inode *dir = req->r_parent;