ASoC: rt5682: improve the sensitivity of push button
Subsystems (3)
PATCH 1/3 ASoC: rt5682: improve the sensitivity of push button
From: Shuming Fan <[email protected]>
The sensitivity could improve by decreasing the HW debounce time and reduce the delay time of workequeue.
This patch added a device property for HW debounce time control. We could change this value to tune the sensitivity of push button.
--- include/sound/rt5682.h | 1 + sound/soc/codecs/rt5682.c | 15 +++++++++++++++ 2 files changed, 16 insertions(+)
include/sound/rt5682.h +1 -0
@@ -31,6 +31,7 @@ struct rt5682_platform_data {enum rt5682_dmic1_data_pin dmic1_data_pin;enum rt5682_dmic1_clk_pin dmic1_clk_pin;enum rt5682_jd_src jd_src; + unsigned int btndet_delay; };#endif
sound/soc/codecs/rt5682.c +15 -0
@@ -44,6 +44,7 @@ static const struct rt5682_platform_data i2s_default_platform_data = { .dmic1_data_pin = RT5682_DMIC1_DATA_GPIO2, .dmic1_clk_pin = RT5682_DMIC1_CLK_GPIO3, .jd_src = RT5682_JD1, + .btndet_delay = 16, };struct rt5682_priv {
@@ -1026,6 +1027,18 @@ static int rt5682_set_jack_detect(struct snd_soc_component *component,regmap_update_bits (rt5682->regmap,RT5682_IRQ_CTRL_2 ,RT5682_JD1_EN_MASK |RT5682_JD1_POL_MASK ,RT5682_JD1_EN |RT5682_JD1_POL_NOR ); +regmap_update_bits (rt5682->regmap,RT5682_4BTN_IL_CMD_4 , +0x7f7f , (rt5682->pdata.btndet_delay <<8 | + rt5682->pdata.btndet_delay)); +regmap_update_bits (rt5682->regmap,RT5682_4BTN_IL_CMD_5 , +0x7f7f , (rt5682->pdata.btndet_delay <<8 | + rt5682->pdata.btndet_delay)); +regmap_update_bits (rt5682->regmap,RT5682_4BTN_IL_CMD_6 , +0x7f7f , (rt5682->pdata.btndet_delay <<8 | + rt5682->pdata.btndet_delay)); +regmap_update_bits (rt5682->regmap,RT5682_4BTN_IL_CMD_7 , +0x7f7f , (rt5682->pdata.btndet_delay <<8 | + rt5682->pdata.btndet_delay));mod_delayed_work (system_power_efficient_wq, &rt5682->jack_detect_work,msecs_to_jiffies (250 ));break ;
@@ -2467,6 +2480,8 @@ static int rt5682_parse_dt(struct rt5682_priv *rt5682, struct device *dev) &rt5682->pdata.dmic1_clk_pin);device_property_read_u32 (dev,"realtek,jd-src" , &rt5682->pdata.jd_src); +device_property_read_u32 (dev,"realtek,btndet-delay" , + &rt5682->pdata.btndet_delay); rt5682->pdata.ldo1_en =of_get_named_gpio (dev->of_node,"realtek,ldo1-en-gpios" ,0 );
Signature · 6 lines
2.23.0 _______________________________________________ Alsa-devel mailing list [email protected] https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Quoted 3 lines · On 10/30/19 3:55 AM, [email protected] wrote:
From: Shuming Fan <[email protected]>
The sensitivity could improve by decreasing the HW debounce time
could be improved
Quoted 1 line
and reduce the delay time of workequeue.
typo: work queue.
Quoted 2 lines
This patch added a device property for HW debounce time control. We could change this value to tune the sensitivity of push button.
so for an Intel platform without DT, could we set this property in the machine driver as done for bytcr_rt5640/51?
Quoted 52 lines
Signed-off-by Shuming Fan <[email protected]>--- include/sound/rt5682.h | 1 + sound/soc/codecs/rt5682.c | 15 +++++++++++++++ 2 files changed, 16 insertions(+)include/sound/rt5682.h +1
-0@@ -31,6 +31,7 @@ struct rt5682_platform_data {enum rt5682_dmic1_data_pin dmic1_data_pin;enum rt5682_dmic1_clk_pin dmic1_clk_pin;enum rt5682_jd_src jd_src; + unsigned int btndet_delay; };#endif sound/soc/codecs/rt5682.c +13
-0@@ -44,6 +44,7 @@ static const struct rt5682_platform_data i2s_default_platform_data = { .dmic1_data_pin = RT5682_DMIC1_DATA_GPIO2, .dmic1_clk_pin = RT5682_DMIC1_CLK_GPIO3, .jd_src = RT5682_JD1, + .btndet_delay = 16, };struct rt5682_priv {@@ -1026,6 +1027,18 @@ static int rt5682_set_jack_detect(struct snd_soc_component *component,regmap_update_bits (rt5682->regmap,RT5682_IRQ_CTRL_2 ,RT5682_JD1_EN_MASK |RT5682_JD1_POL_MASK ,RT5682_JD1_EN |RT5682_JD1_POL_NOR ); +regmap_update_bits (rt5682->regmap,RT5682_4BTN_IL_CMD_4 , +0x7f7f , (rt5682->pdata.btndet_delay <<8 | + rt5682->pdata.btndet_delay)); +regmap_update_bits (rt5682->regmap,RT5682_4BTN_IL_CMD_5 , +0x7f7f , (rt5682->pdata.btndet_delay <<8 | + rt5682->pdata.btndet_delay)); +regmap_update_bits (rt5682->regmap,RT5682_4BTN_IL_CMD_6 , +0x7f7f , (rt5682->pdata.btndet_delay <<8 | + rt5682->pdata.btndet_delay)); +regmap_update_bits (rt5682->regmap,RT5682_4BTN_IL_CMD_7 , +0x7f7f , (rt5682->pdata.btndet_delay <<8 | + rt5682->pdata.btndet_delay));mod_delayed_work (system_power_efficient_wq, &rt5682->jack_detect_work,msecs_to_jiffies (250 ));break ;
sound/soc/codecs/rt5682.c static int rt5682_parse_dt(struct rt5682_priv *rt5682, struct device *dev) · line 2487
Quoted 8 lines
sound/soc/codecs/rt5682.c +2
-0@@ -2467,6 +2480,8 @@ static int rt5682_parse_dt(struct rt5682_priv *rt5682, struct device *dev) &rt5682->pdata.dmic1_clk_pin);device_property_read_u32 (dev,"realtek,jd-src" , &rt5682->pdata.jd_src); +device_property_read_u32 (dev,"realtek,btndet-delay" , + &rt5682->pdata.btndet_delay); rt5682->pdata.ldo1_en =of_get_named_gpio (dev->of_node,"realtek,ldo1-en-gpios" ,0 );
_______________________________________________
Alsa-devel mailing list
[email protected]
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Mark Brown
maintainersound/soc/codecs/rt5682.c static int rt5682_parse_dt(struct rt5682_priv *rt5682, struct device *dev) · line 2484
Quoted 2 lines · On Wed, Oct 30, 2019 at 04:55:33PM +0800, [email protected] wrote:
sound/soc/codecs/rt5682.c +2
-0+device_property_read_u32 (dev,"realtek,btndet-delay" , + &rt5682->pdata.btndet_delay);
This should have a matching binding document update.
_______________________________________________
Alsa-devel mailing list
[email protected]
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Mark Brown
maintainer[alsa-devel] Applied "ASoC: rt5682: improve the sensitivity of push button" to the asoc tree
In reply to [email protected]The patch
ASoC: rt5682: improve the sensitivity of push button
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.5
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
From e226445802cb2a51c3cb127fac31fba0a4330e87 Mon Sep 17 00:00:00 2001
From: Shuming Fan <[email protected]>
Date: Wed, 30 Oct 2019 16:55:33 +0800
Subject: [PATCH] ASoC: rt5682: improve the sensitivity of push button
The sensitivity could improve by decreasing the HW debounce time and reduce the delay time of workequeue.
This patch added a device property for HW debounce time control. We could change this value to tune the sensitivity of push button.
--- include/sound/rt5682.h | 1 + sound/soc/codecs/rt5682.c | 15 +++++++++++++++ 2 files changed, 16 insertions(+)
include/sound/rt5682.h +1 -0
@@ -31,6 +31,7 @@ struct rt5682_platform_data {enum rt5682_dmic1_data_pin dmic1_data_pin;enum rt5682_dmic1_clk_pin dmic1_clk_pin;enum rt5682_jd_src jd_src; + unsigned int btndet_delay; };#endif
sound/soc/codecs/rt5682.c +15 -0
@@ -44,6 +44,7 @@ static const struct rt5682_platform_data i2s_default_platform_data = { .dmic1_data_pin = RT5682_DMIC1_DATA_GPIO2, .dmic1_clk_pin = RT5682_DMIC1_CLK_GPIO3, .jd_src = RT5682_JD1, + .btndet_delay = 16, };struct rt5682_priv {
@@ -1026,6 +1027,18 @@ static int rt5682_set_jack_detect(struct snd_soc_component *component,regmap_update_bits (rt5682->regmap,RT5682_IRQ_CTRL_2 ,RT5682_JD1_EN_MASK |RT5682_JD1_POL_MASK ,RT5682_JD1_EN |RT5682_JD1_POL_NOR ); +regmap_update_bits (rt5682->regmap,RT5682_4BTN_IL_CMD_4 , +0x7f7f , (rt5682->pdata.btndet_delay <<8 | + rt5682->pdata.btndet_delay)); +regmap_update_bits (rt5682->regmap,RT5682_4BTN_IL_CMD_5 , +0x7f7f , (rt5682->pdata.btndet_delay <<8 | + rt5682->pdata.btndet_delay)); +regmap_update_bits (rt5682->regmap,RT5682_4BTN_IL_CMD_6 , +0x7f7f , (rt5682->pdata.btndet_delay <<8 | + rt5682->pdata.btndet_delay)); +regmap_update_bits (rt5682->regmap,RT5682_4BTN_IL_CMD_7 , +0x7f7f , (rt5682->pdata.btndet_delay <<8 | + rt5682->pdata.btndet_delay));mod_delayed_work (system_power_efficient_wq, &rt5682->jack_detect_work,msecs_to_jiffies (250 ));break ;
@@ -2467,6 +2480,8 @@ static int rt5682_parse_dt(struct rt5682_priv *rt5682, struct device *dev) &rt5682->pdata.dmic1_clk_pin);device_property_read_u32 (dev,"realtek,jd-src" , &rt5682->pdata.jd_src); +device_property_read_u32 (dev,"realtek,btndet-delay" , + &rt5682->pdata.btndet_delay); rt5682->pdata.ldo1_en =of_get_named_gpio (dev->of_node,"realtek,ldo1-en-gpios" ,0 );
Signature · 6 lines
2.20.1 _______________________________________________ Alsa-devel mailing list [email protected] https://mailman.alsa-project.org/mailman/listinfo/alsa-devel