Skip to contentSkip to conversation

Remove {config.h,config.mk,features.mk,}.default ?

RFC Petr Vorel 3 participants 4 messages Nov 1, 2019 – Nov 4, 2019

lore
Share & tools
lore

Petr Vorel

author
#0 lore raw

Hi,

I wonder if anybody uses include/config.h.default, include/mk/config.mk.default, include/mk/features.mk.default. Is it their purpose for people who, for some reason can't run ./configure? (I wonder who'd need it) Can we just drop them?

include/config.h.default is out of sync with include/config.h.in; include/mk/config.mk.default and include/mk/features.mk.default are synced.

Kind regards,
Petr

#1 lore raw
Quoted 5 lines · Petr Vorel

Hi,

I wonder if anybody uses include/config.h.default, include/mk/config.mk.default, include/mk/features.mk.default. Is it their purpose for people who, for some reason can't run ./configure? (I wonder who'd need it) Can we just drop them?

Hi Petr

Yes. Reading LTP/INSTALL[1], these files are used when we don't use autoconf. as below:
Using autoconf (preferred):

	$ make autotools # This must be run from "$TOP_SRCDIR"!
	$ test -d "$TOP_BUILDDIR" || mkdir -p "$TOP_BUILDDIR"
	$ cd "$TOP_BUILDDIR" && "$TOP_SRCDIR/configure" \
	  # [configure args go here, e.g. CC=$CC, LDFLAGS=$LDFLAGS, etc]

Not using autoconf:

	$ test -d "$TOP_BUILDDIR" || mkdir -p "$TOP_BUILDDIR"
	$ cp "$TOP_SRCDIR/include/config.h.default" \
	     "$TOP_BUILDDIR/include/config.h"
	$ cp "$TOP_SRCDIR/include/mk/config.mk.default" \
	     "$TOP_BUILDDIR/include/mk/config.mk"
	$ cp "$TOP_SRCDIR/include/mk/features.mk.default" \
	     "$TOP_BUILDDIR/include/mk/features.mk"

[1]https://github.com/linux-test-project/ltp/blob/master/INSTAL

ps:IMO, I don't use these files. Now most distributions have auotconf and we can remove these files.

Thanks
Yang Xu

Quoted 7 lines

include/config.h.default is out of sync with include/config.h.in; include/mk/config.mk.default and include/mk/features.mk.default are synced.

Kind regards,
Petr

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20191104/fa15eda5/attachment.htm>

author
#2 lore raw

Hi Xu,

Quoted 18 lines

Yes. Reading LTP/INSTALL[1], these files are used when we don't use autoconf. as below:
Using autoconf (preferred):

	$ make autotools # This must be run from "$TOP_SRCDIR"!
	$ test -d "$TOP_BUILDDIR" || mkdir -p "$TOP_BUILDDIR"
	$ cd "$TOP_BUILDDIR" && "$TOP_SRCDIR/configure" \
	  # [configure args go here, e.g. CC=$CC, LDFLAGS=$LDFLAGS, etc]

Not using autoconf:

	$ test -d "$TOP_BUILDDIR" || mkdir -p "$TOP_BUILDDIR"
	$ cp "$TOP_SRCDIR/include/config.h.default" \
	     "$TOP_BUILDDIR/include/config.h"
	$ cp "$TOP_SRCDIR/include/mk/config.mk.default" \
	     "$TOP_BUILDDIR/include/mk/config.mk"
	$ cp "$TOP_SRCDIR/include/mk/features.mk.default" \
	     "$TOP_BUILDDIR/include/mk/features.mk"
Quoted 3 lines

[1]https://github.com/linux-test-project/ltp/blob/master/INSTAL

ps:IMO, I don't use these files. Now most distributions have auotconf and we can remove these files.

Thanks for review, I'll send a patch to ML.

Quoted 2 lines

Thanks
Yang Xu

Kind regards,
Petr

#3 lore raw

Hi all,

Quoted 22 lines · Petr Vorel

Hi Xu,

Quoted 17 lines

Yes. Reading LTP/INSTALL[1], these files are used when we don't use autoconf. as below:
Using autoconf (preferred):

	$ make autotools # This must be run from "$TOP_SRCDIR"!
	$ test -d "$TOP_BUILDDIR" || mkdir -p "$TOP_BUILDDIR"
	$ cd "$TOP_BUILDDIR" && "$TOP_SRCDIR/configure" \
	  # [configure args go here, e.g. CC=$CC, LDFLAGS=$LDFLAGS, etc]

Not using autoconf:

	$ test -d "$TOP_BUILDDIR" || mkdir -p "$TOP_BUILDDIR"
	$ cp "$TOP_SRCDIR/include/config.h.default" \
	     "$TOP_BUILDDIR/include/config.h"
	$ cp "$TOP_SRCDIR/include/mk/config.mk.default" \
	     "$TOP_BUILDDIR/include/mk/config.mk"
	$ cp "$TOP_SRCDIR/include/mk/features.mk.default" \
	     "$TOP_BUILDDIR/include/mk/features.mk"
Quoted 4 lines
Quoted 3 lines

[1]https://github.com/linux-test-project/ltp/blob/master/INSTAL

ps:IMO, I don't use these files. Now most distributions have auotconf and we can remove these files.

Thanks for review, I'll send a patch to ML.

The reason for having a non-autoconf path is purely legacy now (like 6-10+ years ago). I vote for axing the support. Thanks,
-Enji