Skip to contentSkip to conversation

staging: rtl8723bs: Remove unnecessary conditional block

PATCH Superseded Javier F. Arias 2 participants 4 messages Nov 2, 2019 – Nov 3, 2019 Staging

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8723bs: Remove unnecessary conditional block

This patch removes a conditional block that had no effect. It also reformat the affected lines to set the right indentation after the removal.
Issue found by Coccinelle.

---
 drivers/staging/rtl8723bs/hal/sdio_halinit.c | 19 +++++++------------
 1 file changed, 7 insertions(+), 12 deletions(-)
drivers/staging/rtl8723bs/hal/sdio_halinit.c +7 -12
index 0f5dd4629e6f..b4b535c66bae 100644
@@ -551,18 +551,13 @@ static void HalRxAggr8723BSdio(struct adapter *padapter)
 
 	pregistrypriv = &padapter->registrypriv;
 
-	if (pregistrypriv->wifi_spec) {
-		/*  2010.04.27 hpfan */
-		/*  Adjust RxAggrTimeout to close to zero disable RxAggr, suggested by designer */
-		/*  Timeout value is calculated by 34 / (2^n) */
-		valueDMATimeout = 0x06;
-		valueDMAPageCount = 0x06;
-	} else {
-		/*  20130530, Isaac@SD1 suggest 3 kinds of parameter */
-		/*  TX/RX Balance */
-		valueDMATimeout = 0x06;
-		valueDMAPageCount = 0x06;
-	}
+	/*  2010.04.27 hpfan */
+	/*  Adjust RxAggrTimeout to close to zero disable RxAggr, suggested by designer */
+	/*  Timeout value is calculated by 34 / (2^n) */
+	valueDMATimeout = 0x06;
+	valueDMAPageCount = 0x06;
+	/*  20130530, Isaac@SD1 suggest 3 kinds of parameter */
+	/*  TX/RX Balance */
 
 	rtw_write8(padapter, REG_RXDMA_AGG_PG_TH + 1, valueDMATimeout);
 	rtw_write8(padapter, REG_RXDMA_AGG_PG_TH, valueDMAPageCount);
Signature · 1 line
2.20.1
maintainer
#1 lore raw
Quoted 9 lines · Javier F. Arias

This patch removes a conditional block that had no effect. It also reformat the affected lines to set the right indentation after the removal.
Issue found by Coccinelle.

---
 drivers/staging/rtl8723bs/hal/sdio_halinit.c | 19 +++++++------------
 1 file changed, 7 insertions(+), 12 deletions(-)

I have 11 patches sent from you, on the same day, for this single driver, yet I have no idea what order to apply them in :(

Please resend all of them as a single patch series so I have a clue as to what to do here. Be kind to maintainers :)

thanks,

greg k-h

#2 lore raw
Quoted 14 lines · Greg KH
Quoted 9 lines · Javier F. Arias

This patch removes a conditional block that had no effect. It also reformat the affected lines to set the right indentation after the removal.
Issue found by Coccinelle.

---
 drivers/staging/rtl8723bs/hal/sdio_halinit.c | 19 +++++++------------
 1 file changed, 7 insertions(+), 12 deletions(-)

I have 11 patches sent from you, on the same day, for this single driver, yet I have no idea what order to apply them in :(

Quoted 11 lines

Please resend all of them as a single patch series so I have a clue as to what to do here. Be kind to maintainers :)

thanks,

greg k-h

Signature · 3 lines
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191102104324.GA184849%40kroah.com.

I'm sorry Greg, I had some patches ready to send and i didn't want to send a single patchset with +200 lines (as suggested in the documentation) so I thought it was easier to split it.

I'm going to resend the biggest patchset for now.

maintainer
#3 lore raw
Quoted 22 lines · Javier F. Arias
Quoted 21 lines · Greg KH
Quoted 9 lines · Javier F. Arias

This patch removes a conditional block that had no effect. It also reformat the affected lines to set the right indentation after the removal.
Issue found by Coccinelle.

---
 drivers/staging/rtl8723bs/hal/sdio_halinit.c | 19 +++++++------------
 1 file changed, 7 insertions(+), 12 deletions(-)

I have 11 patches sent from you, on the same day, for this single driver, yet I have no idea what order to apply them in :(

Please resend all of them as a single patch series so I have a clue as to what to do here. Be kind to maintainers :)

thanks,

greg k-h

Quoted 8 lines
Quoted 4 lines
Signature · 3 lines
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191102104324.GA184849%40kroah.com.

I'm sorry Greg, I had some patches ready to send and i didn't want to send a single patchset with +200 lines (as suggested in the documentation) so I thought it was easier to split it.

I can easily handle patchsets of 50+ patches, so that should not be an issue here. As long as you only do "one logical change per patch" then all is fine.

thanks,

greg k-h