i2c: imx-lpi2c: add clk_disable_unprepare calls
PATCH v2 1/1 i2c: imx-lpi2c: add clk_disable_unprepare calls
The driver forgets to call clk_disable_unprepare when probe fails and remove.
Add the two calls to fix the problem.
Signed-off-by Chuhong Yuan <[email protected]>
---
Changes in v2:
- Adjust the call order to make it consistent in probe failure and removal.
drivers/i2c/busses/i2c-imx-lpi2c.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/i2c/busses/i2c-imx-lpi2c.c +2 -0
@@ -618,6 +618,7 @@ static int lpi2c_imx_probe(struct platform_device *pdev)return 0 ; rpm_disable: +clk_disable_unprepare (lpi2c_imx->clk);pm_runtime_put (&pdev->dev);pm_runtime_disable (&pdev->dev);pm_runtime_dont_use_autosuspend (&pdev->dev);
@@ -630,6 +631,7 @@ static int lpi2c_imx_remove(struct platform_device *pdev)struct lpi2c_imx_struct *lpi2c_imx =platform_get_drvdata (pdev);i2c_del_adapter (&lpi2c_imx->adapter); +clk_disable_unprepare (lpi2c_imx->clk);pm_runtime_disable (&pdev->dev);pm_runtime_dont_use_autosuspend (&pdev->dev);
Signature · 1 line
2.23.0
Quoted 6 lines · Chuhong Yuan
The driver forgets to call
clk_disable_unpreparewhen probe fails and remove.
Add the two calls to fix the problem.Signed-off-by Chuhong Yuan <[email protected]>---
Dong Aisheng, what do you think of this patch?
Quoted 30 lines
Changes in v2:
- Adjust the call order to make it consistent in probe failure and removal.drivers/i2c/busses/i2c-imx-lpi2c.c | 2 ++ 1 file changed, 2 insertions(+)drivers/i2c/busses/i2c-imx-lpi2c.c +2
-0@@ -618,6 +618,7 @@ static int lpi2c_imx_probe(struct platform_device *pdev)return 0 ; rpm_disable: +clk_disable_unprepare (lpi2c_imx->clk);pm_runtime_put (&pdev->dev);pm_runtime_disable (&pdev->dev);pm_runtime_dont_use_autosuspend (&pdev->dev);@@ -630,6 +631,7 @@ static int lpi2c_imx_remove(struct platform_device *pdev)struct lpi2c_imx_struct *lpi2c_imx =platform_get_drvdata (pdev);i2c_del_adapter (&lpi2c_imx->adapter); +clk_disable_unprepare (lpi2c_imx->clk);pm_runtime_disable (&pdev->dev);pm_runtime_dont_use_autosuspend (&pdev->dev);Signature · 1 line
2.23.0