firmware loader: log path to loaded firmwares
Subsystems (2)
PATCH 1/1 firmware loader: log path to loaded firmwares
This is useful for users who are trying to identify the firmwares in use on their system.
--- drivers/base/firmware_loader/main.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/base/firmware_loader/main.c +2 -0
@@ -34,6 +34,7 @@#include <linux/reboot.h> #include <linux/security.h> #include <linux/xz.h> +#include <linux/kernel.h> #include <generated/utsrelease.h>
@@ -504,6 +505,7 @@ fw_get_filesystem_firmware(struct device *device, struct fw_priv *fw_priv, path);continue ; } +printk (KERN_INFO "Loading firmware from %s\n" , path);if (decompress) {dev_dbg (device,"f/w decompressing %s\n" , fw_priv->fw_name);
Signature · 1 line
2.23.0
Greg Kroah-Hartman
maintainerQuoted 21 lines · Drew DeVault
This is useful for users who are trying to identify the firmwares in use on their system.
Signed-off-by Drew DeVault <[email protected]>--- drivers/base/firmware_loader/main.c | 2 ++ 1 file changed, 2 insertions(+)drivers/base/firmware_loader/main.c +1
-0@@ -34,6 +34,7 @@#include <linux/reboot.h> #include <linux/security.h> #include <linux/xz.h> +#include <linux/kernel.h> #include <generated/utsrelease.h>
drivers/base/firmware_loader/main.c fw_get_filesystem_firmware(struct device *device, struct fw_priv *fw_priv, · line 508
Quoted 4 lines
drivers/base/firmware_loader/main.c +1
-0@@ -504,6 +505,7 @@ fw_get_filesystem_firmware(struct device *device, struct fw_priv *fw_priv, path);continue ; } +printk (KERN_INFO "Loading firmware from %s\n" , path);
And it's totally noisy :(
Also, if you have a 'struct device' you should always use the dev_*() calls instead, which will show you exactly what device is asking for what.
Please just make this a debug call, that way you can turn it on dynamically if you really want to see what firmware is attempting to be loaded.
thanks,
greg k-h
Quoted 5 lines · Greg Kroah-Hartman
And it's totally noisy :(
Please just make this a debug call, that way you can turn it on dynamically if you really want to see what firmware is attempting to be loaded.
The typical setup won't need more than say, 10-20 firmwares? On my system I need 13, and 12 of them are just for AMDGPU. In the 20 minutes since I rebooted to this kernel, it constitutes less than 1% of my dmesg volume, and will only get less so over time unless I start hotplugging stuff (in which case, their respective drivers are likely to make noise, too). In practice, I don't think it'll be especially noisy.
On the other hand, enabling debug logs just to get this information would generate heaps of noise for a little bit of signal. This use-case isn't the exceptional case for me, on my systems I only install the firmwares I need so this is something I would reach for every time I set up a new system.
Quoted 3 lines
Also, if you have a 'struct device' you should always use the dev_*() calls instead, which will show you exactly what device is asking for what.
Understood.
Greg Kroah-Hartman
maintainerQuoted 14 lines · Drew DeVault
Quoted 5 lines · Greg Kroah-Hartman
And it's totally noisy :(
Please just make this a debug call, that way you can turn it on dynamically if you really want to see what firmware is attempting to be loaded.
The typical setup won't need more than say, 10-20 firmwares? On my system I need 13, and 12 of them are just for AMDGPU. In the 20 minutes since I rebooted to this kernel, it constitutes less than 1% of my dmesg volume, and will only get less so over time unless I start hotplugging stuff (in which case, their respective drivers are likely to make noise, too). In practice, I don't think it'll be especially noisy.
Quoted 5 lines
On the other hand, enabling debug logs just to get this information would generate heaps of noise for a little bit of signal. This use-case isn't the exceptional case for me, on my systems I only install the firmwares I need so this is something I would reach for every time I set up a new system.
A "normal" system should not have any messages printing to the kernel log. All of this "look ma, I'm now loaded!" doesn't help anyone. Printing errors is the key, that way if you see a message, it means you need to take care of it.
If a firmware file is NOT found that is asked for, then yes, a message should be printed out. Isn't that the case if you do not have the correct firmware file present?
Please never print out "Here is what the code is doing now!" type messages to the info log, that's just noise.
thanks,
greg k-h
Fair enough, v2 sent. Thanks for the feedback!