libpng: whitelist CVE-2019-17371
PATCH 1/1 libpng: whitelist CVE-2019-17371
This is actually a memory leak in gif2png 2.x, so whitelist it in the libpng recipe.
--- meta/recipes-multimedia/libpng/libpng_1.6.37.bb | 3 +++ 1 file changed, 3 insertions(+)
meta/recipes-multimedia/libpng/libpng_1.6.37.bb +3 -0
@@ -29,3 +29,6 @@ PACKAGES =+ "${PN}-tools" FILES_${PN}-tools = "${bindir}/png-fix-itxt ${bindir}/pngfix ${bindir}/pngcp" BBCLASSEXTEND = "native nativesdk" + +# CVE-2019-17371 is actually a memory leak in gif2png 2.x +CVE_CHECK_WHITELIST = "CVE-2019-17371"
Signature · 1 line
2.20.1
Quoted 13 lines · Ross Burton
This is actually a memory leak in gif2png 2.x, so whitelist it in the libpng recipe.
Signed-off-by Ross Burton <[email protected]>--- meta/recipes-multimedia/libpng/libpng_1.6.37.bb | 3 +++ 1 file changed, 3 insertions(+)meta/recipes-multimedia/libpng/libpng_1.6.37.bb +0
-0
meta/recipes-multimedia/libpng/libpng_1.6.37.bb PACKAGES =+ "${PN}-tools" · line 34
Quoted 6 lines
meta/recipes-multimedia/libpng/libpng_1.6.37.bb +3
-0@@ -29,3 +29,6 @@ PACKAGES =+ "${PN}-tools" FILES_${PN}-tools = "${bindir}/png-fix-itxt ${bindir}/pngfix ${bindir}/pngcp" BBCLASSEXTEND = "native nativesdk" + +# CVE-2019-17371 is actually a memory leak in gif2png 2.x +CVE_CHECK_WHITELIST = "CVE-2019-17371"
These should use += to not overwrite whitelists defined by the distribution or the user.
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon SeedQuoted 16 lines · Adrian Bunk
Quoted 15 lines · Ross Burton
This is actually a memory leak in gif2png 2.x, so whitelist it in the libpng recipe.
Signed-off-by Ross Burton <[email protected]>--- meta/recipes-multimedia/libpng/libpng_1.6.37.bb | 3 +++ 1 file changed, 3 insertions(+)meta/recipes-multimedia/libpng/libpng_1.6.37.bb +0
-0@@ -29,3 +29,6 @@ PACKAGES =+ "${PN}-tools" FILES_${PN}-tools = "${bindir}/png-fix-itxt ${bindir}/pngfix ${bindir}/pngcp"
Quoted 7 lines
meta/recipes-multimedia/libpng/libpng_1.6.37.bb PACKAGES =+ "${PN}-tools" · line 34
Quoted 4 lines
meta/recipes-multimedia/libpng/libpng_1.6.37.bb +3
-0BBCLASSEXTEND = "native nativesdk" + +# CVE-2019-17371 is actually a memory leak in gif2png 2.x +CVE_CHECK_WHITELIST = "CVE-2019-17371"These should use += to not overwrite whitelists defined by the distribution or the user.
IMHO, the distribution or user should be using _append. The whitelist should be explicitly per-recipe: there's a CVE which is tagged incorrectly as being in openssl *and* mod_ssl, we don't want to whitelist it globally but only in openssl.
V2 incoming, just to be safe, though.
Ross
Quoted 24 lines · Ross Burton
Quoted 9 lines · Adrian Bunk
Quoted 8 lines · Ross Burton
This is actually a memory leak in gif2png 2.x, so whitelist it in the libpng recipe.
Signed-off-by Ross Burton <[email protected]>--- meta/recipes-multimedia/libpng/libpng_1.6.37.bb | 3 +++ 1 file changed, 3 insertions(+)Quoted 13 lines
meta/recipes-multimedia/libpng/libpng_1.6.37.bb PACKAGES =+ "${PN}-tools" · line 33
Quoted 10 lines
meta/recipes-multimedia/libpng/libpng_1.6.37.bb +3
-0@@ -29,3 +29,6 @@ PACKAGES =+ "${PN}-tools" FILES_${PN}-tools = "${bindir}/png-fix-itxt ${bindir}/pngfix ${bindir}/pngcp" BBCLASSEXTEND = "native nativesdk" + +# CVE-2019-17371 is actually a memory leak in gif2png 2.x +CVE_CHECK_WHITELIST = "CVE-2019-17371"These should use += to not overwrite whitelists defined by the distribution or the user.
Quoted 5 lines
IMHO, the distribution or user should be using
_append. The whitelist
should be explicitly per-recipe: there's a CVE which is tagged incorrectly as being in openssl *and*mod_ssl, we don't want to whitelist it globally but only in openssl.
...
What I had in mind are a distribution-wide cve-whitelist.inc included from the distro conf or using CVE_CHECK_WHITELIST in conf/local.conf, you don't want to start creating dozens of bbappend files in such usecases.
This CVE where a change in OpenSSL created a vulnerability in Apache would go to the global whitelist for me when I am not using Apache. In OE it should not be whitelisted in both OpenSSL and Apache, but this is a different situation.
Quoted 1 line
Ross
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed